113953 2013-04-04 13:22:49 -0700 [EFL] --minimal build fails with error: expected `;' before `return' 2013-04-07 16:51:35 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED EasyFix P2 Normal --- 0 bartosh bartosh gyuyoung.kim kalyan.kondapally laszlo.gombos lucas.de.marchi paroga rakuco webkit.review.bot oldest_to_newest 869309 0 bartosh 2013-04-04 13:22:49 -0700 /home/ed/git/wk/WebKit/Source/WebKit/efl/ewk/ewk_security_origin.cpp: In function `uint64_t ewk_security_origin_web_database_quota_get(const Ewk_Security_Origin*)': /home/ed/git/wk/WebKit/Source/WebKit/efl/ewk/ewk_security_origin.cpp:85:5: error: expected `;' before `return' /home/ed/git/wk/WebKit/Source/WebKit/efl/ewk/ewk_security_origin.cpp:87:1: error: no return statement in function returning non-void [-Werror=return-type] /home/ed/git/wk/WebKit/Source/WebKit/efl/ewk/ewk_security_origin.cpp: At global scope: /home/ed/git/wk/WebKit/Source/WebKit/efl/ewk/ewk_security_origin.cpp:89:6: warning: unused parameter `quota' [-Wunused-parameter] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_security_origin.cpp.o] Error 1 make[1]: *** [Source/WebKit/CMakeFiles/ewebkit.dir/all] Error 2 make: *** [all] Error 2 869312 1 196512 bartosh 2013-04-04 13:25:54 -0700 Created attachment 196512 Patch 870524 2 196809 bartosh 2013-04-07 13:25:37 -0700 Created attachment 196809 Patch Rebased. Please, review. 870572 3 paroga 2013-04-07 16:40:04 -0700 Committed r147885: <http://trac.webkit.org/changeset/147885> 870574 4 196809 gyuyoung.kim 2013-04-07 16:51:35 -0700 Comment on attachment 196809 Patch Clearing r?, cq? 196512 2013-04-04 13:25:54 -0700 2013-04-07 13:25:37 -0700 Patch bug-113953-20130404232542.patch text/plain 1386 bartosh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNDY4NjY3MmMw M2RlMzY2OTdiMjRjZWUwOTU4MzQyZGIzODE5ZGY3YS4uMmZlMDk2MmM1ZTVkNGY4MjAxZTQzOTcw MGJhMmNhMGQ2MTJkMjRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEz LTA0LTA0ICBFZCBCYXJ0b3NoICA8YmFydG9zaEBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0g LS1taW5pbWFsIGJ1aWxkIGZhaWxzIHdpdGggcnJvcjogZXhwZWN0ZWQgYDsnIGJlZm9yZSBgcmV0 dXJuJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEz OTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 ZWQgc3ludGF4IGVycm9yOiBBZGRlZCBtaXNzaW5nIHNlbWljb2xvbgorICAgICAgICAqIGV3ay9l d2tfc2VjdXJpdHlfb3JpZ2luLmNwcDoKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5fd2Vi X2RhdGFiYXNlX3F1b3RhX2dldCk6CisKIDIwMTMtMDQtMDQgIENocmlzdG9waGUgRHVtZXogIDxj aC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtDYWlyb10gRml4IGNhbnZhcyBk cmF3aW5nIG9mIFNWRy1iYXNlZCBwYXR0ZXJucyBhbmQgcmVtb3ZlIE5hdGl2ZUltYWdlQ2Fpcm8K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNw cCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcAppbmRleCBl OGQ4NDk3ZWE0YjAyYjUxNGNkYjIzOTMyNTI1YzgzMmVkOTk5YzZhLi5lZDdiMjk3MjFjMDAzY2Fl NmRlYjU2MWU2MzY4ZmM2ODdjYjY2YTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19zZWN1cml0eV9vcmlnaW4uY3BwCkBAIC04MSw3ICs4MSw3IEBAIHVpbnQ2NF90IGV3a19zZWN1 cml0eV9vcmlnaW5fd2ViX2RhdGFiYXNlX3F1b3RhX2dldChjb25zdCBFd2tfU2VjdXJpdHlfT3Jp Z2luKiBvCiAKICAgICByZXR1cm4gV2ViQ29yZTo6RGF0YWJhc2VNYW5hZ2VyOjptYW5hZ2VyKCku cXVvdGFGb3JPcmlnaW4ob3JpZ2luLT5zZWN1cml0eU9yaWdpbi5nZXQoKSk7CiAjZWxzZQotICAg IFVOVVNFRF9QQVJBTShvcmlnaW4pCisgICAgVU5VU0VEX1BBUkFNKG9yaWdpbik7CiAgICAgcmV0 dXJuIDA7CiAjZW5kaWYKIH0K 196809 2013-04-07 13:25:37 -0700 2013-04-07 16:51:35 -0700 Patch Patch.113953 text/plain 1366 bartosh Y29tbWl0IDcwYjkzYmYyMDFmOGNlOTc1ZGEyZTIwNDI3NjRkZTQyZjJjODY5MjMKQXV0aG9yOiBF ZCBCYXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KRGF0ZTogICBUaHUgQXByIDQgMjM6MzU6Mjcg MjAxMyArMDMwMAoKICAgIEZpeGVkICMxMTM5NTMKICAgIAogICAgU2lnbmVkLW9mZi1ieTogRWQg QmFydG9zaCA8YmFydG9zaEBnbWFpbC5jb20+CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDZiZDFmYzQu LjU0N2Q2MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wNC0wNCAg RWQgQmFydG9zaCAgPGJhcnRvc2hAZ21haWwuY29tPgorCisgICAgICAgIFtFRkxdIC0tbWluaW1h bCBidWlsZCBmYWlscyB3aXRoIHJyb3I6IGV4cGVjdGVkIGA7JyBiZWZvcmUgYHJldHVybicKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzk1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHN5bnRh eCBlcnJvcjogQWRkZWQgbWlzc2luZyBzZW1pY29sb24KKyAgICAgICAgKiBld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5jcHA6CisgICAgICAgIChld2tfc2VjdXJpdHlfb3JpZ2luX3dlYl9kYXRhYmFz ZV9xdW90YV9nZXQpOgorCiAyMDEzLTA0LTA1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgTWFkZSBVU0UoSlNDKSB1bmNvbmRpdGlvbmFsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAKaW5kZXggZThkODQ5Ny4uZWQ3 YjI5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmln aW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNw cApAQCAtODEsNyArODEsNyBAQCB1aW50NjRfdCBld2tfc2VjdXJpdHlfb3JpZ2luX3dlYl9kYXRh YmFzZV9xdW90YV9nZXQoY29uc3QgRXdrX1NlY3VyaXR5X09yaWdpbiogbwogCiAgICAgcmV0dXJu IFdlYkNvcmU6OkRhdGFiYXNlTWFuYWdlcjo6bWFuYWdlcigpLnF1b3RhRm9yT3JpZ2luKG9yaWdp bi0+c2VjdXJpdHlPcmlnaW4uZ2V0KCkpOwogI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ob3JpZ2lu KQorICAgIFVOVVNFRF9QQVJBTShvcmlnaW4pOwogICAgIHJldHVybiAwOwogI2VuZGlmCiB9Cg==