113947 2013-04-04 12:11:05 -0700 REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes 2013-04-04 14:14:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca benjamin simon.fraser webkit-bug-importer oldest_to_newest 869267 0 thorton 2013-04-04 12:11:05 -0700 Now that we reset the size of the FrameView and do layout upon every autoSizeIfEnabled, we also need to reset our width to the minimum auto-size width. Previously we were resetting to the FrameView's current width, which is vaguely OK if we only reset it the first time we autosize, but breaks everything (makes minimum width changes not take effect unless the view is forcefully resized) if we reset it every time. 869268 1 webkit-bug-importer 2013-04-04 12:11:45 -0700 <rdar://problem/13579024> 869283 2 196505 thorton 2013-04-04 12:36:51 -0700 Created attachment 196505 patch 869292 3 thorton 2013-04-04 12:57:50 -0700 https://trac.webkit.org/r147664 869350 4 benjamin 2013-04-04 14:11:10 -0700 fast/layers/no-clipping-overflow-hidden-added-after-transition.html fails after this patch: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r147664%20(6940)/results.html Can you please have a look? 869356 5 thorton 2013-04-04 14:14:58 -0700 (In reply to comment #4) > fast/layers/no-clipping-overflow-hidden-added-after-transition.html fails after this patch: > > http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r147664%20(6940)/results.html > > Can you please have a look? There's no way my change affected tests on Mac at all. 196505 2013-04-04 12:36:51 -0700 2013-04-04 12:44:06 -0700 patch autosize.diff text/plain 1687 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNDM4Mjc1Li5jZWFjZTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMDQtMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE0NzM3Myk6IEF1dG8tc2l6aW5nIGRvZXNuJ3QgYWx3YXlz IHJlc3BlY3QgbWluaW11bSB3aWR0aCBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM5NDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEz NTc5MDI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlc2V0IHRoZSBGcmFtZVZpZXcgc2l6ZSB0byB0aGUgbWluaW11bSBhdXRvLXNpemluZyBzaXpl CisgICAgICAgIGJlZm9yZSBwZXJmb3JtaW5nIGF1dG8tc2l6aW5nLiBXZSB3ZXJlIGFscmVhZHkg cmVzZXR0aW5nIHRoZSBoZWlnaHQsCisgICAgICAgIGJ1dCBub3QgdGhlIHdpZHRoLCBpbnN0ZWFk IHVzaW5nIHRoZSBGcmFtZVZpZXcncyBjdXJyZW50IHdpZHRoLgorCisgICAgICAgIFRoaXMgbWVh bnMgdGhhdCBjaGFuZ2luZyB0aGUgbWluaW11bSB3aWR0aCB3aXRob3V0IGFsc28gbWFudWFsbHkK KyAgICAgICAgcmVzaXppbmcgdGhlIEZyYW1lVmlldyB3aWxsIG5ldmVyIHNlZSB0aGUgd2lkdGgg Y2hhbmdlLgorCisgICAgICAgIEF1dG8tc2l6aW5nIHRlc3RzIGFyZSBub3Qgd29ya2luZyBvbiBN YWMgeWV0LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RnJhbWVWaWV3OjphdXRvU2l6ZUlmRW5hYmxlZCk6CisKIDIwMTMtMDQtMDMgIE90dG8gRGVy ZWsgQ2hldW5nICA8b3RjaGV1bmdAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gU3dp dGNoIE1lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwJ3MgdGltZXIgdG8gdXNlIENMT0NL X01PTk9UT05JQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGFlZGU5ZWUuLmViNjlj ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTI3NzgsOCArMjc3OCw4IEBAIHZv aWQgRnJhbWVWaWV3OjphdXRvU2l6ZUlmRW5hYmxlZCgpCiAgICAgaWYgKCFkb2N1bWVudFZpZXcg fHwgIWRvY3VtZW50RWxlbWVudCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgLy8gU3RhcnQgZnJv bSB0aGUgbWluaW11bSBoZWlnaHQgYW5kIGFsbG93IGl0IHRvIGdyb3cuCi0gICAgcmVzaXplKGZy YW1lUmVjdCgpLndpZHRoKCksIG1fbWluQXV0b1NpemUuaGVpZ2h0KCkpOworICAgIC8vIFN0YXJ0 IGZyb20gdGhlIG1pbmltdW0gc2l6ZSBhbmQgYWxsb3cgaXQgdG8gZ3Jvdy4KKyAgICByZXNpemUo bV9taW5BdXRvU2l6ZS53aWR0aCgpLCBtX21pbkF1dG9TaXplLmhlaWdodCgpKTsKIAogICAgIElu dFNpemUgc2l6ZSA9IGZyYW1lUmVjdCgpLnNpemUoKTsKIA==