113944 2013-04-04 11:19:11 -0700 [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element 2013-04-04 20:44:46 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo commit-queue mifenton rniwa rwlbuis tonikitoo webkit.review.bot oldest_to_newest 869245 0 anlo 2013-04-04 11:19:11 -0700 DOMSupport::isFixedPositionOrHasFixedPositionAncestor should continue traversing up the render tree if the render object is a render view with an html element owner, when checking whether an ancestor is fixed position. 869255 1 196498 anlo 2013-04-04 11:31:03 -0700 Created attachment 196498 Patch 869259 2 196498 rwlbuis 2013-04-04 11:44:02 -0700 Comment on attachment 196498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196498&action=review Ok. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:643 > + if (!currentRenderer->parent() && currentRenderer->isRenderView() && currentRenderer->frame() && currentRenderer->frame()->ownerElement()) { Not sure if RenderView can have a parent in practice... 869534 3 196498 commit-queue 2013-04-04 20:44:44 -0700 Comment on attachment 196498 Patch Clearing flags on attachment: 196498 Committed r147701: <http://trac.webkit.org/changeset/147701> 869535 4 commit-queue 2013-04-04 20:44:46 -0700 All reviewed patches have been landed. Closing bug. 196498 2013-04-04 11:31:03 -0700 2013-04-04 20:44:44 -0700 Patch bug-113944-20130404143102.patch text/plain 2537 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmZTJmYmZjYTU0ZjU3MTRiMWM3ZDVjZDdmNzBkODA2YjFlMDc2YjdiLi42MGI3M2M2MzVm ODJmYWM5YmQ1ZDc3YTE5YjNjMjRiZThhNzI2NDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wNC0wNCAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBET01TdXBwb3J0Ojppc0ZpeGVkUG9zaXRpb25P ckhhc0ZpeGVkUG9zaXRpb25BbmNlc3RvciBzdG9wcyB0cmF2ZXJzaW5nIHJlbmRlciB0cmVlIHdo ZW4gaXQgaGl0cyBhbiBpZnJhbWUgZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzOTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50b24uCisK KyAgICAgICAgSW50ZXJuYWwgUFIgMzIwNzMyLgorICAgICAgICBXaGVuIGNoZWNraW5nIHdoZXRo ZXIgYSBSZW5kZXJPYmplY3QgaXMgZml4ZWQgcG9zaXRpb24gb3IgaGFzIGEgZml4ZWQgcG9zaXRp b24KKyAgICAgICAgYW5jZXN0b3IsIHdlIHRyYXZlcnNlIHRoZSByZW5kZXIgdHJlZSB1cHdhcmRz LgorCisgICAgICAgIFdoZW4gd2UgcmVhY2ggdGhlIHJvb3Qgb2YgdGhlIHRyZWUsIGNoZWNrIHdo ZXRoZXIgdGhlIHJvb3QgaXMgYW4KKyAgICAgICAgaWZyYW1lIGFuZCBoYXMgYW4gZWxlbWVudCBv d25lci4gSWYgc28sIHdlIGFsc28gbmVlZCB0byBjb250aW51ZSBpdGVyYXRpbmcKKyAgICAgICAg dXAgdGhlIHRyZWUgZnJvbSB0aGUgb3duZXIgdG8gc2VlIGlmIHRoZSBpZnJhbWUgaXMgYSBkZXNj ZW5kYW50IG9mIGEgZml4ZWQKKyAgICAgICAgcG9zaXRpb24gZWxlbWVudC4KKworICAgICAgICAq IFdlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OkRPTVN1cHBvcnQ6OmlzRml4ZWRQb3NpdGlvbk9ySGFzRml4ZWRQb3NpdGlvbkFuY2VzdG9y KToKKwogMjAxMy0wNC0wMiAgTWF4aW0gTW9naWxuaXRza3kgIDxtbW9naWxuaXRza3lAcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQVBJIHVwZGF0ZSBmb3IgSW50UmVjdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNw cAppbmRleCAxMTA5NDEwYTJmMjkyYTZjNTIyNGJjMzdkNmE4NTI4MjRlMGU1NGY5Li41Njk5MGJm Yzg5YTNkMjI1MjhlODdiMTNkMzIwYTkzOWVmYWE5NGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcApAQCAtMjMsNiAr MjMsNyBAQAogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAjaW5j bHVkZSAiSFRNTEZvcm1FbGVtZW50LmgiCisjaW5jbHVkZSAiSFRNTEZyYW1lT3duZXJFbGVtZW50 LmgiCiAjaW5jbHVkZSAiSFRNTElucHV0RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgogI2luY2x1ZGUgIkhUTUxUZXh0QXJlYUVsZW1lbnQuaCIKQEAgLTYzOCw2ICs2MzksMTIgQEAg Ym9vbCBpc0ZpeGVkUG9zaXRpb25Pckhhc0ZpeGVkUG9zaXRpb25BbmNlc3RvcihSZW5kZXJPYmpl Y3QqIHJlbmRlcmVyKQogICAgICAgICBpZiAoY3VycmVudFJlbmRlcmVyLT5pc091dE9mRmxvd1Bv c2l0aW9uZWQoKSAmJiBjdXJyZW50UmVuZGVyZXItPnN0eWxlKCktPnBvc2l0aW9uKCkgPT0gRml4 ZWRQb3NpdGlvbikKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAgICAgIC8vIENoZWNr IGlmIHRoZSBjdXJyZW50IGZyYW1lIGlzIGFuIGlmcmFtZS4gSWYgc28sIGNvbnRpbnVlIGNoZWNr aW5nIHdpdGggdGhlIGlmcmFtZSdzIG93bmVyIGVsZW1lbnQuCisgICAgICAgIGlmICghY3VycmVu dFJlbmRlcmVyLT5wYXJlbnQoKSAmJiBjdXJyZW50UmVuZGVyZXItPmlzUmVuZGVyVmlldygpICYm IGN1cnJlbnRSZW5kZXJlci0+ZnJhbWUoKSAmJiBjdXJyZW50UmVuZGVyZXItPmZyYW1lKCktPm93 bmVyRWxlbWVudCgpKSB7CisgICAgICAgICAgICBjdXJyZW50UmVuZGVyZXIgPSBjdXJyZW50UmVu ZGVyZXItPmZyYW1lKCktPm93bmVyRWxlbWVudCgpLT5yZW5kZXJlcigpOworICAgICAgICAgICAg Y29udGludWU7CisgICAgICAgIH0KKwogICAgICAgICBjdXJyZW50UmVuZGVyZXIgPSBjdXJyZW50 UmVuZGVyZXItPnBhcmVudCgpOwogICAgIH0KIAo=