113923 2013-04-03 23:36:47 -0700 Changing typing style with font size delta overrides the previous font size delta 2013-04-04 12:14:20 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa darin enrica mifenton webkit.review.bot oldest_to_newest 869027 0 rniwa 2013-04-03 23:36:47 -0700 Changing typing style with font size delta overrides the previous font size delta 869028 1 196442 rniwa 2013-04-03 23:47:01 -0700 Created attachment 196442 Fixes the bug 869030 2 rniwa 2013-04-03 23:48:13 -0700 <rdar://problem/12947362> 869032 3 rniwa 2013-04-03 23:49:10 -0700 I couldn't think of a good way of testing this fix. Let me know if you have any ideas. I've tried WebKit API tests but it appears that I have to mess with NSFontManager and emulate a whole bunch of stuff. 869118 4 196442 kling 2013-04-04 05:03:43 -0700 Comment on attachment 196442 Fixes the bug LGTM. 869269 5 196442 webkit.review.bot 2013-04-04 12:14:18 -0700 Comment on attachment 196442 Fixes the bug Clearing flags on attachment: 196442 Committed r147661: <http://trac.webkit.org/changeset/147661> 869270 6 webkit.review.bot 2013-04-04 12:14:20 -0700 All reviewed patches have been landed. Closing bug. 196442 2013-04-03 23:47:01 -0700 2013-04-04 12:14:16 -0700 Fixes the bug bug-113923-20130403234650.patch text/plain 2401 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzYxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA0LTAzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENoYW5naW5nIHR5cGluZyBzdHls ZSB3aXRoIGZvbnQgc2l6ZSBkZWx0YSBvdmVycmlkZXMgdGhlIHByZXZpb3VzIGZvbnQgc2l6ZSBk ZWx0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEz OTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IGJ1ZyB3YXMgY2F1c2VkIGJ5IGEgbmV3IGZvbnQgc2l6ZSBkZWx0YSB2YWx1ZSBvdmVycmlkaW5n IHRoZSBvbGQgb25lIGFzCisgICAgICAgIG9wcG9zZWQgdG8gYmVpbmcgYWRkZWQgdG8gdGhlIG9s ZCB2YWx1ZS4gRml4ZWQgdGhhdCBpbiBvdmVycmlkZVdpdGhTdHlsZS4KKworICAgICAgICBBbHNv IG1hZGUgb3ZlcnJpZGVXaXRoU3R5bGUgc2hhcmUgY29kZSB3aXRoIG1lcmdlU3R5bGUgc2luY2Ug dGhlcmUgaXMgYWxyZWFkeQorICAgICAgICBjb2RlIHRvIG1lcmdlIHRleHQtZGVjb3JhdGlvbnMg dGhlcmUuCisKKyAgICAgICAgVW5mb3J0dW5hdGVseSwgYWRkaW5nIGEgdGVzdCBmb3IgdGhpcyBm aXggcHJvdmVkIHRvIGJlIGhhcmQgYmVjYXVzZSB3ZSBkb24ndAorICAgICAgICBleHBvc2UgYW55 IEFQSSB0byBkaXJlY3RseSBzZXQgdHlwaW5nIHN0eWxlLgorCisgICAgICAgICogZWRpdGluZy9F ZGl0aW5nU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdGluZ1N0eWxlOjpvdmVycmlk ZVdpdGhTdHlsZSk6IFVzZSBtZXJnZVN0eWxlLgorICAgICAgICAoV2ViQ29yZTo6RWRpdGluZ1N0 eWxlOjptZXJnZVN0eWxlKTogQWRkIGZvbnQgc2l6ZSBkZWx0YXMgYXMgb3Bwb3NlZCB0byBzaW1w bHkKKyAgICAgICAgdXNpbmcgdGhlIG5ldyB2YWx1ZS4KKwogMjAxMy0wNC0wMyAgR3l1eW91bmcg S2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBhIGRl Y29yYXRpb24gaW1hZ2UgdG8gc2VhcmNoIGlucHV0IGZpZWxkCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZWRpdGluZy9FZGl0aW5nU3R5bGUuY3BwCShyZXZpc2lvbiAxNDc1NzQpCisrKyBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzNCwxMiAr NTM0LDcgQEAgdm9pZCBFZGl0aW5nU3R5bGU6OnNldFN0eWxlKFBhc3NSZWZQdHI8UwogCiB2b2lk IEVkaXRpbmdTdHlsZTo6b3ZlcnJpZGVXaXRoU3R5bGUoY29uc3QgU3R5bGVQcm9wZXJ0eVNldCog c3R5bGUpCiB7Ci0gICAgaWYgKCFzdHlsZSB8fCBzdHlsZS0+aXNFbXB0eSgpKQotICAgICAgICBy ZXR1cm47Ci0gICAgaWYgKCFtX211dGFibGVTdHlsZSkKLSAgICAgICAgbV9tdXRhYmxlU3R5bGUg PSBTdHlsZVByb3BlcnR5U2V0OjpjcmVhdGUoKTsKLSAgICBtX211dGFibGVTdHlsZS0+bWVyZ2VB bmRPdmVycmlkZU9uQ29uZmxpY3Qoc3R5bGUpOwotICAgIGV4dHJhY3RGb250U2l6ZURlbHRhKCk7 CisgICAgcmV0dXJuIG1lcmdlU3R5bGUoc3R5bGUsIE92ZXJyaWRlVmFsdWVzKTsKIH0KIAogdm9p ZCBFZGl0aW5nU3R5bGU6OmNsZWFyKCkKQEAgLTEwNzEsNiArMTA2NiwxMCBAQCB2b2lkIEVkaXRp bmdTdHlsZTo6bWVyZ2VTdHlsZShjb25zdCBTdHlsCiAgICAgICAgIGlmIChtb2RlID09IE92ZXJy aWRlVmFsdWVzIHx8IChtb2RlID09IERvTm90T3ZlcnJpZGVWYWx1ZXMgJiYgIXZhbHVlKSkKICAg ICAgICAgICAgIG1fbXV0YWJsZVN0eWxlLT5zZXRQcm9wZXJ0eShwcm9wZXJ0eS5pZCgpLCBwcm9w ZXJ0eS52YWx1ZSgpLT5jc3NUZXh0KCksIHByb3BlcnR5LmlzSW1wb3J0YW50KCkpOwogICAgIH0K KworICAgIGludCBvbGRGb250U2l6ZURlbHRhID0gbV9mb250U2l6ZURlbHRhOworICAgIGV4dHJh Y3RGb250U2l6ZURlbHRhKCk7CisgICAgbV9mb250U2l6ZURlbHRhICs9IG9sZEZvbnRTaXplRGVs dGE7CiB9CiAKIHN0YXRpYyBQYXNzUmVmUHRyPFN0eWxlUHJvcGVydHlTZXQ+IHN0eWxlRnJvbU1h dGNoZWRSdWxlc0ZvckVsZW1lbnQoRWxlbWVudCogZWxlbWVudCwgdW5zaWduZWQgcnVsZXNUb0lu Y2x1ZGUpCg==