113921 2013-04-03 21:51:31 -0700 fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define 2013-04-03 22:08:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 869010 0 fpizlo 2013-04-03 21:51:31 -0700 Patch forthcoming. 869011 1 196435 fpizlo 2013-04-03 21:54:27 -0700 Created attachment 196435 the patch 869014 2 196435 ggaren 2013-04-03 22:05:02 -0700 Comment on attachment 196435 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=196435&action=review r=me > Source/JavaScriptCore/ftl/FTLLLVMHeaders.h:36 > +// headers don't compile clean with our warnings. Grammar: "cleanly". 869015 3 fpizlo 2013-04-03 22:08:52 -0700 Landed in http://trac.webkit.org/changeset/147608 196435 2013-04-03 21:54:27 -0700 2013-04-03 22:05:02 -0700 the patch blah.patch text/plain 3609 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3NjA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA0LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogSW5jbHVkZSBMTFZNIGhlYWRlcnMgd2l0aCBzdXJyb3VuZGluZyAjcHJhZ21h cyBpbnN0ZWFkIG9mIHVzaW5nIG15ICNkZWZpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhlIExMVk0gY29tbXVuaXR5IHdhbnRzIHVz IHRvIGNvbnRpbnVlIGluY2x1ZGluZyBhbGwgb2YgTExWTSdzIEMrKyBoZWFkZXJzLiBDaGFuZ2UK KyAgICAgICAgdG8gdXNpbmcgI3ByYWdtYSdzIHRvIGRpc2FibGUgd2FybmluZ3MgdGhhdCB0aGV5 IGNhbm5vdCBoYW5kbGUuCisKKyAgICAgICAgKiBmdGwvRlRMTExWTUhlYWRlcnMuaDoKKwogMjAx My0wNC0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIGZvdXJ0 aFRpZXI6IEV2ZXJ5b25lIHNob3VsZCBrbm93IGFib3V0IHRoZSBGVEwKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMTExWTUhlYWRlcnMuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTExMVk1IZWFkZXJzLmgJKHJldmlzaW9uIDE0NzYwNykKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTExWTUhlYWRlcnMuaAkod29ya2luZyBjb3B5 KQpAQCAtMzAsOSArMzAsMTkgQEAKIAogI2lmIEVOQUJMRShGVExfSklUKQogCisvLyBJdCBpcyBu ZWNlc3NhcnkgdG8gaW5jbHVkZSBMTFZNIGhlYWRlcnMgdmlhIHRoaXMgZmlsZSwgYmVjYXVzZToK Ky8vIC0gTExWTSByZXF1aXJlcyBkZWZpbmluZyB0aGluZ3MgdGhhdCB3ZSBkb24ndCBub3JtYWxs eSBkZWZpbmUsIGFuZAorLy8gLSBMTFZNIGluY2x1ZGVzIGl0cyBDKysgaGVhZGVycyBmcm9tIGl0 cyBDIGhlYWRlcnMsIGFuZCBpdHMgQysrCisvLyAgIGhlYWRlcnMgZG9uJ3QgY29tcGlsZSBjbGVh biB3aXRoIG91ciB3YXJuaW5ncy4KKwogI2RlZmluZSBfX1NURENfTElNSVRfTUFDUk9TCiAjZGVm aW5lIF9fU1REQ19DT05TVEFOVF9NQUNST1MKLSNkZWZpbmUgTExWTV9ET19OT1RfSU5DTFVERV9D UFBfSEVBREVSUworCisjaWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0 aWMgcHVzaAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWlzc2luZy1ub3Jl dHVybiIKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV3VudXNlZC1wYXJhbWV0 ZXIiCisjZW5kaWYKIAogI2luY2x1ZGUgPGxsdm0tYy9BbmFseXNpcy5oPgogI2luY2x1ZGUgPGxs dm0tYy9FeGVjdXRpb25FbmdpbmUuaD4KQEAgLTQwLDYgKzUwLDEwIEBACiAjaW5jbHVkZSA8bGx2 bS1jL1RhcmdldC5oPgogI2luY2x1ZGUgPGxsdm0tYy9UcmFuc2Zvcm1zL1NjYWxhci5oPgogCisj aWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCisjZW5kaWYK KwogI2VuZGlmIC8vIEVOQUJMRShGVExfSklUKQogCiAjZW5kaWYgLy8gRlRMTExWTUhlYWRlcnNf aApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwko cmV2aXNpb24gMTQ3NjA3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTMtMDQtMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K KworICAgICAgICBmb3VydGhUaWVyOiBJbmNsdWRlIExMVk0gaGVhZGVycyB3aXRoIHN1cnJvdW5k aW5nICNwcmFnbWFzIGluc3RlYWQgb2YgdXNpbmcgbXkgI2RlZmluZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzOTIxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIExMVk0gY29tbXVuaXR5IHdhbnRz IHVzIHRvIGNvbnRpbnVlIGluY2x1ZGluZyBhbGwgb2YgTExWTSdzIEMrKyBoZWFkZXJzLiBDaGFu Z2UKKyAgICAgICAgdGhlIGV4cG9ydCBzY3JpcHQgdG8gZG8gdGhpcy4KKyAgICAgICAgICAgICAg ICAKKyAgICAgICAgKiBTY3JpcHRzL2V4cG9ydC1sbHZtLWJ1aWxkOgorCiAyMDEzLTAzLTI5ICBG aWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgZm91cnRoVGllcjogQ2hl Y2sgaW4gYSBrbm93bi1nb29kIGJ1aWxkIG9mIExMVk0gaW50byBXZWJLaXRMaWJyYXJpZXMsIGFu ZCBoYXZlIGEgc3RvcnkgZm9yIHVwZGF0aW5nIGl0CkluZGV4OiBUb29scy9TY3JpcHRzL2V4cG9y dC1sbHZtLWJ1aWxkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvZXhwb3J0LWxsdm0tYnVp bGQJKHJldmlzaW9uIDE0NzYwNykKKysrIFRvb2xzL1NjcmlwdHMvZXhwb3J0LWxsdm0tYnVpbGQJ KHdvcmtpbmcgY29weSkKQEAgLTg1LDE2ICs4NSw5IEBAIERpci5ta3RtcGRpciB7CiAgICAgfCBk aXJlY3RvcnkgfAogICAgIGRpcmVjdG9yeSA9IFBhdGhuYW1lLm5ldyhkaXJlY3RvcnkpLnJlYWxw YXRoCiAgICAgRGlyLmNoZGlyKCRsbHZtUGF0aCkgewotICAgICAgICBteXN5cygic3ZuIiwgImV4 cG9ydCIsICJpbmNsdWRlL2xsdm0tYyIsIGRpcmVjdG9yeSArICJsbHZtLWMiKQotICAgICAgICAK LSAgICAgICAgRGlyLm1rZGlyKGRpcmVjdG9yeSArICJsbHZtIikKLSAgICAgICAgRGlyLm1rZGly KGRpcmVjdG9yeSArICJsbHZtL0NvbmZpZyIpCi0gICAgICAgIG15c3lzKCJjcCIsICJpbmNsdWRl L2xsdm0vQ29uZmlnL2xsdm0tY29uZmlnLmgiLCBkaXJlY3RvcnkgKyAibGx2bSIgKyAiQ29uZmln IikKLQotICAgICAgICBEaXIubWtkaXIoZGlyZWN0b3J5ICsgImxsdm0vU3VwcG9ydCIpCi0gICAg ICAgIG15c3lzKCJjcCIsICJpbmNsdWRlL2xsdm0vU3VwcG9ydC9EYXRhVHlwZXMuaCIsIGRpcmVj dG9yeSArICJsbHZtIiArICJTdXBwb3J0IikKKyAgICAgICAgbXlzeXMoInN2biIsICJleHBvcnQi LCAiaW5jbHVkZSIsIGRpcmVjdG9yeSArICJpbmNsdWRlIikKICAgICB9Ci0gICAgRGlyLmNoZGly KGRpcmVjdG9yeSkgeworICAgIERpci5jaGRpcihkaXJlY3RvcnkgKyAiaW5jbHVkZSIpIHsKICAg ICAgICAgbXlzeXMoInRhciIsICItY3l2ZiIsICRjdXJyZW50UGF0aCArICRpbmNsdWRlUGFja2Fn ZSwgIi4iKQogICAgIH0KIH0K