113913 2013-04-03 18:22:07 -0700 [SOUP] Remove unnecessary explicit keyword in SocketStreamError.h 2013-04-05 11:40:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned bfulgham commit-queue mrobinson xan.lopez oldest_to_newest 868986 0 seokju 2013-04-03 18:22:07 -0700 Patch to follow. 868987 1 196428 seokju 2013-04-03 18:24:57 -0700 Created attachment 196428 Patch 869100 2 196428 xan.lopez 2013-04-04 03:57:06 -0700 Comment on attachment 196428 Patch Why is the keyword not needed in this case? Do we want to use it in implicit conversions? 869112 3 seokju 2013-04-04 04:10:55 -0700 (In reply to comment #2) > (From update of attachment 196428 [details]) > Why is the keyword not needed in this case? Do we want to use it in implicit conversions? It seems that c++11 supports for explicit keyword on multi-arg constructor. But normally, we use the C++ keyword explicit for constructors with one argument. So, I have just removed it like other ports. 869643 4 xan.lopez 2013-04-05 01:46:15 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 196428 [details] [details]) > > Why is the keyword not needed in this case? Do we want to use it in implicit conversions? > > It seems that c++11 supports for explicit keyword on multi-arg constructor. > But normally, we use the C++ keyword explicit for constructors with one argument. > So, I have just removed it like other ports. It seems the ctor had originally just one argument, but then another was added in r102339 and the explicit keyword was not removed. If you say C++ before 11 does not support explicit multi-argument ctors then I guess it makse sense to remove it, but on the other hand WebKit is slowly moving to c++11 and this seems to be harmless. So no strong opinion here. Martin reviewed the original commit, so maybe he has an opinion. 869652 5 196428 cdumez 2013-04-05 02:10:52 -0700 Comment on attachment 196428 Patch LGTM. 869744 6 seokju 2013-04-05 06:47:51 -0700 Thanks! xan and cdumez. Martin Robinson : What do you think about it? 869899 7 196428 mrobinson 2013-04-05 11:18:41 -0700 Comment on attachment 196428 Patch I guess we can remove this. 869910 8 196428 commit-queue 2013-04-05 11:40:47 -0700 Comment on attachment 196428 Patch Clearing flags on attachment: 196428 Committed r147769: <http://trac.webkit.org/changeset/147769> 869911 9 commit-queue 2013-04-05 11:40:49 -0700 All reviewed patches have been landed. Closing bug. 196428 2013-04-03 18:24:57 -0700 2013-04-05 11:40:47 -0700 Patch bug-113913-20130404102446.patch text/plain 1516 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBmOWQzODk3Y2VjODg5 ZDk0OTYwMmI2NzViZDUzYjJkODk4NWQ5NC4uMjhlY2I5OTI3ZGMwNmI0MmVkMWI4OWNmMTAxZWIx OTM1MmNhOWYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTAzICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbU09VUF0gUmVtb3Zl IHVubmVjZXNzYXJ5IGV4cGxpY2l0IGtleXdvcmQgaW4gU29ja2V0U3RyZWFtRXJyb3IuaAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzOTEzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBqdXN0IHJlbW92aW5nIGFuIHVubmVjZXNzYXJ5IGNvZGUuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtRXJyb3IuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNv Y2tldFN0cmVhbUVycm9yOjpTb2NrZXRTdHJlYW1FcnJvcik6CisKIDIwMTMtMDQtMDMgIEhhbnMg TXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNpb25zXSBS ZW1vdmVkIEV4Y2x1c2lvblNoYXBlIGRlYWQgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0cmVhbUVycm9yLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtRXJyb3IuaAppbmRleCBhYTRh Nzg5ZTBjYmIxOTIwMGNiYzNhYTcxODQyM2QzNzcyYWI4OWJhLi4wNjc2ODkzY2U2Njc2NjM5MDcy ZmZmZGZkNWMwODZjNTkxZGI5YWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtRXJyb3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtRXJyb3IuaApAQCAtMzgsNyArMzgsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3MgU29ja2V0U3RyZWFtRXJyb3IgOiBwdWJs aWMgU29ja2V0U3RyZWFtRXJyb3JCYXNlIHsKICAgICBwdWJsaWM6CiAgICAgICAgIFNvY2tldFN0 cmVhbUVycm9yKCkgeyB9Ci0gICAgICAgIGV4cGxpY2l0IFNvY2tldFN0cmVhbUVycm9yKGludCBl cnJvckNvZGUsIGNvbnN0IGdjaGFyKiBkZXNjcmlwdGlvbikKKyAgICAgICAgU29ja2V0U3RyZWFt RXJyb3IoaW50IGVycm9yQ29kZSwgY29uc3QgZ2NoYXIqIGRlc2NyaXB0aW9uKQogICAgICAgICAg ICAgOiBTb2NrZXRTdHJlYW1FcnJvckJhc2UoZXJyb3JDb2RlLCBTdHJpbmcoKSwgU3RyaW5nKGRl c2NyaXB0aW9uKSkKICAgICAgICAgewogICAgICAgICB9Cg==