113909 2013-04-03 16:36:14 -0700 Add comment to clarify isStackingContext() in RenderLayer.h 2013-04-03 18:01:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh eric esprehn+autocc esprehn ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 868951 0 shawnsingh 2013-04-03 16:36:14 -0700 Trivial patch coming in a moment - please feel free to WontFix or cq+ this patch as you prefer. Thanks! 868953 1 196423 shawnsingh 2013-04-03 16:38:39 -0700 Created attachment 196423 Patch 868955 2 196423 esprehn 2013-04-03 16:42:06 -0700 Comment on attachment 196423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review > Source/WebCore/rendering/RenderLayer.h:861 > + // from the StyleResolver code. "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that. 868957 3 196424 shawnsingh 2013-04-03 16:55:07 -0700 Created attachment 196424 =Adjusted comment, patch for landing 868958 4 shawnsingh 2013-04-03 16:56:01 -0700 oops - i meant to do cq+ esphren, can you please r+ again The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK. 868959 5 esprehn 2013-04-03 16:57:01 -0700 (In reply to comment #2) > (From update of attachment 196423 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review > > > Source/WebCore/rendering/RenderLayer.h:861 > > + // from the StyleResolver code. > > "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that. (In reply to comment #4) > oops - i meant to do cq+ esphren, can you please r+ again > > The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK. nah, looks good to me. 868976 6 196424 webkit.review.bot 2013-04-03 18:01:23 -0700 Comment on attachment 196424 =Adjusted comment, patch for landing Clearing flags on attachment: 196424 Committed r147600: <http://trac.webkit.org/changeset/147600> 868977 7 webkit.review.bot 2013-04-03 18:01:27 -0700 All reviewed patches have been landed. Closing bug. 196423 2013-04-03 16:38:39 -0700 2013-04-03 16:55:05 -0700 Patch bug-113909-20130403163829.patch text/plain 1619 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODg0MzY3ZjczZDg2YWU3 OTZlZDA2YTAzYWZkYTBlOWM1NzA0MWFmMy4uOTU1NDdmYjFkMWIzZDExODkwY2M1NTVjNjZiOGM3 YjVlMjdlZGRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTAzICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBjb21tZW50 IHRvIGNsYXJpZnkgaXNTdGFja2luZ0NvbnRleHQoKSBpbiBSZW5kZXJMYXllci5oCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM5MDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB3YXMgbm90IG9idmlv dXMgaG93IHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBpc1N0YWNraW5nQ29udGV4dCgpCisgICAgICAg IHdhcyBjb3JyZWN0LCBhIGNvbW1lbnQgaXMgYXBwcm9wcmlhdGUgaGVyZSBmb3IgYW55b25lIHdo byByZWFkcworICAgICAgICB0aGlzIGNvZGUgaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBKdXN0 IGEgY2hhbmdlIGluIGNvbW1lbnQsIG5vIHRlc3QgbmVlZGVkLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyLmg6CisKIDIwMTMtMDQtMDEgIEphbWVzIFNpbW9uc2VuICA8c2ltb25q YW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtSZXNvdXJjZSBUaW1pbmddIEV4cG9zZSB0aW1p bmcgaW5mb3JtYXRpb24gZm9yIGlmcmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmgKaW5kZXggNWUxYzhjOWY4N2JhZjRmNDAzNmE5ZjFlNzk5YWVjYjNhNmFiOTk2MC4uZjdk MDgzOTdjNTJhYTA5NjUwMjhiYTQ0ZGM4MTZiMzU5MTFlM2IxNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTg1Nyw2ICs4NTcsOCBAQCBwcml2YXRlOgogCiAgICAg dm9pZCB1cGRhdGVOb3JtYWxGbG93TGlzdCgpOwogCisgICAgLy8gTm90ZTogcG9zaXRpb25pbmcg Y3JpdGVyaWEgYW5kIG90aGVyIHNwZWNpYWwgY2FzZXMgZm9yIGRldGVybWluaW5nIGEgc3RhY2tp bmcgY29udGV4dCBhcmUgYWxyZWFkeSBmb2xkZWQgaW50byBoYXNBdXRvWkluZGV4KCkKKyAgICAv LyAgICAgICBmcm9tIHRoZSBTdHlsZVJlc29sdmVyIGNvZGUuCiAgICAgYm9vbCBpc1N0YWNraW5n Q29udGV4dChjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0IHsgcmV0dXJuICFzdHlsZS0+ aGFzQXV0b1pJbmRleCgpIHx8IGlzUm9vdExheWVyKCk7IH0KIAogICAgIGJvb2wgaXNEaXJ0eVN0 YWNraW5nQ29udGFpbmVyKCkgY29uc3QgeyByZXR1cm4gbV96T3JkZXJMaXN0c0RpcnR5ICYmIGlz U3RhY2tpbmdDb250YWluZXIoKTsgfQo= 196424 2013-04-03 16:55:07 -0700 2013-04-03 18:01:23 -0700 =Adjusted comment, patch for landing bug-113909-20130403165457.patch text/plain 1619 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODg0MzY3ZjczZDg2YWU3 OTZlZDA2YTAzYWZkYTBlOWM1NzA0MWFmMy4uOTU1NDdmYjFkMWIzZDExODkwY2M1NTVjNjZiOGM3 YjVlMjdlZGRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTAzICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBjb21tZW50 IHRvIGNsYXJpZnkgaXNTdGFja2luZ0NvbnRleHQoKSBpbiBSZW5kZXJMYXllci5oCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM5MDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB3YXMgbm90IG9idmlv dXMgaG93IHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBpc1N0YWNraW5nQ29udGV4dCgpCisgICAgICAg IHdhcyBjb3JyZWN0LCBhIGNvbW1lbnQgaXMgYXBwcm9wcmlhdGUgaGVyZSBmb3IgYW55b25lIHdo byByZWFkcworICAgICAgICB0aGlzIGNvZGUgaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBKdXN0 IGEgY2hhbmdlIGluIGNvbW1lbnQsIG5vIHRlc3QgbmVlZGVkLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyLmg6CisKIDIwMTMtMDQtMDEgIEphbWVzIFNpbW9uc2VuICA8c2ltb25q YW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtSZXNvdXJjZSBUaW1pbmddIEV4cG9zZSB0aW1p bmcgaW5mb3JtYXRpb24gZm9yIGlmcmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmgKaW5kZXggNWUxYzhjOWY4N2JhZjRmNDAzNmE5ZjFlNzk5YWVjYjNhNmFiOTk2MC4uMDJi NWZiZjEyM2I4YWU1NjFkNmE4ZTUxMzQ5MDQ5NTk5YjQ3YmI2ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTg1Nyw2ICs4NTcsOCBAQCBwcml2YXRlOgogCiAgICAg dm9pZCB1cGRhdGVOb3JtYWxGbG93TGlzdCgpOwogCisgICAgLy8gTm9uLWF1dG8gei1pbmRleCBh bHdheXMgaW1wbGllcyBzdGFja2luZyBjb250ZXh0IGhlcmUsIGJlY2F1c2UgU3R5bGVSZXNvbHZl cjo6YWRqdXN0UmVuZGVyU3R5bGUgYWxyZWFkeSBhZGp1c3RzIHotaW5kZXgKKyAgICAvLyBiYXNl ZCBvbiBwb3NpdGlvbmluZyBhbmQgb3RoZXIgY3JpdGVyaWEuCiAgICAgYm9vbCBpc1N0YWNraW5n Q29udGV4dChjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0IHsgcmV0dXJuICFzdHlsZS0+ aGFzQXV0b1pJbmRleCgpIHx8IGlzUm9vdExheWVyKCk7IH0KIAogICAgIGJvb2wgaXNEaXJ0eVN0 YWNraW5nQ29udGFpbmVyKCkgY29uc3QgeyByZXR1cm4gbV96T3JkZXJMaXN0c0RpcnR5ICYmIGlz U3RhY2tpbmdDb250YWluZXIoKTsgfQo=