113904 2013-04-03 15:44:12 -0700 [CSS Exclusions] Removed ExclusionShape dead code 2013-04-03 17:04:23 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 giles_joplin giles_joplin eric esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 868932 0 giles_joplin 2013-04-03 15:44:12 -0700 The private ExclusionShape 'FloatRect boundingBox' field is no longer used. An ExclusionShape's shapeLogicalBoundingBox() is now always computed based on the padded or margin shape. 868936 1 196420 giles_joplin 2013-04-03 15:56:36 -0700 Created attachment 196420 Patch 868963 2 196420 webkit.review.bot 2013-04-03 17:04:19 -0700 Comment on attachment 196420 Patch Clearing flags on attachment: 196420 Committed r147597: <http://trac.webkit.org/changeset/147597> 868964 3 webkit.review.bot 2013-04-03 17:04:23 -0700 All reviewed patches have been landed. Closing bug. 196420 2013-04-03 15:56:36 -0700 2013-04-03 17:04:19 -0700 Patch tmp.patch text/plain 3638 giles_joplin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NDk4MzE0Li45ZjRmZjM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDQtMDMgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAg ICAgW0NTUyBFeGNsdXNpb25zXSBSZW1vdmVkIEV4Y2x1c2lvblNoYXBlIGRlYWQgY29kZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzOTA0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBqdXN0IHJlbW92aW5nIGRlYWQgY29kZS4KKworICAgICAgICAqIHJlbmRlcmluZy9FeGNsdXNp b25TaGFwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFeGNsdXNpb25TaGFwZTo6Y3JlYXRlRXhj bHVzaW9uU2hhcGUpOgorICAgICAgICAqIHJlbmRlcmluZy9FeGNsdXNpb25TaGFwZS5oOgorICAg ICAgICAoRXhjbHVzaW9uU2hhcGUpOgorCiAyMDEzLTA0LTAzICBEYXZlIE1pY2hhZWwgIDxkbWlj aGFlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5hYmxlIHRvIGZvY3VzIG9uIGVtYmVkZGVk IHBsdWdpbnMgc3VjaCBhcyBGbGFzaCB2aWEgamF2YXNjcmlwdCBmb2N1cygpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGUuY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0V4Y2x1c2lvblNoYXBlLmNwcAppbmRleCA5ZDMyOTEwLi5lNTIyMjNm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNpb25TaGFwZS5jcHAKQEAgLTEx Niw3ICsxMTYsNiBAQCBQYXNzT3duUHRyPEV4Y2x1c2lvblNoYXBlPiBFeGNsdXNpb25TaGFwZTo6 Y3JlYXRlRXhjbHVzaW9uU2hhcGUoY29uc3QgQmFzaWNTaGFwZQogICAgICAgICBGbG9hdFJlY3Qg bG9naWNhbEJvdW5kcyA9IHBoeXNpY2FsUmVjdFRvTG9naWNhbChib3VuZHMsIGxvZ2ljYWxCb3hI ZWlnaHQsIHdyaXRpbmdNb2RlKTsKIAogICAgICAgICBleGNsdXNpb25TaGFwZSA9IGNyZWF0ZUV4 Y2x1c2lvblJlY3RhbmdsZShsb2dpY2FsQm91bmRzLCBwaHlzaWNhbFNpemVUb0xvZ2ljYWwoY29y bmVyUmFkaWksIHdyaXRpbmdNb2RlKSk7Ci0gICAgICAgIGV4Y2x1c2lvblNoYXBlLT5tX2JvdW5k aW5nQm94ID0gbG9naWNhbEJvdW5kczsKICAgICAgICAgYnJlYWs7CiAgICAgfQogCkBAIC0xMjgs NyArMTI3LDYgQEAgUGFzc093blB0cjxFeGNsdXNpb25TaGFwZT4gRXhjbHVzaW9uU2hhcGU6OmNy ZWF0ZUV4Y2x1c2lvblNoYXBlKGNvbnN0IEJhc2ljU2hhcGUKICAgICAgICAgRmxvYXRQb2ludCBs b2dpY2FsQ2VudGVyID0gcGh5c2ljYWxQb2ludFRvTG9naWNhbChGbG9hdFBvaW50KGNlbnRlclgs IGNlbnRlclkpLCBsb2dpY2FsQm94SGVpZ2h0LCB3cml0aW5nTW9kZSk7CiAKICAgICAgICAgZXhj bHVzaW9uU2hhcGUgPSBjcmVhdGVFeGNsdXNpb25DaXJjbGUobG9naWNhbENlbnRlciwgcmFkaXVz KTsKLSAgICAgICAgZXhjbHVzaW9uU2hhcGUtPm1fYm91bmRpbmdCb3ggPSBGbG9hdFJlY3QobG9n aWNhbENlbnRlci54KCkgLSByYWRpdXMsIGxvZ2ljYWxDZW50ZXIueSgpIC0gcmFkaXVzLCByYWRp dXMgKiAyLCByYWRpdXMgKiAyKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogCkBAIC0xNDIsNyAr MTQwLDYgQEAgUGFzc093blB0cjxFeGNsdXNpb25TaGFwZT4gRXhjbHVzaW9uU2hhcGU6OmNyZWF0 ZUV4Y2x1c2lvblNoYXBlKGNvbnN0IEJhc2ljU2hhcGUKICAgICAgICAgRmxvYXRTaXplIGxvZ2lj YWxSYWRpaSA9IHBoeXNpY2FsU2l6ZVRvTG9naWNhbChGbG9hdFNpemUocmFkaXVzWCwgcmFkaXVz WSksIHdyaXRpbmdNb2RlKTsKIAogICAgICAgICBleGNsdXNpb25TaGFwZSA9IGNyZWF0ZUV4Y2x1 c2lvbkVsbGlwc2UobG9naWNhbENlbnRlciwgbG9naWNhbFJhZGlpKTsKLSAgICAgICAgZXhjbHVz aW9uU2hhcGUtPm1fYm91bmRpbmdCb3ggPSBGbG9hdFJlY3QobG9naWNhbENlbnRlciAtIGxvZ2lj YWxSYWRpaSwgbG9naWNhbFJhZGlpICsgbG9naWNhbFJhZGlpKTsKICAgICAgICAgYnJlYWs7CiAg ICAgfQogCkBAIC0xNTEsMjAgKzE0OCwxNSBAQCBQYXNzT3duUHRyPEV4Y2x1c2lvblNoYXBlPiBF eGNsdXNpb25TaGFwZTo6Y3JlYXRlRXhjbHVzaW9uU2hhcGUoY29uc3QgQmFzaWNTaGFwZQogICAg ICAgICBjb25zdCBWZWN0b3I8TGVuZ3RoPiYgdmFsdWVzID0gcG9seWdvbi0+dmFsdWVzKCk7CiAg ICAgICAgIHNpemVfdCB2YWx1ZXNTaXplID0gdmFsdWVzLnNpemUoKTsKICAgICAgICAgQVNTRVJU KCEodmFsdWVzU2l6ZSAlIDIpKTsKLSAgICAgICAgRmxvYXRSZWN0IGJvdW5kaW5nQm94OwogICAg ICAgICBWZWN0b3I8RmxvYXRQb2ludD4qIHZlcnRpY2VzID0gbmV3IFZlY3RvcjxGbG9hdFBvaW50 Pih2YWx1ZXNTaXplIC8gMik7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCB2YWx1 ZXNTaXplOyBpICs9IDIpIHsKICAgICAgICAgICAgIEZsb2F0UG9pbnQgdmVydGV4KAogICAgICAg ICAgICAgICAgIGZsb2F0VmFsdWVGb3JMZW5ndGgodmFsdWVzLmF0KGkpLCBib3hXaWR0aCksCiAg ICAgICAgICAgICAgICAgZmxvYXRWYWx1ZUZvckxlbmd0aCh2YWx1ZXMuYXQoaSArIDEpLCBib3hI ZWlnaHQpKTsKICAgICAgICAgICAgICgqdmVydGljZXMpW2kgLyAyXSA9IHBoeXNpY2FsUG9pbnRU b0xvZ2ljYWwodmVydGV4LCBsb2dpY2FsQm94SGVpZ2h0LCB3cml0aW5nTW9kZSk7Ci0gICAgICAg ICAgICBpZiAoIWkpCi0gICAgICAgICAgICAgICAgYm91bmRpbmdCb3guc2V0TG9jYXRpb24odmVy dGV4KTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBib3VuZGluZ0JveC5leHRl bmQodmVydGV4KTsKICAgICAgICAgfQorCiAgICAgICAgIGV4Y2x1c2lvblNoYXBlID0gY3JlYXRl RXhjbHVzaW9uUG9seWdvbihhZG9wdFB0cih2ZXJ0aWNlcyksIHBvbHlnb24tPndpbmRSdWxlKCkp OwotICAgICAgICBleGNsdXNpb25TaGFwZS0+bV9ib3VuZGluZ0JveCA9IGJvdW5kaW5nQm94Owog ICAgICAgICBicmVhazsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9FeGNsdXNpb25TaGFwZS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V4Y2x1c2lv blNoYXBlLmgKaW5kZXggNDIwZjA2My4uNjJjM2JlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0V4Y2x1c2lvblNoYXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0V4Y2x1c2lvblNoYXBlLmgKQEAgLTc2LDcgKzc2LDYgQEAgcHJpdmF0ZToKICAgICBXcml0 aW5nTW9kZSBtX3dyaXRpbmdNb2RlOwogICAgIGZsb2F0IG1fbG9naWNhbEJveFdpZHRoOwogICAg IGZsb2F0IG1fbG9naWNhbEJveEhlaWdodDsKLSAgICBGbG9hdFJlY3QgbV9ib3VuZGluZ0JveDsK ICAgICBmbG9hdCBtX21hcmdpbjsKICAgICBmbG9hdCBtX3BhZGRpbmc7CiB9Owo=