113882 2013-04-03 09:24:19 -0700 REGRESSION(130231): Leaves m_glyphToCharacterIndexes uninitialized 2013-04-15 12:59:57 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 d-r d-r bashi glenn tony oldest_to_newest 868755 0 d-r 2013-04-03 09:24:19 -0700 As commented in https://bugs.webkit.org/show_bug.cgi?id=97993#c13 the patch from r130231 removes - hb_glyph_info_t* infos = hb_buffer_get_glyph_infos(harfBuzzBuffer, 0); - for (unsigned i = 0; i < m_numGlyphs; ++i) - m_glyphToCharacterIndexes[i] = infos[i].cluster; in HarfBuzzShaper::HarfBuzzRun::applyShapeResult. And I can't see any replacement for that in r130231. AFAICS, with that, m_glyphToCharacterIndexes becomes uninitialized. Unfortunately, I don't have a test to prove it yet. But I am suspecting it breaks selection in certain cases. 868763 1 196364 d-r 2013-04-03 09:35:52 -0700 Created attachment 196364 Patch 869164 2 d-r 2013-04-04 08:32:30 -0700 Never mind, it is initialized in @@ -361,6 +346,7 @@ void HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun(HarfBuzzRun* currentRun, hb hb_glyph_position_t* glyphPositions = hb_buffer_get_glyph_positions(harfbuzzBuffer, 0); unsigned numGlyphs = currentRun->numGlyphs(); + uint16_t* glyphToCharacterIndexes = currentRun->glyphToCharacterIndexes(); 870203 3 196364 bfulgham 2013-04-05 20:28:13 -0700 Comment on attachment 196364 Patch Clearing review patch since this was resolved. 196364 2013-04-03 09:35:52 -0700 2013-04-15 12:59:57 -0700 Patch bug-113882-20130403193540.patch text/plain 2009 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjEyOTEyNjg2NmI0YTZm YzU4NGIzMjVjOWNlYzE2N2YwZjc0NGZjZi4uZDA4ZjdjOWJlODc5MjdlOGE3NTNkYThiZDc3Mzgw NzVlZjg0MTY2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTAzICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTigxMzAyMzEpOiBMZWF2ZXMgbV9nbHlwaFRvQ2hhcmFjdGVySW5kZXhlcyB1bmlu aXRpYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTM4ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWluc2VydGluZyB0aGUgbV9nbHlwaFRvQ2hyYWN0ZXJJbmRleGVzIGNvcHlpbmcgYWZ0ZXIg aXQgd2FzCisgICAgICAgIHByb2JhYmx5IGFjY2lkZW50YWxseSByZW1vdmVkIGluIHIxMzAyMzEu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzbyBmYXIgdW5hYmxlIHRvIGZpbmQgYSB0ZXN0IGNh c2UgdGhhdCBleHBvc2VzIHRoaXMgY29kZSBwYXRoLgorICAgICAgICBMaWtlbHkgZXhwb3NlZCB3 aGVuIGRvaW5nIG1vdXNlIHNlbGVjdGlvbiBvZiBjaGFyYWN0ZXJzIHRoYXQKKyAgICAgICAgYXJl IGNvbWJpbmVkIGludG8gc2luZ2xlIGdseXBocy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2hhcmZidXp6L0hhcmZCdXp6U2hhcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhhcmZC dXp6U2hhcGVyOjpIYXJmQnV6elJ1bjo6YXBwbHlTaGFwZVJlc3VsdCk6CisKIDIwMTMtMDQtMDIg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtC bGFja0JlcnJ5XSBJbXBsZW1lbnQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld0xheW91 dFVwZGF0ZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv aGFyZmJ1enovSGFyZkJ1enpTaGFwZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXIuY3BwCmluZGV4IDhlZDJiNGE2YTkxMGVjOGM4 NmVlMzRmOWViZTYyMTllMjkwMTBiNzIuLmZjYmNmZDcyYjNmNmY0MWZjMjhiM2NiNDUwOTZjNWNk OTcwMTJhYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hh cmZidXp6L0hhcmZCdXp6U2hhcGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9oYXJmYnV6ei9IYXJmQnV6elNoYXBlci5jcHAKQEAgLTg4LDYgKzg4LDEwIEBAIHZv aWQgSGFyZkJ1enpTaGFwZXI6OkhhcmZCdXp6UnVuOjphcHBseVNoYXBlUmVzdWx0KGhiX2J1ZmZl cl90KiBoYXJmQnV6ekJ1ZmZlcikKICAgICBtX2FkdmFuY2VzLnJlc2l6ZShtX251bUdseXBocyk7 CiAgICAgbV9nbHlwaFRvQ2hhcmFjdGVySW5kZXhlcy5yZXNpemUobV9udW1HbHlwaHMpOwogICAg IG1fb2Zmc2V0cy5yZXNpemUobV9udW1HbHlwaHMpOworCisgICAgaGJfZ2x5cGhfaW5mb190KiBp bmZvcyA9IGhiX2J1ZmZlcl9nZXRfZ2x5cGhfaW5mb3MoaGFyZkJ1enpCdWZmZXIsIDApOworICAg IGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX251bUdseXBoczsgKytpKQorICAgICAgICBtX2ds eXBoVG9DaGFyYWN0ZXJJbmRleGVzW2ldID0gaW5mb3NbaV0uY2x1c3RlcjsKIH0KIAogdm9pZCBI YXJmQnV6elNoYXBlcjo6SGFyZkJ1enpSdW46OnNldEdseXBoQW5kUG9zaXRpb25zKHVuc2lnbmVk IGluZGV4LCB1aW50MTZfdCBnbHlwaElkLCBmbG9hdCBhZHZhbmNlLCBmbG9hdCBvZmZzZXRYLCBm bG9hdCBvZmZzZXRZKQo=