113873 2013-04-03 06:50:10 -0700 WinCairo build fails to link. 2013-04-04 23:45:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue oldest_to_newest 868686 0 peavo 2013-04-03 06:50:10 -0700 The symbols FrameView::setHeaderHeight(int) and FrameView::setFooterHeight(int) are reported as unresolved externals. They are only compiled if ACCELERATED_COMPOSITING is used. 868691 1 196345 peavo 2013-04-03 07:00:59 -0700 Created attachment 196345 Patch 868692 2 peavo 2013-04-03 07:02:05 -0700 Removed double guards for USE(ACCELERATED_COMPOSITING), and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors. 869575 3 196345 bfulgham 2013-04-04 23:17:07 -0700 Comment on attachment 196345 Patch R=me 869587 4 196345 commit-queue 2013-04-04 23:45:14 -0700 Comment on attachment 196345 Patch Clearing flags on attachment: 196345 Committed r147713: <http://trac.webkit.org/changeset/147713> 869588 5 commit-queue 2013-04-04 23:45:16 -0700 All reviewed patches have been landed. Closing bug. 196345 2013-04-03 07:00:59 -0700 2013-04-04 23:45:14 -0700 Patch bug-113873-20130403160037.patch text/plain 3623 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzU0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTAzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFdpbkNhaXJvIGJ1aWxk IGZhaWxzIHRvIGxpbmsuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTM4NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmVkIGRvdWJsZSBndWFyZHMgZm9yIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJ VElORyksCisgICAgICAgIGFuZCBtb3ZlZCBtZXRob2RzIG91dCBvZiBVU0UoQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpIGd1YXJkIHRvIGZpeCBsaW5rZXIgZXJyb3JzLiAKKworICAgICAgICAqIHBh Z2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2V0V2FudHNM YXllckZvclRvcE92ZXJIYW5nQXJlYSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnNl dFdhbnRzTGF5ZXJGb3JCb3R0b21PdmVySGFuZ0FyZWEpOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3OjpzZXRXYW50c0xheWVyRm9ySGVhZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l Vmlldzo6c2V0V2FudHNMYXllckZvckZvb3Rlcik6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZp ZXc6OnNldEhlYWRlckhlaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnNldEZv b3RlckhlaWdodCk6CisKIDIwMTMtMDQtMDMgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vvay5vaEBj b2xsYWJvcmEuY29tPgogCiAgICAgICAgIFtHVEtdW0FDXSBJbXBsZW1lbnQgbWF0cml4IGtleWZy YW1lIGFuaW1hdGlvbnMgd2l0aCBjbHV0dGVyIGFjIGJhY2tlbmQKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDE0NzUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODY3LDExICs4NjcsNyBAQCBHcmFwaGlj c0xheWVyKiBGcmFtZVZpZXc6OnNldFdhbnRzTGF5ZXJGCiAgICAgaWYgKCFyZW5kZXJWaWV3KQog ICAgICAgICByZXR1cm4gMDsKIAotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAg ICByZXR1cm4gcmVuZGVyVmlldy0+Y29tcG9zaXRvcigpLT51cGRhdGVMYXllckZvclRvcE92ZXJo YW5nQXJlYSh3YW50c0xheWVyKTsKLSNlbHNlCi0gICAgcmV0dXJuIDA7Ci0jZW5kaWYKIH0KIAog R3JhcGhpY3NMYXllciogRnJhbWVWaWV3OjpzZXRXYW50c0xheWVyRm9yQm90dG9tT3ZlckhhbmdB cmVhKGJvb2wgd2FudHNMYXllcikgY29uc3QKQEAgLTg4MCwxMSArODc2LDcgQEAgR3JhcGhpY3NM YXllciogRnJhbWVWaWV3OjpzZXRXYW50c0xheWVyRgogICAgIGlmICghcmVuZGVyVmlldykKICAg ICAgICAgcmV0dXJuIDA7CiAKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAg cmV0dXJuIHJlbmRlclZpZXctPmNvbXBvc2l0b3IoKS0+dXBkYXRlTGF5ZXJGb3JCb3R0b21PdmVy aGFuZ0FyZWEod2FudHNMYXllcik7Ci0jZWxzZQotICAgIHJldHVybiAwOwotI2VuZGlmCiB9CiAK IEdyYXBoaWNzTGF5ZXIqIEZyYW1lVmlldzo6c2V0V2FudHNMYXllckZvckhlYWRlcihib29sIHdh bnRzTGF5ZXIpIGNvbnN0CkBAIC04OTUsMTEgKzg4Nyw3IEBAIEdyYXBoaWNzTGF5ZXIqIEZyYW1l Vmlldzo6c2V0V2FudHNMYXllckYKIAogICAgIEFTU0VSVChtX2ZyYW1lID09IG1fZnJhbWUtPnBh Z2UoKS0+bWFpbkZyYW1lKCkpOwogCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQog ICAgIHJldHVybiByZW5kZXJWaWV3LT5jb21wb3NpdG9yKCktPnVwZGF0ZUxheWVyRm9ySGVhZGVy KHdhbnRzTGF5ZXIpOwotI2Vsc2UKLSAgICByZXR1cm4gMDsKLSNlbmRpZgogfQogCiBHcmFwaGlj c0xheWVyKiBGcmFtZVZpZXc6OnNldFdhbnRzTGF5ZXJGb3JGb290ZXIoYm9vbCB3YW50c0xheWVy KSBjb25zdApAQCAtOTEwLDI4ICs4OTgsMTAgQEAgR3JhcGhpY3NMYXllciogRnJhbWVWaWV3Ojpz ZXRXYW50c0xheWVyRgogCiAgICAgQVNTRVJUKG1fZnJhbWUgPT0gbV9mcmFtZS0+cGFnZSgpLT5t YWluRnJhbWUoKSk7CiAKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgcmV0 dXJuIHJlbmRlclZpZXctPmNvbXBvc2l0b3IoKS0+dXBkYXRlTGF5ZXJGb3JGb290ZXIod2FudHNM YXllcik7Ci0jZWxzZQotICAgIHJldHVybiAwOwotI2VuZGlmCiB9CiAKLSNlbmRpZgotCi12b2lk IEZyYW1lVmlldzo6c2V0SGVhZGVySGVpZ2h0KGludCBoZWFkZXJIZWlnaHQpCi17Ci0gICAgaWYg KG1fZnJhbWUgJiYgbV9mcmFtZS0+cGFnZSgpKQotICAgICAgICBBU1NFUlQobV9mcmFtZSA9PSBt X2ZyYW1lLT5wYWdlKCktPm1haW5GcmFtZSgpKTsKLSAgICBtX2hlYWRlckhlaWdodCA9IGhlYWRl ckhlaWdodDsKLX0KLQotdm9pZCBGcmFtZVZpZXc6OnNldEZvb3RlckhlaWdodChpbnQgZm9vdGVy SGVpZ2h0KQotewotICAgIGlmIChtX2ZyYW1lICYmIG1fZnJhbWUtPnBhZ2UoKSkKLSAgICAgICAg QVNTRVJUKG1fZnJhbWUgPT0gbV9mcmFtZS0+cGFnZSgpLT5tYWluRnJhbWUoKSk7Ci0gICAgbV9m b290ZXJIZWlnaHQgPSBmb290ZXJIZWlnaHQ7Ci19CisjZW5kaWYgLy8gRU5BQkxFKFJVQkJFUl9C QU5ESU5HKQogCiBib29sIEZyYW1lVmlldzo6Zmx1c2hDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0Zy YW1lKEZyYW1lKiByb290RnJhbWVGb3JGbHVzaCkKIHsKQEAgLTk2NCw2ICs5MzQsMjAgQEAgdm9p ZCBGcmFtZVZpZXc6OnNldE5lZWRzT25lU2hvdERyYXdpbmdTeQogCiAjZW5kaWYgLy8gVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogCit2b2lkIEZyYW1lVmlldzo6c2V0SGVhZGVySGVpZ2h0 KGludCBoZWFkZXJIZWlnaHQpCit7CisgICAgaWYgKG1fZnJhbWUgJiYgbV9mcmFtZS0+cGFnZSgp KQorICAgICAgICBBU1NFUlQobV9mcmFtZSA9PSBtX2ZyYW1lLT5wYWdlKCktPm1haW5GcmFtZSgp KTsKKyAgICBtX2hlYWRlckhlaWdodCA9IGhlYWRlckhlaWdodDsKK30KKwordm9pZCBGcmFtZVZp ZXc6OnNldEZvb3RlckhlaWdodChpbnQgZm9vdGVySGVpZ2h0KQoreworICAgIGlmIChtX2ZyYW1l ICYmIG1fZnJhbWUtPnBhZ2UoKSkKKyAgICAgICAgQVNTRVJUKG1fZnJhbWUgPT0gbV9mcmFtZS0+ cGFnZSgpLT5tYWluRnJhbWUoKSk7CisgICAgbV9mb290ZXJIZWlnaHQgPSBmb290ZXJIZWlnaHQ7 Cit9CisKIGJvb2wgRnJhbWVWaWV3OjpoYXNDb21wb3NpdGVkQ29udGVudCgpIGNvbnN0CiB7CiAj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQo=