113872 2013-04-03 06:21:41 -0700 [BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments 2013-04-03 07:34:27 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson cgarcia mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 868675 0 anilsson 2013-04-03 06:21:41 -0700 The recomputeVirtualViewportFromViewportArguments method already contains the check, as pointed out by cgarcia on bug #113829 =) 868680 1 196340 anilsson 2013-04-03 06:30:32 -0700 Created attachment 196340 Patch 868685 2 196340 cgarcia 2013-04-03 06:49:37 -0700 Comment on attachment 196340 Patch Perfect! 868703 3 webkit.review.bot 2013-04-03 07:33:00 -0700 The commit-queue encountered the following flaky tests while processing attachment 196340: fast/js/dfg-inline-resolve.html bug 113046 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. 868704 4 196340 webkit.review.bot 2013-04-03 07:34:24 -0700 Comment on attachment 196340 Patch Clearing flags on attachment: 196340 Committed r147552: <http://trac.webkit.org/changeset/147552> 868705 5 webkit.review.bot 2013-04-03 07:34:27 -0700 All reviewed patches have been landed. Closing bug. 196340 2013-04-03 06:30:32 -0700 2013-04-03 07:34:24 -0700 Patch bug-113872-20130403153022.patch text/plain 2235 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmYmEzMGIwOWRiMmVjOGYwNDA2ZGQxMTdhNTk5Y2M0MzQ3MTM5NzkxLi4yMDUxOGUyMDYy MDkxOGZmMzMyZWRiMWRjZmYxMjYxYTYxMGUxYjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMy0wNC0wMyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSBkZWZhdWx0Vmlld3Bv cnRBcmd1bWVudHMgY2hlY2sgZnJvbSBjYWxsIHNpdGUgb2YgcmVjb21wdXRlVmlydHVhbFZpZXdw b3J0RnJvbVZpZXdwb3J0QXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTM4NzIKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2Fy Y2lhIENhbXBvcy4KKworICAgICAgICBDYXJsb3MgcG9pbnRlZCBvdXQgdGhhdCByZWNvbXB1dGVW aXJ0dWFsVmlld3BvcnRGcm9tVmlld3BvcnRBcmd1bWVudHMKKyAgICAgICAgYWxyZWFkeSBjb250 YWlucyB0aGUgY2hlY2ssIGFuZCByZXR1cm5zIGFuIGVtcHR5IEludFNpemUgaWYgaXQgZmFpbHMu CisgICAgICAgIFNvIHBpY2sgdXAgb24gdGhhdCB0byBtYWtlIHRoZSBjb2RlIGEgYml0IG1vcmUg RFJZLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRTaXplKToKKworMjAxMy0wNC0wMyAg QXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNrQmVycnld IERlY291cGxlIGxheW91dCB2aWV3cG9ydCBmcm9tIHZpc3VhbCB2aWV3cG9ydAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzODI5CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDVmMDMyNzE4ZDE0ZmViOGU0MjU3 NTBkMTA4ZDk1N2VmNWVkNDk3YTguLjE0NDQ3ODBmMWU4MTE5MTdhYzU0M2I1OTAxZWUyYzcyZjRm MjY2MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMzY4 MiwxMSArMzY4Miw4IEBAIGJvb2wgV2ViUGFnZVByaXZhdGU6OnNldFZpZXdwb3J0U2l6ZShjb25z dCBJbnRTaXplJiB0cmFuc2Zvcm1lZEFjdHVhbFZpc2libGVTaXplCiAKICAgICAvLyBSZWNvbXB1 dGUgb3VyIHZpcnR1YWwgdmlld3BvcnQuCiAgICAgYm9vbCBuZWVkc0xheW91dCA9IGZhbHNlOwot ICAgIHN0YXRpYyBWaWV3cG9ydEFyZ3VtZW50cyBkZWZhdWx0Vmlld3BvcnRBcmd1bWVudHM7Ci0g ICAgaWYgKG1fdmlld3BvcnRBcmd1bWVudHMgIT0gZGVmYXVsdFZpZXdwb3J0QXJndW1lbnRzKSB7 Ci0gICAgICAgIC8vIFdlIG1heSBuZWVkIHRvIGluZmVyIHRoZSB3aWR0aCBhbmQgaGVpZ2h0IGZv ciB0aGUgdmlld3BvcnQgd2l0aCByZXNwZWN0IHRvIHRoZSByb3RhdGlvbi4KLSAgICAgICAgUGxh dGZvcm06OkludFNpemUgbmV3VmlydHVhbFZpZXdwb3J0ID0gcmVjb21wdXRlVmlydHVhbFZpZXdw b3J0RnJvbVZpZXdwb3J0QXJndW1lbnRzKCk7Ci0gICAgICAgIEFTU0VSVCghbmV3VmlydHVhbFZp ZXdwb3J0LmlzRW1wdHkoKSk7CisgICAgUGxhdGZvcm06OkludFNpemUgbmV3VmlydHVhbFZpZXdw b3J0ID0gcmVjb21wdXRlVmlydHVhbFZpZXdwb3J0RnJvbVZpZXdwb3J0QXJndW1lbnRzKCk7Cisg ICAgaWYgKCFuZXdWaXJ0dWFsVmlld3BvcnQuaXNFbXB0eSgpKSB7CiAgICAgICAgIG1fd2ViUGFn ZS0+c2V0VmlydHVhbFZpZXdwb3J0U2l6ZShuZXdWaXJ0dWFsVmlld3BvcnQpOwogICAgICAgICBt X21haW5GcmFtZS0+dmlldygpLT5zZXRVc2VGaXhlZExheW91dCh1c2VGaXhlZExheW91dCgpKTsK ICAgICAgICAgbV9tYWluRnJhbWUtPnZpZXcoKS0+c2V0Rml4ZWRMYXlvdXRTaXplKGZpeGVkTGF5 b3V0U2l6ZSgpKTsK