113864 2013-04-03 03:42:18 -0700 [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt. 2013-04-03 09:26:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 113865 113866 1 zeno zeno hausmann oldest_to_newest 868590 0 zeno 2013-04-03 03:42:18 -0700 [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt. 868591 1 196318 zeno 2013-04-03 03:43:40 -0700 Created attachment 196318 Patch 868616 2 196318 hausmann 2013-04-03 04:20:50 -0700 Comment on attachment 196318 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196318&action=review r=me, but the getter needs to be fixed before landing IMHO > Tools/ChangeLog:7 > + As long as we instantiate both TestRunner and TestRunnerQt, > + we need a separate getter for the non-Qt TestRunner instance. ChangeLog shoudl also mention that this moves setDefersLoading at the same time. I think given the size of this patch it's okay if both go in at the same time. Just maybe fix the ChangeLog text before landing :) > Tools/DumpRenderTree/qt/DumpRenderTreeQt.h:92 > + PassRefPtr<TestRunner> jscTestRunner() const { return m_jscController; } I think the common pattern is to use PassRefPtr as return value for create functions, but use raw pointers for getters, i.e. TestRunner* jscTestRunner() { return m_jscController.get(); } If the caller wants to keep a ref, then the RefPtr ctor that takes a raw pointer will do the ref. Otherwise I think PassRefPtr doesn't give us anything here. 868757 3 zeno 2013-04-03 09:26:27 -0700 Committed r147563: <http://trac.webkit.org/changeset/147563> 196318 2013-04-03 03:43:40 -0700 2013-04-03 04:20:50 -0700 Patch bug-113864-20130403124341.patch text/plain 4001 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGJkMDU0YWM1MjllMjdhZmY4OTExODA5MTU2ZGZkZjY5 M2ZkMDllNS4uZTRmMjdhYzI0Njk0YTNmYzU2MjliYzgxMjMzNzdkZGNkY2IyMTAyZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEzLTA0LTAzICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgorCisgICAg ICAgIFtRdF0gQWRkIGdldHRlciBmb3IgSlNDIFRlc3RSdW5uZXIgdG8gRHVtcFJlbmRlclRyZWVR dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzg2 NAorCisgICAgICAgIEFzIGxvbmcgYXMgd2UgaW5zdGFudGlhdGUgYm90aCBUZXN0UnVubmVyIGFu ZCBUZXN0UnVubmVyUXQsCisgICAgICAgIHdlIG5lZWQgYSBzZXBhcmF0ZSBnZXR0ZXIgZm9yIHRo ZSBub24tUXQgVGVzdFJ1bm5lciBpbnN0YW5jZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVl UXQuY3BwOgorICAgICAgICAoV2ViUGFnZTo6cmVzZXRTZXR0aW5ncyk6CisgICAgICAgICogRHVt cFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5oOgorICAgICAgICAoRHVtcFJlbmRlclRy ZWU6OmpzY1Rlc3RSdW5uZXIpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5u ZXJRdC5jcHA6CisgICAgICAgIChUZXN0UnVubmVyOjpzZXREZWZlcnNMb2FkaW5nKToKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuaDoKKyAgICAgICAgKFRlc3RSdW5u ZXJRdCk6CisKIDIwMTMtMDQtMDIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDc0MDEuCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcCBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCmluZGV4IGVmM2UzOGZm M2U5ODk5NGYzMWM2OTkzNTgxOWUwZmEyZWU0NTZlMzUuLjJmYjg3ODI2N2RjNmYwNjhiM2NmYWZk ZDhlZTU0NDFmMDg1ZmVmNDUgMTAwNzU1Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1 bXBSZW5kZXJUcmVlUXQuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5k ZXJUcmVlUXQuY3BwCkBAIC0xOTQsNyArMTk0LDcgQEAgdm9pZCBXZWJQYWdlOjpyZXNldFNldHRp bmdzKCkKIAogICAgIG1fZHJ0LT50ZXN0UnVubmVyKCktPnNldENhcmV0QnJvd3NpbmdFbmFibGVk KGZhbHNlKTsKICAgICBtX2RydC0+dGVzdFJ1bm5lcigpLT5zZXRBdXRob3JBbmRVc2VyU3R5bGVz RW5hYmxlZCh0cnVlKTsKLSAgICBtX2RydC0+dGVzdFJ1bm5lcigpLT5zZXREZWZlcnNMb2FkaW5n KGZhbHNlKTsKKyAgICBtX2RydC0+anNjVGVzdFJ1bm5lcigpLT5zZXREZWZlcnNMb2FkaW5nKGZh bHNlKTsKIAogICAgIC8vIGdsb2JhbFNldHRpbmdzIG11c3QgYmUgcmVzZXQgZXhwbGljaXRseS4K ICAgICBtX2RydC0+dGVzdFJ1bm5lcigpLT5zZXRYU1NBdWRpdG9yRW5hYmxlZChmYWxzZSk7CmRp ZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmggYi9U b29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmgKaW5kZXggMTNkOWU2NTQ5 YmNmOTM4NzVlZTZlZmJhZGFiZTA2NTRiMzdkOTRkNi4uMjkzNjk5NGRjM2ZkOTE5OWY1NDUyOGEx MjI2MjNlYmIzY2VhMGNhYSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVt cFJlbmRlclRyZWVRdC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJU cmVlUXQuaApAQCAtODksNiArODksNyBAQCBwdWJsaWM6CiAgICAgdm9pZCByZXNldFRvQ29uc2lz dGVudFN0YXRlQmVmb3JlVGVzdGluZyhjb25zdCBRVXJsJik7CiAKICAgICBUZXN0UnVubmVyUXQg KnRlc3RSdW5uZXIoKSBjb25zdCB7IHJldHVybiBtX2NvbnRyb2xsZXI7IH0KKyAgICBQYXNzUmVm UHRyPFRlc3RSdW5uZXI+IGpzY1Rlc3RSdW5uZXIoKSBjb25zdCB7IHJldHVybiBtX2pzY0NvbnRy b2xsZXI7IH0KICAgICBFdmVudFNlbmRlciAqZXZlbnRTZW5kZXIoKSBjb25zdCB7IHJldHVybiBt X2V2ZW50U2VuZGVyOyB9CiAgICAgVGV4dElucHV0Q29udHJvbGxlciAqdGV4dElucHV0Q29udHJv bGxlcigpIGNvbnN0IHsgcmV0dXJuIG1fdGV4dElucHV0Q29udHJvbGxlcjsgfQogICAgIFFTdHJp bmcgcGVyc2lzdGVudFN0b3JhZ2VQYXRoKCkgY29uc3QgeyByZXR1cm4gbV9wZXJzaXN0ZW50U3Rv cmFnZVBhdGg7IH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5u ZXJRdC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuY3BwCmluZGV4 IDEwNzgzN2VkZTU2NGQwMjliNTk2YjYwYjhjYjM3YWY2MDU3Njg2MTQuLmZmYWI4YjEwZjgwYjdi ZDg2M2M1Njc5MDU0ODNkZGYyZjA0Nzk5NzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L1Rlc3RSdW5uZXJRdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVz dFJ1bm5lclF0LmNwcApAQCAtNDI2LDExICs0MjYsNiBAQCB2b2lkIFRlc3RSdW5uZXJRdDo6Z29C YWNrKCkKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Z29CYWNrKG1fZHJ0LT5wYWdlQWRh cHRlcigpKTsKIH0KIAotdm9pZCBUZXN0UnVubmVyUXQ6OnNldERlZmVyc0xvYWRpbmcoYm9vbCBm bGFnKQotewotICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXREZWZlcnNMb2FkaW5nKG1f ZHJ0LT5wYWdlQWRhcHRlcigpLCBmbGFnKTsKLX0KLQogdm9pZCBUZXN0UnVubmVyUXQ6OnNldEFs bG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVUkxzKGJvb2wgZW5hYmxlZCkKIHsKICAgICBtX2Ry dC0+d2ViUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpMb2Nh bENvbnRlbnRDYW5BY2Nlc3NSZW1vdGVVcmxzLCBlbmFibGVkKTsKQEAgLTExMzIsOCArMTEyNyw5 IEBAIHZvaWQgVGVzdFJ1bm5lcjo6c2V0R2VvbG9jYXRpb25QZXJtaXNzaW9uKGJvb2wgYWxsb3cp CiB7CiB9CiAKLXZvaWQgVGVzdFJ1bm5lcjo6c2V0RGVmZXJzTG9hZGluZyhib29sKQordm9pZCBU ZXN0UnVubmVyOjpzZXREZWZlcnNMb2FkaW5nKGJvb2wgZmxhZykKIHsKKyAgICBEdW1wUmVuZGVy VHJlZVN1cHBvcnRRdDo6c2V0RGVmZXJzTG9hZGluZyhEdW1wUmVuZGVyVHJlZTo6aW5zdGFuY2Uo KS0+cGFnZUFkYXB0ZXIoKSwgZmxhZyk7CiB9CiAKIHZvaWQgVGVzdFJ1bm5lcjo6c2V0Q2FjaGVN b2RlbChpbnQpCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVy UXQuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5oCmluZGV4IDdmOWZm YmNkYmJhYjhmNjZhZmVkMGQwMjA3ODNmMDdkZTg2YTM0YTAuLjg3MjJiMzFhYTJlZDA5ZWUwOTUz ZDYxNzNlNmRlMzAyY2NmZjU5MWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L1Rlc3RSdW5uZXJRdC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJR dC5oCkBAIC0xOTQsNyArMTk0LDYgQEAgcHVibGljIFFfU0xPVFM6CiAgICAgCiAgICAgdm9pZCBz ZXRUZXh0RGlyZWN0aW9uKGNvbnN0IFFTdHJpbmcmIGRpcmVjdGlvbk5hbWUpOwogICAgIHZvaWQg Z29CYWNrKCk7Ci0gICAgdm9pZCBzZXREZWZlcnNMb2FkaW5nKGJvb2wpOwogICAgIHZvaWQgc2V0 QWx3YXlzQWNjZXB0Q29va2llcyhib29sKTsKICAgICB2b2lkIHNldEFsd2F5c0Jsb2NrQ29va2ll cyhib29sKTsKIAo=