113863 2013-04-03 03:28:48 -0700 [Qt] Move logic of simple forwarding functions to TestRunner. 2013-04-03 05:32:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 113393 1 zeno zeno hausmann oldest_to_newest 868585 0 zeno 2013-04-03 03:28:48 -0700 [Qt] Move logic of simple forwarding functions to TestRunner. 868586 1 196315 zeno 2013-04-03 03:29:30 -0700 Created attachment 196315 Patch 868593 2 196315 hausmann 2013-04-03 03:44:08 -0700 Comment on attachment 196315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196315&action=review > Tools/DumpRenderTree/qt/TestRunnerQt.cpp:833 > + DumpRenderTree* drt = DumpRenderTree::instance(); Since what we need is the QWebPage and not the drt, you could also declare a local QWebPage *webPage variable instead of *drt 868643 3 zeno 2013-04-03 05:32:14 -0700 Committed r147543: <http://trac.webkit.org/changeset/147543> 196315 2013-04-03 03:29:30 -0700 2013-04-03 03:44:07 -0700 Patch bug-113863-20130403122930.patch text/plain 5995 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGJkMDU0YWM1MjllMjdhZmY4OTExODA5MTU2ZGZkZjY5 M2ZkMDllNS4uMDIzZjE3NzYzZDc1YTM1ZmIxYjhhODVkOTgwMDA1Mzk5NWU3NTU4NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA0LTAzICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgorCisgICAg ICAgIFtRdF0gTW92ZSBsb2dpYyBvZiBzaW1wbGUgZm9yd2FyZGluZyBmdW5jdGlvbnMgdG8gVGVz dFJ1bm5lci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzg2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmNwcDoKKyAgICAgICAgKFRlc3RSdW5u ZXI6OnNldFRleHREaXJlY3Rpb24pOgorICAgICAgICAoVGVzdFJ1bm5lcjo6Z29CYWNrKToKKyAg ICAgICAgKFRlc3RSdW5uZXI6OmV2YWx1YXRlU2NyaXB0SW5Jc29sYXRlZFdvcmxkKToKKyAgICAg ICAgKFRlc3RSdW5uZXI6OmFkZFVzZXJTdHlsZVNoZWV0KToKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9xdC9UZXN0UnVubmVyUXQuaDoKKyAgICAgICAgKFRlc3RSdW5uZXJRdCk6CisKIDIwMTMt MDQtMDIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDc0MDEuCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvVGVzdFJ1bm5lclF0LmNwcAppbmRleCAxMDc4MzdlZGU1NjRkMDI5YjU5NmI2MGI4Y2IzN2Fm NjA1NzY4NjE0Li5kMTQ1ZTJhZWFkZTUzYmM1ZjFjZWZmNDhhMGMyOWMyMjZiMzAzODY4IDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuY3BwCisrKyBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5jcHAKQEAgLTQyMSwxMSArNDIxLDYg QEAgdm9pZCBUZXN0UnVubmVyUXQ6OmV2YWx1YXRlSW5XZWJJbnNwZWN0b3IobG9uZyBjYWxsSWQs IGNvbnN0IFFTdHJpbmcmIHNjcmlwdCkKICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6d2Vi SW5zcGVjdG9yRXhlY3V0ZVNjcmlwdChtX2RydC0+cGFnZUFkYXB0ZXIoKSwgY2FsbElkLCBzY3Jp cHQpOwogfQogCi12b2lkIFRlc3RSdW5uZXJRdDo6Z29CYWNrKCkKLXsKLSAgICBEdW1wUmVuZGVy VHJlZVN1cHBvcnRRdDo6Z29CYWNrKG1fZHJ0LT5wYWdlQWRhcHRlcigpKTsKLX0KLQogdm9pZCBU ZXN0UnVubmVyUXQ6OnNldERlZmVyc0xvYWRpbmcoYm9vbCBmbGFnKQogewogICAgIER1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0OjpzZXREZWZlcnNMb2FkaW5nKG1fZHJ0LT5wYWdlQWRhcHRlcigpLCBm bGFnKTsKQEAgLTc0NiwyMiArNzQxLDYgQEAgdm9pZCBUZXN0UnVubmVyUXQ6OnNldE1vY2tHZW9s b2NhdGlvblBvc2l0aW9uKGRvdWJsZSBsYXRpdHVkZSwgZG91YmxlIGxvbmdpdHVkZSwKICAgICAg ICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldE1vY2tHZW9sb2NhdGlvblBvc2l0aW9uKHBh Z2UtPmhhbmRsZSgpLCBsYXRpdHVkZSwgbG9uZ2l0dWRlLCBhY2N1cmFjeSk7CiB9CiAKLXZvaWQg VGVzdFJ1bm5lclF0OjpzdGFydFNwZWVjaElucHV0KGNvbnN0IFFTdHJpbmcmIGlucHV0RWxlbWVu dCkKLXsKLSAgICAvLyBGSVhNRTogSW1wbGVtZW50IGZvciBzcGVlY2ggaW5wdXQgbGF5b3V0IHRl c3RzLgotICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzk0ODUuCi19Ci0KLXZvaWQgVGVzdFJ1bm5lclF0OjpldmFsdWF0ZVNjcmlwdEluSXNvbGF0ZWRX b3JsZChpbnQgd29ybGRJRCwgY29uc3QgUVN0cmluZyYgc2NyaXB0KQotewotICAgIER1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0OjpldmFsdWF0ZVNjcmlwdEluSXNvbGF0ZWRXb3JsZChtX2RydC0+bWFp bkZyYW1lQWRhcHRlcigpLCB3b3JsZElELCBzY3JpcHQpOwotfQotCi12b2lkIFRlc3RSdW5uZXJR dDo6YWRkVXNlclN0eWxlU2hlZXQoY29uc3QgUVN0cmluZyYgc291cmNlQ29kZSkKLXsKLSAgICBE dW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6YWRkVXNlclN0eWxlU2hlZXQobV9kcnQtPnBhZ2VBZGFw dGVyKCksIHNvdXJjZUNvZGUpOwotfQotCiB2b2lkIFRlc3RSdW5uZXJRdDo6cmVtb3ZlQWxsVmlz aXRlZExpbmtzKCkKIHsKICAgICBRV2ViSGlzdG9yeSogaGlzdG9yeSA9IG1fZHJ0LT53ZWJQYWdl KCktPmhpc3RvcnkoKTsKQEAgLTc3NCwxNiArNzUzLDYgQEAgdm9pZCBUZXN0UnVubmVyUXQ6OmFk ZFVSTFRvUmVkaXJlY3QoY29uc3QgUVN0cmluZyYgb3JpZ2luLCBjb25zdCBRU3RyaW5nJiBkZXN0 aW4KICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6YWRkVVJMVG9SZWRpcmVjdChvcmlnaW4s IGRlc3RpbmF0aW9uKTsKIH0KIAotdm9pZCBUZXN0UnVubmVyUXQ6OnNldFRleHREaXJlY3Rpb24o Y29uc3QgUVN0cmluZyYgZGlyZWN0aW9uTmFtZSkKLXsKLSAgICBpZiAoZGlyZWN0aW9uTmFtZSA9 PSAiYXV0byIpCi0gICAgICAgIG1fZHJ0LT53ZWJQYWdlKCktPnRyaWdnZXJBY3Rpb24oUVdlYlBh Z2U6OlNldFRleHREaXJlY3Rpb25EZWZhdWx0KTsKLSAgICBlbHNlIGlmIChkaXJlY3Rpb25OYW1l ID09ICJydGwiKQotICAgICAgICBtX2RydC0+d2ViUGFnZSgpLT50cmlnZ2VyQWN0aW9uKFFXZWJQ YWdlOjpTZXRUZXh0RGlyZWN0aW9uUmlnaHRUb0xlZnQpOwotICAgIGVsc2UgaWYgKGRpcmVjdGlv bk5hbWUgPT0gImx0ciIpCi0gICAgICAgIG1fZHJ0LT53ZWJQYWdlKCktPnRyaWdnZXJBY3Rpb24o UVdlYlBhZ2U6OlNldFRleHREaXJlY3Rpb25MZWZ0VG9SaWdodCk7Ci19Ci0KIHZvaWQgVGVzdFJ1 bm5lclF0OjpzZXRBbHdheXNBY2NlcHRDb29raWVzKGJvb2wgYWNjZXB0KQogewogICAgIFFXZWJT ZXR0aW5ncyogZ2xvYmFsU2V0dGluZ3MgPSBRV2ViU2V0dGluZ3M6Omdsb2JhbFNldHRpbmdzKCk7 CkBAIC04NTksOCArODI4LDE1IEBAIHZvaWQgVGVzdFJ1bm5lcjo6Y2xlYXJBbGxBcHBsaWNhdGlv bkNhY2hlcygpCiB7CiB9CiAKLXZvaWQgVGVzdFJ1bm5lcjo6c2V0VGV4dERpcmVjdGlvbihKU1N0 cmluZ1JlZikKK3ZvaWQgVGVzdFJ1bm5lcjo6c2V0VGV4dERpcmVjdGlvbihKU1N0cmluZ1JlZiBk aXJlY3Rpb25OYW1lKQogeworICAgIER1bXBSZW5kZXJUcmVlKiBkcnQgPSBEdW1wUmVuZGVyVHJl ZTo6aW5zdGFuY2UoKTsKKyAgICBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4Q1N0cmluZyhkaXJl Y3Rpb25OYW1lLCAiYXV0byIpKQorICAgICAgICBkcnQtPndlYlBhZ2UoKS0+dHJpZ2dlckFjdGlv bihRV2ViUGFnZTo6U2V0VGV4dERpcmVjdGlvbkRlZmF1bHQpOworICAgIGVsc2UgaWYgKEpTU3Ry aW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoZGlyZWN0aW9uTmFtZSwgInJ0bCIpKQorICAgICAgICBk cnQtPndlYlBhZ2UoKS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6U2V0VGV4dERpcmVjdGlvblJp Z2h0VG9MZWZ0KTsKKyAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKGRp cmVjdGlvbk5hbWUsICJsdHIiKSkKKyAgICAgICAgZHJ0LT53ZWJQYWdlKCktPnRyaWdnZXJBY3Rp b24oUVdlYlBhZ2U6OlNldFRleHREaXJlY3Rpb25MZWZ0VG9SaWdodCk7CiB9CiAKIHZvaWQgVGVz dFJ1bm5lcjo6bm90aWZ5RG9uZSgpCkBAIC05OTAsNiArOTY2LDcgQEAgdm9pZCBUZXN0UnVubmVy OjprZWVwV2ViSGlzdG9yeSgpCiAKIHZvaWQgVGVzdFJ1bm5lcjo6Z29CYWNrKCkKIHsKKyAgICBE dW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Z29CYWNrKER1bXBSZW5kZXJUcmVlOjppbnN0YW5jZSgp LT5wYWdlQWRhcHRlcigpKTsKIH0KIAogSlNWYWx1ZVJlZiBUZXN0UnVubmVyOjpvcmlnaW5zV2l0 aEFwcGxpY2F0aW9uQ2FjaGUoSlNDb250ZXh0UmVmIGNvbnRleHQpCkBAIC0xMTk5LDYgKzExNzYs NyBAQCBib29sIFRlc3RSdW5uZXI6OmlzQ29tbWFuZEVuYWJsZWQoSlNTdHJpbmdSZWYgbmFtZSkK IAogdm9pZCBUZXN0UnVubmVyOjpldmFsdWF0ZVNjcmlwdEluSXNvbGF0ZWRXb3JsZCh1bnNpZ25l ZCB3b3JsZElELCBKU09iamVjdFJlZiBnbG9iYWxPYmplY3QsIEpTU3RyaW5nUmVmIHNjcmlwdCkK IHsKKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6ZXZhbHVhdGVTY3JpcHRJbklzb2xhdGVk V29ybGQoRHVtcFJlbmRlclRyZWU6Omluc3RhbmNlKCktPm1haW5GcmFtZUFkYXB0ZXIoKSwgd29y bGRJRCwgSlNTdHJpbmdDb3B5UVN0cmluZyhzY3JpcHQpKTsKIH0KIAogdm9pZCBUZXN0UnVubmVy OjpldmFsdWF0ZVNjcmlwdEluSXNvbGF0ZWRXb3JsZEFuZFJldHVyblZhbHVlKHVuc2lnbmVkIHdv cmxkSUQsIEpTT2JqZWN0UmVmIGdsb2JhbE9iamVjdCwgSlNTdHJpbmdSZWYgc2NyaXB0KQpAQCAt MTIxMiw2ICsxMTkwLDcgQEAgSlNTdHJpbmdSZWYgVGVzdFJ1bm5lcjo6Y29weUVuY29kZWRIb3N0 TmFtZShKU1N0cmluZ1JlZiBuYW1lKQogCiB2b2lkIFRlc3RSdW5uZXI6OmFkZFVzZXJTdHlsZVNo ZWV0KEpTU3RyaW5nUmVmIHNvdXJjZSwgYm9vbCBhbGxGcmFtZXMpCiB7CisgICAgRHVtcFJlbmRl clRyZWVTdXBwb3J0UXQ6OmFkZFVzZXJTdHlsZVNoZWV0KER1bXBSZW5kZXJUcmVlOjppbnN0YW5j ZSgpLT5wYWdlQWRhcHRlcigpLCBKU1N0cmluZ0NvcHlRU3RyaW5nKHNvdXJjZSkpOwogfQogCiB2 b2lkIFRlc3RSdW5uZXI6OmV4ZWNDb21tYW5kKEpTU3RyaW5nUmVmIG5hbWUsIEpTU3RyaW5nUmVm IHZhbHVlKQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0 LmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQuaAppbmRleCA3ZjlmZmJj ZGJiYWI4ZjY2YWZlZDBkMDIwNzgzZjA3ZGU4NmEzNGEwLi5hOWUxNWE1OGE2ZDMyMzliYmY3MDQ4 OTkyOGQzMjdmOGE4MmRlOWM3IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9U ZXN0UnVubmVyUXQuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0UnVubmVyUXQu aApAQCAtMTc5LDggKzE3OSw2IEBAIHB1YmxpYyBRX1NMT1RTOgogICAgIGJvb2wgaXNHZW9sb2Nh dGlvblBlcm1pc3Npb25TZXQoKSBjb25zdCB7IHJldHVybiBtX2lzR2VvbG9jYXRpb25QZXJtaXNz aW9uU2V0OyB9CiAgICAgYm9vbCBnZW9sb2NhdGlvblBlcm1pc3Npb24oKSBjb25zdCB7IHJldHVy biBtX2dlb2xvY2F0aW9uUGVybWlzc2lvbjsgfQogCi0gICAgdm9pZCBzdGFydFNwZWVjaElucHV0 KGNvbnN0IFFTdHJpbmcmIGlucHV0RWxlbWVudCk7Ci0KICAgICB2b2lkIGFkZFVSTFRvUmVkaXJl Y3QoY29uc3QgUVN0cmluZyYgb3JpZ2luLCBjb25zdCBRU3RyaW5nJiBkZXN0aW5hdGlvbik7CiAK ICAgICAvKgpAQCAtMTg5LDExICsxODcsNiBAQCBwdWJsaWMgUV9TTE9UUzoKICAgICAqLwogICAg IHZvaWQgc2V0U2Nyb2xsYmFyUG9saWN5KGNvbnN0IFFTdHJpbmcmIG9yaWVudGF0aW9uLCBjb25z dCBRU3RyaW5nJiBwb2xpY3kpOwogCi0gICAgdm9pZCBldmFsdWF0ZVNjcmlwdEluSXNvbGF0ZWRX b3JsZChpbnQgd29ybGRJRCwgY29uc3QgUVN0cmluZyYgc2NyaXB0KTsKLSAgICB2b2lkIGFkZFVz ZXJTdHlsZVNoZWV0KGNvbnN0IFFTdHJpbmcmIHNvdXJjZUNvZGUpOwotICAgIAotICAgIHZvaWQg c2V0VGV4dERpcmVjdGlvbihjb25zdCBRU3RyaW5nJiBkaXJlY3Rpb25OYW1lKTsKLSAgICB2b2lk IGdvQmFjaygpOwogICAgIHZvaWQgc2V0RGVmZXJzTG9hZGluZyhib29sKTsKICAgICB2b2lkIHNl dEFsd2F5c0FjY2VwdENvb2tpZXMoYm9vbCk7CiAgICAgdm9pZCBzZXRBbHdheXNCbG9ja0Nvb2tp ZXMoYm9vbCk7Cg==