113818 2013-04-02 12:18:19 -0700 AX: Make sure all AX methods called from outside call prepareAccessibility 2013-04-10 13:36:58 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue ddkilzer dmazzoni jdiggs webkit.review.bot oldest_to_newest 868156 0 cfleizach 2013-04-02 12:18:19 -0700 That will ensure we haven't invalidated ourselves before a call 868461 1 196286 cfleizach 2013-04-02 23:31:03 -0700 Created attachment 196286 patch 873204 2 196286 commit-queue 2013-04-10 13:36:56 -0700 Comment on attachment 196286 patch Clearing flags on attachment: 196286 Committed r148135: <http://trac.webkit.org/changeset/148135> 873205 3 commit-queue 2013-04-10 13:36:58 -0700 All reviewed patches have been landed. Closing bug. 196286 2013-04-02 23:31:03 -0700 2013-04-10 13:36:56 -0700 patch patch text/plain 4987 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEzLTA0LTAyICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1ha2Ugc3VyZSBh bGwgQVggbWV0aG9kcyBjYWxsZWQgZnJvbSBvdXRzaWRlIGNhbGwgcHJlcGFyZUFjY2Vzc2liaWxp dHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzgx OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug c3VyZSBhbnkgY2FsbHMgdGhhdCBjYW4gYmUgbWFkZSBmcm9tIG91dHNpZGUgV2ViQ29yZSBhcmUg cHJvdGVjdGVkIHdpdGggdGhlCisgICAgICAgIHByZXBhcmVBY2Nlc3NpYmlsaXR5IG1ldGhvZC4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVySU9TLm1tOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nl c3NpYmlsaXR5TWF0aFJvb3RJbmRleE9iamVjdF0pOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmls aXR5T2JqZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5TWF0aFJhZGljYW5kT2JqZWN0XSk6CisgICAg ICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlNYXRoTnVt ZXJhdG9yT2JqZWN0XSk6CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy IGFjY2Vzc2liaWxpdHlNYXRoRGVub21pbmF0b3JPYmplY3RdKToKKyAgICAgICAgKC1bV2ViQWNj ZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eU1hdGhCYXNlT2JqZWN0XSk6Cisg ICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlNYXRo U3Vic2NyaXB0T2JqZWN0XSk6CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyIGFjY2Vzc2liaWxpdHlNYXRoU3VwZXJzY3JpcHRPYmplY3RdKToKKyAgICAgICAgKC1bV2Vi QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eU1hdGhVbmRlck9iamVjdF0p OgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5 TWF0aE92ZXJPYmplY3RdKToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXIgYWNjZXNzaWJpbGl0eU1hdGhGZW5jZWRPcGVuU3RyaW5nXSk6CisgICAgICAgICgtW1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlNYXRoRmVuY2VkQ2xvc2VTdHJp bmddKToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJp bGl0eUlzTWF0aFRvcE9iamVjdF0pOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0 V3JhcHBlciBhY2Nlc3NpYmlsaXR5TWF0aFR5cGVdKToKKwogMjAxMy0wNC0wMiAgSmFtZXMgQ3Jh aWcgIDxqYW1lc0Bjb29raWVjcm9vay5jb20+CiAKICAgICAgICAgQVhSb2xlRGVzY3JpcHRvbiBm b3IgREwgaXMgImxpc3QiOyBzaG91bGQgYmUgImRlc2NyaXB0aW9uIGxpc3QiCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl cklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQkocmV2aXNpb24gMTQ3NTIwKQorKysg U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdy YXBwZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5NDQsNjEgKzE5NDQsOTcgQEAKIAogLSAo V2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgKilhY2Nlc3NpYmlsaXR5TWF0aFJvb3RJbmRl eE9iamVjdAogeworICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2FsbF0pCisg ICAgICAgIHJldHVybiBuaWw7CisKICAgICByZXR1cm4gbV9vYmplY3QtPm1hdGhSb290SW5kZXhP YmplY3QoKSA/IG1fb2JqZWN0LT5tYXRoUm9vdEluZGV4T2JqZWN0KCktPndyYXBwZXIoKSA6IDA7 CiB9CiAKIC0gKFdlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyICopYWNjZXNzaWJpbGl0eU1h dGhSYWRpY2FuZE9iamVjdAogeworICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5 Q2FsbF0pCisgICAgICAgIHJldHVybiBuaWw7CisKICAgICByZXR1cm4gbV9vYmplY3QtPm1hdGhS YWRpY2FuZE9iamVjdCgpID8gbV9vYmplY3QtPm1hdGhSYWRpY2FuZE9iamVjdCgpLT53cmFwcGVy KCkgOiAwOwogfQogCiAtIChXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciAqKWFjY2Vzc2li aWxpdHlNYXRoTnVtZXJhdG9yT2JqZWN0CiB7CisgICAgaWYgKCFbc2VsZiBfcHJlcGFyZUFjY2Vz c2liaWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKwogICAgIHJldHVybiBtX29iamVj dC0+bWF0aE51bWVyYXRvck9iamVjdCgpID8gbV9vYmplY3QtPm1hdGhOdW1lcmF0b3JPYmplY3Qo KS0+d3JhcHBlcigpIDogMDsKIH0KIAogLSAoV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIg KilhY2Nlc3NpYmlsaXR5TWF0aERlbm9taW5hdG9yT2JqZWN0CiB7CisgICAgaWYgKCFbc2VsZiBf cHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKwogICAgIHJl dHVybiBtX29iamVjdC0+bWF0aERlbm9taW5hdG9yT2JqZWN0KCkgPyBtX29iamVjdC0+bWF0aERl bm9taW5hdG9yT2JqZWN0KCktPndyYXBwZXIoKSA6IDA7CiB9CiAKIC0gKFdlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyICopYWNjZXNzaWJpbGl0eU1hdGhCYXNlT2JqZWN0CiB7CisgICAgaWYg KCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIG5pbDsK KwogICAgIHJldHVybiBtX29iamVjdC0+bWF0aEJhc2VPYmplY3QoKSA/IG1fb2JqZWN0LT5tYXRo QmFzZU9iamVjdCgpLT53cmFwcGVyKCkgOiAwOwogfQogCiAtIChXZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlciAqKWFjY2Vzc2liaWxpdHlNYXRoU3Vic2NyaXB0T2JqZWN0CiB7CisgICAgaWYg KCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIG5pbDsK KwogICAgIHJldHVybiBtX29iamVjdC0+bWF0aFN1YnNjcmlwdE9iamVjdCgpID8gbV9vYmplY3Qt Pm1hdGhTdWJzY3JpcHRPYmplY3QoKS0+d3JhcHBlcigpIDogMDsKIH0KIAogLSAoV2ViQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXIgKilhY2Nlc3NpYmlsaXR5TWF0aFN1cGVyc2NyaXB0T2JqZWN0 CiB7CisgICAgaWYgKCFbc2VsZiBfcHJlcGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAgICAgICAg cmV0dXJuIG5pbDsKKwogICAgIHJldHVybiBtX29iamVjdC0+bWF0aFN1cGVyc2NyaXB0T2JqZWN0 KCkgPyBtX29iamVjdC0+bWF0aFN1cGVyc2NyaXB0T2JqZWN0KCktPndyYXBwZXIoKSA6IDA7CiB9 CiAKIC0gKFdlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyICopYWNjZXNzaWJpbGl0eU1hdGhV bmRlck9iamVjdAogeworICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2FsbF0p CisgICAgICAgIHJldHVybiBuaWw7CisKICAgICByZXR1cm4gbV9vYmplY3QtPm1hdGhVbmRlck9i amVjdCgpID8gbV9vYmplY3QtPm1hdGhVbmRlck9iamVjdCgpLT53cmFwcGVyKCkgOiAwOwogfQog CiAtIChXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciAqKWFjY2Vzc2liaWxpdHlNYXRoT3Zl ck9iamVjdAogeworICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2FsbF0pCisg ICAgICAgIHJldHVybiBuaWw7CisKICAgICByZXR1cm4gbV9vYmplY3QtPm1hdGhPdmVyT2JqZWN0 KCkgPyBtX29iamVjdC0+bWF0aE92ZXJPYmplY3QoKS0+d3JhcHBlcigpIDogMDsKIH0KIAogLSAo TlNTdHJpbmcgKilhY2Nlc3NpYmlsaXR5TWF0aEZlbmNlZE9wZW5TdHJpbmcKIHsKKyAgICBpZiAo IVtzZWxmIF9wcmVwYXJlQWNjZXNzaWJpbGl0eUNhbGxdKQorICAgICAgICByZXR1cm4gbmlsOwor CiAgICAgcmV0dXJuIG1fb2JqZWN0LT5tYXRoRmVuY2VkT3BlblN0cmluZygpOwogfQogCiAtIChO U1N0cmluZyAqKWFjY2Vzc2liaWxpdHlNYXRoRmVuY2VkQ2xvc2VTdHJpbmcKIHsKKyAgICBpZiAo IVtzZWxmIF9wcmVwYXJlQWNjZXNzaWJpbGl0eUNhbGxdKQorICAgICAgICByZXR1cm4gbmlsOwor CiAgICAgcmV0dXJuIG1fb2JqZWN0LT5tYXRoRmVuY2VkQ2xvc2VTdHJpbmcoKTsKIH0KIAogLSAo Qk9PTClhY2Nlc3NpYmlsaXR5SXNNYXRoVG9wT2JqZWN0CiB7CisgICAgaWYgKCFbc2VsZiBfcHJl cGFyZUFjY2Vzc2liaWxpdHlDYWxsXSkKKyAgICAgICAgcmV0dXJuIE5POworCiAgICAgcmV0dXJu IG1fb2JqZWN0LT5yb2xlVmFsdWUoKSA9PSBEb2N1bWVudE1hdGhSb2xlOwogfQogCkBAIC0yMDEy LDYgKzIwNDgsOSBAQAogCiAtIChOU1N0cmluZyAqKWFjY2Vzc2liaWxpdHlNYXRoVHlwZQogewor ICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2FsbF0pCisgICAgICAgIHJldHVy biBuaWw7CisKICAgICBpZiAobV9vYmplY3QtPnJvbGVWYWx1ZSgpID09IE1hdGhFbGVtZW50Um9s ZSkgewogICAgICAgICBpZiAobV9vYmplY3QtPmlzTWF0aEZyYWN0aW9uKCkpCiAgICAgICAgICAg ICByZXR1cm4gQCJBWE1hdGhGcmFjdGlvbiI7Cg==