113809 2013-04-02 11:10:25 -0700 [GTK] gst-plugins-good fails to build with newer Linux(v4l2) 2013-10-08 07:47:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo jonathon pnormand oldest_to_newest 868069 0 gustavo 2013-04-02 11:10:25 -0700 [GTK] gst-plugins-good fails to build with newer Linux(v4l2) 868074 1 196189 gustavo 2013-04-02 11:12:46 -0700 Created attachment 196189 Patch 868165 2 gustavo 2013-04-02 12:32:34 -0700 One thing to consider: I think the media stream stuff requires v4l2, we need this properly fixed when we start running tests for that. 868201 3 196189 pnormand 2013-04-02 13:20:39 -0700 Comment on attachment 196189 Patch Ok! Do you know if the v4l2 plugin is already fixed in 1.0.5 or higher? 868231 4 gustavo 2013-04-02 14:00:25 -0700 Thanks! It is not, but I understood from this discussion that that will be reverted in the kernel, so I'm not 100% it should be fixed in the v4l2 plugin right away - the discussion also seems to indicate these have never been implemented for real, so it should be a simple fix. I reported it here: https://bugzilla.gnome.org/show_bug.cgi?id=697147 868254 5 gustavo 2013-04-02 14:39:36 -0700 From the gnome bug; I guess bumping the gst-plugins-good version to 1.0.6 would work as well, would you prefer that, no strong opinion here? --- Comment #1 from Tim-Philipp Müller <t.i.m@zen.co.uk> 2013-04-02 21:17:41 UTC --- I believe this has been fixed already, both in git master and in 1.0.6: commit 8e633d2059cb835448021cf79becb487aff10975 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Mar 18 14:59:35 2013 +0000 v4l2: fix compilation against newer kernel headers as on FC19 868456 6 pnormand 2013-04-02 23:22:43 -0700 I would prefer bumping but that'd require some time to check the media tests with the new version. 868656 7 gustavo 2013-04-03 05:55:00 -0700 Makes sense, I'll land this for now, then. 868662 8 196189 gustavo 2013-04-03 06:10:49 -0700 Comment on attachment 196189 Patch Clearing flags on attachment: 196189 Committed r147546: <http://trac.webkit.org/changeset/147546> 868663 9 gustavo 2013-04-03 06:10:56 -0700 All reviewed patches have been landed. Closing bug. 937507 10 pnormand 2013-10-08 07:47:40 -0700 We should re-enable this plugin. I indeed need it for mediastream :) 196189 2013-04-02 11:12:46 -0700 2013-04-03 06:10:49 -0700 Patch bug-113809-20130402151237.patch text/plain 1535 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDRiMzg2Mjc3YTVlMGYxMmQ5OTIyN2JiYjUwYTk3ZWVh ODM2YTBhOS4uZjY5YmNlNjY1MTU4NGM1NTM2ZWVlZTZhOTMwMjBiMDhmYzJkODU3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA0LTAyICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFA Y29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXSBnc3QtcGx1Z2lucy1nb29kIGZhaWxzIHRv IGJ1aWxkIHdpdGggbmV3ZXIgTGludXgodjRsMikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzgwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5ld2VyIExpbnV4IGtlcm5lbHMgaGF2ZSByZW1vdmVkIHNv bWUgZGVwcmVjYXRlZCBtYWNyb3MgZnJvbSB2NGwyCisgICAgICAgIGhlYWRlcnMsIGNhdXNpbmcg Z3N0LXBsdWdpbnMtZ29vZCdzIGJ1aWxkIHRvIGJyZWFrLiBXZSBkb24ndCBuZWVkIGl0CisgICAg ICAgIHJpZ2h0IG5vdywgc28ganVzdCBkaXNhYmxlIGl0LgorCisgICAgICAgICogZ3RrL2poYnVp bGQubW9kdWxlczogZGlzYWJsZSB2NGwyIHVzYWdlIGluIGdzdC1wbHVnaW5zLWdvb2QuCisKIDIw MTMtMDQtMDIgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IERhc2hib2FyZCByZWZhY3RvcjogTW92ZSBkYXNoYm9hcmQgc3BlY2lmaWMgaGlzdG9yeSByZWxh dGVkIGZlYXR1cmVzIHRvIEhpc3RvcnkuCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvamhidWlsZC5t b2R1bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwppbmRleCAxMzMzYWExZjU5MDMxN2Fl NDA0M2NjNTFkN2UzZjQxNzc5MWYzYTliLi5kNzFmMjM1NjY5ODQyMTE4NzYwNWJhZTViNTYwNWI2 ZmRhNTY4ZGVmIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCisrKyBiL1Rv b2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKQEAgLTI2MCw3ICsyNjAsNyBAQAogICAgIDxicmFuY2gg cmVwbz0iZ3N0cmVhbWVyIiBtb2R1bGU9ImdzdC1wbHVnaW5zLWJhc2UiIGNoZWNrb3V0ZGlyPSJn c3QtcGx1Z2lucy1iYXNlIiB0YWc9IjEuMC40Ii8+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDxhdXRv dG9vbHMgaWQ9ImdzdC1wbHVnaW5zLWdvb2QiIGF1dG9nZW5hcmdzPSItLWRpc2FibGUtZXhhbXBs ZXMgLS1kaXNhYmxlLXNvdXAiPgorICA8YXV0b3Rvb2xzIGlkPSJnc3QtcGx1Z2lucy1nb29kIiBh dXRvZ2VuYXJncz0iLS1kaXNhYmxlLWV4YW1wbGVzIC0tZGlzYWJsZS1zb3VwIC0tZGlzYWJsZS1n c3RfdjRsMiAtLXdpdGhvdXQtbGlidjRsMiI+CiAgICAgPGRlcGVuZGVuY2llcz4KICAgICAgIDxk ZXAgcGFja2FnZT0iZ3N0LXBsdWdpbnMtYmFzZSIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgo=