113800 2013-04-02 09:49:14 -0700 Padding applied twice for empty generated RenderInlines 2013-04-02 16:15:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae abarth eric esprehn+autocc jchaffraix ojan.autocc webkit.review.bot oldest_to_newest 867958 0 eae 2013-04-02 09:49:14 -0700 The padding for empty generated content render objects is incorrectly applied twice. Downstream chromium bug: https://code.google.com/p/chromium/issues/detail?id=225054 867959 1 196168 eae 2013-04-02 09:50:57 -0700 Created attachment 196168 Patch 867962 2 196168 leviw 2013-04-02 09:56:25 -0700 Comment on attachment 196168 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196168&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:325 > + if (!isEmptyInline(parentAsRenderInline)) { So if it's empty, where does the border/padding/margin get added? 867965 3 eae 2013-04-02 10:00:08 -0700 (In reply to comment #2) > (From update of attachment 196168 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196168&action=review > > > Source/WebCore/rendering/RenderBlockLineLayout.cpp:325 > > + if (!isEmptyInline(parentAsRenderInline)) { > > So if it's empty, where does the border/padding/margin get added? To the RenderInline instead of the child RenderText 868303 4 196168 leviw 2013-04-02 15:41:06 -0700 Comment on attachment 196168 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196168&action=review LGTM. > LayoutTests/fast/css-generated-content/margin-empty-content-expected.html:5 > + ul { > + list-style-type: none; Lookit all the whitespace! 868324 5 196168 webkit.review.bot 2013-04-02 16:15:42 -0700 Comment on attachment 196168 Patch Clearing flags on attachment: 196168 Committed r147505: <http://trac.webkit.org/changeset/147505> 868325 6 webkit.review.bot 2013-04-02 16:15:45 -0700 All reviewed patches have been landed. Closing bug. 196168 2013-04-02 09:50:57 -0700 2013-04-02 16:15:42 -0700 Patch bug-113800-20130402095049.patch text/plain 5003 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzQ0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTAyICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBQYWRkaW5nIGFwcGxpZWQgdHdp Y2UgZm9yIGVtcHR5IGdlbmVyYXRlZCBSZW5kZXJJbmxpbmVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM4MDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBwYWRkaW5nIGZvciBlbXB0 eSBnZW5lcmF0ZWQgY29udGVudCByZW5kZXIgb2JqZWN0cyBpcworICAgICAgICBpbmNvcnJlY3Rs eSBhcHBsaWVkIHR3aWNlLiBSZWdyZXNzaW9uIGZyb20gcjE0MDY5My4KKworICAgICAgICBUZXN0 OiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9tYXJnaW4tZW1wdHktY29udGVudC5odG1sCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmlubGluZUxvZ2ljYWxXaWR0aCk6CisKIDIwMTMtMDQtMDIgIEFkYW0gS2xlaW4g IDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSFRNTCBwYXJzZXIgc2hvdWxkIGNvbnNp c3RlbnRseSBpbnNwZWN0IHRoZSBuYW1lc3BhY2Ugb2YgZWxlbWVudHMgb24gdGhlIHN0YWNrIG9m IG9wZW4gZWxlbWVudHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j a0xpbmVMYXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCShyZXZpc2lvbiAxNDc0NDEpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzIyLDEyICszMjIsMTQgQEAgc3RhdGljIExheW91dFVuaXQgaW5saW5lTG9naWNhbFdpZHRo KFJlbgogICAgIFJlbmRlck9iamVjdCogcGFyZW50ID0gY2hpbGQtPnBhcmVudCgpOwogICAgIHdo aWxlIChwYXJlbnQtPmlzUmVuZGVySW5saW5lKCkgJiYgbGluZURlcHRoKysgPCBjTWF4TGluZURl cHRoKSB7CiAgICAgICAgIFJlbmRlcklubGluZSogcGFyZW50QXNSZW5kZXJJbmxpbmUgPSB0b1Jl bmRlcklubGluZShwYXJlbnQpOwotICAgICAgICBpZiAoc3RhcnQgJiYgc2hvdWxkQWRkQm9yZGVy UGFkZGluZ01hcmdpbihjaGlsZC0+cHJldmlvdXNTaWJsaW5nKCksIHN0YXJ0KSkKLSAgICAgICAg ICAgIGV4dHJhV2lkdGggKz0gYm9yZGVyUGFkZGluZ01hcmdpblN0YXJ0KHBhcmVudEFzUmVuZGVy SW5saW5lKTsKLSAgICAgICAgaWYgKGVuZCAmJiBzaG91bGRBZGRCb3JkZXJQYWRkaW5nTWFyZ2lu KGNoaWxkLT5uZXh0U2libGluZygpLCBlbmQpKQotICAgICAgICAgICAgZXh0cmFXaWR0aCArPSBi b3JkZXJQYWRkaW5nTWFyZ2luRW5kKHBhcmVudEFzUmVuZGVySW5saW5lKTsKLSAgICAgICAgaWYg KCFzdGFydCAmJiAhZW5kKQotICAgICAgICAgICAgcmV0dXJuIGV4dHJhV2lkdGg7CisgICAgICAg IGlmICghaXNFbXB0eUlubGluZShwYXJlbnRBc1JlbmRlcklubGluZSkpIHsKKyAgICAgICAgICAg IGlmIChzdGFydCAmJiBzaG91bGRBZGRCb3JkZXJQYWRkaW5nTWFyZ2luKGNoaWxkLT5wcmV2aW91 c1NpYmxpbmcoKSwgc3RhcnQpKQorICAgICAgICAgICAgICAgIGV4dHJhV2lkdGggKz0gYm9yZGVy UGFkZGluZ01hcmdpblN0YXJ0KHBhcmVudEFzUmVuZGVySW5saW5lKTsKKyAgICAgICAgICAgIGlm IChlbmQgJiYgc2hvdWxkQWRkQm9yZGVyUGFkZGluZ01hcmdpbihjaGlsZC0+bmV4dFNpYmxpbmco KSwgZW5kKSkKKyAgICAgICAgICAgICAgICBleHRyYVdpZHRoICs9IGJvcmRlclBhZGRpbmdNYXJn aW5FbmQocGFyZW50QXNSZW5kZXJJbmxpbmUpOworICAgICAgICAgICAgaWYgKCFzdGFydCAmJiAh ZW5kKQorICAgICAgICAgICAgICAgIHJldHVybiBleHRyYVdpZHRoOworICAgICAgICB9CiAgICAg ICAgIGNoaWxkID0gcGFyZW50OwogICAgICAgICBwYXJlbnQgPSBjaGlsZC0+cGFyZW50KCk7CiAg ICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3NDQxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDQtMDIgIEVtaWwgQSBFa2x1 bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFBhZGRpbmcgYXBwbGllZCB0d2ljZSBm b3IgZW1wdHkgZ2VuZXJhdGVkIFJlbmRlcklubGluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzgwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQWRkIHRlc3QgZm9yIGVtcHR5IGdlbmVy YXRlZCBjb250ZW50IHdpdGggcGFkZGluZy4KKworICAgICAgICAqIGZhc3QvY3NzLWdlbmVyYXRl ZC1jb250ZW50L21hcmdpbi1lbXB0eS1jb250ZW50LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L21hcmdpbi1lbXB0eS1jb250ZW50Lmh0 bWw6IEFkZGVkLgorCiAyMDEzLTA0LTAyICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEhUTUwgcGFyc2VyIHNob3VsZCBjb25zaXN0ZW50bHkgaW5zcGVjdCB0aGUg bmFtZXNwYWNlIG9mIGVsZW1lbnRzIG9uIHRoZSBzdGFjayBvZiBvcGVuIGVsZW1lbnRzCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9tYXJnaW4tZW1wdHktY29u dGVudC1leHBlY3RlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzLWdl bmVyYXRlZC1jb250ZW50L21hcmdpbi1lbXB0eS1jb250ZW50LWV4cGVjdGVkLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9tYXJnaW4t ZW1wdHktY29udGVudC1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIwIEBA Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHN0eWxlPgorICAgICAgICAgICAgdWwgewor ICAgICAgICAgICAgICAgIGxpc3Qtc3R5bGUtdHlwZTogbm9uZTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIGxpIHsKKyAgICAgICAgICAgICAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7Cisg ICAgICAgICAgICB9CisgICAgICAgICAgICBsaTphZnRlciB7CisgICAgICAgICAgICAgICAgbWFy Z2luOiAwIDAgMCAxcHg7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc3R5bGU+CisgICAgPC9o ZWFkPgorICAgIDxib2R5PgorICAgICAgICA8dWw+CisgICAgICAgICAgICA8bGk+U2hvdWxkIG5v dCB3cmFwPC9saT4KKyAgICAgICAgPC91bD4KKyAgICA8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0 eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9tYXJn aW4tZW1wdHktY29udGVudC1leHBlY3RlZC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjptaW1l LXR5cGUKICAgKyB0ZXh0L2h0bWwKQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoKSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L21hcmdpbi1lbXB0eS1jb250 ZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNv bnRlbnQvbWFyZ2luLWVtcHR5LWNvbnRlbnQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L21hcmdpbi1lbXB0eS1jb250ZW50Lmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjEgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAg ICA8c3R5bGU+CisgICAgICAgICAgICB1bCB7CisgICAgICAgICAgICAgICAgbGlzdC1zdHlsZS10 eXBlOiBub25lOworICAgICAgICAgICAgfQorICAgICAgICAgICAgbGkgeworICAgICAgICAgICAg ICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGxp OmFmdGVyIHsKKyAgICAgICAgICAgICAgICBtYXJnaW46IDAgMCAwIDFweDsKKyAgICAgICAgICAg ICAgICBjb250ZW50OiAiIjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICA8 L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDx1bD4KKyAgICAgICAgICAgIDxsaT5TaG91bGQg bm90IHdyYXA8L2xpPgorICAgICAgICA8L3VsPgorICAgIDwvYm9keT4KKzwvaHRtbD4KClByb3Bl cnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L21h cmdpbi1lbXB0eS1jb250ZW50Lmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOm1pbWUtdHlwZQog ICArIHRleHQvaHRtbApBZGRlZDogc3ZuOmVvbC1zdHlsZQogICArIExGCgo=