113799 2013-04-02 09:45:24 -0700 [CSS Exclusions] refactor shape-outside code to use isFloatingWithShapeOutside() helper method 2013-04-02 14:16:36 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98664 1 bjonesbe bjonesbe eric esprehn+autocc ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 867954 0 bjonesbe 2013-04-02 09:45:24 -0700 Julien suggested that I add this method in bug 110349. It turns out there are a lot of places it can be used, so I'm separating using it into a separate bug for my sanity. 868214 1 196217 bjonesbe 2013-04-02 13:42:24 -0700 Created attachment 196217 Patch Refactor to use helper method 868237 2 196217 webkit.review.bot 2013-04-02 14:16:33 -0700 Comment on attachment 196217 Patch Clearing flags on attachment: 196217 Committed r147495: <http://trac.webkit.org/changeset/147495> 868238 3 webkit.review.bot 2013-04-02 14:16:36 -0700 All reviewed patches have been landed. Closing bug. 196217 2013-04-02 13:42:24 -0700 2013-04-02 14:16:33 -0700 Patch bug-113799-20130402134215.patch text/plain 5645 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE3N2RlZGY1MDU5MGMw NTZlMDM1MGYzNzUxOWRkZWUwMDhkNTNlZC4uMDY5NTAwMjc3MWNhYThkN2QyNmQwZDQ4NjBjOGZm ZjUyNzUzZmFjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTA0LTAyICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgRXhjbHVzaW9u c10gcmVmYWN0b3Igc2hhcGUtb3V0c2lkZSBjb2RlIHRvIHVzZSBpc0Zsb2F0aW5nV2l0aFNoYXBl T3V0c2lkZSgpIGhlbHBlciBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMzc5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gcmV2aWV3aW5nIG15IHBhdGNoIGZvciBidWcgMTEwMzQ5LCBK dWxpZW4gbWVudGlvbmVkIHRoYXQgdGhlCisgICAgICAgIGNvbW1vbiB0ZXN0IGZvciBmbG9hdGlu ZyB3aXRoIHNoYXBlIG91dHNpZGUgc2hvdWxkIGJlIGZhY3RvcmVkIG91dC4KKyAgICAgICAgVGhp cyBwYXRjaCBkb2VzIHRoYXQuCisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHksIHNvIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9FeGNsdXNpb25TaGFwZU91dHNpZGVJ bmZvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV4Y2x1c2lvblNoYXBlT3V0c2lkZUluZm86Omlz RW5hYmxlZEZvcik6IFVzZSBoZWxwZXIgbWV0aG9kLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6ZXhjbHVzaW9uU2hhcGVPdXRz aWRlSW5mbyk6IERpdHRvLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6c2hvdWxkQmVOb3JtYWxGbG93T25seSk6IERp dHRvLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuaDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck9iamVjdDo6aGFzUGFpbnRPZmZzZXQpOiAgRGl0dG8uCisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJPYmplY3Q6OmlzRmxvYXRpbmdXaXRoU2hhcGVPdXRzaWRlKTogQWRkIG1ldGhv ZCB0bworICAgICAgICAgICAgZW5jYXBzdWxhdGUgdGhlIGNvbW1vbiB0ZXN0LgorCiAyMDEzLTA0 LTAyICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBWaWV3cG9ydCBj b25zdHJhaW5lZCBlbGVtZW50cyBzaG91bGQgd29yayBwcm9wZXJseSB3aXRoIGhlYWRlcnMgYW5k IGZvb3RlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNpb25T aGFwZU91dHNpZGVJbmZvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNpb25T aGFwZU91dHNpZGVJbmZvLmNwcAppbmRleCAwMDJiMmRkYjZhNmFmYzMxOTY4MzQwZWZhNmU3ZTQy NmY3ZTgwOTU0Li5lZDczOGE4ZDAzODQ2MGQ5ZWYyYTJhNGVkZmMyYmFiMzE0OWQ5ZGUyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGVPdXRzaWRlSW5m by5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V4Y2x1c2lvblNoYXBlT3V0c2lk ZUluZm8uY3BwCkBAIC0zOSw3ICszOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGJvb2wgRXhj bHVzaW9uU2hhcGVPdXRzaWRlSW5mbzo6aXNFbmFibGVkRm9yKGNvbnN0IFJlbmRlckJveCogYm94 KQogewogICAgIEV4Y2x1c2lvblNoYXBlVmFsdWUqIHZhbHVlID0gYm94LT5zdHlsZSgpLT5zaGFw ZU91dHNpZGUoKTsKLSAgICByZXR1cm4gKGJveC0+aXNGbG9hdGluZygpICYmIHZhbHVlICYmIHZh bHVlLT50eXBlKCkgPT0gRXhjbHVzaW9uU2hhcGVWYWx1ZTo6U0hBUEUpID8gdmFsdWUtPnNoYXBl KCkgOiAwOworICAgIHJldHVybiAoYm94LT5pc0Zsb2F0aW5nV2l0aFNoYXBlT3V0c2lkZSgpICYm IHZhbHVlLT50eXBlKCkgPT0gRXhjbHVzaW9uU2hhcGVWYWx1ZTo6U0hBUEUpID8gdmFsdWUtPnNo YXBlKCkgOiAwOwogfQogCiBib29sIEV4Y2x1c2lvblNoYXBlT3V0c2lkZUluZm86OmNvbXB1dGVT ZWdtZW50c0ZvckxpbmUoTGF5b3V0VW5pdCBsaW5lVG9wLCBMYXlvdXRVbml0IGxpbmVIZWlnaHQp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKaW5kZXggNTFmZWU1MWVhYmE4MDY3ZTM4 Yjk2ZTczZGEyNzNhNTFjMWRkZmEzNy4uNjFlODNkZTdjMWU0OTgwMGZkM2U5NGFiZmUyYjg2OTE2 MTViMWY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaApAQCAtNDksNyArNDks NyBAQCBwdWJsaWM6CiAKICAgICAvLyBoYXNBdXRvWkluZGV4IG9ubHkgcmV0dXJucyB0cnVlIGlm IHRoZSBlbGVtZW50IGlzIHBvc2l0aW9uZWQgb3IgYSBmbGV4LWl0ZW0gc2luY2UKICAgICAvLyBw b3NpdGlvbjpzdGF0aWMgZWxlbWVudHMgdGhhdCBhcmUgbm90IGZsZXgtaXRlbXMgZ2V0IHRoZWly IHotaW5kZXggY29lcmNlZCB0byBhdXRvLgotICAgIHZpcnR1YWwgYm9vbCByZXF1aXJlc0xheWVy KCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gaXNSb290KCkgfHwgaXNQb3NpdGlvbmVkKCkgfHwg Y3JlYXRlc0dyb3VwKCkgfHwgaGFzQ2xpcFBhdGgoKSB8fCBoYXNPdmVyZmxvd0NsaXAoKSB8fCBo YXNUcmFuc2Zvcm0oKSB8fCBoYXNIaWRkZW5CYWNrZmFjZSgpIHx8IGhhc1JlZmxlY3Rpb24oKSB8 fCBzdHlsZSgpLT5zcGVjaWZpZXNDb2x1bW5zKCkgfHwgIXN0eWxlKCktPmhhc0F1dG9aSW5kZXgo KSB8fCAoc3R5bGUoKS0+c2hhcGVPdXRzaWRlKCkgJiYgaXNGbG9hdGluZygpKTsgfQorICAgIHZp cnR1YWwgYm9vbCByZXF1aXJlc0xheWVyKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gaXNSb290 KCkgfHwgaXNQb3NpdGlvbmVkKCkgfHwgY3JlYXRlc0dyb3VwKCkgfHwgaGFzQ2xpcFBhdGgoKSB8 fCBoYXNPdmVyZmxvd0NsaXAoKSB8fCBoYXNUcmFuc2Zvcm0oKSB8fCBoYXNIaWRkZW5CYWNrZmFj ZSgpIHx8IGhhc1JlZmxlY3Rpb24oKSB8fCBzdHlsZSgpLT5zcGVjaWZpZXNDb2x1bW5zKCkgfHwg IXN0eWxlKCktPmhhc0F1dG9aSW5kZXgoKSB8fCBpc0Zsb2F0aW5nV2l0aFNoYXBlT3V0c2lkZSgp OyB9CiAKICAgICB2aXJ0dWFsIGJvb2wgYmFja2dyb3VuZElzS25vd25Ub0JlT3BhcXVlSW5SZWN0 KGNvbnN0IExheW91dFJlY3QmIGxvY2FsUmVjdCkgY29uc3QgT1ZFUlJJREU7CiAKQEAgLTU4Miw3 ICs1ODIsNyBAQCBwdWJsaWM6CiAjaWYgRU5BQkxFKENTU19FWENMVVNJT05TKQogICAgIEV4Y2x1 c2lvblNoYXBlT3V0c2lkZUluZm8qIGV4Y2x1c2lvblNoYXBlT3V0c2lkZUluZm8oKSBjb25zdAog ICAgIHsKLSAgICAgICAgcmV0dXJuIHN0eWxlKCktPnNoYXBlT3V0c2lkZSgpICYmIEV4Y2x1c2lv blNoYXBlT3V0c2lkZUluZm86OmlzRW5hYmxlZEZvcih0aGlzKSA/IEV4Y2x1c2lvblNoYXBlT3V0 c2lkZUluZm86OmluZm8odGhpcykgOiAwOworICAgICAgICByZXR1cm4gaXNGbG9hdGluZ1dpdGhT aGFwZU91dHNpZGUoKSAmJiBFeGNsdXNpb25TaGFwZU91dHNpZGVJbmZvOjppc0VuYWJsZWRGb3Io dGhpcykgPyBFeGNsdXNpb25TaGFwZU91dHNpZGVJbmZvOjppbmZvKHRoaXMpIDogMDsKICAgICB9 CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXgg M2JkNWVhNWJjOWUxMzU4YjRhZGZiNTg0ZDJmNDM4ZDBjMTRmMjhmMC4uNWU4OGEyMTUzMTk3ODM3 ZWVhMTVhZjVjNDhmNGRhMjQ4Mjk1MDU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwCkBAIC01ODQ3LDcgKzU4NDcsNyBAQCBib29sIFJlbmRlckxheWVyOjpzaG91 bGRCZU5vcm1hbEZsb3dPbmx5KCkgY29uc3QKICAgICAgICAgICAgICYmICFpc1RyYW5zcGFyZW50 KCkKICAgICAgICAgICAgICYmICFuZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcoKQogI2lmIEVOQUJM RShDU1NfRVhDTFVTSU9OUykKLSAgICAgICAgICAgICYmICEocmVuZGVyZXIoKS0+aXNGbG9hdGlu ZygpICYmIHJlbmRlcmVyKCktPnN0eWxlKCktPnNoYXBlT3V0c2lkZSgpKQorICAgICAgICAgICAg JiYgIXJlbmRlcmVyKCktPmlzRmxvYXRpbmdXaXRoU2hhcGVPdXRzaWRlKCkKICNlbmRpZgogICAg ICAgICAgICAgOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4 IDMxNWMxMjdjZmZiMjE2NjUxOGFlNjU5Y2IwYzVmMTAyMWRjNzJjN2YuLmI1YTdkYTRiNjY3YjVk OTk5NmE4ODJkZmI5NGY4NjQ4NjlmNjUzNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmgKQEAgLTU1NCw3ICs1NTQsNyBAQCBwdWJsaWM6CiAjaWYgRU5BQkxFKENTU19F WENMVVNJT05TKQogICAgICAgICAvLyBTaGFwZSBvdXRzaWRlIG9uIGEgZmxvYXQgY2FuIHJlcG9z aXRpb24gdGhlIGZsb2F0IGluIG11Y2ggdGhlCiAgICAgICAgIC8vIHNhbWUgd2F5IGFzIHJlbGF0 aXZlIHBvc2l0aW9uaW5nLCBzbyB0cmVhdCBpdCBhcyBzdWNoLgotICAgICAgICBwb3NpdGlvbmVk ID0gcG9zaXRpb25lZCB8fCAobV9iaXRmaWVsZHMuZmxvYXRpbmcoKSAmJiBtX2JpdGZpZWxkcy5p c0JveCgpICYmIHN0eWxlKCktPnNoYXBlT3V0c2lkZSgpKTsKKyAgICAgICAgcG9zaXRpb25lZCA9 IHBvc2l0aW9uZWQgfHwgaXNGbG9hdGluZ1dpdGhTaGFwZU91dHNpZGUoKTsKICNlbmRpZgogICAg ICAgICByZXR1cm4gcG9zaXRpb25lZDsKICAgICB9CkBAIC04NzksNiArODc5LDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgdW5zaWduZWQgaW50IGxlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIDE7IH0K IAogICAgIGJvb2wgaXNGbG9hdGluZ09yT3V0T2ZGbG93UG9zaXRpb25lZCgpIGNvbnN0IHsgcmV0 dXJuIChpc0Zsb2F0aW5nKCkgfHwgaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkpOyB9CisgICAgYm9v bCBpc0Zsb2F0aW5nV2l0aFNoYXBlT3V0c2lkZSgpIGNvbnN0IHsgcmV0dXJuIGlzQm94KCkgJiYg aXNGbG9hdGluZygpICYmIHN0eWxlKCktPnNoYXBlT3V0c2lkZSgpOyB9CiAKICAgICBib29sIGlz VHJhbnNwYXJlbnQoKSBjb25zdCB7IHJldHVybiBzdHlsZSgpLT5vcGFjaXR5KCkgPCAxLjBmOyB9 CiAgICAgZmxvYXQgb3BhY2l0eSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCktPm9wYWNpdHkoKTsg fQo=