113795 2013-04-02 09:25:49 -0700 [BlackBerry] Create a selection from two points irregardless of the caret position. 2013-04-02 11:15:39 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nghanavatian nghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 867928 0 nghanavatian 2013-04-02 09:25:49 -0700 SSIA 867943 1 196165 nghanavatian 2013-04-02 09:34:03 -0700 Created attachment 196165 Patch 867951 2 196165 rwlbuis 2013-04-02 09:43:06 -0700 Comment on attachment 196165 Patch LGTM. 868078 3 196165 webkit.review.bot 2013-04-02 11:15:36 -0700 Comment on attachment 196165 Patch Clearing flags on attachment: 196165 Committed r147467: <http://trac.webkit.org/changeset/147467> 868079 4 webkit.review.bot 2013-04-02 11:15:39 -0700 All reviewed patches have been landed. Closing bug. 196165 2013-04-02 09:34:03 -0700 2013-04-02 11:15:35 -0700 Patch bug-113795-20130402122704.patch text/plain 4289 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhMmUxNGYyOWVjOWEwZTg5NjBlZDc2OTYwNjA3MDY4ZjJjYzFhODYzLi4zYWUzZDFhZDIw YmI4ODQyZWJkYzhjYWM4NWEyZDg1ODA2NGE3NjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wNC0wMSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkBibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ3JlYXRl IGEgc2VsZWN0aW9uIGZyb20gdHdvIHBvaW50cyBpcnJlZ2FyZGxlc3Mgb2YgdGhlIGNhcmV0IHBv c2l0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEzNzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICBQUjI3NjU3Nwor ICAgICAgICBJZiB3ZSBhcmUgdG8gc2V0IGJvdGggdGhlIGJhc2UgYW5kIGV4dGVudCBvZiBhIHNl bGVjdGlvbiwgd2Ugc2hvdWxkIG1haW50YWluIHRoZSBiYXNlIHVwb24gc2V0dGluZyB0aGUgZXh0 ZW50LgorICAgICAgICBUaGlzIHByZXZlbnRzIHVzIGZyb20gb3ZlcndyaXRpbmcgdGhlIHByZXZp b3VzIGNhbGN1bGF0aW9uIHdoZW4gc2V0dGluZyBleHRlbnQuCisgICAgICAgIEZ1cnRoZXIsIGlu c3RlYWQgb2Ygc2V0dGluZyBhbmQgbWFuaXB1bGF0aW5nIHRoZSBzZWxlY3Rpb24sIHNpbXBseSBz ZXQgdXAgc3RhcnQgYW5kIGVuZCBWaXNpYmxlUG9zaXRpb25zIGFuZAorICAgICAgICBjcmVhdGUg YSBuZXcgZGlyZWN0aW9uYWwgc2VsZWN0aW9uIHNvIGFzIHRvIHNldCB0aGUgYmFzZSBhbmQgZXh0 ZW50IHNpbXVsdGFuZW91c2x5LgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25I YW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0aW9uSGFuZGxl cjo6c2V0U2VsZWN0aW9uKToKKwogMjAxMy0wMy0yOCAgSmFrb2IgUGV0c292aXRzICA8anBldHNv dml0c0BibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRG9uJ3QgdXNlIFdl YktpdCB0aHJlYWQgc2NhbGUgaW5mb3JtYXRpb24gaW4gV2ViUGFnZUNvbXBvc2l0b3IuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25I YW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVj dGlvbkhhbmRsZXIuY3BwCmluZGV4IDcwNGU3OWJjYTU1ZmMwYzcyY2M4MWQ5YzZjZmQ4OGEzYTgy ZjY4MDMuLjgxODk4NzgxMTYzMWI4ZjVlM2NjMDA4MDgyYzViY2M0YzZlM2QwNGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVj dGlvbkhhbmRsZXIuY3BwCkBAIC01MDcsNDQgKzUwNywzMiBAQCB2b2lkIFNlbGVjdGlvbkhhbmRs ZXI6OnNldFNlbGVjdGlvbihjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgc3RhcnQsIGNvbnN0IFdl YkNvcgogICAgIFdlYkNvcmU6OkludFBvaW50IHJlbGF0aXZlU3RhcnQgPSBzdGFydDsKICAgICBX ZWJDb3JlOjpJbnRQb2ludCByZWxhdGl2ZUVuZCA9IGVuZDsKIAotICAgIFZpc2libGVTZWxlY3Rp b24gbmV3U2VsZWN0aW9uKGNvbnRyb2xsZXItPnNlbGVjdGlvbigpKTsKLQotICAgIC8vIFdlIG5l ZWQgdGhlIHNlbGVjdGlvbiB0byBiZSBvcmRlcmVkIGJhc2UgdGhlbiBleHRlbnQuCi0gICAgaWYg KCFjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5pc0Jhc2VGaXJzdCgpKQotICAgICAgICBjb250cm9s bGVyLT5zZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlvbihjb250cm9sbGVyLT5zZWxlY3Rpb24o KS5zdGFydCgpLCBjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5lbmQoKSwgdHJ1ZSAvKiBpc0RpcmVj dGlvbmFsICovKSk7CisgICAgLy8gSW5pdGlhbGl6ZSB0aGUgbmV3IHN0YXJ0IGFuZCBlbmQgb2Yg b3VyIHNlbGVjdGlvbiBhdCB0aGUgY3VycmVudCBwb3NpdGlvbnMuCisgICAgVmlzaWJsZVBvc2l0 aW9uIG5ld1N0YXJ0ID0gY29udHJvbGxlci0+c2VsZWN0aW9uKCkudmlzaWJsZVN0YXJ0KCk7Cisg ICAgVmlzaWJsZVBvc2l0aW9uIG5ld0VuZCA9IGNvbnRyb2xsZXItPnNlbGVjdGlvbigpLnZpc2li bGVFbmQoKTsKIAogICAgIC8vIFdlIGRvbid0IHJldHVybiBlYXJseSBpbiB0aGUgZm9sbG93aW5n LCBzbyB0aGF0IHdlIGNhbiBkbyBpbnB1dCBmaWVsZCBzY3JvbGxpbmcgaWYgdGhlCiAgICAgLy8g aGFuZGxlIGlzIG91dHNpZGUgdGhlIGJvdW5kcyBvZiB0aGUgZmllbGQuIFRoaXMgY2FuIGJlIGV4 dGVuZGVkIHRvIGhhbmRsZSBzdWItcmVnaW9uCiAgICAgLy8gc2Nyb2xsaW5nIGFzIHdlbGwKICAg ICBpZiAoc3RhcnRJc1ZhbGlkKSB7CiAgICAgICAgIHJlbGF0aXZlU3RhcnQgPSBET01TdXBwb3J0 Ojpjb252ZXJ0UG9pbnRUb0ZyYW1lKG1fd2ViUGFnZS0+bWFpbkZyYW1lKCksIGZvY3VzZWRGcmFt ZSwgc3RhcnQpOwotCiAgICAgICAgIFZpc2libGVQb3NpdGlvbiBiYXNlID0gdmlzaWJsZVBvc2l0 aW9uRm9yUG9pbnRJZ25vcmluZ0NsaXBwaW5nKCpmb2N1c2VkRnJhbWUsIGNsaXBQb2ludFRvVmlz aWJsZUNvbnRhaW5lcihzdGFydCkpOwotICAgICAgICBpZiAoYmFzZS5pc05vdE51bGwoKSkgewot ICAgICAgICAgICAgLy8gVGhlIGZ1bmN0aW9uIHNldEJhc2UgdmFsaWRhdGVzIHRoZSAiYmFzZSIK LSAgICAgICAgICAgIG5ld1NlbGVjdGlvbi5zZXRCYXNlKGJhc2UpOwotICAgICAgICAgICAgbmV3 U2VsZWN0aW9uLnNldFdpdGhvdXRWYWxpZGF0aW9uKG5ld1NlbGVjdGlvbi5iYXNlKCksIGNvbnRy b2xsZXItPnNlbGVjdGlvbigpLmVuZCgpKTsKLSAgICAgICAgICAgIC8vIERvbid0IHJldHVybiBl YXJseS4KLSAgICAgICAgfQorICAgICAgICBpZiAoYmFzZS5pc05vdE51bGwoKSkKKyAgICAgICAg ICAgIG5ld1N0YXJ0ID0gYmFzZTsKICAgICB9CiAKICAgICBpZiAobV9sYXN0VXBkYXRlZEVuZFBv aW50SXNWYWxpZCkgewogICAgICAgICByZWxhdGl2ZUVuZCA9IERPTVN1cHBvcnQ6OmNvbnZlcnRQ b2ludFRvRnJhbWUobV93ZWJQYWdlLT5tYWluRnJhbWUoKSwgZm9jdXNlZEZyYW1lLCBlbmQpOwot CiAgICAgICAgIFZpc2libGVQb3NpdGlvbiBleHRlbnQgPSB2aXNpYmxlUG9zaXRpb25Gb3JQb2lu dElnbm9yaW5nQ2xpcHBpbmcoKmZvY3VzZWRGcmFtZSwgY2xpcFBvaW50VG9WaXNpYmxlQ29udGFp bmVyKGVuZCkpOwotICAgICAgICBpZiAoZXh0ZW50LmlzTm90TnVsbCgpKSB7Ci0gICAgICAgICAg ICAvLyBUaGUgZnVuY3Rpb24gc2V0RXh0ZW50IHZhbGlkYXRlcyB0aGUgImV4dGVudCIKLSAgICAg ICAgICAgIG5ld1NlbGVjdGlvbi5zZXRFeHRlbnQoZXh0ZW50KTsKLSAgICAgICAgICAgIG5ld1Nl bGVjdGlvbi5zZXRXaXRob3V0VmFsaWRhdGlvbihjb250cm9sbGVyLT5zZWxlY3Rpb24oKS5zdGFy dCgpLCBuZXdTZWxlY3Rpb24uZXh0ZW50KCkpOwotICAgICAgICAgICAgLy8gRG9uJ3QgcmV0dXJu IGVhcmx5LgotICAgICAgICB9CisgICAgICAgIGlmIChleHRlbnQuaXNOb3ROdWxsKCkpCisgICAg ICAgICAgICBuZXdFbmQgPSBleHRlbnQ7CiAgICAgfQogCisgICAgVmlzaWJsZVNlbGVjdGlvbiBu ZXdTZWxlY3Rpb24obmV3U3RhcnQsIG5ld0VuZCwgdHJ1ZSAvKiBpc0RpcmVjdGlvbmFsICovKTsK KwogICAgIGlmICghY29udHJvbGxlci0+c2VsZWN0aW9uKCkuaXNSYW5nZSgpKQogICAgICAgICBt X3dlYlBhZ2UtPnVwZGF0ZVNlbGVjdGlvblNjcm9sbFZpZXcobmV3U2VsZWN0aW9uLnZpc2libGVF bmQoKS5kZWVwRXF1aXZhbGVudCgpLmFuY2hvck5vZGUoKSk7CiAKLSAgICBuZXdTZWxlY3Rpb24u c2V0SXNEaXJlY3Rpb25hbCh0cnVlKTsKLQogICAgIGlmIChtX3dlYlBhZ2UtPm1faW5wdXRIYW5k bGVyLT5pc0lucHV0TW9kZSgpKSB7CiAgICAgICAgIGlmICh1cGRhdGVPckhhbmRsZUlucHV0U2Vs ZWN0aW9uKG5ld1NlbGVjdGlvbiwgcmVsYXRpdmVTdGFydCwgcmVsYXRpdmVFbmQpKQogICAgICAg ICAgICAgcmV0dXJuOwo=