113794 2013-04-02 09:18:50 -0700 [GTK] WebKitWebNavigationAction: dispose and finalize mixed up 2013-04-03 08:16:35 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 alban.crequy webkit-unassigned glenn webkit.review.bot oldest_to_newest 867923 0 196158 alban.crequy 2013-04-02 09:18:50 -0700 Created attachment 196158 [PATCH] WebKitWebNavigationAction: fix mix between dispose and finalize WebKitWebNavigationAction's dispose function calls the parent's finalize function. It causes a segfault in some scenarios. I am testing the attached patch. 868526 1 alban.crequy 2013-04-03 01:37:16 -0700 The patch fixes the crash for me. 868647 2 196158 gustavo 2013-04-03 05:40:59 -0700 Comment on attachment 196158 [PATCH] WebKitWebNavigationAction: fix mix between dispose and finalize Patch looks good, you need a ChangeLog entry, though: http://www.webkit.org/coding/contributing.html 868660 3 196336 alban.crequy 2013-04-03 06:07:53 -0700 Created attachment 196336 [PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize patch updated with: - a changelog - changelog in the commit log too 868669 4 196336 gustavo 2013-04-03 06:17:38 -0700 Comment on attachment 196336 [PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize Good to go, I'll wait for EWS and set cq+ 868730 5 196336 webkit.review.bot 2013-04-03 08:16:33 -0700 Comment on attachment 196336 [PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize Clearing flags on attachment: 196336 Committed r147557: <http://trac.webkit.org/changeset/147557> 868731 6 webkit.review.bot 2013-04-03 08:16:35 -0700 All reviewed patches have been landed. Closing bug. 196158 2013-04-02 09:18:50 -0700 2013-04-03 06:07:53 -0700 [PATCH] WebKitWebNavigationAction: fix mix between dispose and finalize 0001-WebKitWebNavigationAction-fix-mix-between-dispose-an.patch text/plain 1093 alban.crequy RnJvbSBlYjQ2NDViODM3Mzk4MWEwMjg5Y2ExMGU3NDllYmIzMDY5OWZlYjFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGJhbiBDcmVxdXkgPGFsYmFuLmNyZXF1eUBjb2xsYWJvcmEu Y28udWs+CkRhdGU6IFR1ZSwgMiBBcHIgMjAxMyAxNjoyNjoxMyArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFdlYktpdFdlYk5hdmlnYXRpb25BY3Rpb246IGZpeCBtaXggYmV0d2VlbiBkaXNwb3NlIGFu ZAogZmluYWxpemUKCi0tLQogU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYm5hdmln YXRpb25hY3Rpb24uY3BwIHwgICAgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYm5hdmlnYXRpb25hY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYm5hdmlnYXRpb25hY3Rpb24uY3BwCmluZGV4IGNhOGE3MjUuLjViNzBjNmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9u LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VibmF2aWdhdGlvbmFj dGlvbi5jcHAKQEAgLTEzNCw3ICsxMzQsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX25hdmln YXRpb25fYWN0aW9uX2NsYXNzX2luaXQoV2ViS2l0V2ViTmF2aWdhdGlvbkFjdGlvbkNsYQogCiAg ICAgb2JqZWN0Q2xhc3MtPmdldF9wcm9wZXJ0eSA9IHdlYmtpdF93ZWJfbmF2aWdhdGlvbl9hY3Rp b25fZ2V0X3Byb3BlcnR5OwogICAgIG9iamVjdENsYXNzLT5zZXRfcHJvcGVydHkgPSB3ZWJraXRf d2ViX25hdmlnYXRpb25fYWN0aW9uX3NldF9wcm9wZXJ0eTsKLSAgICBvYmplY3RDbGFzcy0+ZGlz cG9zZSA9IHdlYmtpdF93ZWJfbmF2aWdhdGlvbl9hY3Rpb25fZmluYWxpemU7CisgICAgb2JqZWN0 Q2xhc3MtPmZpbmFsaXplID0gd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9maW5hbGl6ZTsK IAogICAgIC8qKgogICAgICAqIFdlYktpdFdlYk5hdmlnYXRpb25BY3Rpb246cmVhc29uOgotLSAK MS43LjEwLjQKCg== 196336 2013-04-03 06:07:53 -0700 2013-04-03 08:16:32 -0700 [PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize 0001-GTK-WebKitWebNavigationAction-fix-mix-between-dispos.patch text/plain 2454 alban.crequy RnJvbSBiMGY3ODUyZjNlYjk2NDZiYThkY2I2YTU2ZTM1MmVkY2Y0MmM0MTEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGJhbiBDcmVxdXkgPGFsYmFuLmNyZXF1eUBjb2xsYWJvcmEu Y28udWs+CkRhdGU6IFR1ZSwgMiBBcHIgMjAxMyAxNjoyNjoxMyArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIFtHVEtdIFdlYktpdFdlYk5hdmlnYXRpb25BY3Rpb246IGZpeCBtaXggYmV0d2VlbiBkaXNw b3NlIGFuZAogZmluYWxpemUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzc5NAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpXZWJLaXRXZWJOYXZpZ2F0aW9u QWN0aW9uJ3MgZGlzcG9zZSBmdW5jdGlvbiB3YXMgbmFtZWQgZmluYWxpemUgYW5kIHdhcyBjYWxs aW5nCnRoZSBwYXJlbnQgY2xhc3MncyBmaW5hbGlzZSBmdW5jdGlvbiwgY2F1c2luZyBhIG1lbW9y eSBjb3JydXB0aW9uLiBDaGFuZ2UgaXQgdG8KYmUgYSBwcm9wZXIgZmluYWxpemUgZnVuY3Rpb24g aW5zdGVhZC4KCiogd2Via2l0L3dlYmtpdHdlYm5hdmlnYXRpb25hY3Rpb24uY3BwOgood2Via2l0 X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9jbGFzc19pbml0KToKLS0tCiBTb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysr KysrCiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VibmF2aWdhdGlvbmFjdGlvbi5j cHAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMDZmYzNjMC4uNDMwNWRjZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTAzICBBbGJhbiBDcmVxdXkgIDxhbGJhbi5j cmVxdXlAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFtHVEtdIFdlYktpdFdlYk5hdmlnYXRp b25BY3Rpb246IGZpeCBtaXggYmV0d2VlbiBkaXNwb3NlIGFuZCBmaW5hbGl6ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzk0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0V2ViTmF2aWdhdGlv bkFjdGlvbidzIGRpc3Bvc2UgZnVuY3Rpb24gd2FzIG5hbWVkIGZpbmFsaXplIGFuZCB3YXMgY2Fs bGluZworICAgICAgICB0aGUgcGFyZW50IGNsYXNzJ3MgZmluYWxpc2UgZnVuY3Rpb24sIGNhdXNp bmcgYSBtZW1vcnkgY29ycnVwdGlvbi4gQ2hhbmdlIGl0IHRvCisgICAgICAgIGJlIGEgcHJvcGVy IGZpbmFsaXplIGZ1bmN0aW9uIGluc3RlYWQuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vi bmF2aWdhdGlvbmFjdGlvbi5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX25hdmlnYXRpb25fYWN0 aW9uX2NsYXNzX2luaXQpOgorCiAyMDEzLTAzLTI4ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtA aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBCdWlsZCBHVEstc3BlY2lmaWMsIG5vbi1sYXll ci12aW9sYXRpbmcgc291cmNlIGNvZGUgaW50byBXZWJDb3JlLWluZGVwZW5kZW50IGxpYlBsYXRm b3JtR3RrLmxhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi bmF2aWdhdGlvbmFjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi bmF2aWdhdGlvbmFjdGlvbi5jcHAKaW5kZXggOWE3ZjA3ZC4uYzc4ZTc1NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYm5hdmlnYXRpb25hY3Rpb24uY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9uLmNw cApAQCAtMTM0LDcgKzEzNCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfbmF2aWdhdGlvbl9h Y3Rpb25fY2xhc3NfaW5pdChXZWJLaXRXZWJOYXZpZ2F0aW9uQWN0aW9uQ2xhCiAKICAgICBvYmpl Y3RDbGFzcy0+Z2V0X3Byb3BlcnR5ID0gd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9nZXRf cHJvcGVydHk7CiAgICAgb2JqZWN0Q2xhc3MtPnNldF9wcm9wZXJ0eSA9IHdlYmtpdF93ZWJfbmF2 aWdhdGlvbl9hY3Rpb25fc2V0X3Byb3BlcnR5OwotICAgIG9iamVjdENsYXNzLT5kaXNwb3NlID0g d2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9maW5hbGl6ZTsKKyAgICBvYmplY3RDbGFzcy0+ ZmluYWxpemUgPSB3ZWJraXRfd2ViX25hdmlnYXRpb25fYWN0aW9uX2ZpbmFsaXplOwogCiAgICAg LyoqCiAgICAgICogV2ViS2l0V2ViTmF2aWdhdGlvbkFjdGlvbjpyZWFzb246Ci0tIAoxLjcuMTAu NAoK