113793 2013-04-02 09:08:49 -0700 Web Inspector: [CodeMirror] do not show cursor in read-only mode 2013-04-02 10:47:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 867911 0 lushnikov 2013-04-02 09:08:49 -0700 Do not show cursor in read-only mode. 867914 1 196156 lushnikov 2013-04-02 09:11:42 -0700 Created attachment 196156 Patch 867924 2 196156 apavlov 2013-04-02 09:22:01 -0700 Comment on attachment 196156 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196156&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:136 > + if (readOnly) Why not just this._codeMirror.setOption("readOnly", isReadOnlySection ? "nocursor" : false); ? 867952 3 196156 lushnikov 2013-04-02 09:43:58 -0700 Comment on attachment 196156 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196156&action=review >> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:136 >> + if (readOnly) > > Why not just > > this._codeMirror.setOption("readOnly", isReadOnlySection ? "nocursor" : false); ? yep, your solution is much better! Thanks! 867969 4 196171 lushnikov 2013-04-02 10:08:14 -0700 Created attachment 196171 Patch 868002 5 196171 apavlov 2013-04-02 10:42:52 -0700 Comment on attachment 196171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196171&action=review > Source/WebCore/ChangeLog:8 > + No new tests. We usually specify the reason for which a change has no tests. E.g., "No new tests - a UI change" 868009 6 196171 webkit.review.bot 2013-04-02 10:47:56 -0700 Comment on attachment 196171 Patch Clearing flags on attachment: 196171 Committed r147451: <http://trac.webkit.org/changeset/147451> 868010 7 webkit.review.bot 2013-04-02 10:47:59 -0700 All reviewed patches have been landed. Closing bug. 196156 2013-04-02 09:11:42 -0700 2013-04-02 10:08:05 -0700 Patch bug-113793-20130402201133.patch text/plain 2385 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWYxODkyNjA3MmE0N2U1 ZTQ1ZjZlMTY5NDlhZWY4NzdkNmJmMDdjZi4uNDE1ZmM5NTNmNTEzZTI2ZDRjY2Q0YWNkMzc5MDFi OTU3OGM0YTFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEzLTA0LTAyICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gZG8gbm90IHNob3cgY3Vyc29yIGluIHJlYWQtb25seSBtb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM3OTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuCisKKyAgICAgICAgLSBNYXJrIHJlYWRvbmx5IG1vZGUgb2YgY29kZW1pcnJvciBlZGl0 b3Igd2l0aCBhICdjbS1yZWFkb25seScgc3R5bGUgY2xhc3MuCisgICAgICAgIC0gQWRkIGEgY3Nz IHJ1bGUgdG8gaGlkZSBjb2RlbWlycm9yIGN1cnNvciBmb3IgcmVhZG9ubHkgbW9kZS4KKworICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IucHJvdG90eXBlLnNldFJlYWRP bmx5KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2NtL2NtZGV2dG9vbHMuY3NzOgor ICAgICAgICAoLkNvZGVNaXJyb3IuY20tcmVhZG9ubHkgLkNvZGVNaXJyb3ItY3Vyc29yKToKKwor MjAxMy0wNC0wMiAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5vcmc+CisK ICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVzb3VyY2UgcHJldmlldyBvZiBodG1sL2pzL2NzcyB0 eXBlcyBzaG91bGQgYmUgb24gYSBncmV5IGJhY2tncm91bmQKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzc5MQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcwpp bmRleCBiYjRhNDZmMWQyOTkzZTMyMTdiNmM2YTlhYmM3ZjRhM2VmMGJiODMwLi42YmZlOGI1ODll NDRiODQ4OTdlOGY3ODJiNDUzMzA2MDI5YzgxODJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKQEAg LTEzMyw2ICsxMzMsMTAgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLnByb3Rv dHlwZSA9IHsKICAgICBzZXRSZWFkT25seTogZnVuY3Rpb24ocmVhZE9ubHkpCiAgICAgewogICAg ICAgICB0aGlzLl9jb2RlTWlycm9yLnNldE9wdGlvbigicmVhZE9ubHkiLCByZWFkT25seSk7Cisg ICAgICAgIGlmIChyZWFkT25seSkKKyAgICAgICAgICAgIHRoaXMuZWxlbWVudC5maXJzdENoaWxk LmFkZFN0eWxlQ2xhc3MoImNtLXJlYWRvbmx5Iik7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAg IHRoaXMuZWxlbWVudC5maXJzdENoaWxkLnJlbW92ZVN0eWxlQ2xhc3MoImNtLXJlYWRvbmx5Iik7 CiAgICAgfSwKIAogICAgIC8qKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9jbS9jbWRldnRvb2xzLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvY20vY21kZXZ0b29scy5jc3MKaW5kZXggZjE5M2JkODg5MDFlZDc2ZmM4NTdhNTlk MDYzZTZlZTgyZWNlMmY0OC4uODcyNTAzYTBiNjUzMGRmMmIyMTNkZWJjMjY5YmY5ZjFjYjFlN2Nh OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9jbS9jbWRl dnRvb2xzLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2NtL2Nt ZGV2dG9vbHMuY3NzCkBAIC0yLDYgKzIsMTAgQEAKICAgLXdlYmtpdC1ib3gtc2l6aW5nOiBjb250 ZW50LWJveDsKIH0KIAorLkNvZGVNaXJyb3IuY20tcmVhZG9ubHkgLkNvZGVNaXJyb3ItY3Vyc29y IHsKKyAgICBkaXNwbGF5OiBub25lOworfQorCiAuQ29kZU1pcnJvciB7CiAgIGxpbmUtaGVpZ2h0 OiAxLjJlbSAhaW1wb3J0YW50OwogICBoZWlnaHQ6IDEwMCUgIWltcG9ydGFudDsK 196171 2013-04-02 10:08:14 -0700 2013-04-02 10:47:56 -0700 Patch bug-113793-20130402210805.patch text/plain 1565 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWYxODkyNjA3MmE0N2U1 ZTQ1ZjZlMTY5NDlhZWY4NzdkNmJmMDdjZi4uYzAwZGEwZTZiMzgzZDU0NTliZTJjODliODQzMGM0 OGU5M2ZmZWIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTA0LTAyICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gZG8gbm90IHNob3cgY3Vyc29yIGluIHJlYWQtb25seSBtb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM3OTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuCisKKyAgICAgICAgUGFzcyAibm9jdXJzb3IiIG9wdGlvbiB0byBDb2RlTWlycm9yJ3Mg InJlYWRvbmx5IiBzZXR0aW5nLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db2Rl TWlycm9yVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4 dEVkaXRvci5wcm90b3R5cGUuc2V0UmVhZE9ubHkpOgorCisyMDEzLTA0LTAyICBBbmRyZXkgTHVz aG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiByZXNvdXJjZSBwcmV2aWV3IG9mIGh0bWwvanMvY3NzIHR5cGVzIHNob3VsZCBiZSBvbiBhIGdy ZXkgYmFja2dyb3VuZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEzNzkxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCmluZGV4IGJiNGE0NmYxZDI5OTNlMzIx N2I2YzZhOWFiYzdmNGEzZWYwYmI4MzAuLjM4MTgxMTNkNGZlMDg5NmI0OTBkYmJkOWE0NjA5ZDll ZTFjMmZlZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29kZU1pcnJvclRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcwpAQCAtMTMyLDcgKzEzMiw3IEBAIFdlYklu c3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAgICAgICovCiAgICAg c2V0UmVhZE9ubHk6IGZ1bmN0aW9uKHJlYWRPbmx5KQogICAgIHsKLSAgICAgICAgdGhpcy5fY29k ZU1pcnJvci5zZXRPcHRpb24oInJlYWRPbmx5IiwgcmVhZE9ubHkpOworICAgICAgICB0aGlzLl9j b2RlTWlycm9yLnNldE9wdGlvbigicmVhZE9ubHkiLCByZWFkT25seSA/ICJub2N1cnNvciIgOiBm YWxzZSk7CiAgICAgfSwKIAogICAgIC8qKgo=