113785 2013-04-02 08:24:47 -0700 [CoordGfx] Background color should not be part of GraphicsLayerState 2013-04-15 05:02:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109579 1 kbalazs kbalazs cmarcelo commit-queue luiz noam webkit.review.bot zeno oldest_to_newest 867864 0 kbalazs 2013-04-02 08:24:47 -0700 The background is not part of the flushing process, we can send it ASAP. 867873 1 196147 kbalazs 2013-04-02 08:34:18 -0700 Created attachment 196147 Patch 867879 2 196147 noam 2013-04-02 08:43:27 -0700 Comment on attachment 196147 Patch LGTM, please get sign off from WK2 owner. 875186 3 196147 commit-queue 2013-04-13 09:55:51 -0700 Comment on attachment 196147 Patch Rejecting attachment 196147 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 196147, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/97184 875718 4 196147 kbalazs 2013-04-15 05:02:20 -0700 Comment on attachment 196147 Patch Landed in http://trac.webkit.org/changeset/148430 196147 2013-04-02 08:34:18 -0700 2013-04-15 05:02:20 -0700 Patch bug-113785-20130402173404.patch text/plain 5680 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhhYmY5MjhhOTkzMjUw MDUxZjA3MjdkOWQ2Nzc3YjZlMzUwNjJjOC4uMDczYmE2MDM0NTQ3YmRlOTQ3MzBkYzY5ODZmN2Yz NDNhOWZjNTRhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTAyICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbQ29vcmRHZnhdIEJh Y2tncm91bmQgY29sb3Igc2hvdWxkIG5vdCBiZSBwYXJ0IG9mIEdyYXBoaWNzTGF5ZXJTdGF0ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzg1CisK KyAgICAgICAgUGFnZSBiYWNrZ3JvdW5kIGlzIGluZGVwZW5kZW50IGZyb20gbGF5ZXIgc3RhdGUs IHNlbmQgaXQgdG8gdGhlIFVJCisgICAgICAgIGFzIHNvb24gYXMgcG9zc2libGUuCisKKyAgICAg ICAgU2hvdWxkIG5vdCBjYXVzZSBvYnNlcnZhYmxlIGNoYW5nZSBpbiBiZWhhdmlvciBzbyBubyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0 ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3Jk aW5hdGVkR3JhcGhpY3NTY2VuZTo6Y29tbWl0U2NlbmVTdGF0ZSk6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTdGF0ZS5o OgorCiAyMDEzLTAzLTIyICBEYXZpZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBJbmRleGVkREI6IEhpc3RvZ3JhbSBhdmFpbGFibGUgZGlzayBzcGFjZSBvbiBhdHRl bXB0IHRvIG9wZW4gZGF0YWJhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5OWY4ZTI5MTBmOTU5ODc2ODc4YTZk NDliMWQ1YWEzMWM4NjZiYjk4Li42NDJhZWIyYWU5ZDllZTk4NjQ4ODc0YmI2YTYyOWJmYmM4M2E4 MDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMDQtMDIgIEJhbGF6cyBLZWxl bWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtDb29yZEdmeF0gQmFja2dyb3Vu ZCBjb2xvciBzaG91bGQgbm90IGJlIHBhcnQgb2YgR3JhcGhpY3NMYXllclN0YXRlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM3ODUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYWdlIGJhY2tncm91bmQg aXMgaW5kZXBlbmRlbnQgZnJvbSBsYXllciBzdGF0ZSwgc2VuZCBpdCB0byB0aGUgVUkKKyAgICAg ICAgYXMgc29vbiBhcyBwb3NzaWJsZS4KKworICAgICAgICAqIFNoYXJlZC9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHA6CisgICAgICAgIChD b3JlSVBDOjo6OmVuY29kZSk6CisgICAgICAgIChDb3JlSVBDOjo6OmRlY29kZSk6CisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXll clRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 OjpzZXRCYWNrZ3JvdW5kQ29sb3IpOgorCiAyMDEzLTAzLTIyICBUaW1vdGh5IEhhdGNoZXIgIDx0 aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYW4gYXNzZXJ0IHdoZW4gb3BlbmluZyB0 aGUgV2ViIEluc3BlY3RvciB3aW5kb3cgZm9yIHRoZSBmaXJzdCB0aW1lLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcAppbmRleCBl MjY2OGYzZGE3OGFkNDYwZTA3YzUxYjMwMmI2NGU1MTFkYzk4N2QwLi5jMzU4Y2M1ODEwNjI2M2Q1 MGFkOTZkNTljN2Y1NjFkMGQyNjMzMjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5l LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRp bmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcApAQCAtNjE4LDkgKzYxOCw2IEBAIHZv aWQgQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjpjb21taXRTY2VuZVN0YXRlKGNvbnN0IENvb3Jk aW5hdGVkR3JhcGhpY3NTdGF0ZSYKICAgICBpZiAoc3RhdGUucm9vdENvbXBvc2l0aW5nTGF5ZXIg IT0gbV9yb290TGF5ZXJJRCkKICAgICAgICAgc2V0Um9vdExheWVySUQoc3RhdGUucm9vdENvbXBv c2l0aW5nTGF5ZXIpOwogCi0gICAgaWYgKHN0YXRlLmJhY2tncm91bmRDb2xvciAhPSBtX2JhY2tn cm91bmRDb2xvcikKLSAgICAgICAgc2V0QmFja2dyb3VuZENvbG9yKHN0YXRlLmJhY2tncm91bmRD b2xvcik7Ci0KICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHN0YXRlLmltYWdlc1RvVXBkYXRl LnNpemUoKTsgKytpKQogICAgICAgICB1cGRhdGVJbWFnZUJhY2tpbmcoc3RhdGUuaW1hZ2VzVG9V cGRhdGVbaV0uZmlyc3QsIHN0YXRlLmltYWdlc1RvVXBkYXRlW2ldLnNlY29uZCk7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9Db29yZGluYXRlZEdyYXBoaWNzU3RhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU3RhdGUuaAppbmRl eCAxODE4N2IzZGZkNTg4MWM5ZWIyYThlMWYyMmUxNjNjNDFlYjExM2Q3Li45MTBiMGVlNjMyYWU3 NjFiNzdlOGJlMzE3MjQ3Y2YwYzMxOGU1N2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1N0 YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3Jk aW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTdGF0ZS5oCkBAIC0xNzQsNyArMTc0LDYgQEAgc3Ry dWN0IENvb3JkaW5hdGVkR3JhcGhpY3NMYXllclN0YXRlIHsKIAogc3RydWN0IENvb3JkaW5hdGVk R3JhcGhpY3NTdGF0ZSB7CiAgICAgdWludDMyX3Qgcm9vdENvbXBvc2l0aW5nTGF5ZXI7Ci0gICAg Q29sb3IgYmFja2dyb3VuZENvbG9yOwogICAgIEZsb2F0UG9pbnQgc2Nyb2xsUG9zaXRpb247CiAg ICAgSW50U2l6ZSBjb250ZW50c1NpemU7CiAgICAgSW50UmVjdCBjb3ZlcmVkUmVjdDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5h dGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwCmlu ZGV4IDAwM2U0N2MzMWZiMGJlMGY2MGU4YmU3NDhmMTY2ZDZiNDI5MTg2ZWIuLjYyMGYwYjEwOTc0 OGIzZWJlOTRmZjg5NDEyN2Y0Yjk1NWY5YjEyYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENv ZGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcApAQCAtMTAxNyw3ICsxMDE3LDYg QEAgYm9vbCBBcmd1bWVudENvZGVyPFRpbGVDcmVhdGlvbkluZm8+OjpkZWNvZGUoQXJndW1lbnRE ZWNvZGVyJiBkZWNvZGVyLCBUaWxlQ3JlYXQKIHZvaWQgQXJndW1lbnRDb2RlcjxDb29yZGluYXRl ZEdyYXBoaWNzU3RhdGU+OjplbmNvZGUoQXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBD b29yZGluYXRlZEdyYXBoaWNzU3RhdGUmIHN0YXRlKQogewogICAgIGVuY29kZXIgPDwgc3RhdGUu cm9vdENvbXBvc2l0aW5nTGF5ZXI7Ci0gICAgZW5jb2RlciA8PCBzdGF0ZS5iYWNrZ3JvdW5kQ29s b3I7CiAgICAgZW5jb2RlciA8PCBzdGF0ZS5zY3JvbGxQb3NpdGlvbjsKICAgICBlbmNvZGVyIDw8 IHN0YXRlLmNvbnRlbnRzU2l6ZTsKICAgICBlbmNvZGVyIDw8IHN0YXRlLmNvdmVyZWRSZWN0OwpA QCAtMTA0Niw5ICsxMDQ1LDYgQEAgYm9vbCBBcmd1bWVudENvZGVyPENvb3JkaW5hdGVkR3JhcGhp Y3NTdGF0ZT46OmRlY29kZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIEMKICAgICBpZiAoIWRl Y29kZXIuZGVjb2RlKHN0YXRlLnJvb3RDb21wb3NpdGluZ0xheWVyKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCi0gICAgaWYgKCFkZWNvZGVyLmRlY29kZShzdGF0ZS5iYWNrZ3JvdW5kQ29sb3Ip KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHN0YXRl LnNjcm9sbFBvc2l0aW9uKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29y ZGluYXRlZExheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAppbmRl eCBjMWYyNDA0ZGIzM2Q5MGFhNGU2MjI0YWIzNGRhYjA3ZmUyMzY4OGI4Li5jYWNkY2VjNmM5ZWE2 ZTUzMzZhYjY4NmJlYmEzMWVkNTQzZTAyN2I0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJl ZUhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTgwMyw4ICs4MDMs NyBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6cmVsZWFzZUluYWN0aXZlQXRsYXNl c1RpbWVyRmlyZWQoVGltZXI8Q29vcmRpbmF0ZQogCiB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdDo6c2V0QmFja2dyb3VuZENvbG9yKGNvbnN0IFdlYkNvcmU6OkNvbG9yJiBjb2xvcikKIHsK LSAgICBtX3Nob3VsZFN5bmNGcmFtZSA9IHRydWU7Ci0gICAgbV9zdGF0ZS5iYWNrZ3JvdW5kQ29s b3IgPSBjb2xvcjsKKyAgICBtX3dlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OkNvb3JkaW5hdGVkTGF5 ZXJUcmVlSG9zdFByb3h5OjpTZXRCYWNrZ3JvdW5kQ29sb3IoY29sb3IpKTsKIH0KIAogdm9pZCBD b29yZGluYXRlZExheWVyVHJlZUhvc3Q6OmNvbW1pdFNjcm9sbE9mZnNldCh1aW50MzJfdCBsYXll cklELCBjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBvZmZzZXQpCg==