113784 2013-04-02 08:12:56 -0700 [Qt] Fail gracefully if an OpenGL context could not be created. 2013-04-03 08:01:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno andy.shaw bruno.abinader dino hausmann jturcotte noam webkit.review.bot oldest_to_newest 867851 0 zeno 2013-04-02 08:12:56 -0700 [Qt] Fail gracefully if an OpenGL context could not be created. 867853 1 196143 zeno 2013-04-02 08:15:11 -0700 Created attachment 196143 Patch 867871 2 196143 jturcotte 2013-04-02 08:31:06 -0700 Comment on attachment 196143 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196143&action=review > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:373 > - return context->m_private ? context.release() : 0; > + return (context->m_private && context->platformGraphicsContext3D()) ? context.release() : 0; To avoid spreading the failure logic I think it would be cleaner to add a check in GraphicsContext3D::GraphicsContext3D and set m_private = nullptr if (!m_private->m_platformContext). Something like changing "if (!m_private->m_surface) {" to "if (!m_private->m_surface || !m_private->m_platformContext) {" at line 398. 868142 3 196205 zeno 2013-04-02 12:00:38 -0700 Created attachment 196205 Patch 868143 4 zeno 2013-04-02 12:01:24 -0700 (In reply to comment #2) > To avoid spreading the failure logic I think it would be cleaner to add a check in GraphicsContext3D::GraphicsContext3D and set m_private = nullptr if (!m_private->m_platformContext). A very good point! Thx a lot! :) 868719 5 196205 zeno 2013-04-03 08:01:03 -0700 Comment on attachment 196205 Patch Clearing flags on attachment: 196205 Committed r147553: <http://trac.webkit.org/changeset/147553> 868720 6 zeno 2013-04-03 08:01:08 -0700 All reviewed patches have been landed. Closing bug. 196143 2013-04-02 08:15:11 -0700 2013-04-02 12:00:32 -0700 Patch bug-113784-20130402171512.patch text/plain 2358 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFjNmZlMzg1MmMyYzE4 Yjk3OWJkMThmOTI0YWZmNWY5ZTdkOTEyNy4uYzhhNzM1NmM5Mjk1ZjEyY2Q3ZDk3MjNiNWQ3N2Ez ZGM2YjA1NjRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTAyICBaZW5v IEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gRmFpbCBncmFjZWZ1 bGx5IGlmIGFuIE9wZW5HTCBjb250ZXh0IGNvdWxkIG5vdCBiZSBjcmVhdGVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzg0CisKKyAgICAgICAg SW4gY2FzZSB3ZSBmYWlsIHRvIGNyZWF0ZSBvciBhZG9wdCBhIHZhbGlkIHBsYXRmb3JtIE9wZW5H TCBjb250ZXh0CisgICAgICAgIHdlIGRvIG5vdCB3YW50IHRvIHByb3ZpZGUgYSBHcmFwaGljc0Nv bnRleHQzRCBpbnN0YW5jZS4KKyAgICAgICAgT3RoZXJ3aXNlIHdlIHdvdWxkIGNyYXNoIGFzIHNv b24gYXMgdGhlIGluc3RhbmNlIGlzIGJlaW5nIHVzZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZTo6R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dDNEOjpjcmVhdGUpOgorCiAyMDEzLTA0LTAyICBBbmRyZXkgTHVzaG5pa292ICA8 bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzb3VyY2Ug bG9jYXRpb24gZ2V0cyBmcm96ZW4gYWZ0ZXIgaW5zcGVjdG9yIHJlbG9hZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQz RFF0LmNwcAppbmRleCA1NTE3YmE5NWEyNjRjMTQxZjg4MTNkNzZmMDVmYTY2MzFhZmNjMmE2Li5m YTMzYTg4NmJiOGZkZjZhM2ViMmQyZGZkMDM0YzRmY2FlNjA1YTIxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQz RFF0LmNwcApAQCAtMTExLDcgKzExMSw4IEBAIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6R3Jh cGhpY3NDb250ZXh0M0RQcml2YXRlKEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0LCBICiB7CiAg ICAgaWYgKHJlbmRlclN0eWxlID09IEdyYXBoaWNzQ29udGV4dDNEOjpSZW5kZXJUb0N1cnJlbnRH TENvbnRleHQpIHsKICAgICAgICAgbV9wbGF0Zm9ybUNvbnRleHQgPSBRT3BlbkdMQ29udGV4dDo6 Y3VycmVudENvbnRleHQoKTsKLSAgICAgICAgbV9zdXJmYWNlID0gbV9wbGF0Zm9ybUNvbnRleHQt PnN1cmZhY2UoKTsKKyAgICAgICAgaWYgKG1fcGxhdGZvcm1Db250ZXh0KQorICAgICAgICAgICAg bV9zdXJmYWNlID0gbV9wbGF0Zm9ybUNvbnRleHQtPnN1cmZhY2UoKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KIApAQCAtMzY5LDcgKzM3MCw3IEBAIFBhc3NSZWZQdHI8R3JhcGhpY3NDb250ZXh0 M0Q+IEdyYXBoaWNzQ29udGV4dDNEOjpjcmVhdGUoR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpCiAg ICAgaWYgKHJlbmRlclN0eWxlID09IFJlbmRlckRpcmVjdGx5VG9Ib3N0V2luZG93KQogICAgICAg ICByZXR1cm4gMDsKICAgICBSZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+IGNvbnRleHQgPSBhZG9w dFJlZihuZXcgR3JhcGhpY3NDb250ZXh0M0QoYXR0cnMsIGhvc3RXaW5kb3csIHJlbmRlclN0eWxl KSk7Ci0gICAgcmV0dXJuIGNvbnRleHQtPm1fcHJpdmF0ZSA/IGNvbnRleHQucmVsZWFzZSgpIDog MDsKKyAgICByZXR1cm4gKGNvbnRleHQtPm1fcHJpdmF0ZSAmJiBjb250ZXh0LT5wbGF0Zm9ybUdy YXBoaWNzQ29udGV4dDNEKCkpID8gY29udGV4dC5yZWxlYXNlKCkgOiAwOwogfQogCiBHcmFwaGlj c0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QoR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0 ZXMgYXR0cnMsIEhvc3RXaW5kb3cqIGhvc3RXaW5kb3csIEdyYXBoaWNzQ29udGV4dDNEOjpSZW5k ZXJTdHlsZSByZW5kZXJTdHlsZSkK 196205 2013-04-02 12:00:38 -0700 2013-04-03 08:01:03 -0700 Patch bug-113784-20130402210029.patch text/plain 2220 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE5MTFjZjYxNjVhNjA4 YzdiNzY2ZGVkNWQyZDA2YTJhOTNjNmQ3Mi4uMzQ4MTA0ODJkZDg4M2YxZDVjMTJkNWQyZGRkMTAw ODg1MmZhYTUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTAyICBaZW5v IEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gRmFpbCBncmFjZWZ1 bGx5IGlmIGFuIE9wZW5HTCBjb250ZXh0IGNvdWxkIG5vdCBiZSBjcmVhdGVkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzg0CisKKyAgICAgICAg SW4gY2FzZSB3ZSBmYWlsIHRvIGNyZWF0ZSBvciBhZG9wdCBhIHZhbGlkIHBsYXRmb3JtIE9wZW5H TCBjb250ZXh0CisgICAgICAgIHdlIGRvIG5vdCB3YW50IHRvIHByb3ZpZGUgYSBHcmFwaGljc0Nv bnRleHQzRCBpbnN0YW5jZS4KKyAgICAgICAgT3RoZXJ3aXNlIHdlIHdvdWxkIGNyYXNoIGFzIHNv b24gYXMgdGhlIGluc3RhbmNlIGlzIGJlaW5nIHVzZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZTo6R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dDNEOjpHcmFwaGljc0NvbnRleHQzRCk6CisKIDIwMTMtMDQtMDIgIEFuZHJleSBM dXNobmlrb3YgIDxsdXNobmlrb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE1ha2UgU291cmNlIEZyYW1lICYgc3RhdHVzIGJhciBhIGxheW91dCBib3VuZGFyeQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250 ZXh0M0RRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcAppbmRleCA1NTE3YmE5NWEyNjRjMTQxZjg4MTNkNzZmMDVmYTY2MzFh ZmNjMmE2Li44NWNlOTMyMzE5MTY4MmFhNDBiOWY1MGU5NTRjNDFjZmJiODEyOWZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQz RFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcApAQCAtMTExLDcgKzExMSw4IEBAIEdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZTo6R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0 LCBICiB7CiAgICAgaWYgKHJlbmRlclN0eWxlID09IEdyYXBoaWNzQ29udGV4dDNEOjpSZW5kZXJU b0N1cnJlbnRHTENvbnRleHQpIHsKICAgICAgICAgbV9wbGF0Zm9ybUNvbnRleHQgPSBRT3BlbkdM Q29udGV4dDo6Y3VycmVudENvbnRleHQoKTsKLSAgICAgICAgbV9zdXJmYWNlID0gbV9wbGF0Zm9y bUNvbnRleHQtPnN1cmZhY2UoKTsKKyAgICAgICAgaWYgKG1fcGxhdGZvcm1Db250ZXh0KQorICAg ICAgICAgICAgbV9zdXJmYWNlID0gbV9wbGF0Zm9ybUNvbnRleHQtPnN1cmZhY2UoKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIApAQCAtMzk1LDggKzM5Niw4IEBAIEdyYXBoaWNzQ29udGV4dDNE OjpHcmFwaGljc0NvbnRleHQzRChHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRycywg SG9zdFdpCiB7CiAgICAgdmFsaWRhdGVBdHRyaWJ1dGVzKCk7CiAKLSAgICBpZiAoIW1fcHJpdmF0 ZS0+bV9zdXJmYWNlKSB7Ci0gICAgICAgIExPR19FUlJPUigiR3JhcGhpY3NDb250ZXh0M0Q6IFFH TFdpZGdldCBpbml0aWFsaXphdGlvbiBmYWlsZWQuIik7CisgICAgaWYgKCFtX3ByaXZhdGUtPm1f c3VyZmFjZSB8fCAhbV9wcml2YXRlLT5tX3BsYXRmb3JtQ29udGV4dCkgeworICAgICAgICBMT0df RVJST1IoIkdyYXBoaWNzQ29udGV4dDNEOiBHTCBjb250ZXh0IGNyZWF0aW9uIGZhaWxlZC4iKTsK ICAgICAgICAgbV9wcml2YXRlID0gbnVsbHB0cjsKICAgICAgICAgcmV0dXJuOwogICAgIH0K