113771 2013-04-02 05:40:45 -0700 Web Inspector: [CodeMirror] Popover for codemirror 2013-04-02 06:14:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 867754 0 lushnikov 2013-04-02 05:40:45 -0700 Implement: - CodeMirrorTextEditor.cursorPositionToCoordinates - CodeMirrorTextEditor.coordinatesToCursorPosition - CodeMirrorTextEditor.tokenAtTextPosition to support required interfaces for popover. 867758 1 196124 lushnikov 2013-04-02 05:48:55 -0700 Created attachment 196124 Patch 867769 2 196124 webkit.review.bot 2013-04-02 06:13:59 -0700 Comment on attachment 196124 Patch Clearing flags on attachment: 196124 Committed r147421: <http://trac.webkit.org/changeset/147421> 867770 3 webkit.review.bot 2013-04-02 06:14:02 -0700 All reviewed patches have been landed. Closing bug. 196124 2013-04-02 05:48:55 -0700 2013-04-02 06:13:58 -0700 Patch bug-113771-20130402164846.patch text/plain 5107 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI2NTY4ZjQ4NDJiODJi ZTk5ZDVlZDMxMzYyNTA4ZDY3NzZiNGQ0OC4uMDhkNDg0Y2ZhMWI0OTFiMGQ2OTgzMjZlZTFiZGZj OWE2YmJkMDQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTA0LTAyICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gUG9wb3ZlciBmb3IgY29kZW1pcnJvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzcxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IG1ldGhvZHMgVGV4 dEVkaXRvci5jdXJzb3JQb3NpdGlvblRvQ29vcmRpbmF0ZXMsIFRleHRFZGl0b3IuY29vcmRpbmF0 ZXNUb0N1cnNvclBvc2l0aW9uIGFuZAorICAgICAgICBUZXh0RWRpdG9yLnRva2VuQXRUZXh0UG9z aXRpb24gaW4gQ29kZU1pcnJvclRleHRFZGl0b3IgdG8gc3VwcG9ydCBwb3BvdmVyCisgICAgICAg IGZ1bmN0aW9uYWxpdHkuIEFkZCBjc3MgY2xhc3NlcyB0byBoaWdobGlnaHQgcG9wb3ZlciBhbmNo b3JpbmcgdGV4dC4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLnByb3RvdHlwZS5jdXJzb3JQb3NpdGlvblRvQ29vcmRp bmF0ZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLnByb3Rv dHlwZS5jb29yZGluYXRlc1RvQ3Vyc29yUG9zaXRpb24pOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkNvZGVNaXJyb3JUZXh0RWRpdG9yLnByb3RvdHlwZS50b2tlbkF0VGV4dFBvc2l0aW9uKToKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2NtL2NtZGV2dG9vbHMuY3NzOgorICAgICAgICAo LkNvZGVNaXJyb3IgLnNvdXJjZS1mcmFtZS1ldmFsLWV4cHJlc3Npb24pOgorICAgICAgICAoLkNv ZGVNaXJyb3IgLnNvdXJjZS1mcmFtZS1ldmFsLWV4cHJlc3Npb24tZW5kKToKKyAgICAgICAgKC5D b2RlTWlycm9yIC5zb3VyY2UtZnJhbWUtZXZhbC1leHByZXNzaW9uLXN0YXJ0KToKKworMjAxMy0w NC0wMiAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgV2ViIEluc3BlY3RvcjogU2VwYXJhdGUgSmF2YVNjcmlwdFNvdXJjZUZyYW1lIHBvcG92ZXIg ZnJvbSBrbm93bGVkZ2Ugb2YgZWRpdG9yJ3MgRE9NCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM0MTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKaW5kZXgg YmI0YTQ2ZjFkMjk5M2UzMjE3YjZjNmE5YWJjN2Y0YTNlZjBiYjgzMC4uZTI4M2IyYTIwYzg5Y2U4 NzI3N2I0ZDgwN2E0MDVlOTVlNzE0NTFmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCkBAIC05Miw2 ICs5Miw2NyBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IgPSBmdW5jdGlvbih1 cmwsIGRlbGVnYXRlKQogV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLnByb3RvdHlw ZSA9IHsKIAogICAgIC8qKgorICAgICAqIEBwYXJhbSB7bnVtYmVyfSBsaW5lTnVtYmVyCisgICAg ICogQHBhcmFtIHtudW1iZXJ9IGNvbHVtbgorICAgICAqIEByZXR1cm4gez97eDogbnVtYmVyLCB5 OiBudW1iZXIsIGhlaWdodDogbnVtYmVyfX0KKyAgICAgKi8KKyAgICBjdXJzb3JQb3NpdGlvblRv Q29vcmRpbmF0ZXM6IGZ1bmN0aW9uKGxpbmVOdW1iZXIsIGNvbHVtbikKKyAgICB7CisgICAgICAg IGlmIChsaW5lTnVtYmVyID49IHRoaXMuX2NvZGVNaXJyb3IubGluZUNvdW50IHx8IGNvbHVtbiA+ IHRoaXMuX2NvZGVNaXJyb3IuZ2V0TGluZShsaW5lTnVtYmVyKS5sZW5ndGggfHwgbGluZU51bWJl ciA8IDAgfHwgY29sdW1uIDwgMCkKKyAgICAgICAgICAgIHJldHVybiBudWxsOworCisgICAgICAg IHZhciBtZXRyaWNzID0gdGhpcy5fY29kZU1pcnJvci5jdXJzb3JDb29yZHMoQ29kZU1pcnJvci5Q b3MobGluZU51bWJlciwgY29sdW1uKSk7CisKKyAgICAgICAgcmV0dXJuIHsKKyAgICAgICAgICAg IHg6IG1ldHJpY3MubGVmdCwKKyAgICAgICAgICAgIHk6IG1ldHJpY3MudG9wLAorICAgICAgICAg ICAgaGVpZ2h0OiBtZXRyaWNzLmJvdHRvbSAtIG1ldHJpY3MudG9wCisgICAgICAgIH07CisgICAg fSwKKworICAgIC8qKgorICAgICAqIEBwYXJhbSB7bnVtYmVyfSB4CisgICAgICogQHBhcmFtIHtu dW1iZXJ9IHkKKyAgICAgKiBAcmV0dXJuIHs/V2ViSW5zcGVjdG9yLlRleHRSYW5nZX0KKyAgICAg Ki8KKyAgICBjb29yZGluYXRlc1RvQ3Vyc29yUG9zaXRpb246IGZ1bmN0aW9uKHgsIHkpCisgICAg eworICAgICAgICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmVsZW1lbnRGcm9tUG9pbnQoeCwgeSk7 CisgICAgICAgIGlmICghZWxlbWVudCB8fCAhZWxlbWVudC5pc1NlbGZPckRlc2NlbmRhbnQodGhp cy5fY29kZU1pcnJvci5nZXRXcmFwcGVyRWxlbWVudCgpKSkKKyAgICAgICAgICAgIHJldHVybiBu dWxsOworICAgICAgICB2YXIgZ3V0dGVyQm94ID0gdGhpcy5fY29kZU1pcnJvci5nZXRHdXR0ZXJF bGVtZW50KCkuYm94SW5XaW5kb3coKTsKKyAgICAgICAgaWYgKHggPj0gZ3V0dGVyQm94LnggJiYg eCA8PSBndXR0ZXJCb3gueCArIGd1dHRlckJveC53aWR0aCAmJgorICAgICAgICAgICAgeSA+PSBn dXR0ZXJCb3gueSAmJiB5IDw9IGd1dHRlckJveC55ICsgZ3V0dGVyQm94LmhlaWdodCkKKyAgICAg ICAgICAgIHJldHVybiBudWxsOworICAgICAgICB2YXIgY29vcmRzID0gdGhpcy5fY29kZU1pcnJv ci5jb29yZHNDaGFyKHtsZWZ0OiB4LCB0b3A6IHl9KTsKKyAgICAgICAgKytjb29yZHMuY2g7Cisg ICAgICAgIHJldHVybiB0aGlzLl90b1JhbmdlKGNvb3JkcywgY29vcmRzKTsKKyAgICB9LAorCisg ICAgLyoqCisgICAgICogQHBhcmFtIHtudW1iZXJ9IGxpbmVOdW1iZXIKKyAgICAgKiBAcGFyYW0g e251bWJlcn0gY29sdW1uCisgICAgICogQHJldHVybiB7P3tzdGFydENvbHVtbjogbnVtYmVyLCBl bmRDb2x1bW46IG51bWJlciwgdG9rZW46IHN0cmluZ319CisgICAgICovCisgICAgdG9rZW5BdFRl eHRQb3NpdGlvbjogZnVuY3Rpb24obGluZU51bWJlciwgY29sdW1uKQorICAgIHsKKyAgICAgICAg aWYgKGxpbmVOdW1iZXIgPCAwIHx8IGxpbmVOdW1iZXIgPj0gdGhpcy5fY29kZU1pcnJvci5saW5l Q291bnQoKSkKKyAgICAgICAgICAgIHJldHVybiBudWxsOworICAgICAgICB2YXIgdG9rZW4gPSB0 aGlzLl9jb2RlTWlycm9yLmdldFRva2VuQXQoQ29kZU1pcnJvci5Qb3MobGluZU51bWJlciwgY29s dW1uIHx8IDEpKTsKKyAgICAgICAgaWYgKCF0b2tlbiB8fCAhdG9rZW4udHlwZSkKKyAgICAgICAg ICAgIHJldHVybiBudWxsOworICAgICAgICB2YXIgY29udmVydGVkVHlwZSA9IG51bGw7CisgICAg ICAgIGlmICh0b2tlbi50eXBlLnN0YXJ0c1dpdGgoInZhcmlhYmxlIikgfHwgdG9rZW4udHlwZS5z dGFydHNXaXRoKCJwcm9wZXJ0eSIpKSB7CisgICAgICAgICAgICByZXR1cm4geworICAgICAgICAg ICAgICAgIHN0YXJ0Q29sdW1uOiB0b2tlbi5zdGFydCwKKyAgICAgICAgICAgICAgICBlbmRDb2x1 bW46IHRva2VuLmVuZCAtIDEsCisgICAgICAgICAgICAgICAgdHlwZTogImphdmFzY3JpcHQtaWRl bnQiCisgICAgICAgICAgICB9OworICAgICAgICB9CisgICAgICAgIHJldHVybiBudWxsOworICAg IH0sCisKKyAgICAvKioKICAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5UZXh0UmFuZ2V9IHRl eHRSYW5nZQogICAgICAqIEByZXR1cm4ge3N0cmluZ30KICAgICAgKi8KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvY20vY21kZXZ0b29scy5jc3MgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2NtL2NtZGV2dG9vbHMuY3NzCmluZGV4IDBh OWZiZmFmODQ5ZmFlMGM5YTM4NDZmMGNmNzNkYzRlMDk0ZWIzZDYuLmRmMTc1MmJjOGM1MDQ5OGZm MmJhNzgyYjkyNDdmMTkzZjhmYTUyNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvY20vY21kZXZ0b29scy5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9jbS9jbWRldnRvb2xzLmNzcwpAQCAtNyw2ICs3LDI0IEBACiAgIGhl aWdodDogMTAwJSAhaW1wb3J0YW50OwogfQogCisuQ29kZU1pcnJvciAuc291cmNlLWZyYW1lLWV2 YWwtZXhwcmVzc2lvbiB7CisgIG91dGxpbmU6IDBweDsKKyAgYm9yZGVyOiAxcHggc29saWQgcmdi KDE2MywgNDEsIDM0KTsKKyAgYm9yZGVyLWxlZnQtd2lkdGg6IDBweDsKKyAgYm9yZGVyLXJpZ2h0 LXdpZHRoOiAwcHg7Cit9CisKKy5Db2RlTWlycm9yIC5zb3VyY2UtZnJhbWUtZXZhbC1leHByZXNz aW9uLWVuZCB7CisgIGJvcmRlci1yaWdodC13aWR0aDogMXB4OworICBtYXJnaW4tcmlnaHQ6IC0x cHg7Cit9CisKKy5Db2RlTWlycm9yIC5zb3VyY2UtZnJhbWUtZXZhbC1leHByZXNzaW9uLXN0YXJ0 IHsKKyAgYm9yZGVyLWxlZnQtd2lkdGg6IDFweDsKKyAgbWFyZ2luLWxlZnQ6IC0xcHg7Cit9CisK KwogLkNvZGVNaXJyb3ItbGluZW51bWJlciB7CiAgIHBhZGRpbmctdG9wOiAxcHggIWltcG9ydGFu dDsKICAgbWluLXdpZHRoOiAyMnB4ICFpbXBvcnRhbnQ7Cg==