113763 2013-04-02 02:38:50 -0700 [BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated() 2013-04-02 05:15:08 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned andersca anilsson cmarcelo jamesr luiz mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 867682 0 cgarcia 2013-04-02 02:38:50 -0700 And remove the custom methods frameViewFrameRectDidChange() and frameViewContentsSizeDidChange() 867683 1 196108 cgarcia 2013-04-02 02:46:12 -0700 Created attachment 196108 Patch 867703 2 196108 anilsson 2013-04-02 03:25:11 -0700 Comment on attachment 196108 Patch LGTM 867736 3 196108 rwlbuis 2013-04-02 04:32:08 -0700 Comment on attachment 196108 Patch LGTM. 867748 4 196108 webkit.review.bot 2013-04-02 05:15:05 -0700 Comment on attachment 196108 Patch Clearing flags on attachment: 196108 Committed r147418: <http://trac.webkit.org/changeset/147418> 867749 5 webkit.review.bot 2013-04-02 05:15:08 -0700 All reviewed patches have been landed. Closing bug. 196108 2013-04-02 02:46:12 -0700 2013-04-02 05:15:04 -0700 Patch bb-scrolling.diff text/plain 5043 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NjNhZjJjLi41NDkxMTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTMtMDQtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBJbXBsZW1lbnQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6 OmZyYW1lVmlld0xheW91dFVwZGF0ZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUFIgMzE4OTQ1CisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQg YnkgSmFrb2IgUGV0c292aXRzLgorCisgICAgICAgIEFuZCByZW1vdmUgdGhlIEJsYWNrQmVycnkg c3BlY2lmaWMgbWV0aG9kcworICAgICAgICBmcmFtZVZpZXdGcmFtZVJlY3REaWRDaGFuZ2UgYW5k IGZyYW1lVmlld0NvbnRlbnRzU2l6ZURpZENoYW5nZS4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xs aW5nL2JsYWNrYmVycnkvU2Nyb2xsaW5nQ29vcmRpbmF0b3JCbGFja0JlcnJ5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yQmxhY2tCZXJyeTo6ZnJhbWVWaWV3TGF5 b3V0VXBkYXRlZCk6CisgICAgICAgIENhbGxlZCB3aGVuIHRoZSBmcmFtZSB2aWV3IGhhcyBiZWVu IGxhaWQgb3V0LiBVcGRhdGUgdGhlIGNvbnRlbnRzCisgICAgICAgIHJlY3RhbmdsZSBhbmQgdmlz aWJsZSBhcmVhIG9mIHRoZSBzY3JvbGwgbGF5ZXIgZm9yIHRoZSBnaXZlbiBmcmFtZQorICAgICAg ICB2aWV3LgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL2JsYWNrYmVycnkvU2Nyb2xsaW5nQ29v cmRpbmF0b3JCbGFja0JlcnJ5Lmg6CisgICAgICAgIChTY3JvbGxpbmdDb29yZGluYXRvckJsYWNr QmVycnkpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJXZWJL aXRUaHJlYWQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyV2ViS2l0VGhyZWFkOjpzZXRGcmFt ZVZpc2libGVSZWN0KTogUmV0dXJuIGVhcmx5IGlmCisgICAgICAgIHZhbHVlIGhhc24ndCBjaGFu Z2VkLgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJXZWJLaXRUaHJlYWQ6OnNldEZyYW1lQ29udGVu dHNTaXplKTogRGl0dG8uCisKIDIwMTMtMDQtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtYMTFdW0JsYWNrQmVycnldIENoZWNrIGlmIE1P Wl9YMTEgaXMgZGVmaW5lZCBpbnN0ZWFkIG9mIFhQX1VOSVggbnBydW50aW1lX2ludGVybmFsLmgK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL2JsYWNrYmVycnkvU2Ny b2xsaW5nQ29vcmRpbmF0b3JCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL2JsYWNrYmVycnkvU2Nyb2xsaW5nQ29vcmRpbmF0b3JCbGFja0JlcnJ5LmNwcAppbmRl eCBlZGM1NzgzLi4zOWQ5MDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9ibGFja2JlcnJ5L1Njcm9sbGluZ0Nvb3JkaW5hdG9yQmxhY2tCZXJyeS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvYmxhY2tiZXJyeS9TY3JvbGxpbmdDb29yZGlu YXRvckJsYWNrQmVycnkuY3BwCkBAIC02NywxNiArNjcsMTIgQEAgdm9pZCBTY3JvbGxpbmdDb29y ZGluYXRvckJsYWNrQmVycnk6OnNldExheWVyRml4ZWRUb0NvbnRhaW5lckxheWVyRWRnZShHcmFw aGljc0wKICAgICBsYXllci0+cGxhdGZvcm1MYXllcigpLT5zZXRGaXhlZFRvTGVmdChmaXhlZFRv TGVmdCk7CiB9CiAKLXZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3JCbGFja0JlcnJ5OjpmcmFtZVZp ZXdGcmFtZVJlY3REaWRDaGFuZ2UoRnJhbWVWaWV3KiB2aWV3KQordm9pZCBTY3JvbGxpbmdDb29y ZGluYXRvckJsYWNrQmVycnk6OmZyYW1lVmlld0xheW91dFVwZGF0ZWQoRnJhbWVWaWV3KiBmcmFt ZVZpZXcpCiB7Ci0gICAgaWYgKEdyYXBoaWNzTGF5ZXIqIHNjcm9sbExheWVyID0gc2Nyb2xsTGF5 ZXJGb3JGcmFtZVZpZXcodmlldykpCi0gICAgICAgIHNjcm9sbExheWVyLT5wbGF0Zm9ybUxheWVy KCktPnNldEZyYW1lVmlzaWJsZVJlY3Qodmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KCkpOwotfQot Ci12b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yQmxhY2tCZXJyeTo6ZnJhbWVWaWV3Q29udGVudHNT aXplRGlkQ2hhbmdlKEZyYW1lVmlldyogdmlldykKLXsKLSAgICBpZiAoR3JhcGhpY3NMYXllciog c2Nyb2xsTGF5ZXIgPSBzY3JvbGxMYXllckZvckZyYW1lVmlldyh2aWV3KSkKLSAgICAgICAgc2Ny b2xsTGF5ZXItPnBsYXRmb3JtTGF5ZXIoKS0+c2V0RnJhbWVDb250ZW50c1NpemUodmlldy0+Y29u dGVudHNTaXplKCkpOworICAgIGlmIChHcmFwaGljc0xheWVyKiBzY3JvbGxMYXllciA9IHNjcm9s bExheWVyRm9yRnJhbWVWaWV3KGZyYW1lVmlldykpIHsKKyAgICAgICAgc2Nyb2xsTGF5ZXItPnBs YXRmb3JtTGF5ZXIoKS0+c2V0RnJhbWVDb250ZW50c1NpemUoZnJhbWVWaWV3LT5jb250ZW50c1Np emUoKSk7CisgICAgICAgIHNjcm9sbExheWVyLT5wbGF0Zm9ybUxheWVyKCktPnNldEZyYW1lVmlz aWJsZVJlY3QoZnJhbWVWaWV3LT52aXNpYmxlQ29udGVudFJlY3QoKSk7CisgICAgfQogfQogCiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9ibGFja2JlcnJ5L1Nj cm9sbGluZ0Nvb3JkaW5hdG9yQmxhY2tCZXJyeS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvYmxhY2tiZXJyeS9TY3JvbGxpbmdDb29yZGluYXRvckJsYWNrQmVycnkuaAppbmRleCA3 Yzg0OWEwLi4xZTZmY2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9ibGFja2JlcnJ5L1Njcm9sbGluZ0Nvb3JkaW5hdG9yQmxhY2tCZXJyeS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL2JsYWNrYmVycnkvU2Nyb2xsaW5nQ29vcmRpbmF0b3JC bGFja0JlcnJ5LmgKQEAgLTM0LDYgKzM0LDkgQEAgY2xhc3MgU2Nyb2xsaW5nQ29vcmRpbmF0b3JC bGFja0JlcnJ5IDogcHVibGljIFNjcm9sbGluZ0Nvb3JkaW5hdG9yIHsKIHB1YmxpYzoKICAgICBl eHBsaWNpdCBTY3JvbGxpbmdDb29yZGluYXRvckJsYWNrQmVycnkoUGFnZSopOwogCisgICAgLy8g U2hvdWxkIGJlIGNhbGxlZCB3aGVuZXZlciB0aGUgZ2l2ZW4gZnJhbWUgdmlldyBoYXMgYmVlbiBs YWlkIG91dC4KKyAgICB2aXJ0dWFsIHZvaWQgZnJhbWVWaWV3TGF5b3V0VXBkYXRlZChGcmFtZVZp ZXcqKTsKKwogICAgIC8vIFJldHVybiB3aGV0aGVyIHRoaXMgc2Nyb2xsaW5nIGNvb3JkaW5hdG9y IGNhbiBrZWVwIGZpeGVkIHBvc2l0aW9uIGxheWVycyBmaXhlZCB0byB0aGVpcgogICAgIC8vIGNv bnRhaW5lcnMgd2hpbGUgc2Nyb2xsaW5nLgogICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0ZpeGVk UG9zaXRpb25MYXllcnMoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CkBAIC00Niw5ICs0OSw2IEBA IHB1YmxpYzoKIAogICAgIC8vIFdoZXRoZXIgdGhlIGxheWVyIGlzIGZpeGVkIHRoZSB0b3Agb3Ig Ym90dG9tIGVkZ2UsIGxlZnQgb3IgcmlnaHQgZWRnZS4KICAgICB2b2lkIHNldExheWVyRml4ZWRU b0NvbnRhaW5lckxheWVyRWRnZShHcmFwaGljc0xheWVyKiwgYm9vbCBmaXhlZFRvVG9wLCBib29s IGZpeGVkVG9MZWZ0KTsKLQotICAgIHZpcnR1YWwgdm9pZCBmcmFtZVZpZXdGcmFtZVJlY3REaWRD aGFuZ2UoRnJhbWVWaWV3Kik7Ci0gICAgdmlydHVhbCB2b2lkIGZyYW1lVmlld0NvbnRlbnRzU2l6 ZURpZENoYW5nZShGcmFtZVZpZXcqKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5 ZXJXZWJLaXRUaHJlYWQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuaAppbmRleCAzZmM1Y2U1Li4wMWFmOWY1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyV2Vi S2l0VGhyZWFkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9MYXllcldlYktpdFRocmVhZC5oCkBAIC0xNjAsOCArMTYwLDIxIEBAIHB1YmxpYzoKICAg ICAgICAgc2V0TmVlZHNDb21taXQoKTsKICAgICB9CiAKLSAgICB2b2lkIHNldEZyYW1lVmlzaWJs ZVJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkgeyBtX2ZyYW1lVmlzaWJsZVJlY3QgPSByZWN0OyBz ZXROZWVkc0NvbW1pdCgpOyB9Ci0gICAgdm9pZCBzZXRGcmFtZUNvbnRlbnRzU2l6ZShjb25zdCBJ bnRTaXplJiBzaXplKSB7IG1fZnJhbWVDb250ZW50c1NpemUgPSBzaXplOyBzZXROZWVkc0NvbW1p dCgpOyB9CisgICAgdm9pZCBzZXRGcmFtZVZpc2libGVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3Qp CisgICAgeworICAgICAgICBpZiAobV9mcmFtZVZpc2libGVSZWN0ID09IHJlY3QpCisgICAgICAg ICAgICByZXR1cm47CisgICAgICAgIG1fZnJhbWVWaXNpYmxlUmVjdCA9IHJlY3Q7CisgICAgICAg IHNldE5lZWRzQ29tbWl0KCk7CisgICAgfQorCisgICAgdm9pZCBzZXRGcmFtZUNvbnRlbnRzU2l6 ZShjb25zdCBJbnRTaXplJiBzaXplKQorICAgIHsKKyAgICAgICAgaWYgKG1fZnJhbWVDb250ZW50 c1NpemUgPT0gc2l6ZSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgbV9mcmFtZUNvbnRl bnRzU2l6ZSA9IHNpemU7CisgICAgICAgIHNldE5lZWRzQ29tbWl0KCk7CisgICAgfQogCiAgICAg dm9pZCBzZXRDb250ZW50cyhJbWFnZSopOwogICAgIEltYWdlKiBjb250ZW50cygpIGNvbnN0IHsg cmV0dXJuIG1fY29udGVudHMuZ2V0KCk7IH0K