113762 2013-04-02 02:18:26 -0700 [GStreamer] Memory leaks in MediaPlayerPrivateGStreamer 2013-04-02 13:02:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis eric.carlson feature-media-reviews gustavo jer.noble menard mrobinson pnormand webkit.review.bot oldest_to_newest 867680 0 naginenis 2013-04-02 02:18:26 -0700 strings returned by gst_element_get_name() and gst_missing_plugin_message_get_installer_detail() must be freed to avoid memory leaks. 1) ==21665== 99 bytes in 3 blocks are definitely lost in loss record 24,564 of 34,507 ==21665== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21665== by 0xD3E18D8: g_malloc (gmem.c:159) ==21665== by 0xD3F76FD: g_strdup (gstrfuncs.c:364) ==21665== by 0xB6693CC: gst_object_get_name (gstobject.c:657) ==21665== by 0x6F08280: WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties(_GObject*) (MediaPlayerPrivateGStreamer.cpp:151) ==21665== by 0x6F080B8: WebCore::setAudioStreamPropertiesCallback(_GstChildProxy*, _GObject*, char*, WebCore::MediaPlayerPrivateGStreamer*) (MediaPlayerPrivateGStreamer.cpp:125) ==21665== by 0x127ABF97: ffi_call_unix64 (in /home/sudarsana/Webkit/gtk/WebKit/WebKitBuild/Dependencies/Root/lib64/libffi.so.5.0.10) ==21665== by 0x127AB93C: ffi_call (ffi64.c:486) 2) ==21665== ==21665== 384 bytes in 2 blocks are definitely lost in loss record 30,965 of 34,507 ==21665== at 0x4C2B7B2: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21665== by 0xD3E1996: g_realloc (gmem.c:224) ==21665== by 0xD3F9A26: g_string_maybe_expand (gstring.c:107) ==21665== by 0xD3FAE66: g_string_append_vprintf (gstring.c:1168) ==21665== by 0xD3FB066: g_string_append_printf (gstring.c:1268) ==21665== by 0x414F0DF: gst_missing_plugin_message_get_installer_detail (missing-plugins.c:467) ==21665== by 0x6F0B8DF: WebCore::MediaPlayerPrivateGStreamer::handleMessage(_GstMessage*) (MediaPlayerPrivateGStreamer.cpp:780) ==21665== by 0x6F07FEC: WebCore::mediaPlayerPrivateMessageCallback(_GstBus*, _GstMessage*, WebCore::MediaPlayerPrivateGStreamer*) (MediaPlayerPrivateGStreamer.cpp:88) 867936 1 196162 naginenis 2013-04-02 09:30:09 -0700 Created attachment 196162 Patch 867953 2 196162 pnormand 2013-04-02 09:44:12 -0700 Comment on attachment 196162 Patch Thanks! 867956 3 pnormand 2013-04-02 09:45:31 -0700 BTW I know these leaks are programming errors but perhaps it would be interesting to have a debug EWS bot running valgrind on patches pending-review. What do you think about that? 868176 4 naginenis 2013-04-02 12:49:42 -0700 (In reply to comment #3) > BTW I know these leaks are programming errors but perhaps it would be interesting to have a debug EWS bot running valgrind on patches pending-review. What do you think about that? This is exactly what I have been thinking. I'm going to spend some time trying to setup the leak bot. 868192 5 196162 webkit.review.bot 2013-04-02 13:02:24 -0700 Comment on attachment 196162 Patch Clearing flags on attachment: 196162 Committed r147490: <http://trac.webkit.org/changeset/147490> 868193 6 webkit.review.bot 2013-04-02 13:02:28 -0700 All reviewed patches have been landed. Closing bug. 196162 2013-04-02 09:30:09 -0700 2013-04-02 13:02:24 -0700 Patch 113762.patch text/plain 3347 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZGNjZTViLi5lZTE3NWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDQtMDIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gTWVtb3J5IGxlYWtzIGluIE1lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEzNzYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRG9uJ3QgbGVhayBzdHJpbmdzIHJldHVybmVkIGJ5IGdzdF9lbGVtZW50X2dl dF9uYW1lKCkgYW5kCisgICAgICAgIGdzdF9taXNzaW5nX3BsdWdpbl9tZXNzYWdlX2dldF9pbnN0 YWxsZXJfZGV0YWlsKCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6c2V0QXVkaW9TdHJlYW1Qcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZSk6CisKIDIwMTMt MDQtMDIgIERhdmlkIFZlc3QgIDxkYXZ2ZUBvcGVyYS5jb20+CiAKICAgICAgICAgSGFuZyB3aGVu IGNhbGxpbmcgc2V0Q3VycmVudFRpbWUgb24gU1ZHIHdpdGggY3ljbGljIGFuaW1hdGlvbiBkZXBl bmRlbmN5IGNoYWluCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwCmluZGV4IDhjODgzZjYuLjJlYTU2YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0xNDgsNyArMTQ4LDggQEAgdm9pZCBNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnNldEF1ZGlvU3RyZWFtUHJvcGVydGllcyhHT2JqZWN0 KiBvYmplY3QpCiAgICAgR3N0U3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSBnc3Rfc3RydWN0dXJlX25l dygic3RyZWFtLXByb3BlcnRpZXMiLCAibWVkaWEucm9sZSIsIEdfVFlQRV9TVFJJTkcsIHJvbGUs IE5VTEwpOwogICAgIGdfb2JqZWN0X3NldChvYmplY3QsICJzdHJlYW0tcHJvcGVydGllcyIsIHN0 cnVjdHVyZSwgTlVMTCk7CiAgICAgZ3N0X3N0cnVjdHVyZV9mcmVlKHN0cnVjdHVyZSk7Ci0gICAg TE9HX01FRElBX01FU1NBR0UoIlNldCBtZWRpYS5yb2xlIGFzICVzIGF0ICVzIiwgcm9sZSwgZ3N0 X2VsZW1lbnRfZ2V0X25hbWUoR1NUX0VMRU1FTlQob2JqZWN0KSkpOworICAgIEdPd25QdHI8Z2No YXI+IGVsZW1lbnROYW1lKGdzdF9lbGVtZW50X2dldF9uYW1lKEdTVF9FTEVNRU5UKG9iamVjdCkp KTsKKyAgICBMT0dfTUVESUFfTUVTU0FHRSgiU2V0IG1lZGlhLnJvbGUgYXMgJXMgYXQgJXMiLCBy b2xlLCBlbGVtZW50TmFtZS5nZXQoKSk7CiB9CiAKIFBhc3NPd25QdHI8TWVkaWFQbGF5ZXJQcml2 YXRlSW50ZXJmYWNlPiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNyZWF0ZShNZWRpYVBs YXllciogcGxheWVyKQpAQCAtNzY5LDcgKzc3MCw4IEBAIGdib29sZWFuIE1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQogICAgICAg ICBnc3RfbWVzc2FnZV9wYXJzZV9yZXF1ZXN0X3N0YXRlKG1lc3NhZ2UsICZyZXF1ZXN0ZWRTdGF0 ZSk7CiAgICAgICAgIGdzdF9lbGVtZW50X2dldF9zdGF0ZShtX3BsYXlCaW4uZ2V0KCksICZjdXJy ZW50U3RhdGUsIE5VTEwsIDI1MCk7CiAgICAgICAgIGlmIChyZXF1ZXN0ZWRTdGF0ZSA8IGN1cnJl bnRTdGF0ZSkgewotICAgICAgICAgICAgTE9HX01FRElBX01FU1NBR0UoIkVsZW1lbnQgJXMgcmVx dWVzdGVkIHN0YXRlIGNoYW5nZSB0byAlcyIsIGdzdF9lbGVtZW50X2dldF9uYW1lKEdTVF9NRVNT QUdFX1NSQyhtZXNzYWdlKSksCisgICAgICAgICAgICBHT3duUHRyPGdjaGFyPiBlbGVtZW50TmFt ZShnc3RfZWxlbWVudF9nZXRfbmFtZShHU1RfRUxFTUVOVChtZXNzYWdlKSkpOworICAgICAgICAg ICAgTE9HX01FRElBX01FU1NBR0UoIkVsZW1lbnQgJXMgcmVxdWVzdGVkIHN0YXRlIGNoYW5nZSB0 byAlcyIsIGVsZW1lbnROYW1lLmdldCgpLAogICAgICAgICAgICAgICAgIGdzdF9lbGVtZW50X3N0 YXRlX2dldF9uYW1lKHJlcXVlc3RlZFN0YXRlKSk7CiAgICAgICAgICAgICBtX3JlcXVlc3RlZFN0 YXRlID0gcmVxdWVzdGVkU3RhdGU7CiAgICAgICAgICAgICBjaGFuZ2VQaXBlbGluZVN0YXRlKHJl cXVlc3RlZFN0YXRlKTsKQEAgLTc3Nyw5ICs3NzksMTAgQEAgZ2Jvb2xlYW4gTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAgICAg ICAgIGJyZWFrOwogICAgIGNhc2UgR1NUX01FU1NBR0VfRUxFTUVOVDoKICAgICAgICAgaWYgKGdz dF9pc19taXNzaW5nX3BsdWdpbl9tZXNzYWdlKG1lc3NhZ2UpKSB7Ci0gICAgICAgICAgICBjaGFy KiBkZXRhaWwgPSBnc3RfbWlzc2luZ19wbHVnaW5fbWVzc2FnZV9nZXRfaW5zdGFsbGVyX2RldGFp bChtZXNzYWdlKTsKKyAgICAgICAgICAgIGdjaGFyKiBkZXRhaWwgPSBnc3RfbWlzc2luZ19wbHVn aW5fbWVzc2FnZV9nZXRfaW5zdGFsbGVyX2RldGFpbChtZXNzYWdlKTsKICAgICAgICAgICAgIEdz dEluc3RhbGxQbHVnaW5zUmV0dXJuIHJlc3VsdCA9IGdzdF9pbnN0YWxsX3BsdWdpbnNfYXN5bmMo JmRldGFpbCwgMCwgbWVkaWFQbGF5ZXJQcml2YXRlUGx1Z2luSW5zdGFsbGVyUmVzdWx0RnVuY3Rp b24sIHRoaXMpOwogICAgICAgICAgICAgbV9taXNzaW5nUGx1Z2lucyA9IHJlc3VsdCA9PSBHU1Rf SU5TVEFMTF9QTFVHSU5TX1NUQVJURURfT0s7CisgICAgICAgICAgICBnX2ZyZWUoZGV0YWlsKTsK ICAgICAgICAgfQogICAgICAgICBicmVhazsKICAgICBkZWZhdWx0Ogo=