113738 2013-04-01 18:24:43 -0700 Hide non-coordinated scrollbars for Android M26 2013-04-02 08:23:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 trchen webkit-unassigned aelias eric esprehn+autocc jamesr ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 867468 0 trchen 2013-04-01 18:24:43 -0700 Hide non-coordinated scrollbars for Android M26 867469 1 196050 trchen 2013-04-01 18:27:32 -0700 Created attachment 196050 Patch 867473 2 196050 simon.fraser 2013-04-01 18:35:48 -0700 Comment on attachment 196050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > Source/WebCore/platform/ScrollView.cpp:919 > +#if OS(ANDROID) This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. 867474 3 trchen 2013-04-01 18:44:33 -0700 (In reply to comment #2) > (From update of attachment 196050 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > > > Source/WebCore/platform/ScrollView.cpp:919 > > +#if OS(ANDROID) > > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that. 867510 4 simon.fraser 2013-04-01 20:34:29 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 196050 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > > > > > Source/WebCore/platform/ScrollView.cpp:919 > > > +#if OS(ANDROID) > > > > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. > > It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that. That seems a bit crazy, but OK. 867511 5 196050 simon.fraser 2013-04-01 20:34:49 -0700 Comment on attachment 196050 Patch r+ assuming it's immediately reverted. 867514 6 196050 aelias 2013-04-01 20:41:27 -0700 Comment on attachment 196050 Patch Thanks for humoring our strange tools :) 867580 7 196050 webkit.review.bot 2013-04-01 23:14:45 -0700 Comment on attachment 196050 Patch Clearing flags on attachment: 196050 Committed r147389: <http://trac.webkit.org/changeset/147389> 867581 8 webkit.review.bot 2013-04-01 23:14:48 -0700 All reviewed patches have been landed. Closing bug. 867863 9 aelias 2013-04-02 08:23:31 -0700 Reverted r147389 for reason: Patch specified it should be reverted Committed r147436: <http://trac.webkit.org/changeset/147436> 196050 2013-04-01 18:27:32 -0700 2013-04-01 23:14:45 -0700 Patch bug-113738-20130401182724.patch text/plain 2948 trchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRmMGViMDg3MmYxNjBl Mjk0YjVhMDgxY2FmODZiM2Y0NjkwMzFmYi4uMGEzNmVkMGE2MWI3NzYxYzdhZGQ5ZDc3NjA1NTNj NmY1YjAwZDRjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA0LTAxICBUaWVu LVJlbiBDaGVuICA8dHJjaGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBIaWRlIG5vbi1jb29y ZGluYXRlZCBzY3JvbGxiYXJzIGZvciBBbmRyb2lkIE0yNgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCB3aWxsIGhpZGUgYW55IG5vbi1j b29yZGluYXRlZCBzY3JvbGxiYXJzIG9uIEFuZHJvaWQuCisgICAgICAgIENvb3JkaW5hdGVkIHNj cm9sbGJhcnMgd29uJ3QgYmUgYWZmZWN0ZWQuCisKKyAgICAgICAgQ3VycmVudGx5IGFsbCBzY3Jv bGxiYXJzIGFyZSBjb29yZGluYXRlZCBvbiBBbmRyb2lkLiBUaGUgc29sZSBwdXJwb3NlCisgICAg ICAgIG9mIHRoaXMgcGF0Y2ggaXMgdG8gYmUgY2hlcnJ5LXBpY2tlZCB0byB0aGUgTTI2IGJyYW5j aC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFBsZWFzZSByZXZlcnQgaW1tZWRpYXRlbHkgYWZ0 ZXIgbGFuZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpwb3NpdGlvblNjcm9sbGJhckxheWVyKToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFj a2luZzo6cG9zaXRpb25PdmVyZmxvd0NvbnRyb2xzTGF5ZXJzKToKKwogMjAxMy0wNC0wMSAgS29q aSBJc2hpaSAgPGtvamlpc2hpQGdtYWlsLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVE OiBtX3B1cmdlUHJldmVudENvdW50IHdoZW4gY2xpY2tpbmcgdGV4dCB3aXRoIGVtcGhhc2lzIG1h cmtzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDBiYTA2ZDE2NGNi ZGRhNWJkZWQzMDFkNDM0ODU4OWIxMzAxZmFiMjkuLjAxY2YzYmQ3MDVkNDZlYjQwY2JlMjExNDJk ZGY4MTMyYWQwYjBmOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBA IC05MTYsNyArOTE2LDExIEBAIHN0YXRpYyB2b2lkIHBvc2l0aW9uU2Nyb2xsYmFyTGF5ZXIoR3Jh cGhpY3NMYXllciogZ3JhcGhpY3NMYXllciwgU2Nyb2xsYmFyKiBzY3JvCiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKKyNpZiBPUyhBTkRST0lEKQorICAgIGdyYXBoaWNzTGF5ZXItPnNldERyYXdz Q29udGVudChmYWxzZSk7CisjZWxzZQogICAgIGdyYXBoaWNzTGF5ZXItPnNldERyYXdzQ29udGVu dCh0cnVlKTsKKyNlbmRpZgogICAgIGdyYXBoaWNzTGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNr aW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw CmluZGV4IGJlYmFkMjVmMmFjZDg4YWNhZGM0ODY4MWYzNjBmNzgyMTA0NzllYmYuLjI1N2M2MWMw YWI3MDE2Mzg5ZmEwOTg2MTVlMGNhN2YwNTI0YWJkYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0xMDg5LDcgKzEwODksMTEgQEAg dm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnBvc2l0aW9uT3ZlcmZsb3dDb250cm9sc0xheWVycyhj b25zdCBJbnRTaXplJiBvZmZzZXRGcm8KICAgICAgICAgICAgIGlmIChsYXllci0+aGFzQ29udGVu dHNMYXllcigpKQogICAgICAgICAgICAgICAgIGxheWVyLT5zZXRDb250ZW50c1JlY3QoSW50UmVj dChJbnRQb2ludCgpLCBoQmFyLT5mcmFtZVJlY3QoKS5zaXplKCkpKTsKICAgICAgICAgfQorI2lm IE9TKEFORFJPSUQpCisgICAgICAgIGxheWVyLT5zZXREcmF3c0NvbnRlbnQoZmFsc2UpOworI2Vs c2UKICAgICAgICAgbGF5ZXItPnNldERyYXdzQ29udGVudChoQmFyICYmICFsYXllci0+aGFzQ29u dGVudHNMYXllcigpKTsKKyNlbmRpZgogICAgIH0KICAgICAKICAgICBpZiAoR3JhcGhpY3NMYXll ciogbGF5ZXIgPSBsYXllckZvclZlcnRpY2FsU2Nyb2xsYmFyKCkpIHsKQEAgLTExMDAsNyArMTEw NCwxMSBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6cG9zaXRpb25PdmVyZmxvd0NvbnRyb2xz TGF5ZXJzKGNvbnN0IEludFNpemUmIG9mZnNldEZybwogICAgICAgICAgICAgaWYgKGxheWVyLT5o YXNDb250ZW50c0xheWVyKCkpCiAgICAgICAgICAgICAgICAgbGF5ZXItPnNldENvbnRlbnRzUmVj dChJbnRSZWN0KEludFBvaW50KCksIHZCYXItPmZyYW1lUmVjdCgpLnNpemUoKSkpOwogICAgICAg ICB9CisjaWYgT1MoQU5EUk9JRCkKKyAgICAgICAgbGF5ZXItPnNldERyYXdzQ29udGVudChmYWxz ZSk7CisjZWxzZQogICAgICAgICBsYXllci0+c2V0RHJhd3NDb250ZW50KHZCYXIgJiYgIWxheWVy LT5oYXNDb250ZW50c0xheWVyKCkpOworI2VuZGlmCiAgICAgfQogCiAgICAgaWYgKEdyYXBoaWNz TGF5ZXIqIGxheWVyID0gbGF5ZXJGb3JTY3JvbGxDb3JuZXIoKSkgewo=