113737 2013-04-01 18:15:04 -0700 Make feature_defines.sh work for VS2010 2013-04-01 22:41:16 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham roger_fong thorton oldest_to_newest 867462 0 roger_fong 2013-04-01 18:15:04 -0700 VS2010 build uses a new FeatureDefines.props file with a different format from the original FeatureDefines.vsprops. The feature defines string outputted by feature-defines.sh needs to be corrected for this. Also creating a feature_defines2010.sh because we still need both feature_defines scripts for now. 867463 1 roger_fong 2013-04-01 18:15:22 -0700 <rdar://problem/13343147> 867466 2 196048 roger_fong 2013-04-01 18:23:22 -0700 Created attachment 196048 patch 867478 3 196052 roger_fong 2013-04-01 19:09:33 -0700 Created attachment 196052 patch 867480 4 196052 thorton 2013-04-01 19:11:04 -0700 Comment on attachment 196052 patch View in context: https://bugs.webkit.org/attachment.cgi?id=196052&action=review > WebKitLibraries/win/tools/scripts/feature-defines2010.sh:3 > +# Copyright (C) 2010 Apple Inc. All rights reserved. 2013 867556 5 roger_fong 2013-04-01 22:41:16 -0700 committed: http://trac.webkit.org/changeset/147375 196048 2013-04-01 18:23:22 -0700 2013-04-01 19:09:33 -0700 patch patch.patch text/plain 2536 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzM3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTAxICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVlMyMDEwIFdlYkNvcmVHZW5l cmF0ZWQgYnVpbGQgc2NyaXB0cyBzaG91bGQgdXNlIG5ldyBmZWF0dXJlLWRlZmluZXMgc2NyaXB0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzM3 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi Q29yZS52Y3hwcm9qL2J1aWxkLWdlbmVyYXRlZC1maWxlcy5zaDoKKwogMjAxMy0wNC0wMSAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBBdXRvc2l6ZSBz aG91bGQgdXNlIGRvY3VtZW50UmVjdCBoZWlnaHQgaW5zdGVhZCBvZiBzY3JvbGxIZWlnaHQKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9idWlsZC1nZW5lcmF0ZWQtZmlsZXMu c2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL2J1aWxkLWdl bmVyYXRlZC1maWxlcy5zaAkocmV2aXNpb24gMTQ3MzU4KQorKysgU291cmNlL1dlYkNvcmUvV2Vi Q29yZS52Y3hwcm9qL2J1aWxkLWdlbmVyYXRlZC1maWxlcy5zaAkod29ya2luZyBjb3B5KQpAQCAt NTksNSArNTksNSBAQAogY2QgIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcyIK IAogZXhwb3J0IFdlYkNvcmU9IiR7WFNSQ1JPT1R9IgotZXhwb3J0IEZFQVRVUkVfREVGSU5FUz1g JFNES1JPT1QvdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMuc2ggJFNES1JPT1QgJDNgCitl eHBvcnQgRkVBVFVSRV9ERUZJTkVTPWAkU0RLUk9PVC90b29scy9zY3JpcHRzL2ZlYXR1cmUtZGVm aW5lczIwMTAuc2ggJFNES1JPT1QgJDNgCiBtYWtlIC1mICIkV2ViQ29yZS9EZXJpdmVkU291cmNl cy5tYWtlIiAtaiAke05VTUNQVVN9IHx8IGV4aXQgMQpJbmRleDogV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCShyZXZpc2lv biAxNDczNzMpCisrKyBXZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTMtMDQtMDEgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxl LmNvbT4KKworICAgICAgICBVcGRhdGUgRkVBVFVSRV9ERUZJTkVTIHN0cmluZyBnZW5lcmF0aW9u IGZvciBWUzIwMTAgc29sdXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTM3MzcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMuc2g6CisK IDIwMTMtMDMtMjkgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLiBSb2xsb3V0IHIxNDY4MTguCkluZGV4OiBXZWJLaXRMaWJyYXJpZXMvd2lu L3Rvb2xzL3NjcmlwdHMvZmVhdHVyZS1kZWZpbmVzLnNoCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExp YnJhcmllcy93aW4vdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMuc2gJKHJldmlzaW9uIDE0 NzM1OCkKKysrIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmlu ZXMuc2gJKHdvcmtpbmcgY29weSkKQEAgLTIzLDkgKzIzLDkgQEAKICMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIGlmIFsgIiQy IiA9ICJjYWlybyIgXTsgdGhlbgotICAgIEZlYXR1cmVEZWZpbmVzPSQxL3Rvb2xzL3ZzcHJvcHMv RmVhdHVyZURlZmluZXNDYWlyby52c3Byb3BzCisgICAgRmVhdHVyZURlZmluZXM9JDEvdG9vbHMv dnNwcm9wcy9GZWF0dXJlRGVmaW5lc0NhaXJvLnByb3BzCiBlbHNlCi0gICAgRmVhdHVyZURlZmlu ZXM9JDEvdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy52c3Byb3BzCisgICAgRmVhdHVyZURl ZmluZXM9JDEvdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy5wcm9wcwogZmkKIAogZ3JlcCBW YWx1ZT1cIkVOQUJMRV8gJEZlYXR1cmVEZWZpbmVzIHwgc2VkICdzL14uKlZhbHVlXD1cIi8gLycg fCBzZWQgJ3MvXCIvLycgfCB0ciAtZCAnXG4nCg== 196052 2013-04-01 19:09:33 -0700 2013-04-01 19:11:04 -0700 patch patch.patch text/plain 3741 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzM3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTAxICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVlMyMDEwIFdlYkNvcmVHZW5l cmF0ZWQgYnVpbGQgc2NyaXB0cyBzaG91bGQgdXNlIG5ldyBmZWF0dXJlLWRlZmluZXMgc2NyaXB0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNzM3 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi Q29yZS52Y3hwcm9qL2J1aWxkLWdlbmVyYXRlZC1maWxlcy5zaDoKKwogMjAxMy0wNC0wMSAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBBdXRvc2l6ZSBz aG91bGQgdXNlIGRvY3VtZW50UmVjdCBoZWlnaHQgaW5zdGVhZCBvZiBzY3JvbGxIZWlnaHQKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9idWlsZC1nZW5lcmF0ZWQtZmlsZXMu c2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL2J1aWxkLWdl bmVyYXRlZC1maWxlcy5zaAkocmV2aXNpb24gMTQ3MzU4KQorKysgU291cmNlL1dlYkNvcmUvV2Vi Q29yZS52Y3hwcm9qL2J1aWxkLWdlbmVyYXRlZC1maWxlcy5zaAkod29ya2luZyBjb3B5KQpAQCAt NTksNSArNTksNSBAQAogY2QgIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcyIK IAogZXhwb3J0IFdlYkNvcmU9IiR7WFNSQ1JPT1R9IgotZXhwb3J0IEZFQVRVUkVfREVGSU5FUz1g JFNES1JPT1QvdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMuc2ggJFNES1JPT1QgJDNgCitl eHBvcnQgRkVBVFVSRV9ERUZJTkVTPWAkU0RLUk9PVC90b29scy9zY3JpcHRzL2ZlYXR1cmUtZGVm aW5lczIwMTAuc2ggJFNES1JPT1QgJDNgCiBtYWtlIC1mICIkV2ViQ29yZS9EZXJpdmVkU291cmNl cy5tYWtlIiAtaiAke05VTUNQVVN9IHx8IGV4aXQgMQpJbmRleDogV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCShyZXZpc2lv biAxNDczNzMpCisrKyBXZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTMtMDQtMDEgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxl LmNvbT4KKworICAgICAgICBVcGRhdGUgRkVBVFVSRV9ERUZJTkVTIHN0cmluZyBnZW5lcmF0aW9u IGZvciBWUzIwMTAgc29sdXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTM3MzcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMyMDEwLnNo OiBBZGRlZC4KKwogMjAxMy0wMy0yOSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJvbGxvdXQgcjE0NjgxOC4KSW5kZXg6IFdlYktpdExp YnJhcmllcy93aW4vdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMyMDEwLnNoCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvc2NyaXB0cy9mZWF0dXJlLWRlZmluZXMy MDEwLnNoCShyZXZpc2lvbiAwKQorKysgV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy9zY3JpcHRz L2ZlYXR1cmUtZGVmaW5lczIwMTAuc2gJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzMiBAQAor IyEvdXNyL2Jpbi9iYXNoCisKKyMgQ29weXJpZ2h0IChDKSAyMDEwIEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1p dHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworIyBhcmUgbWV0Ogor IyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92 ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkg Zm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRo aXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhl CisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0 aCB0aGUgZGlzdHJpYnV0aW9uLgorIyAKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBB UFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJyBBTkQgQU5ZCisjIEVYUFJF U1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywg VEhFIElNUExJRUQKKyMgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1Mg Rk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorIyBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBT SEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyMg RElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05T RVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9D VVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworIyBMT1NTIE9GIFVTRSwg REFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNF RCBBTkQgT04KKyMgQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1Qs IFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9U SEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMKKyMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CisKK2lmIFsgIiQyIiA9ICJjYWlybyIgXTsgdGhlbgorICAgIEZlYXR1cmVEZWZpbmVzPSQxL3Rv b2xzL3ZzcHJvcHMvRmVhdHVyZURlZmluZXNDYWlyby5wcm9wcworZWxzZQorICAgIEZlYXR1cmVE ZWZpbmVzPSQxL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURlZmluZXMucHJvcHMKK2ZpCisKK2dyZXAg IjxFTkFCTEVfIiAkRmVhdHVyZURlZmluZXMgfCBzZWQgJy9cLz4vZCcgfCBzZWQgJ3MvPFwvLio+ Ly8nIHwgc2VkICdzLzwuKj4vLycgfCB0ciAtZCAnXG4nCisK