113721 2013-04-01 14:00:26 -0700 [WK2] NetworkProcess still needs to implement a sync version of shouldUseCredentialStorage 2013-04-01 14:10:53 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 867338 0 ap 2013-04-01 14:00:26 -0700 ResourceHandleMac uses shouldUseCredentialStorage internally. It's not a real problem for NetworkProcess, as it doesn't have to do IPC to reply, although it of course breaks the model somewhat. 867343 1 196020 ap 2013-04-01 14:03:44 -0700 Created attachment 196020 proposed fix 867346 2 webkit.review.bot 2013-04-01 14:06:27 -0700 Attachment 196020 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 867347 3 ap 2013-04-01 14:10:53 -0700 Committed <http://trac.webkit.org/changeset/147359>. 196020 2013-04-01 14:03:44 -0700 2013-04-01 14:05:34 -0700 proposed fix SessionAuth.txt text/plain 5176 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzM1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTAxICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM3MjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEz NTQ5MTgxPiBSRUdSRVNTSU9OIChyMTQ2OTI5KTogSFRUUCBhdXRoIGNyZWRlbnRpYWxzIG5vdCBy ZXVzZWQgZHVyaW5nIHNlc3Npb24KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1t OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnN0YXJ0KToKKyAgICAgICAgKFdl YkNvcmU6OlJlc291cmNlSGFuZGxlOjpkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2Up OgorICAgICAgICBBZGRlZCBGSVhNRXMuCisKIDIwMTMtMDQtMDEgIFRpbW90aHkgSGF0Y2hlciAg PHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgJ3RoaXMnIGV2YWx1YXRlIHRvIHRo ZSBjb3JyZWN0IG9iamVjdCB3aGVuIHBhdXNlZCBpbiB0aGUgRGVidWdnZXIuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhh bmRsZU1hYy5tbQkocmV2aXNpb24gMTQ3MzUxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE3NSw2 ICsxNzUsNyBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydCgpCiAgICAgZC0+bV9wcm94eS5h ZG9wdE5TKHdrQ3JlYXRlTlNVUkxDb25uZWN0aW9uRGVsZWdhdGVQcm94eSgpKTsKICAgICBbc3Rh dGljX2Nhc3Q8V2ViQ29yZU5TVVJMQ29ubmVjdGlvbkRlbGVnYXRlUHJveHkqPihkLT5tX3Byb3h5 LmdldCgpKSBzZXREZWxlZ2F0ZTpSZXNvdXJjZUhhbmRsZTo6ZGVsZWdhdGUoKV07CiAKKyAgICAv LyBGSVhNRTogRG8gbm90IHVzZSB0aGUgc3luYyB2ZXJzaW9uIG9mIHNob3VsZFVzZUNyZWRlbnRp YWxTdG9yYWdlIHdoZW4gdGhlIGNsaWVudCByZXR1cm5zIHRydWUgZnJvbSB1c2VzQXN5bmNDYWxs YmFja3MuCiAgICAgYm9vbCBzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSA9ICFjbGllbnQoKSB8 fCBjbGllbnQoKS0+c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UodGhpcyk7CiAKICAgICBkLT5t X25lZWRzU2l0ZVNwZWNpZmljUXVpcmtzID0gZC0+bV9jb250ZXh0LT5uZWVkc1NpdGVTcGVjaWZp Y1F1aXJrcygpOwpAQCAtNDc1LDYgKzQ3Niw3IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmRpZFJl Y2VpdmVBdXRoZW50aWMKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIC8vIEZJWE1FOiBE byBub3QgdXNlIHRoZSBzeW5jIHZlcnNpb24gb2Ygc2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2Ug d2hlbiB0aGUgY2xpZW50IHJldHVybnMgdHJ1ZSBmcm9tIHVzZXNBc3luY0NhbGxiYWNrcy4KICAg ICBpZiAoIWNsaWVudCgpIHx8IGNsaWVudCgpLT5zaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSh0 aGlzKSkgewogICAgICAgICBpZiAoIWQtPm1faW5pdGlhbENyZWRlbnRpYWwuaXNFbXB0eSgpIHx8 IGNoYWxsZW5nZS5wcmV2aW91c0ZhaWx1cmVDb3VudCgpKSB7CiAgICAgICAgICAgICAvLyBUaGUg c3RvcmVkIGNyZWRlbnRpYWwgd2Fzbid0IGFjY2VwdGVkLCBzdG9wIHVzaW5nIGl0LgpJbmRleDog U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwkocmV2aXNpb24gMTQ3MzU4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDQtMDEgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9u IChPT1BTISkuCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05l dHdvcmtSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJj ZUxvYWRlcjo6c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UpOgorICAgICAgICAoV2ViS2l0KToK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpzaG91bGRVc2VDcmVkZW50 aWFsU3RvcmFnZUFzeW5jKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3Vy Y2VMb2FkZXIuaDoKKyAgICAgICAgKE5ldHdvcmtSZXNvdXJjZUxvYWRlcik6CisKIDIwMTMtMDMt MDUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBcHBs eSBjaGFuZ2VzIGZyb20gc3RvcmFnZSBldmVudHMgbG9jYWxseQpJbmRleDogU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3Bw CShyZXZpc2lvbiAxNDczNTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDAsMTIgKzMwMCwxOSBA QCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6Y2Fubm90U2hvd1VSCiAgICAgbm90SW1wbGVt ZW50ZWQoKTsKIH0KIAotdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnNob3VsZFVzZUNyZWRl bnRpYWxTdG9yYWdlQXN5bmMoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSkKK2Jvb2wgTmV0d29ya1Jl c291cmNlTG9hZGVyOjpzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZShXZWJDb3JlOjpSZXNvdXJj ZUhhbmRsZSopCiB7CiAgICAgLy8gV2hlbiB0aGUgV2ViUHJvY2VzcyBpcyBoYW5kbGluZyBsb2Fk aW5nIGEgY2xpZW50IGlzIGNvbnN1bHRlZCBlYWNoIHRpbWUgdGhpcyBzaG91bGRVc2VDcmVkZW50 aWFsU3RvcmFnZSBxdWVzdGlvbiBpcyBhc2tlZC4KICAgICAvLyBJbiBOZXR3b3JrUHJvY2VzcyBt b2RlIHdlIGFzayB0aGUgV2ViUHJvY2VzcyBjbGllbnQgdXAgZnJvbnQgb25jZSBhbmQgdGhlbiBy ZXVzZSB0aGUgY2FjaGVkIGFuc3dlci4KIAotICAgIGhhbmRsZS0+Y29udGludWVTaG91bGRVc2VD cmVkZW50aWFsU3RvcmFnZShhbGxvd1N0b3JlZENyZWRlbnRpYWxzKCkgPT0gQWxsb3dTdG9yZWRD cmVkZW50aWFscyk7CisgICAgLy8gV2Ugc3RpbGwgbmVlZCB0aGlzIHN5bmMgdmVyc2lvbiwgYmVj YXVzZSBSZXNvdXJjZUhhbmRsZSBpdHNlbGYgdXNlcyBpdCBpbnRlcm5hbGx5LCBldmVuIHdoZW4g dGhlIGRlbGVnYXRlIHVzZXMgYW4gYXN5bmMgb25lLgorCisgICAgcmV0dXJuIGFsbG93U3RvcmVk Q3JlZGVudGlhbHMoKSA9PSBBbGxvd1N0b3JlZENyZWRlbnRpYWxzOworfQorCit2b2lkIE5ldHdv cmtSZXNvdXJjZUxvYWRlcjo6c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2VBc3luYyhSZXNvdXJj ZUhhbmRsZSogaGFuZGxlKQoreworICAgIGhhbmRsZS0+Y29udGludWVTaG91bGRVc2VDcmVkZW50 aWFsU3RvcmFnZShzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZShoYW5kbGUpKTsKIH0KIAogdm9p ZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZShSZXNvdXJjZUhhbmRsZSosIGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiBjaGFsbGVu Z2UpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuaAkocmV2aXNpb24gMTQ3MzUxKQorKysgU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmgJKHdvcmtpbmcgY29weSkKQEAg LTc1LDYgKzc1LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRGYWlsKFdlYkNvcmU6 OlJlc291cmNlSGFuZGxlKiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpIE9WRVJSSURF OwogICAgIHZpcnR1YWwgdm9pZCB3YXNCbG9ja2VkKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKikg T1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGNhbm5vdFNob3dVUkwoV2ViQ29yZTo6UmVzb3Vy Y2VIYW5kbGUqKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkVXNlQ3JlZGVudGlh bFN0b3JhZ2UoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqKSBPVkVSUklERTsKICAgICB2aXJ0dWFs IHZvaWQgc2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2VBc3luYyhXZWJDb3JlOjpSZXNvdXJjZUhh bmRsZSopIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRp b25DaGFsbGVuZ2UoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpBdXRo ZW50aWNhdGlvbkNoYWxsZW5nZSYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBkaWRDYW5j ZWxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZSosIGNvbnN0 IFdlYkNvcmU6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJikgT1ZFUlJJREU7Cg==