113710 2013-04-01 10:49:54 -0700 SharedMemory release build hardening 2013-04-01 11:03:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 867217 0 beidson 2013-04-01 10:49:54 -0700 SharedMemory release build hardening. Making a named memory entry can succeed but give a memory object size smaller than the size requested. This is an error for us and should be treated as a failure to create the memory. <rdar://problem/13546860> 867218 1 beidson 2013-04-01 10:50:15 -0700 Note, there's already an ASSERT to this effect, but it needs to be handled in release builds also. 867226 2 195995 beidson 2013-04-01 10:56:37 -0700 Created attachment 195995 Patch v1 867229 3 beidson 2013-04-01 11:03:50 -0700 http://trac.webkit.org/changeset/147342 195995 2013-04-01 10:56:37 -0700 2013-04-01 11:00:28 -0700 Patch v1 patch text/plain 2702 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YmFhZmVjLi40MmFiN2I0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDQtMDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFNoYXJlZE1lbW9yeSByZWxlYXNlIGJ1aWxkIGhhcmRlbmluZy4KKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEzNTQ2ODYwPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMzcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFN1Y2Nlc3NmdWwgY3JlYXRpb24gb2YgYSBtZW1vcnkgZW50cnkgd2l0aCBhIHNpemUg bGVzcyB0aGFuIHRoZSBzaXplIHdlIHJlcXVlc3RlZCBzaG91bGQgYmUgdHJlYXRlZAorICAgICAg ICBhcyBhIGZhaWx1cmUgdG8gY3JlYXRlIHRoZSBTaGFyZWRNZW1vcnkgb2JqZWN0LgorCisgICAg ICAgICogUGxhdGZvcm0vbWFjL1NoYXJlZE1lbW9yeU1hYy5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlNoYXJlZE1lbW9yeTo6Y3JlYXRlRnJvbVZNQnVmZmVyKTogRWFybHkgcmV0dXJuIGlmIHRoZSBw b3J0IHdlIGdldCBpcyBib2d1cyBmb3Igb3VyIG5lZWRzLgorICAgICAgICAoV2ViS2l0OjpTaGFy ZWRNZW1vcnk6OmNyZWF0ZUhhbmRsZSk6IERpdHRvLgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRN ZW1vcnk6OmNyZWF0ZSk6IEd1YXJhbnRlZSB3ZSBwYXNzIHZhbGlkIGlucHV0IGluIHRvIG1hY2hf dm1fbWFwLgorCiAyMDEzLTAzLTMwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZGZpeCBhZnRlciByMTQ3MjYwLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vbWFjL1NoYXJlZE1lbW9yeU1hYy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMvU2hhcmVkTWVtb3J5TWFjLmNwcAppbmRleCA4OTNh NDljLi5jN2I1MmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMvU2hh cmVkTWVtb3J5TWFjLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMvU2hhcmVk TWVtb3J5TWFjLmNwcApAQCAtMTI2LDYgKzEyNiwxMCBAQCBQYXNzUmVmUHRyPFNoYXJlZE1lbW9y eT4gU2hhcmVkTWVtb3J5OjpjcmVhdGVGcm9tVk1CdWZmZXIodm9pZCogZGF0YSwgc2l6ZV90IHNp egogICAgIH0KIAogICAgIEFTU0VSVChtZW1vcnlPYmplY3RTaXplID49IHJvdW5kX3BhZ2Uoc2l6 ZSkpOworICAgIGlmIChtZW1vcnlPYmplY3RTaXplIDwgcm91bmRfcGFnZShzaXplKSkgeworICAg ICAgICBtYWNoX3BvcnRfZGVhbGxvY2F0ZShtYWNoX3Rhc2tfc2VsZigpLCBwb3J0KTsKKyAgICAg ICAgcmV0dXJuIDA7CisgICAgfQogCiAgICAgUmVmUHRyPFNoYXJlZE1lbW9yeT4gc2hhcmVkTWVt b3J5KGFkb3B0UmVmKG5ldyBTaGFyZWRNZW1vcnkpKTsKICAgICBzaGFyZWRNZW1vcnktPm1fc2l6 ZSA9IHNpemU7CkBAIC0xNTQsMTAgKzE1OCwxMiBAQCBQYXNzUmVmUHRyPFNoYXJlZE1lbW9yeT4g U2hhcmVkTWVtb3J5OjpjcmVhdGUoY29uc3QgSGFuZGxlJiBoYW5kbGUsIFByb3RlY3Rpb24gcAog ICAgIGlmIChoYW5kbGUuaXNOdWxsKCkpCiAgICAgICAgIHJldHVybiAwOwogICAgIAorICAgIEFT U0VSVChyb3VuZF9wYWdlKGhhbmRsZS5tX3NpemUpID09IGhhbmRsZS5tX3NpemUpOworCiAgICAg Ly8gTWFwIHRoZSBtZW1vcnkuCiAgICAgdm1fcHJvdF90IHZtUHJvdGVjdGlvbiA9IG1hY2hQcm90 ZWN0aW9uKHByb3RlY3Rpb24pOwogICAgIG1hY2hfdm1fYWRkcmVzc190IG1hcHBlZEFkZHJlc3Mg PSAwOwotICAgIGtlcm5fcmV0dXJuX3Qga3IgPSBtYWNoX3ZtX21hcChtYWNoX3Rhc2tfc2VsZigp LCAmbWFwcGVkQWRkcmVzcywgaGFuZGxlLm1fc2l6ZSwgMCwgVk1fRkxBR1NfQU5ZV0hFUkUsIGhh bmRsZS5tX3BvcnQsIDAsIGZhbHNlLCB2bVByb3RlY3Rpb24sIHZtUHJvdGVjdGlvbiwgVk1fSU5I RVJJVF9OT05FKTsKKyAgICBrZXJuX3JldHVybl90IGtyID0gbWFjaF92bV9tYXAobWFjaF90YXNr X3NlbGYoKSwgJm1hcHBlZEFkZHJlc3MsIHJvdW5kX3BhZ2UoaGFuZGxlLm1fc2l6ZSksIDAsIFZN X0ZMQUdTX0FOWVdIRVJFLCBoYW5kbGUubV9wb3J0LCAwLCBmYWxzZSwgdm1Qcm90ZWN0aW9uLCB2 bVByb3RlY3Rpb24sIFZNX0lOSEVSSVRfTk9ORSk7CiAgICAgaWYgKGtyICE9IEtFUk5fU1VDQ0VT UykKICAgICAgICAgcmV0dXJuIDA7CiAKQEAgLTIwNSw2ICsyMTEsMTAgQEAgYm9vbCBTaGFyZWRN ZW1vcnk6OmNyZWF0ZUhhbmRsZShIYW5kbGUmIGhhbmRsZSwgUHJvdGVjdGlvbiBwcm90ZWN0aW9u KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIEFTU0VSVChzaXplID49IHJv dW5kX3BhZ2UobV9zaXplKSk7CisgICAgICAgIGlmIChzaXplIDwgcm91bmRfcGFnZShtX3NpemUp KSB7CisgICAgICAgICAgICBtYWNoX3BvcnRfZGVhbGxvY2F0ZShtYWNoX3Rhc2tfc2VsZigpLCBw b3J0KTsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQogICAgIH0KIAogICAg IGhhbmRsZS5tX3BvcnQgPSBwb3J0Owo=