113704 2013-04-01 08:47:52 -0700 r147324 broke the world 2013-04-01 09:07:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 867139 0 mhahnenberg 2013-04-01 08:47:52 -0700 Build fix is significant enough to warrant a quick review. Thanks for nothing, EWS. 867143 1 195977 mhahnenberg 2013-04-01 08:54:26 -0700 Created attachment 195977 Patch 867147 2 195977 mark.lam 2013-04-01 08:57:33 -0700 Comment on attachment 195977 Patch LGTM. The changes are superficial. 867149 3 mhahnenberg 2013-04-01 08:59:21 -0700 Committed r147330: <http://trac.webkit.org/changeset/147330> 867157 4 195977 darin 2013-04-01 09:07:28 -0700 Comment on attachment 195977 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195977&action=review > Source/JavaScriptCore/heap/SuperRegion.cpp:33 > +const uint64_t SuperRegion::s_fixedHeapMemoryPoolSize = 4LLU * 1024LLU * static_cast<uint64_t>(MB); I’m not sure the changes to add LLU are portable enough (since they might be bigger or smaller than uint64_t on various platforms), and they probably also are not needed since you’ve casted MB to uint64_t. 195977 2013-04-01 08:54:26 -0700 2013-04-01 09:07:28 -0700 Patch bug-113704-20130401085419.patch text/plain 4340 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3MzI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEzLTA0LTAxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgcjE0NzMyNCBicm9rZSB0aGUgd29ybGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBhIGJ1bmNoIG9mIHVudXNlZCB2YXJpYWJs ZXMgYW5kIHVzZSB0aGUgY29ycmVjdGx5IHNpemVkIHR5cGVzIGZvciAzMi1iaXQgcGxhdGZvcm1z LgorCisgICAgICAgICogaGVhcC9CbG9ja0FsbG9jYXRvci5jcHA6CisgICAgICAgIChKU0M6OkJs b2NrQWxsb2NhdG9yOjpCbG9ja0FsbG9jYXRvcik6CisgICAgICAgICogaGVhcC9CbG9ja0FsbG9j YXRvci5oOgorICAgICAgICAoQmxvY2tBbGxvY2F0b3IpOgorICAgICAgICAqIGhlYXAvSGVhcC5j cHA6CisgICAgICAgIChKU0M6OkhlYXA6OkhlYXApOgorICAgICAgICAqIGhlYXAvU3VwZXJSZWdp b24uY3BwOgorICAgICAgICAoSlNDOjpTdXBlclJlZ2lvbjo6U3VwZXJSZWdpb24pOgorICAgICAg ICAqIGhlYXAvU3VwZXJSZWdpb24uaDoKKyAgICAgICAgKFN1cGVyUmVnaW9uKToKKwogMjAxMy0w NC0wMSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAg IDMyLWJpdCBXaW5kb3dzIGJ1aWxkIGZpeApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvQmxvY2tBbGxvY2F0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0Jsb2NrQWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMTQ3MzI2KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z NCw4ICszNCw4IEBACiAKIG5hbWVzcGFjZSBKU0MgewogCi1CbG9ja0FsbG9jYXRvcjo6QmxvY2tB bGxvY2F0b3IoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhKQotICAgIDogbV9zdXBlclJlZ2lvbihn bG9iYWxEYXRhKQorQmxvY2tBbGxvY2F0b3I6OkJsb2NrQWxsb2NhdG9yKCkKKyAgICA6IG1fc3Vw ZXJSZWdpb24oKQogICAgICwgbV9jb3BpZWRSZWdpb25TZXQoQ29waWVkQmxvY2s6OmJsb2NrU2l6 ZSkKICAgICAsIG1fbWFya2VkUmVnaW9uU2V0KE1hcmtlZEJsb2NrOjpibG9ja1NpemUpCiAgICAg LCBtX2ZvdXJLQkJsb2NrUmVnaW9uU2V0KFdlYWtCbG9jazo6YmxvY2tTaXplKQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0FsbG9jYXRvci5oCShyZXZpc2lvbiAxNDcz MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0FsbG9jYXRvci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01MCw3ICs1MCw3IEBAIGNsYXNzIFdlYWtCbG9jazsKIAogY2xhc3MgQmxv Y2tBbGxvY2F0b3IgewogcHVibGljOgotICAgIEJsb2NrQWxsb2NhdG9yKEpTR2xvYmFsRGF0YSop OworICAgIEJsb2NrQWxsb2NhdG9yKCk7CiAgICAgfkJsb2NrQWxsb2NhdG9yKCk7CiAKICAgICB0 ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gRGVhZEJsb2NrKiBhbGxvY2F0ZSgpOwpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHJldmlzaW9uIDE0NzMyNikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTAsNyArMjUwLDcg QEAgSGVhcDo6SGVhcChKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEsIEhlYQogICAgICwgbV9ieXRl c0FsbG9jYXRlZCgwKQogICAgICwgbV9ieXRlc0FiYW5kb25lZCgwKQogICAgICwgbV9vcGVyYXRp b25JblByb2dyZXNzKE5vT3BlcmF0aW9uKQotICAgICwgbV9ibG9ja0FsbG9jYXRvcihnbG9iYWxE YXRhKQorICAgICwgbV9ibG9ja0FsbG9jYXRvcigpCiAgICAgLCBtX29iamVjdFNwYWNlKHRoaXMp CiAgICAgLCBtX3N0b3JhZ2VTcGFjZSh0aGlzKQogICAgICwgbV9tYWNoaW5lVGhyZWFkcyh0aGlz KQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1cGVyUmVnaW9uLmNwcAkocmV2 aXNpb24gMTQ3MzI5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiwxNiArMjYsMTQgQEAKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJTdXBlclJlZ2lvbi5oIgogCi0jaW5jbHVkZSAiSlNHbG9iYWxEYXRhLmgi CiAjaW5jbHVkZSAiUmVnaW9uLmgiCiAKIG5hbWVzcGFjZSBKU0MgewogCi1jb25zdCB1aW50NjRf dCBTdXBlclJlZ2lvbjo6c19maXhlZEhlYXBNZW1vcnlQb29sU2l6ZSA9IDQgKiAxMDI0ICogTUI7 Citjb25zdCB1aW50NjRfdCBTdXBlclJlZ2lvbjo6c19maXhlZEhlYXBNZW1vcnlQb29sU2l6ZSA9 IDRMTFUgKiAxMDI0TExVICogc3RhdGljX2Nhc3Q8dWludDY0X3Q+KE1CKTsKIAotU3VwZXJSZWdp b246OlN1cGVyUmVnaW9uKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSkKK1N1cGVyUmVnaW9uOjpT dXBlclJlZ2lvbigpCiAgICAgOiBNZXRhQWxsb2NhdG9yKFJlZ2lvbjo6c19yZWdpb25TaXplLCBS ZWdpb246OnNfcmVnaW9uU2l6ZSkKLSAgICAsIG1fZ2xvYmFsRGF0YShnbG9iYWxEYXRhKQogICAg ICwgbV9yZXNlcnZhdGlvbkJhc2UoMCkKIHsKICNpZiBFTkFCTEUoU1VQRVJfUkVHSU9OKQpAQCAt NDMsNiArNDEsOSBAQCBTdXBlclJlZ2lvbjo6U3VwZXJSZWdpb24oSlNHbG9iYWxEYXRhKiBnCiAg ICAgbV9yZXNlcnZhdGlvbiA9IFBhZ2VSZXNlcnZhdGlvbjo6cmVzZXJ2ZShzX2ZpeGVkSGVhcE1l bW9yeVBvb2xTaXplICsgUmVnaW9uOjpzX3JlZ2lvblNpemUsIE9TQWxsb2NhdG9yOjpKU0dDSGVh cFBhZ2VzKTsKICAgICBtX3Jlc2VydmF0aW9uQmFzZSA9IGdldEFsaWduZWRCYXNlKG1fcmVzZXJ2 YXRpb24pOwogICAgIGFkZEZyZXNoRnJlZVNwYWNlKG1fcmVzZXJ2YXRpb25CYXNlLCBzX2ZpeGVk SGVhcE1lbW9yeVBvb2xTaXplKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKG1fcmVzZXJ2YXRp b24pOworICAgIFVOVVNFRF9QQVJBTShtX3Jlc2VydmF0aW9uQmFzZSk7CiAjZW5kaWYKIH0KIApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3VwZXJSZWdpb24uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdXBlclJlZ2lvbi5oCShyZXZpc2lvbiAx NDczMjkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdXBlclJlZ2lvbi5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBAIGNsYXNzIEpTR2xvYmFsRGF0YTsKIAogY2xhc3Mg U3VwZXJSZWdpb24gOiBwdWJsaWMgV1RGOjpNZXRhQWxsb2NhdG9yIHsKIHB1YmxpYzoKLSAgICBT dXBlclJlZ2lvbihKU0dsb2JhbERhdGEqKTsKKyAgICBTdXBlclJlZ2lvbigpOwogCiBwcm90ZWN0 ZWQ6CiAgICAgdmlydHVhbCB2b2lkKiBhbGxvY2F0ZU5ld1NwYWNlKHNpemVfdCYpOwpAQCAtNDgs NyArNDgsNiBAQCBwcml2YXRlOgogCiAgICAgc3RhdGljIHZvaWQqIGdldEFsaWduZWRCYXNlKFBh Z2VSZXNlcnZhdGlvbiYpOwogCi0gICAgSlNHbG9iYWxEYXRhKiBtX2dsb2JhbERhdGE7CiAgICAg UGFnZVJlc2VydmF0aW9uIG1fcmVzZXJ2YXRpb247CiAgICAgdm9pZCogbV9yZXNlcnZhdGlvbkJh c2U7CiB9Owo=