113699 2013-04-01 04:55:59 -0700 [ATK] build fails when accessibility is turned off 2013-04-04 01:37:53 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 bartosh webkit-unassigned g.czajkowski gyuyoung.kim k.czech mifenton webkit.review.bot oldest_to_newest 867046 0 bartosh 2013-04-01 04:55:59 -0700 Running build with --minimal while working on #113641 and #113660 triggered this build failure: Source/WebCore/editing/atk/FrameSelectionAtk.cpp:28:40: fatal error: WebKitAccessibleWrapperAtk.h: No such file or directory compilation terminated. [ 80%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/page/efl/EventHandlerEfl.cpp.o make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/editing/atk/FrameSelectionAtk.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2 make: *** [all] Error 2 Compilation exited abnormally with code 2 at Mon Apr 1 14:46:55 867056 1 195961 bartosh 2013-04-01 05:13:44 -0700 Created attachment 195961 Patch 867455 2 195961 gyuyoung.kim 2013-04-01 18:04:42 -0700 Comment on attachment 195961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195961&action=review > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:24 > #include "FrameSelection.h" WebKit coding style says that *all implementation files must #include the primary header second, just after "config.h"* > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:-26 > - Do not touch file unrelated to patch. 867456 3 gyuyoung.kim 2013-04-01 18:05:18 -0700 (In reply to comment #2) > Do not touch file unrelated to patch. s/file/line/g 868056 4 196187 bartosh 2013-04-02 11:05:31 -0700 Created attachment 196187 Updated according to reviewer suggestions. 868419 5 196187 gyuyoung.kim 2013-04-02 21:28:27 -0700 Comment on attachment 196187 Updated according to reviewer suggestions. View in context: https://bugs.webkit.org/attachment.cgi?id=196187&action=review LGTM otherwise. > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:23 > +#if HAVE(ACCESSIBILITY) It would be good if you add a new line below. > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:111 > +#endif // HAVE(ACCESSIBILITY) It would be good if you add a new line above. 868873 6 196403 bartosh 2013-04-03 13:04:49 -0700 Created attachment 196403 Patch Updated according to review comments. 869057 7 196403 webkit.review.bot 2013-04-04 01:37:48 -0700 Comment on attachment 196403 Patch Clearing flags on attachment: 196403 Committed r147615: <http://trac.webkit.org/changeset/147615> 869058 8 webkit.review.bot 2013-04-04 01:37:53 -0700 All reviewed patches have been landed. Closing bug. 195961 2013-04-01 05:13:44 -0700 2013-04-02 11:05:31 -0700 Patch bug-113699-20130401151336.patch text/plain 1412 bartosh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRmMGViMDg3MmYxNjBl Mjk0YjVhMDgxY2FmODZiM2Y0NjkwMzFmYi4uZDY3ZjY2YzVmZjViYzhiZWY5NzVmNTY1NTE3N2Rm Yzk5ZTg3ZjI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTAxICBFZCBC YXJ0b3NoICA8YmFydG9zaEBnbWFpbC5jb20+CisKKyAgICAgICAgW0FUS10gYnVpbGQgZmFpbHMg d2hlbiBhY2Nlc3NpYmlsaXR5IGlzIHR1cm5lZCBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsu Y3BwOiBXcmFwcGVkIGFjY2Vzc2liaWxpdHkgY29kZSBpbiAjaWYgSEFWRShBQ0NFU1NJQklMSVRZ KQorCiAyMDEzLTA0LTAxICBLb2ppIElzaGlpICA8a29qaWlzaGlAZ21haWwuY29tPgogCiAgICAg ICAgIEFTU0VSVElPTiBGQUlMRUQ6IG1fcHVyZ2VQcmV2ZW50Q291bnQgd2hlbiBjbGlja2luZyB0 ZXh0IHdpdGggZW1waGFzaXMgbWFya3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvYXRrL0ZyYW1lU2VsZWN0aW9uQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvYXRr L0ZyYW1lU2VsZWN0aW9uQXRrLmNwcAppbmRleCA2ZGZkNjdjNzQ2N2RiMTAzMWMzNWVmOTI2ZjY0 MzY1Mjg1OGE3M2M0Li43ODdkODQ2NjEyY2ExZGVmYjhiYWJhMGM1NTQ1OTI2ZGQwNmQ4ZDk4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2F0ay9GcmFtZVNlbGVjdGlvbkF0ay5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsuY3Bw CkBAIC0xOCwxMiArMTgsMTQgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpZiBI QVZFKEFDQ0VTU0lCSUxJVFkpCisKICNpbmNsdWRlICJGcmFtZVNlbGVjdGlvbi5oIgogCiAjaW5j bHVkZSAiQVhPYmplY3RDYWNoZS5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiV2Vi S2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuaCIKLQogI2lmIFBMQVRGT1JNKEVGTCkKICNpbmNsdWRl IDxnbGliLmg+CiAjZWxzZQpAQCAtMTA3LDMgKzEwOSw0IEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246 Om5vdGlmeUFjY2Vzc2liaWxpdHlGb3JTZWxlY3Rpb25DaGFuZ2UoKQogfQogCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCisjZW5kaWYgLy8gSEFWRShBQ0NFU1NJQklMSVRZKQo= 196187 2013-04-02 11:05:31 -0700 2013-04-03 13:04:49 -0700 Updated according to reviewer suggestions. Patch.113699 text/plain 1410 bartosh Y29tbWl0IGJjZmU1ZGM0OGU5ZGVlNjU0YmMwNmJhODY1YmNlNGY0NjQ4ZDgyMzEKQXV0aG9yOiBF ZCBCYXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KRGF0ZTogICBUdWUgQXByIDIgMjA6MDE6MTQg MjAxMyArMDMwMAoKICAgIEZpeGVkIDExMzY5OQogICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBFZCBC YXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZjYjZiZC4uNmUwYTc1 ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTAxICBFZCBCYXJ0b3NoICA8 YmFydG9zaEBnbWFpbC5jb20+CisKKyAgICAgICAgW0FUS10gYnVpbGQgZmFpbHMgd2hlbiBhY2Nl c3NpYmlsaXR5IGlzIHR1cm5lZCBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMzY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsuY3BwOiBXcmFw cGVkIGFjY2Vzc2liaWxpdHkgY29kZSBpbiAjaWYgSEFWRShBQ0NFU1NJQklMSVRZKQorCiAyMDEz LTA0LTAyICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhUTUwg cGFyc2VyIHNob3VsZCBjb25zaXN0ZW50bHkgaW5zcGVjdCB0aGUgbmFtZXNwYWNlIG9mIGVsZW1l bnRzIG9uIHRoZSBzdGFjayBvZiBvcGVuIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL2F0ay9GcmFtZVNlbGVjdGlvbkF0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL2F0ay9GcmFtZVNlbGVjdGlvbkF0ay5jcHAKaW5kZXggNmRmZDY3Yy4uMDllMWRkYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvYXRrL0ZyYW1lU2VsZWN0aW9uQXRrLmNw cApAQCAtMjAsNiArMjAsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZyYW1l U2VsZWN0aW9uLmgiCiAKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCiAjaW5jbHVkZSAiQVhPYmpl Y3RDYWNoZS5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiV2ViS2l0QWNjZXNzaWJs ZVdyYXBwZXJBdGsuaCIKQEAgLTEwNywzICsxMDgsNCBAQCB2b2lkIEZyYW1lU2VsZWN0aW9uOjpu b3RpZnlBY2Nlc3NpYmlsaXR5Rm9yU2VsZWN0aW9uQ2hhbmdlKCkKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQorI2VuZGlmIC8vIEhBVkUoQUNDRVNTSUJJTElUWSkK 196403 2013-04-03 13:04:49 -0700 2013-04-04 01:37:48 -0700 Patch Patch.113699 text/plain 1414 bartosh Y29tbWl0IGFjZDIwOThlNDU1Y2NhMGViNmVmMGY2NmI1MGQ5NDM0ZjBiMjhmZWYKQXV0aG9yOiBF ZCBCYXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KRGF0ZTogICBUdWUgQXByIDIgMjA6MDE6MTQg MjAxMyArMDMwMAoKICAgIEZpeGVkIDExMzY5OQogICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBFZCBC YXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZjYjZiZC4uNmUwYTc1 ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA0LTAxICBFZCBCYXJ0b3NoICA8 YmFydG9zaEBnbWFpbC5jb20+CisKKyAgICAgICAgW0FUS10gYnVpbGQgZmFpbHMgd2hlbiBhY2Nl c3NpYmlsaXR5IGlzIHR1cm5lZCBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMzY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsuY3BwOiBXcmFw cGVkIGFjY2Vzc2liaWxpdHkgY29kZSBpbiAjaWYgSEFWRShBQ0NFU1NJQklMSVRZKQorCiAyMDEz LTA0LTAyICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEhUTUwg cGFyc2VyIHNob3VsZCBjb25zaXN0ZW50bHkgaW5zcGVjdCB0aGUgbmFtZXNwYWNlIG9mIGVsZW1l bnRzIG9uIHRoZSBzdGFjayBvZiBvcGVuIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL2F0ay9GcmFtZVNlbGVjdGlvbkF0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL2F0ay9GcmFtZVNlbGVjdGlvbkF0ay5jcHAKaW5kZXggNmRmZDY3Yy4uZjI4YjU5ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvYXRrL0ZyYW1lU2VsZWN0aW9uQXRrLmNw cApAQCAtMjAsNiArMjAsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZyYW1l U2VsZWN0aW9uLmgiCiAKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCisKICNpbmNsdWRlICJBWE9i amVjdENhY2hlLmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJXZWJLaXRBY2Nlc3Np YmxlV3JhcHBlckF0ay5oIgpAQCAtMTA3LDMgKzEwOSw1IEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246 Om5vdGlmeUFjY2Vzc2liaWxpdHlGb3JTZWxlY3Rpb25DaGFuZ2UoKQogfQogCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBIQVZFKEFDQ0VTU0lCSUxJVFkpCg==