113694 2013-04-01 02:22:03 -0700 Web Inspector: [DataGrid] Reject resizing columns to inacceptible widths. 2013-04-07 22:26:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 112666 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 866996 0 eustas 2013-04-01 02:22:03 -0700 In DataGrid column width constrain misbehaves in case when user tries to drag resizer between two thin columns. That is because Number.constrain input parameters are inconsistent (maximum < minimum). Additional restriction: columns with width specified by weight should not be thinner than 1 weight point. If user doesn't want to see column he should hide it completely. 866999 1 195946 eustas 2013-04-01 02:37:55 -0700 Created attachment 195946 Patch 867055 2 195946 pfeldman 2013-04-01 05:10:37 -0700 Comment on attachment 195946 Patch Could you provide a test? Implementation looks fragile. 867606 3 eustas 2013-04-01 23:49:56 -0700 Actually this patch consists of 3 changes that doesn't look fragile: 1) Ensure that constraint is correct. If constraint is incorrect, then we can't apply this. That way we will prevent making columns thinner (that they were before dragging) 2) Move weight-assigning block up, before styles are changed. This change itself doesn't change behavior. But it is required for change (3) 3) Split new weight calculation and assigning. Add minimal weight constraint. Because of change (2) "return" statement will leave columns consistent, as nothing has been changed up to this moment. OK, I'll try to add test for this. 195946 2013-04-01 02:37:55 -0700 2013-04-01 05:10:37 -0700 Patch bug-113694-20130401133747.patch text/plain 3668 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdiZjIzMGRjMDlkOWQ2 Y2ZlODE1N2I3MmY1M2NhZGQzODQ0YmNhNy4uYzA3NmQ5N2I1MWYxOTNlZjYwNzUwYWE1MGZjZmUx OTJiY2VhOWEwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTAxICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtEYXRhR3JpZF0gUmVqZWN0IHJlc2l6aW5nIGNvbHVtbnMgdG8gaW5hY2NlcHRpYmxl IHdpZHRocy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzY5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIERhdGFHcmlkIGNvbHVtbiB3aWR0aCBjb25zdHJhaW4gbWlzYmVoYXZlcyBpbiBjYXNlIHdo ZW4gdXNlciB0cmllcworICAgICAgICB0byBkcmFnIHJlc2l6ZXIgYmV0d2VlbiB0d28gdGhpbiBj b2x1bW5zLgorCisgICAgICAgIFRvIHJlc29sdmUgdGhpcyBwcm9ibGVtIG5ldyBndWFyZGluZyBj b25kaXRpb24gaXMgYWRkZWQuCisKKyAgICAgICAgQWRkaXRpb25hbGx5IHJlc3RyaWN0ZWQgY29s dW1ucyBzcGVjaWZpZWQgd2VpZ2h0IHRvIGJlIG5vIHRoaW5uZXIKKyAgICAgICAgdGhhbiAxIHdl aWdodCBwb2ludC4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLl9yZXNpemVyRHJhZ2dp bmcpOiBBZGRlZCBndWFyZHMuCisKIDIwMTMtMDMtMzEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBHcmFkaWVudCBiYWNrZ3JvdW5kIGRvZXMgbm90IGdldCByZXBh aW50ZWQgd2hlbiBjaGlsZCBib3ggaXMgZXhwYW5kZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9EYXRhR3JpZC5qcwppbmRleCA5Yzk0YTg0N2JhYThiZGY5ZDI5NmQz OWE3YzFjZTg1Mzk0OTYwZDQyLi42MjRjNzg4OTFkMDlkZTVkZjBiYWFjZjQzMjdhZGZhMGViZWUz MmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFH cmlkLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQu anMKQEAgLTEwMjYsOSArMTAyNiwyNCBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBl ID0gewogICAgICAgICAvLyBHaXZlIGVhY2ggY29sdW1uIHNvbWUgcGFkZGluZyBzbyB0aGF0IHRo ZXkgZG9uJ3QgZGlzYXBwZWFyLgogICAgICAgICB2YXIgbGVmdE1pbmltdW0gPSBsZWZ0RWRnZU9m UHJldmlvdXNDb2x1bW4gKyB0aGlzLkNvbHVtblJlc2l6ZVBhZGRpbmc7CiAgICAgICAgIHZhciBy aWdodE1heGltdW0gPSByaWdodEVkZ2VPZk5leHRDb2x1bW4gLSB0aGlzLkNvbHVtblJlc2l6ZVBh ZGRpbmc7CisgICAgICAgIGlmIChsZWZ0TWluaW11bSA+IHJpZ2h0TWF4aW11bSkKKyAgICAgICAg ICAgIHJldHVybjsKIAogICAgICAgICBkcmFnUG9pbnQgPSBOdW1iZXIuY29uc3RyYWluKGRyYWdQ b2ludCwgbGVmdE1pbmltdW0sIHJpZ2h0TWF4aW11bSk7CiAKKyAgICAgICAgdmFyIGxlZnRDb2x1 bW4gPSB0aGlzLl9jb2x1bW5zQXJyYXlbbGVmdENlbGxJbmRleF07CisgICAgICAgIHZhciByaWdo dENvbHVtbiA9IHRoaXMuX2NvbHVtbnNBcnJheVtyaWdodENlbGxJbmRleF07CisgICAgICAgIGlm IChsZWZ0Q29sdW1uLndlaWdodCB8fCByaWdodENvbHVtbi53ZWlnaHQpIHsKKyAgICAgICAgICAg IHZhciBzdW1PZldlaWdodHMgPSBsZWZ0Q29sdW1uLndlaWdodCArIHJpZ2h0Q29sdW1uLndlaWdo dDsKKyAgICAgICAgICAgIHZhciBkZWx0YSA9IHJpZ2h0RWRnZU9mTmV4dENvbHVtbiAtIGxlZnRF ZGdlT2ZQcmV2aW91c0NvbHVtbjsKKyAgICAgICAgICAgIHZhciBsZWZ0Q29sdW1uV2VpZ2h0ID0g KGRyYWdQb2ludCAtIGxlZnRFZGdlT2ZQcmV2aW91c0NvbHVtbikgKiBzdW1PZldlaWdodHMgLyBk ZWx0YTsKKyAgICAgICAgICAgIHZhciByaWdodENvbHVtbldlaWdodCA9IChyaWdodEVkZ2VPZk5l eHRDb2x1bW4gLSBkcmFnUG9pbnQpICogc3VtT2ZXZWlnaHRzIC8gZGVsdGE7CisgICAgICAgICAg ICBpZiAoKGxlZnRDb2x1bW5XZWlnaHQgPCAxKSB8fCAocmlnaHRDb2x1bW5XZWlnaHQgPCAxKSkK KyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBsZWZ0Q29sdW1uLndlaWdodCA9 IGxlZnRDb2x1bW5XZWlnaHQ7CisgICAgICAgICAgICByaWdodENvbHVtbi53ZWlnaHQgPSByaWdo dENvbHVtbldlaWdodDsKKyAgICAgICAgfQorCiAgICAgICAgIHJlc2l6ZXIuc3R5bGUubGVmdCA9 IChkcmFnUG9pbnQgLSB0aGlzLkNlbnRlclJlc2l6ZXJPdmVyQm9yZGVyQWRqdXN0bWVudCkgKyAi cHgiOwogCiAgICAgICAgIHZhciBwZXJjZW50TGVmdENvbHVtbiA9ICgoKGRyYWdQb2ludCAtIGxl ZnRFZGdlT2ZQcmV2aW91c0NvbHVtbikgLyB0YWJsZVdpZHRoKSAqIDEwMCkgKyAiJSI7CkBAIC0x MDM5LDE1ICsxMDU0LDYgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZSA9IHsKICAg ICAgICAgdGhpcy5faGVhZGVyVGFibGVDb2x1bW5Hcm91cC5jaGlsZHJlbltyaWdodENlbGxJbmRl eF0uc3R5bGUud2lkdGggPSAgcGVyY2VudFJpZ2h0Q29sdW1uOwogICAgICAgICB0aGlzLl9kYXRh VGFibGVDb2x1bW5Hcm91cC5jaGlsZHJlbltyaWdodENlbGxJbmRleF0uc3R5bGUud2lkdGggPSBw ZXJjZW50UmlnaHRDb2x1bW47CiAKLSAgICAgICAgdmFyIGxlZnRDb2x1bW4gPSB0aGlzLl9jb2x1 bW5zQXJyYXlbbGVmdENlbGxJbmRleF07Ci0gICAgICAgIHZhciByaWdodENvbHVtbiA9IHRoaXMu X2NvbHVtbnNBcnJheVtyaWdodENlbGxJbmRleF07Ci0gICAgICAgIGlmIChsZWZ0Q29sdW1uLndl aWdodCB8fCByaWdodENvbHVtbi53ZWlnaHQpIHsKLSAgICAgICAgICAgIHZhciBzdW1PZldlaWdo dHMgPSBsZWZ0Q29sdW1uLndlaWdodCArIHJpZ2h0Q29sdW1uLndlaWdodDsKLSAgICAgICAgICAg IHZhciBkZWx0YSA9IHJpZ2h0RWRnZU9mTmV4dENvbHVtbiAtIGxlZnRFZGdlT2ZQcmV2aW91c0Nv bHVtbjsKLSAgICAgICAgICAgIGxlZnRDb2x1bW4ud2VpZ2h0ID0gKGRyYWdQb2ludCAtIGxlZnRF ZGdlT2ZQcmV2aW91c0NvbHVtbikgKiBzdW1PZldlaWdodHMgLyBkZWx0YTsKLSAgICAgICAgICAg IHJpZ2h0Q29sdW1uLndlaWdodCA9IChyaWdodEVkZ2VPZk5leHRDb2x1bW4gLSBkcmFnUG9pbnQp ICogc3VtT2ZXZWlnaHRzIC8gZGVsdGE7Ci0gICAgICAgIH0KLQogICAgICAgICB0aGlzLl9wb3Np dGlvblJlc2l6ZXJzKCk7CiAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5FdmVu dHMuQ29sdW1uc1Jlc2l6ZWQpOwo=