113689 2013-04-01 01:43:12 -0700 REGRESSION (r147241): Failures in three IDB layout tests on GTK 2013-04-01 22:29:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 113091 1 zan webkit-unassigned ggaren haraken jsbell michael mrobinson oliver webkit.review.bot oldest_to_newest 866983 0 zan 2013-04-01 01:43:12 -0700 Three IDB layout tests started failing on GTK after r147241. http://trac.webkit.org/changeset/147241 These are the failing tests: storage/indexeddb/clone-exception.html storage/indexeddb/exceptions.html storage/indexeddb/structured-clone.html From a quick look at the changes it seems the JSC bindings are not handling this as expected (i.e. as V8 bindings do). http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=storage%2Findexeddb%2Fclone-exception.html%2Cstorage%2Findexeddb%2Fexceptions.html%2Cstorage%2Findexeddb%2Fstructured-clone.html --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/clone-exception-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/clone-exception-actual.txt @@ -10,27 +10,21 @@ onUpgradeNeeded(): Expecting exception from db.createObjectStore('store').put(NON_CLONEABLE, 0); -PASS Exception was thrown. -PASS code is 25 -PASS ename is 'DataCloneError' +FAIL No exception thrown! Should have been 25 doSecondOpen(): indexedDB.open(dbname + '2') onUpgradeNeeded(): Expecting exception from db.createObjectStore('store').put(NON_CLONEABLE, 0); -PASS Exception was thrown. -PASS code is 25 -PASS ename is 'DataCloneError' +FAIL No exception thrown! Should have been 25 doThirdOpen(): indexedDB.open(dbname + '3') onUpgradeNeeded(): Expecting exception from db.createObjectStore('store').put(NON_CLONEABLE, INVALID_KEY); -PASS Exception was thrown. -PASS code is 25 -PASS ename is 'DataCloneError' +FAIL No exception thrown! Should have been 25 PASS successfullyParsed is true TEST COMPLETE -------- --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/exceptions-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/exceptions-actual.txt @@ -143,8 +143,7 @@ PASS ename is 'TransactionInactiveError' The data being stored could not be cloned by the internal structured cloning algorithm. Expecting exception from store.add(self, 0) -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR IDBObjectStore.clear() This method throws a DOMException of type ReadOnlyError if the transaction which this IDBObjectStore belongs to is has its mode set to "readonly". @@ -240,8 +239,7 @@ PASS ename is 'TransactionInactiveError' The data being stored could not be cloned by the internal structured cloning algorithm. Expecting exception from store.put(self, 0) -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR db.close() ro_transaction.oncomplete = transactionComplete rw_transaction.oncomplete = transactionComplete @@ -444,8 +442,7 @@ PASS ename is 'DataError' If the structured clone algorithm throws an exception, that exception is rethrown. Expecting exception from cursor.update(self) -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR The transaction this IDBCursor belongs to is not active. Expecting exception from cursorFromInactiveTransaction.update({}) PASS Exception was thrown. -------- --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/structured-clone-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/structured-clone-actual.txt @@ -781,22 +781,17 @@ Other JavaScript object types: Expecting exception from store.put(new Error, 'key') -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR Expecting exception from store.put(new Function, 'key') -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR Other host object types: Expecting exception from store.put(self, 'key') -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR Expecting exception from store.put(document, 'key') -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR Expecting exception from store.put(document.body, 'key') -PASS Exception was thrown. -PASS code is DOMException.DATA_CLONE_ERR +FAIL No exception thrown! Should have been DOMException.DATA_CLONE_ERR PASS successfullyParsed is true TEST COMPLETE 867257 1 195998 michael 2013-04-01 11:52:11 -0700 Created attachment 195998 Patch 867285 2 jsbell 2013-04-01 12:37:04 -0700 Sorry about that. We need to try and get ScriptState and SSV better aligned *internally* in the V8 binding and between V8 and and JSC. Some vague notes in https://bugs.webkit.org/show_bug.cgi?id=113091 Apologies for not anticipating this failure. :( 867299 3 michael 2013-04-01 12:53:47 -0700 (In reply to comment #2) > Sorry about that. We need to try and get ScriptState and SSV better aligned *internally* in the V8 binding and between V8 and and JSC. > > Some vague notes in https://bugs.webkit.org/show_bug.cgi?id=113091 > > Apologies for not anticipating this failure. :( The JSC implementation of ScriptValue::serialize(ScriptState*, MessagePortArray*, ArrayBufferArray*, bool&), added in r116763, was flawed in that it called the specialized SerializedScriptValue::create(JSContextRef, JSValueRef, MessagePortArray*, ArrayBufferArray*, JSValueRef*). This variant of SerializedScriptValue::create(), which returns the exception thrown in its final parameter and clears the exception on the JSContextRef, was intended for use in the WebKit layer and not in WebCore bindings (r51256). The fix in r147241 exposed this formerly latent error. 867416 4 195998 haraken 2013-04-01 16:42:09 -0700 Comment on attachment 195998 Patch Although a right way to fix the bug would be making SSV's APIs better (in both V8 and JSC), this looks reasonable as an immediate fix. 867547 5 195998 webkit.review.bot 2013-04-01 22:29:35 -0700 Comment on attachment 195998 Patch Clearing flags on attachment: 195998 Committed r147382: <http://trac.webkit.org/changeset/147382> 867548 6 webkit.review.bot 2013-04-01 22:29:39 -0700 All reviewed patches have been landed. Closing bug. 195998 2013-04-01 11:52:11 -0700 2013-04-01 22:29:35 -0700 Patch idb-exceptions.patch text/plain 3704 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogTW9uLCAxIEFwciAy MDEzIDExOjQwOjE1IC0wNzAwClN1YmplY3Q6IFtKU0NdIEluZGV4ZWREQjogRXhjZXB0aW9ucyBu b3QgdGhyb3duIGZvciBub24tY2xvbmVhYmxlIHZhbHVlcwoKLS0tCiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgIHwgICAgNCAtLS0tCiBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRWYWx1ZS5jcHAgfCAgICA1ICsrLS0tCiA0 IGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDQ3Y2IxZGIuLjcyYWIyOTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wNC0wMSAgTWlj aGFlbCBQcnVldHQgIDxtaWNoYWVsQDY4ay5vcmc+CisKKyAgICAgICAgW0pTQ10gSW5kZXhlZERC OiBFeGNlcHRpb25zIG5vdCB0aHJvd24gZm9yIG5vbi1jbG9uZWFibGUgdmFsdWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM2ODkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9U ZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTA0LTAxICBWaWN0b3IgQ2FyYnVuZSAgPHZjYXJidW5l QGNocm9taXVtLm9yZz4KIAogICAgICAgICBQYXJzaW5nIFdlYlZUVCBSZWdpb24gSGVhZGVyIE1l dGFkYXRhCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDc0 ZWM2ODcuLjg3YzBhNzQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zCkBAIC0xMzg1LDEwICsxMzg1LDYgQEAgd2Via2l0Lm9yZy9iLzExMjcwNSBmYXN0L2RvbS9p Y29uLXVybC1wcm9wZXJ0eS5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xMTMxMjcg bWVkaWEvdHJhY2svdHJhY2stcHJlZmVyLWNhcHRpb25zLmh0bWwgWyBUaW1lb3V0IF0KIAotd2Vi a2l0Lm9yZy9iLzExMzY4OSBzdG9yYWdlL2luZGV4ZWRkYi9jbG9uZS1leGNlcHRpb24uaHRtbCBb IEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzExMzY4OSBzdG9yYWdlL2luZGV4ZWRkYi9leGNlcHRp b25zLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMTM2ODkgc3RvcmFnZS9pbmRleGVk ZGIvc3RydWN0dXJlZC1jbG9uZS5odG1sIFsgRmFpbHVyZSBdCi0KICMvLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vCiAjIEVuZCBvZiBUZXN0cyBmYWlsaW5nCiAjLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGI4ZjI3ZjIuLjE5Yjg0MGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMy0wNC0wMSAgTWljaGFlbCBQcnVldHQgIDxtaWNoYWVs QDY4ay5vcmc+CisKKyAgICAgICAgW0pTQ10gSW5kZXhlZERCOiBFeGNlcHRpb25zIG5vdCB0aHJv d24gZm9yIG5vbi1jbG9uZWFibGUgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTY3JpcHRWYWx1ZTo6c2VyaWFsaXplKCkgc2hvdWxkIG5vdCBj bGVhciBleGNlcHRpb25zIHRocm93biBkdXJpbmcKKyAgICAgICAgc2VyaWFsaXphdGlvbi4gVGhp cyBjaGFuZ2UgaXMgbmVlZGVkIHRvIG1hdGNoIGJlaGF2aW9yIGluIFY4LgorCisgICAgICAgIFRl c3RzOiBzdG9yYWdlL2luZGV4ZWRkYi9jbG9uZS1leGNlcHRpb24uaHRtbAorICAgICAgICAgICAg ICAgc3RvcmFnZS9pbmRleGVkZGIvZXhjZXB0aW9ucy5odG1sCisgICAgICAgICAgICAgICBzdG9y YWdlL2luZGV4ZWRkYi9zdHJ1Y3R1cmVkLWNsb25lLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdz L2pzL1NjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFZhbHVlOjpzZXJp YWxpemUpOgorCiAyMDEzLTA0LTAxICBEbWl0cnkgWnZvcnlnaW4gIDx6dm9yeWdpbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRXhjZXB0aW9uIGluIGNvbnNvbGUgb24g YXR0ZW1wdCB0byBmaWx0ZXIgamF2YXNjcmlwdCBtZXNzYWdlcy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcAppbmRleCAwYTA1MTgyLi40NTU1N2FmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRWYWx1ZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuY3BwCkBAIC0xMDUsOSArMTA1LDgg QEAgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNjcmlwdFZhbHVlOjpzZXJpYWxp emUoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXQKIAogUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0 VmFsdWU+IFNjcmlwdFZhbHVlOjpzZXJpYWxpemUoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlLCBN ZXNzYWdlUG9ydEFycmF5KiBtZXNzYWdlUG9ydHMsIEFycmF5QnVmZmVyQXJyYXkqIGFycmF5QnVm ZmVycywgYm9vbCYgZGlkVGhyb3cpCiB7Ci0gICAgSlNWYWx1ZVJlZiBleGNlcHRpb24gPSAwOwot ICAgIFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHNlcmlhbGl6ZWRWYWx1ZSA9IFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKHRvUmVmKHNjcmlwdFN0YXRlKSwgdG9SZWYoc2NyaXB0 U3RhdGUsIGpzVmFsdWUoKSksIG1lc3NhZ2VQb3J0cywgYXJyYXlCdWZmZXJzLCAmZXhjZXB0aW9u KTsKLSAgICBkaWRUaHJvdyA9IGV4Y2VwdGlvbiA/IHRydWUgOiBmYWxzZTsKKyAgICBSZWZQdHI8 U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBzZXJpYWxpemVkVmFsdWUgPSBTZXJpYWxpemVkU2NyaXB0 VmFsdWU6OmNyZWF0ZShzY3JpcHRTdGF0ZSwganNWYWx1ZSgpLCBtZXNzYWdlUG9ydHMsIGFycmF5 QnVmZmVycyk7CisgICAgZGlkVGhyb3cgPSBzY3JpcHRTdGF0ZS0+aGFkRXhjZXB0aW9uKCk7CiAg ICAgcmV0dXJuIHNlcmlhbGl6ZWRWYWx1ZS5yZWxlYXNlKCk7CiB9CiAKLS0gCjEuNy4xMC40Cgo=