113681 2013-03-31 23:56:28 -0700 Remove a couple of malloc from ExceptionBase construction 2013-04-01 13:00:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 866946 0 benjamin 2013-03-31 23:56:28 -0700 Remove a couple of malloc from ExceptionBase construction 866950 1 195931 benjamin 2013-04-01 00:04:14 -0700 Created attachment 195931 Patch 866980 2 195931 darin 2013-04-01 01:13:04 -0700 Comment on attachment 195931 Patch Looks good. We also need to fix this so we don’t need to use String::number in cases like this; should format the number into a temporary buffer that can then be appended to the string, not a heap-allocated string. 867280 3 benjamin 2013-04-01 12:27:25 -0700 (In reply to comment #2) > (From update of attachment 195931 [details]) > Looks good. We also need to fix this so we don’t need to use String::number in cases like this; should format the number into a temporary buffer that can then be appended to the string, not a heap-allocated string. Yep, this have been annoying me for a while but I have not got the time to fix it yet. Thank you for the review. 867301 4 195931 webkit.review.bot 2013-04-01 13:00:03 -0700 Comment on attachment 195931 Patch Clearing flags on attachment: 195931 Committed r147353: <http://trac.webkit.org/changeset/147353> 867302 5 webkit.review.bot 2013-04-01 13:00:06 -0700 All reviewed patches have been landed. Closing bug. 195931 2013-04-01 00:04:14 -0700 2013-04-01 13:00:03 -0700 Patch bug-113681-20130401000407.patch text/plain 2093 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWY3MjNlNWIyY2FmYTY4 MmFiNjY3OTI5MTc3ZjhkMWE1ZWFlYjA4MS4uMWM2MzkzNzYzNmU2NDBkMTI4YTdmMWI3NWI4Nzhh YmI4YmQzOWZiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTMxICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgYSBj b3VwbGUgb2YgbWFsbG9jIGZyb20gRXhjZXB0aW9uQmFzZSBjb25zdHJ1Y3Rpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzY4MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0V4Y2VwdGlvbkJh c2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXhjZXB0aW9uQmFzZTo6RXhjZXB0aW9uQmFzZSk6 CisgICAgICAgIFdoZW4gdGhlIGNvbmRpdGlvbiBpcyB0cnVlLCB3ZSB3ZXJlIGNyZWF0aW5nIGEg bmV3IFN0cmluZyBmb3IKKyAgICAgICAgZGVzY3JpcHRpb24ubmFtZS4gVGhlIGNvbnN0cnVjdG9y IGhhZCBhbHJlYWR5IGFsbG9jYXRlZCBhIHN0cmluZyBmb3IKKyAgICAgICAgdGhhdDogbV9uYW1l LiBVc2UgdGhhdCBzdHJpbmcgaW5zdGVhZCBvZiBjcmVhdGluZyBhIG5ldyBvbmUuCisKKyAgICAg ICAgV2hlbiB0aGUgY29uZGl0aW9uIGlzIGZhbHNlLCB3ZSB3ZXJlIGNyZWF0aW5nIGEgU3RyaW5n IGZvciB0eXBlTmFtZQorICAgICAgICBqdXN0IHRvIHVzZSB0aGUgc3RyaW5nIG9wZXJhdG9ycy4g VGhpcyBpcyBhIHdhc3RlIG9mIHRpbWUsIHdlIGNhbiB1c2UKKyAgICAgICAgbWFrZVN0cmluZygp IHRvIGludm9rZSB0aGUgc3RyaW5nIGNvbmNhdGVuYXRpb24gZnVuY3Rpb25zIGRpcmVjdGx5Lgor CiAyMDEzLTAzLTMwICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IENyb3NzLU9yaWdpbiBjb3B5JnBhc3RlIC8gZHJhZyZkcm9wIGFsbG93aW5nIFhTUyB2aWEgc3Jj ZG9jIGF0dHJpYnV0ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25C YXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25CYXNlLmNwcAppbmRleCA0NTUx ZThkYTBiMGVjZWJkNDBkYzQ3MzhlNjJkZDQzYzI2YTljZDc5Li42ZjBmYTI4Mzg1MjYxYmZiYTEy OTk5YmY3NGJlMDQyMmVjNTBmOTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXhj ZXB0aW9uQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V4Y2VwdGlvbkJhc2UuY3Bw CkBAIC00MCw5ICs0MCw5IEBAIEV4Y2VwdGlvbkJhc2U6OkV4Y2VwdGlvbkJhc2UoY29uc3QgRXhj ZXB0aW9uQ29kZURlc2NyaXB0aW9uJiBkZXNjcmlwdGlvbikKICAgICAsIG1fZGVzY3JpcHRpb24o ZGVzY3JpcHRpb24uZGVzY3JpcHRpb24pCiB7CiAgICAgaWYgKGRlc2NyaXB0aW9uLm5hbWUpCi0g ICAgICAgIG1fbWVzc2FnZSA9IFN0cmluZyhkZXNjcmlwdGlvbi5uYW1lKSArICI6ICIgKyBkZXNj cmlwdGlvbi50eXBlTmFtZSArICIgRXhjZXB0aW9uICIgKyBTdHJpbmc6Om51bWJlcihkZXNjcmlw dGlvbi5jb2RlKTsKKyAgICAgICAgbV9tZXNzYWdlID0gbV9uYW1lICsgIjogIiArIGRlc2NyaXB0 aW9uLnR5cGVOYW1lICsgIiBFeGNlcHRpb24gIiArIFN0cmluZzo6bnVtYmVyKGRlc2NyaXB0aW9u LmNvZGUpOwogICAgIGVsc2UKLSAgICAgICAgbV9tZXNzYWdlID0gU3RyaW5nKGRlc2NyaXB0aW9u LnR5cGVOYW1lKSArICIgRXhjZXB0aW9uICIgKyBTdHJpbmc6Om51bWJlcihkZXNjcmlwdGlvbi5j b2RlKTsKKyAgICAgICAgbV9tZXNzYWdlID0gbWFrZVN0cmluZyhkZXNjcmlwdGlvbi50eXBlTmFt ZSwgIiBFeGNlcHRpb24gIiwgU3RyaW5nOjpudW1iZXIoZGVzY3JpcHRpb24uY29kZSkpOwogfQog CiBTdHJpbmcgRXhjZXB0aW9uQmFzZTo6dG9TdHJpbmcoKSBjb25zdAo=