113664 2013-03-31 13:01:03 -0700 NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks 2013-03-31 13:12:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap sam oldest_to_newest 866807 0 beidson 2013-03-31 13:01:03 -0700 NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks In the "two part" callbacks that do a dispatch_async followed by a dispatch_semaphore_wait the delegate might have been released and destroyed by the time the semaphore returns. This is bad, and can be fixed with a RetainPtr<> protector. In radar as <rdar://problem/13541868> 866809 1 195904 beidson 2013-03-31 13:04:07 -0700 Created attachment 195904 Patch v1 866812 2 beidson 2013-03-31 13:12:21 -0700 http://trac.webkit.org/changeset/147287 195904 2013-03-31 13:04:07 -0700 2013-03-31 13:07:07 -0700 Patch v1 patch text/plain 3523 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZjcyM2U1Li4xOWRkMzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDMtMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE5ldHdvcmtQcm9jZXNzIGNyYXNoZXMgaW4gV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVy YXRpb25RdWV1ZURlbGVnYXRlIGNhbGxiYWNrcy4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEz NTQxODY4PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzY2 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRo ZSAidHdvLXBhcnQiIGNhbGxiYWNrcyB0aGF0IGludm9sdmUgd2FpdGluZyBvbiBhIHNlbWFwaG9y ZSBmb3IgdGhlIGFzeW5jIGJsb2NrIHRvIGZpbmlzaCwKKyAgICAgICAgdGhlIGRlbGVnYXRlIG1p Z2h0IGhhdmUgYmVlbiBkZXN0cm95ZWQgYnkgdGhlIHRpbWUgdGhlIHdhaXQgY29tcGxldGVzLgor CisgICAgICAgIEEgUmV0YWluUHRyPD4gcHJvdGVjdG9yIHdpbGwgZml4IHRoYXQgdXAgbmljZWx5 LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvV2ViQ29yZVJlc291cmNlSGFuZGxl QXNPcGVyYXRpb25RdWV1ZURlbGVnYXRlLm1tOgorICAgICAgICAoLVtXZWJDb3JlUmVzb3VyY2VI YW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUgY29ubmVjdGlvbjp3aWxsU2VuZFJlcXVlc3Q6 cmVkaXJlY3RSZXNwb25zZTpdKToKKyAgICAgICAgKC1bV2ViQ29yZVJlc291cmNlSGFuZGxlQXNP cGVyYXRpb25RdWV1ZURlbGVnYXRlIGNvbm5lY3Rpb25TaG91bGRVc2VDcmVkZW50aWFsU3RvcmFn ZTpdKToKKyAgICAgICAgKC1bV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURl bGVnYXRlIGNvbm5lY3Rpb246Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZTpd KToKKyAgICAgICAgKC1bV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURlbGVn YXRlIGNvbm5lY3Rpb246d2lsbENhY2hlUmVzcG9uc2U6XSk6CisKIDIwMTMtMDMtMzAgIFRvbSBT ZXBleiAgPHRzZXBlekBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ3Jvc3MtT3JpZ2luIGNvcHkm cGFzdGUgLyBkcmFnJmRyb3AgYWxsb3dpbmcgWFNTIHZpYSBzcmNkb2MgYXR0cmlidXRlLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvV2ViQ29yZVJlc291 cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURlbGVnYXRlLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9tYWMvV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURl bGVnYXRlLm1tCmluZGV4IDg1MTA1NDMuLjhlZjAyMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzT3BlcmF0aW9u UXVldWVEZWxlZ2F0ZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21h Yy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW0KQEAgLTEx NSw2ICsxMTUsOCBAQCAtIChOU1VSTFJlcXVlc3QgKiljb25uZWN0aW9uOihOU1VSTENvbm5lY3Rp b24gKiljb25uZWN0aW9uIHdpbGxTZW5kUmVxdWVzdDooTlNVUgogICAgICAgICBMT0coTmV0d29y aywgIkhhbmRsZSAlcCBkZWxlZ2F0ZSBjb25uZWN0aW9uOiVwIHdpbGxTZW5kUmVxdWVzdDolQCBy ZWRpcmVjdFJlc3BvbnNlOm5vbi1IVFRQIiwgbV9oYW5kbGUsIGNvbm5lY3Rpb24sIFtuZXdSZXF1 ZXN0IGRlc2NyaXB0aW9uXSk7IAogI2VuZGlmCiAKKyAgICBSZXRhaW5QdHI8aWQ+IHByb3RlY3Rv cihzZWxmKTsKKwogICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCks IF57CiAgICAgICAgIGlmICghbV9oYW5kbGUpIHsKICAgICAgICAgICAgIG1fcmVxdWVzdFJlc3Vs dCA9IG51bGxwdHI7CkBAIC0xMzgsNiArMTQwLDggQEAgLSAoQk9PTCljb25uZWN0aW9uU2hvdWxk VXNlQ3JlZGVudGlhbFN0b3JhZ2U6KE5TVVJMQ29ubmVjdGlvbiAqKWNvbm5lY3Rpb24KIAogICAg IExPRyhOZXR3b3JrLCAiSGFuZGxlICVwIGRlbGVnYXRlIGNvbm5lY3Rpb25TaG91bGRVc2VDcmVk ZW50aWFsU3RvcmFnZTolcCIsIG1faGFuZGxlLCBjb25uZWN0aW9uKTsKIAorICAgIFJldGFpblB0 cjxpZD4gcHJvdGVjdG9yKHNlbGYpOworCiAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0 X21haW5fcXVldWUoKSwgXnsKICAgICAgICAgaWYgKCFtX2hhbmRsZSkgewogICAgICAgICAgICAg bV9ib29sUmVzdWx0ID0gTk87CkBAIC0xOTEsNiArMTk1LDggQEAgLSAoQk9PTCljb25uZWN0aW9u OihOU1VSTENvbm5lY3Rpb24gKiljb25uZWN0aW9uIGNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90 ZWN0aW8KIAogICAgIExPRyhOZXR3b3JrLCAiSGFuZGxlICVwIGRlbGVnYXRlIGNvbm5lY3Rpb246 JXAgY2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZTolQDovLyVAOiV1IHJlYWxt OiVAIG1ldGhvZDolQCAlQCVAIiwgbV9oYW5kbGUsIGNvbm5lY3Rpb24sIFtwcm90ZWN0aW9uU3Bh Y2UgcHJvdG9jb2xdLCBbcHJvdGVjdGlvblNwYWNlIGhvc3RdLCBbcHJvdGVjdGlvblNwYWNlIHBv cnRdLCBbcHJvdGVjdGlvblNwYWNlIHJlYWxtXSwgW3Byb3RlY3Rpb25TcGFjZSBhdXRoZW50aWNh dGlvbk1ldGhvZF0sIFtwcm90ZWN0aW9uU3BhY2UgaXNQcm94eV0gPyBAInByb3h5OiIgOiBAIiIs IFtwcm90ZWN0aW9uU3BhY2UgaXNQcm94eV0gPyBbcHJvdGVjdGlvblNwYWNlIHByb3h5VHlwZV0g OiBAIiIpOwogCisgICAgUmV0YWluUHRyPGlkPiBwcm90ZWN0b3Ioc2VsZik7CisKICAgICBkaXNw YXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBeewogICAgICAgICBpZiAoIW1f aGFuZGxlKSB7CiAgICAgICAgICAgICBtX2Jvb2xSZXN1bHQgPSBOTzsKQEAgLTM0MSw2ICszNDcs OCBAQCAtIChOU0NhY2hlZFVSTFJlc3BvbnNlICopY29ubmVjdGlvbjooTlNVUkxDb25uZWN0aW9u ICopY29ubmVjdGlvbiB3aWxsQ2FjaGVSZXNwbwogCiAgICAgTE9HKE5ldHdvcmssICJIYW5kbGUg JXAgZGVsZWdhdGUgY29ubmVjdGlvbjolcCB3aWxsQ2FjaGVSZXNwb25zZTolcCIsIG1faGFuZGxl LCBjb25uZWN0aW9uLCBjYWNoZWRSZXNwb25zZSk7CiAKKyAgICBSZXRhaW5QdHI8aWQ+IHByb3Rl Y3RvcihzZWxmKTsKKwogICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVl KCksIF57CiAgICAgICAgIGlmICghbV9oYW5kbGUgfHwgIW1faGFuZGxlLT5jbGllbnQoKSkgewog ICAgICAgICAgICAgbV9jYWNoZWRSZXNwb25zZVJlc3VsdCA9IG51bGxwdHI7Cg==