113657 2013-03-31 01:35:36 -0700 SVGImage::nativeImageForCurrentFrame() does not work if using DontCopyBackingStore 2023-09-26 02:06:30 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 113420 1 cdumez webkit-unassigned ahmad.saleem792 kkinnunen pdr sabouhallawa schenney senorblanco simon.fraser zimmermann oldest_to_newest 866756 0 cdumez 2013-03-31 01:35:36 -0700 The current implementation of SVGImage::nativeImageForCurrentFrame() creates a temporary ImageBuffer, draw the SVG to it and then returns a pointer to the native image using: ImageBuffer::copyImage(CopyBackingStore)->nativeImageForCurrentFrame(); Using CopyBackingStore here is suboptimal. However, DontCopyBackingStore does not work in this case, at least with Skia implementation. The reason for this is that the underlying SkBitmap pixels do not get copied when creating the new Image but the pixels get freed when the temporary ImageBuffer gets destroyed. Therefore, the returned native image has no valid pixel data. 1059824 1 schenney 2015-01-08 08:36:18 -0800 The Skia limitation is obviously not relevant any more, so maybe this can be fixed for other ports. Even in Chromium, the Skia limitation is no longer a problem. 1979039 2 ahmad.saleem792 2023-09-21 09:33:06 -0700 https://searchfox.org/wubkat/source/Source/WebCore/svg/graphics/SVGImageForContainer.cpp#57 RefPtr<NativeImage> SVGImageForContainer::nativeImageForCurrentFrame() { return m_image->nativeImageForCurrentFrame(); } Do we need to keep this open? 1980107 3 kkinnunen 2023-09-26 02:06:30 -0700 No, this is already fixed by "sinking" the imagebuffer into the native image, which does not incur a copy.