113645 2013-03-30 16:34:41 -0700 [GTK] Configure should verify ICU is installed on mingw 2013-04-08 14:06:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 eric mrobinson commit-queue gustavo mrobinson zan oldest_to_newest 866701 0 eric 2013-03-30 16:34:41 -0700 I was able to pass ./configure on my system without having ICU installed. This lead to a few minutes of head scratching when make failed. AFAIK you can use pkg-config with ICU, just like many of WebKitGTK's other dependencies. 866744 1 zan 2013-03-30 22:02:49 -0700 Currently ICU is checked for using the icu-config, though there's a TODO mentioning switching to using pkg-config for the task. http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4#L109 Can you give a bit more description of what the failure was? I guess it should be fixed one way or the other even if not using pkg-config. 866747 2 mrobinson 2013-03-30 22:55:10 -0700 (In reply to comment #1) > Currently ICU is checked for using the icu-config, though there's a TODO mentioning switching to using pkg-config for the task. > http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4#L109 > > Can you give a bit more description of what the failure was? I guess it should be fixed one way or the other even if not using pkg-config. The debian package for ICU and indeed earlier versions of ICU itself did not install .pc files. The correct thing to do is to check pkg-config for ICU and then fall back to icu-config. I'm not sure what's up with the original bug report. I'm not sure why invoking icu-config doesn't fail when the development packages aren't installed. 866796 3 eric 2013-03-31 12:07:21 -0700 I'm building on mingw. The ./configure script didn't warn me at all about ICU. 866798 4 mrobinson 2013-03-31 12:22:42 -0700 (In reply to comment #3) > I'm building on mingw. The ./configure script didn't warn me at all about ICU. It seems that for mingw and OS X the headers and link arguments are just hard-coded. It should instead call AC_CHECK_HEADERS. 866808 5 eric 2013-03-31 13:03:09 -0700 Thanks for looking into this! There's a few other hurdles building on mingw, but it looks like many of them are already ticketed. 866864 6 195915 mrobinson 2013-03-31 19:18:52 -0700 Created attachment 195915 Patch 866865 7 mrobinson 2013-03-31 19:19:09 -0700 Eric, do you mind verifying that the patch I posted for this issue works? Thanks! 871158 8 195915 commit-queue 2013-04-08 14:06:16 -0700 Comment on attachment 195915 Patch Clearing flags on attachment: 195915 Committed r147951: <http://trac.webkit.org/changeset/147951> 871159 9 commit-queue 2013-04-08 14:06:20 -0700 All reviewed patches have been landed. Closing bug. 195915 2013-03-31 19:18:52 -0700 2013-04-08 14:06:16 -0700 Patch bug-113645-20130331191846.patch text/plain 1308 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L0ZpbmREZXBlbmRlbmNpZXMubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMu bTQKaW5kZXggNTUzNjcxNGJjNDk3MDk4Y2I4ZTY1OWFiYjdmYzc2NDYzMjhhM2MzOS4uYjg1MmYx Mjc1NTRlZTI3OTVlY2RlMWNkZDg2MWZkZDViZTQzZTM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL2F1 dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00CisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvRmluZERl cGVuZGVuY2llcy5tNApAQCAtMTE1LDYgKzExNSw3IEBAIGNhc2UgIiRob3N0IiBpbgogICAgICot Ki1taW5ndyopCiAgICAgICAgIFVOSUNPREVfQ0ZMQUdTPSIiCiAgICAgICAgIFVOSUNPREVfTElC Uz0iLWxpY3VpMThuIC1saWN1dWMiCisgICAgICAgIEFDX0NIRUNLX0hFQURFUlMoW3VuaWNvZGUv dWNoYXIuaF0sIFtdLCBbQUNfTVNHX0VSUk9SKFtDb3VsZCBub3QgZmluZCBJQ1UgaGVhZGVycy5d KV0pCiAgICAgICAgIDs7CiAgICAgKikKICAgICAgICAgQUNfUEFUSF9QUk9HKGljdV9jb25maWcs IGljdS1jb25maWcsIG5vKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IDY0NzZhOTg1MTUwZTYzNzcxOTJiMmUwNDQ0MDAxYjY2ZTlkYTA3NDUuLjFlOGU5MzQ2MWY0ZmNj MDdlNGZiMzhjNTNhZmIyYWY0YzQ1ZjNjYzUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMy0zMSAgTWFydGluIFJvYmluc29uICA8 bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQ29uZmlndXJlIHNob3VsZCB2 ZXJpZnkgSUNVIGlzIGluc3RhbGxlZCBvbiBtaW5ndworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNjQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNp ZXMubTQ6IFdoZW4gZmFsbGluZyBiYWNrIHRvIGhhcmQtY29kZWQgY29tcGlsZXIgZmxhZ3MKKyAg ICAgICAgZm9yIElDVSBhbmQgbWluZ3csIGNoZWNrIHRoYXQgaGVhZGVycyBkbyBleGlzdCBvbiB0 aGUgc3lzdGVtIGFuZCBlcnJvciBvdXQgb3RoZXJ3aXNlLgorCiAyMDEzLTAzLTI5ICBDaGFybGVz IFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gQ2xlYW51cCB0aGUgQ09OVEVYVF9NRU5VUyBpbiBCbGFja0JlcnJ5IHBvcnRpbmcK