113639 2013-03-30 04:58:58 -0700 [Qt] assignToHTMLImageElement no longer exists in Qt5 2013-04-03 04:13:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kristof webkit-unassigned darin hausmann jturcotte webkit.review.bot oldest_to_newest 866605 0 kristof 2013-03-30 04:58:58 -0700 assignToHTMLImageElement no longer exists in Qt5 866606 1 195855 kristof 2013-03-30 04:59:39 -0700 Created attachment 195855 Patch 866607 2 kristof 2013-03-30 05:00:21 -0700 QWebKit allows developers to export QImage objects to Javascript and use Javascript to assign the QImage to an <img/> element. This is documented in http://qt-project.org/doc/qt-5.0/qtwebkit/qtwebkit-bridge.html The problem is that the documentation no longer matches reality. The (Javascript) function was indeed called assignToHTMLImageElement in Qt 4.8, but in Qt5 it's simply 'assignTo'. The responsible code can be found in qtwebkit/Source/WebCore/bridge/qt/qt_pixmapruntime.cpp (QtPixmapRuntime::getClassRef()). I feel very strongly that there was no good reason to change the function name so rather than updating the documentation to reflect the code the code should simply be changed back to expose the old name, or to allow both. It should be trivial to allow both assignTo and assignToHTMLImageElement to be used. See also https://bugreports.qt-project.org/browse/QTBUG-30208 867768 3 195855 jturcotte 2013-04-02 06:09:41 -0700 Comment on attachment 195855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195855&action=review > Source/WebCore/ChangeLog:3 > + assignToHTMLImageElement no longer exists in Qt5 We usually add a [Qt] prefix before the titles and ChangeLog headlines of Qt-specific WebKit bugs. > Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:257 > + { "assignToHTMLImageElement", assignToHTMLImageElement, 0 }, > { "assignTo", assignToHTMLImageElement, 0 }, This was a mistake so I think that we can just replace the "assignTo" entry instead of having two names for the function. 867968 4 kristof 2013-04-02 10:05:37 -0700 I chose to keep the old name so things wouldn't break for anyone using qt-5.0.1 with javascript code using 'assignTo'. I'll submit a new patch to fix both remarks. 867970 5 196172 kristof 2013-04-02 10:09:40 -0700 Created attachment 196172 Patch 868004 6 196172 jturcotte 2013-04-02 10:45:23 -0700 Comment on attachment 196172 Patch Great :) 868012 7 jturcotte 2013-04-02 10:48:13 -0700 (In reply to comment #4) > I chose to keep the old name so things wouldn't break for anyone using qt-5.0.1 with javascript code using 'assignTo'. That also makes sense. Since the documentation wasn't matching normallly they should be as skeptical as you were (that is if they bothered digging in the code) and they shouldn't be surprised that it gets changed back. I'll pick this change into 5.1. 868026 8 196172 webkit.review.bot 2013-04-02 10:55:53 -0700 Comment on attachment 196172 Patch Rejecting attachment 196172 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 196172, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 55>At revision 14075. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://webkit-commit-queue.appspot.com/results/17334471 868080 9 196172 jturcotte 2013-04-02 11:17:00 -0700 Comment on attachment 196172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196172&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please state that this bug is already covered by the tst_hybridPixmap API test (which doesn't seem to be run by the bot for some reason). The OOPS in the "Reviewed by" line will be replaced by the commit queue. 868135 10 196202 kristof 2013-04-02 11:54:31 -0700 Created attachment 196202 Patch 868609 11 196202 webkit.review.bot 2013-04-03 04:13:48 -0700 Comment on attachment 196202 Patch Clearing flags on attachment: 196202 Committed r147539: <http://trac.webkit.org/changeset/147539> 868610 12 webkit.review.bot 2013-04-03 04:13:51 -0700 All reviewed patches have been landed. Closing bug. 195855 2013-03-30 04:59:39 -0700 2013-04-02 10:09:35 -0700 Patch bug-113639-20130330125936.patch text/plain 1360 kristof U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3Mjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTIzOWRmYTYzMzhiZmI2 ZTNlYzZlYzFmOGVkODM0NTljMDhhZWMyMy4uYTA3NGVmYzU1YjFiNWU0ZDQ1MzZiMWNhMWI3N2M0 YTNjZThjZjFlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTMwICBLcmlz dG9mIFByb3Zvc3QgIDxrcmlzdG9mQHNpZ3NlZ3YuYmU+CisKKyAgICAgICAgYXNzaWduVG9IVE1M SW1hZ2VFbGVtZW50IG5vIGxvbmdlciBleGlzdHMgaW4gUXQ1CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM2MzkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAg ICAgICAqIGJyaWRnZS9xdC9xdF9waXhtYXBydW50aW1lLmNwcDoKKyAgICAgICAgKEpTQzo6Qmlu ZGluZ3M6OlF0UGl4bWFwUnVudGltZTo6Z2V0Q2xhc3NSZWYpOgorCiAyMDEzLTAzLTMwICBBbGV4 ZWkgRmlsaXBwb3YgIDxhbHBoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBGb250cyByZWZhY3RvcmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0 L3F0X3BpeG1hcHJ1bnRpbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3BpeG1h cHJ1bnRpbWUuY3BwCmluZGV4IDJiYzVjMmNhY2E0NDdlYzRlODc1NjM2NzM1N2M0ODg4ODg1YjMz NDcuLmQ1N2YxYjUzOTE4ODg4YTE0ZDAxODFjODM4Yjg2M2E2NmVhNzY1YTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9waXhtYXBydW50aW1lLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcGl4bWFwcnVudGltZS5jcHAKQEAgLTI1Myw2ICsyNTMs NyBAQCBKU0NsYXNzUmVmIFF0UGl4bWFwUnVudGltZTo6Z2V0Q2xhc3NSZWYoKQogICAgIH07CiAK ICAgICBzdGF0aWMgY29uc3QgSlNTdGF0aWNGdW5jdGlvbiBzdGF0aWNGdW5jdGlvbnNbXSA9IHsK KyAgICAgICAgeyAiYXNzaWduVG9IVE1MSW1hZ2VFbGVtZW50IiwgYXNzaWduVG9IVE1MSW1hZ2VF bGVtZW50LCAwIH0sCiAgICAgICAgIHsgImFzc2lnblRvIiwgYXNzaWduVG9IVE1MSW1hZ2VFbGVt ZW50LCAwIH0sCiAgICAgICAgIHsgInRvRGF0YVVybCIsIHBpeG1hcFRvRGF0YVVybCwgMCB9LAog ICAgICAgICB7ICJ0b0ltYWdlRGF0YSIsIHBpeG1hcFRvSW1hZ2VEYXRhLCAwIH0sCg== 196172 2013-04-02 10:09:40 -0700 2013-04-02 11:54:27 -0700 Patch bug-113639-20130402190931.patch text/plain 1467 kristof U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZjYjZiZDQ2NDA5ODMz MDJlYThhOTVhNWVhZmNmMDMxNGU3MjhmMS4uNzI2MmQzYTc5ZTRmMDYyOTU5NmI2MTE1YTEzMmU4 MDdjYWY2MzlkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTAyICBLcmlz dG9mIFByb3Zvc3QgIDxrcmlzdG9mQGNvZGVwcm8uYmU+CisKKyAgICAgICAgW1F0XSBhc3NpZ25U b0hUTUxJbWFnZUVsZW1lbnQgbm8gbG9uZ2VyIGV4aXN0cyBpbiBRdDUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzYzOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgor CisgICAgICAgICogYnJpZGdlL3F0L3F0X3BpeG1hcHJ1bnRpbWUuY3BwOgorICAgICAgICAoSlND OjpCaW5kaW5nczo6UXRQaXhtYXBSdW50aW1lOjpnZXRDbGFzc1JlZik6CisKIDIwMTMtMDQtMDIg IEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSFRNTCBwYXJzZXIg c2hvdWxkIGNvbnNpc3RlbnRseSBpbnNwZWN0IHRoZSBuYW1lc3BhY2Ugb2YgZWxlbWVudHMgb24g dGhlIHN0YWNrIG9mIG9wZW4gZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jy aWRnZS9xdC9xdF9waXhtYXBydW50aW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9x dF9waXhtYXBydW50aW1lLmNwcAppbmRleCAyYmM1YzJjYWNhNDQ3ZWM0ZTg3NTYzNjczNTdjNDg4 ODg4NWIzMzQ3Li5mNTA0NjU5Nzk0MWZhNmFmZTVlYTM4NGQ0ZmY0Y2MyZGUxZWI1MzllIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcGl4bWFwcnVudGltZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3BpeG1hcHJ1bnRpbWUuY3BwCkBAIC0yNTMs NyArMjUzLDcgQEAgSlNDbGFzc1JlZiBRdFBpeG1hcFJ1bnRpbWU6OmdldENsYXNzUmVmKCkKICAg ICB9OwogCiAgICAgc3RhdGljIGNvbnN0IEpTU3RhdGljRnVuY3Rpb24gc3RhdGljRnVuY3Rpb25z W10gPSB7Ci0gICAgICAgIHsgImFzc2lnblRvIiwgYXNzaWduVG9IVE1MSW1hZ2VFbGVtZW50LCAw IH0sCisgICAgICAgIHsgImFzc2lnblRvSFRNTEltYWdlRWxlbWVudCIsIGFzc2lnblRvSFRNTElt YWdlRWxlbWVudCwgMCB9LAogICAgICAgICB7ICJ0b0RhdGFVcmwiLCBwaXhtYXBUb0RhdGFVcmws IDAgfSwKICAgICAgICAgeyAidG9JbWFnZURhdGEiLCBwaXhtYXBUb0ltYWdlRGF0YSwgMCB9LAog ICAgICAgICB7ICJ0b1N0cmluZyIsIHBpeG1hcFRvU3RyaW5nLCAwIH0K 196202 2013-04-02 11:54:31 -0700 2013-04-03 04:13:47 -0700 Patch bug-113639-20130402205423.patch text/plain 1518 kristof U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZjYjZiZDQ2NDA5ODMz MDJlYThhOTVhNWVhZmNmMDMxNGU3MjhmMS4uYmRkMzY3NGE4YjMxMmI4YTdmMzgyMmU5ZTlmOTFh Nzg4NDNkM2M0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTAyICBLcmlz dG9mIFByb3Zvc3QgIDxrcmlzdG9mQGNvZGVwcm8uYmU+CisKKyAgICAgICAgW1F0XSBhc3NpZ25U b0hUTUxJbWFnZUVsZW1lbnQgbm8gbG9uZ2VyIGV4aXN0cyBpbiBRdDUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzYzOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogY292ZXJlZCBi eSAuL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvaHlicmlkUGl4bWFwL3Rlc3QuaHRtbAorCisgICAg ICAgICogYnJpZGdlL3F0L3F0X3BpeG1hcHJ1bnRpbWUuY3BwOgorICAgICAgICAoSlNDOjpCaW5k aW5nczo6UXRQaXhtYXBSdW50aW1lOjpnZXRDbGFzc1JlZik6CisKIDIwMTMtMDQtMDIgIEFkYW0g S2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSFRNTCBwYXJzZXIgc2hvdWxk IGNvbnNpc3RlbnRseSBpbnNwZWN0IHRoZSBuYW1lc3BhY2Ugb2YgZWxlbWVudHMgb24gdGhlIHN0 YWNrIG9mIG9wZW4gZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9x dC9xdF9waXhtYXBydW50aW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9waXht YXBydW50aW1lLmNwcAppbmRleCAyYmM1YzJjYWNhNDQ3ZWM0ZTg3NTYzNjczNTdjNDg4ODg4NWIz MzQ3Li5mNTA0NjU5Nzk0MWZhNmFmZTVlYTM4NGQ0ZmY0Y2MyZGUxZWI1MzllIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcGl4bWFwcnVudGltZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3BpeG1hcHJ1bnRpbWUuY3BwCkBAIC0yNTMsNyArMjUz LDcgQEAgSlNDbGFzc1JlZiBRdFBpeG1hcFJ1bnRpbWU6OmdldENsYXNzUmVmKCkKICAgICB9Owog CiAgICAgc3RhdGljIGNvbnN0IEpTU3RhdGljRnVuY3Rpb24gc3RhdGljRnVuY3Rpb25zW10gPSB7 Ci0gICAgICAgIHsgImFzc2lnblRvIiwgYXNzaWduVG9IVE1MSW1hZ2VFbGVtZW50LCAwIH0sCisg ICAgICAgIHsgImFzc2lnblRvSFRNTEltYWdlRWxlbWVudCIsIGFzc2lnblRvSFRNTEltYWdlRWxl bWVudCwgMCB9LAogICAgICAgICB7ICJ0b0RhdGFVcmwiLCBwaXhtYXBUb0RhdGFVcmwsIDAgfSwK ICAgICAgICAgeyAidG9JbWFnZURhdGEiLCBwaXhtYXBUb0ltYWdlRGF0YSwgMCB9LAogICAgICAg ICB7ICJ0b1N0cmluZyIsIHBpeG1hcFRvU3RyaW5nLCAwIH0K