113618 2013-03-29 16:05:53 -0700 [WK2] --no-backing-store build fails because FloatPoint is not declared 2013-04-05 17:47:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 113153 0 bartosh webkit-unassigned ap benjamin commit-queue gyuyoung.kim lucas.de.marchi rakuco simon.fraser webkit.review.bot oldest_to_newest 866451 0 bartosh 2013-03-29 16:05:53 -0700 Here is the error: In file included from /home/ed/git/wk/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.h:32:0, from /home/ed/git/wk/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:27: /home/ed/git/wk/WebKit/Source/WebKit2/WebProcess/Plugins/Plugin.h:270:58: error: `FloatPoint' in namespace `WebCore' does not name a type /home/ed/git/wk/WebKit/Source/WebKit2/WebProcess/Plugins/Plugin.h:270:77: error: ISO C++ forbids declaration of `parameter' with no type [-fpermissive] make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/PluginProcess/PluginControllerProxy.cpp.o] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2 make: *** [all] Error 2 866467 1 195816 bartosh 2013-03-29 16:20:04 -0700 Created attachment 195816 Patch 866972 2 bartosh 2013-04-01 01:05:28 -0700 Reverting back to UNCONFIRMED after reading https://bugs.webkit.org/page.cgi?id=fields.html#status 867018 3 gyuyoung.kim 2013-04-01 03:35:26 -0700 LGTM. You need to get WK2 owner's sign off. 867019 4 gyuyoung.kim 2013-04-01 03:37:11 -0700 BTW, I wonder if this patch is only for EFL port. It looks this patch will be influence on other ports as well. 867027 5 bartosh 2013-04-01 03:59:52 -0700 Changing to WK2 as suggested. 868248 6 195816 ap 2013-04-02 14:31:29 -0700 Comment on attachment 195816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195816&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] --no-tiled-backing-store build fails because FloatPoint is not declared Please fix the prefix here to match the bug title. 869337 7 196522 bartosh 2013-04-04 13:55:27 -0700 Created attachment 196522 Patch Alexey, thank you for review. I'm sorry for the delay. I've missed your comment somehow. Updated the patch according to your suggestion. 870057 8 bartosh 2013-04-05 13:53:27 -0700 Simon, can you please review this really small one? 870068 9 196522 simon.fraser 2013-04-05 14:07:18 -0700 Comment on attachment 196522 Patch Please just forward-declare to avoid extra includes. 870101 10 ap 2013-04-05 15:13:39 -0700 Good point, I don't know what I was thinking when saying r+. 870105 11 196690 bartosh 2013-04-05 15:26:54 -0700 Created attachment 196690 Patch 870106 12 bartosh 2013-04-05 15:28:01 -0700 Updated according to reviewer's suggestion. Please review. 870175 13 196690 commit-queue 2013-04-05 17:47:49 -0700 Comment on attachment 196690 Patch Clearing flags on attachment: 196690 Committed r147823: <http://trac.webkit.org/changeset/147823> 870176 14 commit-queue 2013-04-05 17:47:53 -0700 All reviewed patches have been landed. Closing bug. 195816 2013-03-29 16:20:04 -0700 2013-04-04 13:55:27 -0700 Patch bug-113618-20130330012000.patch text/plain 1173 bartosh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmNiZDFiMjBlNTNkNmNk ZTM2ZjBlZDI2MGEzYWFjODU3NmI4NTcwMS4uYTk1ODg1YjdkYTlhNGMzNzdkM2FjYmE3NWMzNGVk Nzk2ZGE3ZTEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAzLTI5ICBFZCBC YXJ0b3NoICA8YmFydG9zaEBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0gLS1uby10aWxlZC1i YWNraW5nLXN0b3JlIGJ1aWxkIGZhaWxzIGJlY2F1c2UgRmxvYXRQb2ludCBpcyBub3QgZGVjbGFy ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzYx OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5oOiBpbmNsdWRlZCBXZWJDb3JlL0Zsb2F0UG9pbnQuaAor CiAyMDEzLTAzLTI4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZSBsZWFrIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzIG9iamVjdHMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luLmggYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luLmgKaW5kZXggOGRiNDUyZjFjNGVkZTE4 OTJkMGI5ZGVkOGNjMmUyNjllZmIxMWFmMS4uZjhjNjY1NGNiMDdhMDJkMjRkNGY4YTZmMWFlZjll NDk3ZGQxZGZmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW4u aApAQCAtMjcsNiArMjcsNyBAQAogI2RlZmluZSBQbHVnaW5faAogCiAjaW5jbHVkZSA8V2ViQ29y ZS9GaW5kT3B0aW9ucy5oPgorI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRQb2ludC5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvR3JhcGhpY3NMYXllci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvS1VSTC5oPgog I2luY2x1ZGUgPFdlYkNvcmUvU2Nyb2xsVHlwZXMuaD4K 196522 2013-04-04 13:55:27 -0700 2013-04-05 15:26:48 -0700 Patch Patch.113618 text/plain 1188 bartosh Y29tbWl0IGU4ODBkZjA5YWRhNzA4YmQ2ZjlkNWU2MzVkZDQ1NWFkNGEwYmNjZGIKQXV0aG9yOiBF ZCBCYXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KRGF0ZTogICBTYXQgTWFyIDMwIDAxOjMxOjE2 IDIwMTMgKzAyMDAKCiAgICBGaXhlZCAjMTEzNjE4CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDU5M2U0NTYuLjYw YjY3NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMy0yOSAgRWQgQmFydG9z aCAgPGJhcnRvc2hAZ21haWwuY29tPgorCisgICAgICAgIFtXSzJdIC0tbm8tdGlsZWQtYmFja2lu Zy1zdG9yZSBidWlsZCBmYWlscyBiZWNhdXNlIEZsb2F0UG9pbnQgaXMgbm90IGRlY2xhcmVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM2MTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvUGx1Z2lucy9QbHVnaW4uaDogaW5jbHVkZWQgV2ViQ29yZS9GbG9hdFBvaW50LmgKKwogMjAx My0wNC0wMyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3Nl IHNldHRpbmdzIHRvIGRpc2FibGUgcGx1Z2luIHNuYXBzaG90dGluZyBhdXRvc3RhcnQgYW5kIHBy aW1hcnkgZGV0ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvUGx1Z2luLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2lu LmgKaW5kZXggOGRiNDUyZi4uZjhjNjY1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9QbHVnaW4uaApAQCAtMjcsNiArMjcsNyBAQAogI2RlZmluZSBQbHVnaW5faAogCiAj aW5jbHVkZSA8V2ViQ29yZS9GaW5kT3B0aW9ucy5oPgorI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRQ b2ludC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvR3JhcGhpY3NMYXllci5oPgogI2luY2x1ZGUgPFdl YkNvcmUvS1VSTC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2Nyb2xsVHlwZXMuaD4K 196690 2013-04-05 15:26:54 -0700 2013-04-05 17:47:49 -0700 Patch bug-113618-20130406012641.patch text/plain 1170 bartosh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTkzZTQ1NjJkZDM3OGZl MmQ4MjUwY2I5MmVkZDZjMWMxNGJmZjRjNS4uYzVjOTUzMmUxNTFjMjMxMmQ3NzNiMTFiODgzMmZi MTVkNDNjMzk0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAzLTI5ICBFZCBC YXJ0b3NoICA8YmFydG9zaEBnbWFpbC5jb20+CisKKyAgICAgICAgW1dLMl0gLS1uby10aWxlZC1i YWNraW5nLXN0b3JlIGJ1aWxkIGZhaWxzIGJlY2F1c2UgRmxvYXRQb2ludCBpcyBub3QgZGVjbGFy ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzYx OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5oOiBGb3J3YXJkIGRlY2xhcmVkIEZsb2F0UG9pbnQKKwog MjAxMy0wNC0wMyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgRXhw b3NlIHNldHRpbmdzIHRvIGRpc2FibGUgcGx1Z2luIHNuYXBzaG90dGluZyBhdXRvc3RhcnQgYW5k IHByaW1hcnkgZGV0ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvUGx1Z2luLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1 Z2luLmgKaW5kZXggOGRiNDUyZjFjNGVkZTE4OTJkMGI5ZGVkOGNjMmUyNjllZmIxMWFmMS4uMjYz ZTUxZmM1ZjY0M2YzMGVmYzdjYTJlMmIxN2QyNjE0MGJmMWM0NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW4uaApAQCAtNTQsNiArNTQsNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgY2xhc3MgSW50UG9pbnQ7CiAgICAgY2xhc3MgSW50UmVjdDsKICAgICBj bGFzcyBJbnRTaXplOworICAgIGNsYXNzIEZsb2F0UG9pbnQ7CiAgICAgY2xhc3MgU2Nyb2xsYmFy OwogICAgIGNsYXNzIFNoYXJlZEJ1ZmZlcjsKIH0K