113602 2013-03-29 13:29:22 -0700 Objective-C API: Remove -[JSManagedValue managedValueWithValue:owner:] 2013-03-29 14:35:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 866331 0 mhahnenberg 2013-03-29 13:29:22 -0700 We ended up putting the managed value interface on JSVirtualMachine instead. Let's just make sure that API knows how to handle a JSManagedValue. 866332 1 mhahnenberg 2013-03-29 13:29:32 -0700 <rdar://problem/13520749> 866337 2 195788 mhahnenberg 2013-03-29 13:34:19 -0700 Created attachment 195788 Patch 866368 3 195788 ggaren 2013-03-29 14:14:40 -0700 Comment on attachment 195788 Patch r=me 866384 4 195788 webkit.review.bot 2013-03-29 14:35:21 -0700 Comment on attachment 195788 Patch Clearing flags on attachment: 195788 Committed r147252: <http://trac.webkit.org/changeset/147252> 866385 5 webkit.review.bot 2013-03-29 14:35:23 -0700 All reviewed patches have been landed. Closing bug. 195788 2013-03-29 13:34:19 -0700 2013-03-29 14:35:20 -0700 Patch bug-113602-20130329133416.patch text/plain 6152 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3MjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDEzLTAzLTI5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgT2JqZWN0aXZlLUMgQVBJOiBSZW1vdmUgLVtKU01hbmFnZWRWYWx1ZSBtYW5hZ2Vk VmFsdWVXaXRoVmFsdWU6b3duZXI6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEzNjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2luY2Ugd2UgcHV0IHRoZSBwcmltYXJ5IHdheSBvZiBrZWVwaW5nIHRy YWNrIG9mIGV4dGVybmFsIG9iamVjdCBncmFwaHMgKGkuZS4gIm1hbmFnZWQiIHJlZmVyZW5jZXMp IAorICAgICAgICBpbiBKU1ZpcnR1YWxNYWNoaW5lLCB0aGVyZSBpcyBzb21lIG92ZXJsYXAgaW4g dGhlIGZ1bmN0aW9uYWxpdHkgb2YgdGhhdCBpbnRlcmZhY2UgYW5kIEpTTWFuYWdlZFZhbHVlLgor ICAgICAgICBTcGVjaWZpY2FsbHksIHdlIG5vIGxvbmdlciBuZWVkIHRoZSBtZXRob2RzIHRoYXQg aW5jbHVkZSBhbiBvd25lciwgc2luY2Ugb3duZXJzaGlwIGlzIG5vdyB0cmFja2VkIAorICAgICAg ICBieSBKU1ZpcnR1YWxNYWNoaW5lLiBUaGVzZSBKU01hbmFnZWRWYWx1ZXMgd2lsbCBiZWNvbWUg d2VhayBwb2ludGVycyB1bmxlc3MgdGhleSBhcmUgdXNlZCAKKyAgICAgICAgd2l0aCBbSlNWaXJ0 dWFsTWFjaGluZSBhZGRNYW5hZ2VkUmVmZXJlbmNlOndpdGhPd25lcjpdLCBpbiB3aGljaCBjYXNl IHRoZWlyIGxpZmV0aW1lIGlzIHRpZWQgdG8gdGhhdCAKKyAgICAgICAgb2YgdGhlaXIgb3duZXIu CisKKyAgICAgICAgKiBBUEkvSlNNYW5hZ2VkVmFsdWUuaDoKKyAgICAgICAgKiBBUEkvSlNNYW5h Z2VkVmFsdWUubW06CisgICAgICAgICgtW0pTTWFuYWdlZFZhbHVlIGluaXRdKToKKyAgICAgICAg KC1bSlNNYW5hZ2VkVmFsdWUgaW5pdFdpdGhWYWx1ZTpdKToKKyAgICAgICAgKEpTTWFuYWdlZFZh bHVlSGFuZGxlT3duZXI6OmlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKToKKyAgICAgICAgKiBB UEkvSlNWaXJ0dWFsTWFjaGluZS5tbToKKyAgICAgICAgKGdldEludGVybmFsT2JqY09iamVjdCk6 CisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkubW06CisgICAgICAgICgtW1RleHRYWVogc2V0 T25jbGljazpdKToKKyAgICAgICAgKC1bVGV4dFhZWiBkZWFsbG9jXSk6CisKIDIwMTMtMDMtMjkg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlmaWVk IGJ5dGVjb2RlIGdlbmVyYXRpb24gYnkgdW5mb3JraW5nICJjb25kaXRpb24gY29udGV4dCIgY29k ZWdlbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU01hbmFnZWRWYWx1ZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNNYW5hZ2VkVmFsdWUuaAko cmV2aXNpb24gMTQ3MjQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU01hbmFnZWRW YWx1ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNywxMCArMzcsOCBAQCBOU19DTEFTU19BVkFJTEFC TEUoMTBfOSwgTkEpCiBAaW50ZXJmYWNlIEpTTWFuYWdlZFZhbHVlIDogTlNPYmplY3QKIAogKyAo SlNNYW5hZ2VkVmFsdWUgKiltYW5hZ2VkVmFsdWVXaXRoVmFsdWU6KEpTVmFsdWUgKil2YWx1ZTsK LSsgKEpTTWFuYWdlZFZhbHVlICopbWFuYWdlZFZhbHVlV2l0aFZhbHVlOihKU1ZhbHVlICopdmFs dWUgb3duZXI6KGlkKW93bmVyOwogCiAtIChpZClpbml0V2l0aFZhbHVlOihKU1ZhbHVlICopdmFs dWU7Ci0tIChpZClpbml0V2l0aFZhbHVlOihKU1ZhbHVlICopdmFsdWUgb3duZXI6KGlkKW93bmVy OwogCiAtIChKU1ZhbHVlICopdmFsdWU7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvSlNNYW5hZ2VkVmFsdWUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9KU01hbmFnZWRWYWx1ZS5tbQkocmV2aXNpb24gMTQ3MjQzKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9KU01hbmFnZWRWYWx1ZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNDksMTMg KzQ5LDggQEAgc3RhdGljIEpTTWFuYWdlZFZhbHVlSGFuZGxlT3duZXIqIG1hbmFnZQogICAgIHJl dHVybiAmanNNYW5hZ2VkVmFsdWVIYW5kbGVPd25lcjsKIH0KIAotQGludGVyZmFjZSBKU01hbmFn ZWRWYWx1ZSAoSW50ZXJuYWwpCi0tIChpZCl3ZWFrT3duZXI7Ci1AZW5kCi0KIEBpbXBsZW1lbnRh dGlvbiBKU01hbmFnZWRWYWx1ZSB7CiAgICAgSlNDOjpXZWFrPEpTQzo6SlNPYmplY3Q+IG1fdmFs dWU7Ci0gICAgaWQgbV93ZWFrT3duZXI7CiB9CiAKICsgKEpTTWFuYWdlZFZhbHVlICopbWFuYWdl ZFZhbHVlV2l0aFZhbHVlOihKU1ZhbHVlICopdmFsdWUKQEAgLTYzLDIzICs1OCwxMyBAQCArIChK U01hbmFnZWRWYWx1ZSAqKW1hbmFnZWRWYWx1ZVdpdGhWYWx1CiAgICAgcmV0dXJuIFtbW3NlbGYg YWxsb2NdIGluaXRXaXRoVmFsdWU6dmFsdWVdIGF1dG9yZWxlYXNlXTsKIH0KIAotKyAoSlNNYW5h Z2VkVmFsdWUgKiltYW5hZ2VkVmFsdWVXaXRoVmFsdWU6KEpTVmFsdWUgKil2YWx1ZSBvd25lcjoo aWQpb3duZXIKLXsKLSAgICByZXR1cm4gW1tbc2VsZiBhbGxvY10gaW5pdFdpdGhWYWx1ZTp2YWx1 ZSBvd25lcjpvd25lcl0gYXV0b3JlbGVhc2VdOwotfQotCiAtIChpZClpbml0CiB7Ci0gICAgcmV0 dXJuIFtzZWxmIGluaXRXaXRoVmFsdWU6bmlsIG93bmVyOm5pbF07CisgICAgcmV0dXJuIFtzZWxm IGluaXRXaXRoVmFsdWU6bmlsXTsKIH0KIAogLSAoaWQpaW5pdFdpdGhWYWx1ZTooSlNWYWx1ZSAq KXZhbHVlCiB7Ci0gICAgcmV0dXJuIFtzZWxmIGluaXRXaXRoVmFsdWU6dmFsdWUgb3duZXI6bmls XTsKLX0KLQotLSAoaWQpaW5pdFdpdGhWYWx1ZTooSlNWYWx1ZSAqKXZhbHVlIG93bmVyOihpZClv d25lcgotewogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07CiAgICAgaWYgKCFzZWxmKQogICAgICAg ICByZXR1cm4gbmlsOwpAQCAtOTMsMTcgKzc4LDkgQEAgLSAoaWQpaW5pdFdpdGhWYWx1ZTooSlNW YWx1ZSAqKXZhbHVlIG93bgogICAgICAgICBtX3ZhbHVlLnN3YXAod2Vhayk7CiAgICAgfQogCi0g ICAgb2JqY19pbml0V2VhaygmbV93ZWFrT3duZXIsIG93bmVyKTsKLQogICAgIHJldHVybiBzZWxm OwogfQogCi0tICh2b2lkKWRlYWxsb2MKLXsKLSAgICBvYmpjX2Rlc3Ryb3lXZWFrKCZtX3dlYWtP d25lcik7Ci0gICAgW3N1cGVyIGRlYWxsb2NdOwotfQotCiAtIChKU1ZhbHVlICopdmFsdWUKIHsK ICAgICBpZiAoIW1fdmFsdWUpCkBAIC0xMTUsMjIgKzkyLDEwIEBAIC0gKEpTVmFsdWUgKil2YWx1 ZQogCiBAZW5kCiAKLUBpbXBsZW1lbnRhdGlvbiBKU01hbmFnZWRWYWx1ZSAoSW50ZXJuYWwpCi0K LS0gKGlkKXdlYWtPd25lcgotewotICAgIHJldHVybiBvYmpjX2xvYWRXZWFrKCZtX3dlYWtPd25l cik7Ci19Ci0KLUBlbmQKLQogYm9vbCBKU01hbmFnZWRWYWx1ZUhhbmRsZU93bmVyOjppc1JlYWNo YWJsZUZyb21PcGFxdWVSb290cyhKU0M6OkhhbmRsZTxKU0M6OlVua25vd24+LCB2b2lkKiBjb250 ZXh0LCBKU0M6OlNsb3RWaXNpdG9yJiB2aXNpdG9yKQogewogICAgIEpTTWFuYWdlZFZhbHVlICpt YW5hZ2VkVmFsdWUgPSBzdGF0aWNfY2FzdDxKU01hbmFnZWRWYWx1ZSAqPihjb250ZXh0KTsKLSAg ICBpZCB3ZWFrT3duZXIgPSBbbWFuYWdlZFZhbHVlIHdlYWtPd25lcl07Ci0gICAgaWYgKCF3ZWFr T3duZXIpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gdmlzaXRvci5jb250YWlu c09wYXF1ZVJvb3Qod2Vha093bmVyKTsKKyAgICByZXR1cm4gdmlzaXRvci5jb250YWluc09wYXF1 ZVJvb3QobWFuYWdlZFZhbHVlKTsKIH0KIAogI2VuZGlmIC8vIEpTQ19PQkpDX0FQSV9FTkFCTEVE CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lLm1t CShyZXZpc2lvbiAxNDcyNDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVh bE1hY2hpbmUubW0JKHdvcmtpbmcgY29weSkKQEAgLTEyNSwxNCArMTI1LDE5IEBAIC0gKHZvaWQp ZGVhbGxvYwogCiBzdGF0aWMgaWQgZ2V0SW50ZXJuYWxPYmpjT2JqZWN0KGlkIG9iamVjdCkKIHsK LSAgICBpZiAoW29iamVjdCBpc0tpbmRPZkNsYXNzOltKU01hbmFnZWRWYWx1ZSBjbGFzc11dKQot ICAgICAgICBvYmplY3QgPSBbc3RhdGljX2Nhc3Q8SlNNYW5hZ2VkVmFsdWUgKj4ob2JqZWN0KSB2 YWx1ZV07CisgICAgaWYgKFtvYmplY3QgaXNLaW5kT2ZDbGFzczpbSlNNYW5hZ2VkVmFsdWUgY2xh c3NdXSkgeworICAgICAgICBKU1ZhbHVlKiB2YWx1ZSA9IFtzdGF0aWNfY2FzdDxKU01hbmFnZWRW YWx1ZSAqPihvYmplY3QpIHZhbHVlXTsKKyAgICAgICAgaWQgdGVtcCA9IHRyeVVud3JhcE9iamNP YmplY3QoW3ZhbHVlLmNvbnRleHQgZ2xvYmFsQ29udGV4dFJlZl0sIFt2YWx1ZSBKU1ZhbHVlUmVm XSk7CisgICAgICAgIGlmICh0ZW1wKQorICAgICAgICAgICAgcmV0dXJuIHRlbXA7CisgICAgICAg IHJldHVybiBvYmplY3Q7CisgICAgfQogICAgIAogICAgIGlmIChbb2JqZWN0IGlzS2luZE9mQ2xh c3M6W0pTVmFsdWUgY2xhc3NdXSkgewogICAgICAgICBKU1ZhbHVlICp2YWx1ZSA9IHN0YXRpY19j YXN0PEpTVmFsdWUgKj4ob2JqZWN0KTsKICAgICAgICAgb2JqZWN0ID0gdHJ5VW53cmFwT2JqY09i amVjdChbdmFsdWUuY29udGV4dCBnbG9iYWxDb250ZXh0UmVmXSwgW3ZhbHVlIEpTVmFsdWVSZWZd KTsKICAgICB9Ci0gICAgCisKICAgICByZXR1cm4gb2JqZWN0OwogfQogCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCShyZXZpc2lvbiAxNDcyNDMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0JKHdvcmtpbmcgY29w eSkKQEAgLTEzMyw3ICsxMzMsOCBAQCAtICh2b2lkKXNldFdlYWtPbmNsaWNrOihKU1ZhbHVlICop dmFsdWUKIAogLSAodm9pZClzZXRPbmNsaWNrOihKU1ZhbHVlICopdmFsdWUKIHsKLSAgICBtX29u Y2xpY2tIYW5kbGVyID0gW0pTTWFuYWdlZFZhbHVlIG1hbmFnZWRWYWx1ZVdpdGhWYWx1ZTp2YWx1 ZSBvd25lcjpzZWxmXTsKKyAgICBtX29uY2xpY2tIYW5kbGVyID0gW0pTTWFuYWdlZFZhbHVlIG1h bmFnZWRWYWx1ZVdpdGhWYWx1ZTp2YWx1ZV07CisgICAgW3ZhbHVlLmNvbnRleHQudmlydHVhbE1h Y2hpbmUgYWRkTWFuYWdlZFJlZmVyZW5jZTptX29uY2xpY2tIYW5kbGVyIHdpdGhPd25lcjpzZWxm XTsKIH0KIC0gKEpTVmFsdWUgKil3ZWFrT25jbGljawogewpAQCAtMTUxLDYgKzE1MiwxMCBAQCAt ICh2b2lkKWNsaWNrCiAgICAgSlNWYWx1ZSAqZnVuY3Rpb24gPSBbbV9vbmNsaWNrSGFuZGxlciB2 YWx1ZV07CiAgICAgW2Z1bmN0aW9uIGNhbGxXaXRoQXJndW1lbnRzOltOU0FycmF5IGFycmF5XV07 CiB9CistICh2b2lkKWRlYWxsb2MKK3sKKyAgICBbW21fb25jbGlja0hhbmRsZXIgdmFsdWVdLmNv bnRleHQudmlydHVhbE1hY2hpbmUgcmVtb3ZlTWFuYWdlZFJlZmVyZW5jZTptX29uY2xpY2tIYW5k bGVyIHdpdGhPd25lcjpzZWxmXTsKK30KIEBlbmQKIAogQGNsYXNzIFRpbnlET01Ob2RlOwo=