11360 2006-10-19 11:44:41 -0700 editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock 2006-10-26 14:24:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/post-commit-powerpc-mac-os-x/3925/editing/pasteboard/copy-paste-bidi-diffs.txt LayoutTestFailure P2 Normal --- 1 aroben webkit-unassigned ap aroben hyatt justin.garcia mitz timothy oldest_to_newest 51786 0 aroben 2006-10-19 11:44:41 -0700 editing/pasteboard/copy-paste-bidi is sometimes failing with this diff: @@ -49,7 +49,6 @@ text run at (0,0) width 32: "1234" text run at (32,0) width 36 RTL: "\x{5E9}\x{5D3}\x{5D2}\x{5DB}" text run at (68,0) width 4: ":" - RenderBlock (anonymous) at (0,18) size 784x0 RenderBlock {DIV} at (0,18) size 784x18 RenderText {#text} at (712,0) size 72x18 text run at (712,0) width 40 RTL: "\x{5E9}\x{5D3}\x{5D2}\x{5DB}:" 51209 1 mitz 2006-10-22 12:43:24 -0700 I discovered that the undeterminism enters in ReplaceSelectionCommand::removeRedundantStyles(). The iteration order over the NodeStyleMap (in the for loop) isn't the same in every run (despite the order of traversal in the while loop that fills up the map being deterministic, of course). You can probably simply replace the map with two vectors and iterate them simultaneously, to ensure deterministic order. However, you can also consider the current results as indicating two bugs in the rendering code: (a) leftover empty anonymous block(s) and (b) the final render tree depends on the order of operations. 51211 2 aroben 2006-10-22 13:17:41 -0700 Nice detective work, Mitz. I'm CCing hyatt to get his input on this. 51192 3 11185 mitz 2006-10-22 14:09:57 -0700 Created attachment 11185 Test case showing how empty anonymous blocks can be left behind This test shows how the render tree can end up with empty anonymous blocks (in the failing layout test, the span is a temporary "Apple style span"). 49510 4 darin 2006-10-26 14:24:46 -0700 Fixed in r17311. 11185 2006-10-22 14:09:57 -0700 2006-10-22 14:09:57 -0700 Test case showing how empty anonymous blocks can be left behind leftover anonymous block.html text/html 310 mitz PHNjcmlwdD4KICAgIGZ1bmN0aW9uIHJlbW92ZSgpCiAgICB7CiAgICAgICAgdmFyIHQgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgidCIpOwogICAgICAgIHQucGFyZW50Tm9kZS5yZW1vdmVDaGls ZCh0KTsKICAgIH0KPC9zY3JpcHQ+CjxwPgogICAgQWZ0ZXIgY2xpY2tpbmcgdGhlIGJ1dHRvbiB0 aGVyZSB3aWxsIGJlIGFuIGVtcHR5IGFub255bW91cyBibG9jayBpbiB0aGUgcmVuZGVyIHRyZWUu CjwvcD4KPGJ1dHRvbiBvbmNsaWNrPSJyZW1vdmUoKSI+UmVtb3ZlPC9idXR0b24+Cjxocj4KPHNw YW4+PGRpdiBpZD0idCIgLz48L3NwYW4+Cg==