113597 2013-03-29 12:13:56 -0700 [Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs 2013-04-01 22:28:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell abarth alecflett dgrogan webkit.review.bot oldest_to_newest 866291 0 jsbell 2013-03-29 12:13:56 -0700 [Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs 866295 1 195778 jsbell 2013-03-29 12:16:17 -0700 Created attachment 195778 Patch 866296 2 jsbell 2013-03-29 12:16:43 -0700 alecflett@, dgrogan@ - worth it or overkill? 866298 3 195778 dgrogan 2013-03-29 12:21:40 -0700 Comment on attachment 195778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195778&action=review Definitely worth it. > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1359 > + ASSERT(m_factory || WebKit::Platform::current()->unitTestSupport()); Does it make sense to put #else ASSERT(m_factory) Do the other ports have unit tests? 866302 4 195778 jsbell 2013-03-29 12:27:57 -0700 Comment on attachment 195778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195778&action=review >> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1359 >> + ASSERT(m_factory || WebKit::Platform::current()->unitTestSupport()); > > Does it make sense to put > #else > ASSERT(m_factory) > > Do the other ports have unit tests? Not at this level of intrusion. Waffling on the #else - it's valid for now so probably worth adding. 867316 5 196014 jsbell 2013-04-01 13:20:16 -0700 Created attachment 196014 Patch 867317 6 jsbell 2013-04-01 13:20:40 -0700 abarth@ - could you take a look at this? 867544 7 196014 webkit.review.bot 2013-04-01 22:28:02 -0700 Comment on attachment 196014 Patch Clearing flags on attachment: 196014 Committed r147381: <http://trac.webkit.org/changeset/147381> 867545 8 webkit.review.bot 2013-04-01 22:28:05 -0700 All reviewed patches have been landed. Closing bug. 195778 2013-03-29 12:16:17 -0700 2013-04-01 13:20:14 -0700 Patch bug-113597-20130329121613.patch text/plain 2710 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWFkZDM2NjEyZTUyM2E3 MGQ2MTMxZTM5OTE2ZDhlMTM2NGY3MDAzZS4uN2RhZjMyYWY0NDY5MWM4MzI4ZDk1NDY3NmIwMzZi NjQ2NjU3ZjY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTI5ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBJbmRl eGVkREI6IFR1cm4gInNob3VsZCBvbmx5IGJlIHRydWUgaW4gdW5pdCB0ZXN0cyIgY29tbWVudHMg aW50byBBU1NFUlRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTM1OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbiB0aGUgdmVpbiBvZiB3a2J1Zy5jb20vMTExMjMzIGFuZCB3a2J1Zy5jb20vMTEwODIw IGRvbid0IGp1c3QgY29tbWVudCB0aGF0CisgICAgICAgIHNvbWUgY29uZGl0aW9uIGlzIHRydWUg b25seSBpbiB1bml0IHRlc3RzIC0gQVNTRVJUIHRoYXQgQ2hyb21pdW0ncyB1bml0VGVzdFN1cHBv cnQoKQorICAgICAgICBpcyBub24tbnVsbCB0byBjYXRjaCBlcnJvcnMgZHVyaW5nIGRldmVsb3Bt ZW50LgorCisgICAgICAgIEV4ZXJjaXNlZCBieSBDaHJvbWl1bSdzIHdlYmtpdF91bml0X3Rlc3Rz LgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpvcGVuQ29ubmVj dGlvbik6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpjbG9zZSk6 CisKIDIwMTMtMDMtMjggIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vvay5vaEBjb2xsYWJvcmEuY29t PgogCiAgICAgICAgIFtHVEtdW0FDXSBBbmltYXRpbmcgbGF5ZXIgZGlzYXBwZWFycyB3aGlsZSBy dW5uaW5nIHdpdGggY2x1dHRlciBiYWNrZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCmluZGV4IDgw NWM4ZjY1MTQ2ODYzYTczMGI2NjljMDYwYmNiNDJkYTZmOWRiMWQuLjRlOGQ2YWU3NzVmY2YwNzRj NzlhZGZkMzYyOGRmMDg5YWIwYjdhYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCkBAIC0zOCw2 ICszOCw5IEBACiAjaW5jbHVkZSAiSURCVHJhbnNhY3Rpb25CYWNrZW5kSW1wbC5oIgogI2luY2x1 ZGUgIklEQlRyYW5zYWN0aW9uQ29vcmRpbmF0b3IuaCIKICNpbmNsdWRlICJTaGFyZWRCdWZmZXIu aCIKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyNpbmNsdWRlIDxwdWJsaWMvUGxhdGZvcm0uaD4K KyNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTEyMTEsNiArMTIxNCw5IEBAIHZv aWQgSURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6b3BlbkNvbm5lY3Rpb24oUGFzc1JlZlB0cjxJREJD YWxsYmFja3M+IHBycENhbGxiYWNrCiAKICAgICBpZiAodmVyc2lvbiA9PSBJREJEYXRhYmFzZU1l dGFkYXRhOjpEZWZhdWx0SW50VmVyc2lvbikgewogICAgICAgICAvLyBGb3IgdW5pdCB0ZXN0cyBv bmx5IC0gc2tpcCB1cGdyYWRlIHN0ZXBzLiBDYWxsaW5nIGZyb20gc2NyaXB0IHdpdGggRGVmYXVs dEludFZlcnNpb24gdGhyb3dzIGV4Y2VwdGlvbi4KKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAg ICAgICAgQVNTRVJUKFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+dW5pdFRlc3RTdXBwb3J0 KCkpOworI2VuZGlmCiAgICAgICAgIEFTU0VSVChpc05ld0RhdGFiYXNlKTsKICAgICAgICAgbV9k YXRhYmFzZUNhbGxiYWNrc1NldC5hZGQoZGF0YWJhc2VDYWxsYmFja3MpOwogICAgICAgICBjYWxs YmFja3MtPm9uU3VjY2Vzcyh0aGlzLCB0aGlzLT5tZXRhZGF0YSgpKTsKQEAgLTEzNDcsNyArMTM1 MywxMSBAQCB2b2lkIElEQkRhdGFiYXNlQmFja2VuZEltcGw6OmNsb3NlKFBhc3NSZWZQdHI8SURC RGF0YWJhc2VDYWxsYmFja3M+IHBycENhbGxiYWNrcwogICAgICAgICBBU1NFUlQobV90cmFuc2Fj dGlvbnMuaXNFbXB0eSgpKTsKIAogICAgICAgICBtX2JhY2tpbmdTdG9yZS5jbGVhcigpOwotICAg ICAgICAvLyBUaGlzIGNoZWNrIHNob3VsZCBvbmx5IGJlIGZhbHNlIGluIHRlc3RzLgorCisgICAg ICAgIC8vIFRoaXMgY2hlY2sgc2hvdWxkIG9ubHkgYmUgZmFsc2UgaW4gdW5pdCB0ZXN0cy4KKyNp ZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICAgICAgQVNTRVJUKG1fZmFjdG9yeSB8fCBXZWJLaXQ6 OlBsYXRmb3JtOjpjdXJyZW50KCktPnVuaXRUZXN0U3VwcG9ydCgpKTsKKyNlbmRpZgogICAgICAg ICBpZiAobV9mYWN0b3J5KQogICAgICAgICAgICAgbV9mYWN0b3J5LT5yZW1vdmVJREJEYXRhYmFz ZUJhY2tlbmQobV9pZGVudGlmaWVyKTsKICAgICB9Cg== 196014 2013-04-01 13:20:16 -0700 2013-04-01 22:28:02 -0700 Patch bug-113597-20130401132008.patch text/plain 2772 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRmMGViMDg3MmYxNjBl Mjk0YjVhMDgxY2FmODZiM2Y0NjkwMzFmYi4uZmIxOTllYjY4ZGI5NjQ2NTFlMGVmMGQ1OTA5ODhk MmYyMmYzZjdlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTI5ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBJbmRl eGVkREI6IFR1cm4gInNob3VsZCBvbmx5IGJlIHRydWUgaW4gdW5pdCB0ZXN0cyIgY29tbWVudHMg aW50byBBU1NFUlRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTM1OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbiB0aGUgdmVpbiBvZiB3a2J1Zy5jb20vMTExMjMzIGFuZCB3a2J1Zy5jb20vMTEwODIw IGRvbid0IGp1c3QgY29tbWVudCB0aGF0CisgICAgICAgIHNvbWUgY29uZGl0aW9uIGlzIHRydWUg b25seSBpbiB1bml0IHRlc3RzIC0gQVNTRVJUIHRoYXQgQ2hyb21pdW0ncyB1bml0VGVzdFN1cHBv cnQoKQorICAgICAgICBpcyBub24tbnVsbCB0byBjYXRjaCBlcnJvcnMgZHVyaW5nIGRldmVsb3Bt ZW50LgorCisgICAgICAgIEV4ZXJjaXNlZCBieSBDaHJvbWl1bSdzIHdlYmtpdF91bml0X3Rlc3Rz LgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpvcGVuQ29ubmVj dGlvbik6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpjbG9zZSk6 CisKIDIwMTMtMDQtMDEgIEtvamkgSXNoaWkgIDxrb2ppaXNoaUBnbWFpbC5jb20+CiAKICAgICAg ICAgQVNTRVJUSU9OIEZBSUxFRDogbV9wdXJnZVByZXZlbnRDb3VudCB3aGVuIGNsaWNraW5nIHRl eHQgd2l0aCBlbXBoYXNpcyBtYXJrcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcAppbmRleCA0NTczYzlj ZWJiM2JkMDJlNTg4ODkyMzhmZjA0YmQ5OGFmYWUyOGM0Li5lNTgxNzdjMDc2NzUxYWE4OGU4Nzcw YWUyODE0ZDBjNzA2ZmY0ZTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2lu ZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcApAQCAtMzgsNiArMzgs OSBAQAogI2luY2x1ZGUgIklEQlRyYW5zYWN0aW9uQmFja2VuZEltcGwuaCIKICNpbmNsdWRlICJJ REJUcmFuc2FjdGlvbkNvb3JkaW5hdG9yLmgiCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVyLmgiCisj aWYgUExBVEZPUk0oQ0hST01JVU0pCisjaW5jbHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CisjZW5k aWYKICNpbmNsdWRlIDx3dGYvVGVtcG9yYXJ5Q2hhbmdlLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKQEAgLTEyMTIsNiArMTIxNSw5IEBAIHZvaWQgSURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6b3Bl bkNvbm5lY3Rpb24oUGFzc1JlZlB0cjxJREJDYWxsYmFja3M+IHBycENhbGxiYWNrCiAKICAgICBp ZiAodmVyc2lvbiA9PSBJREJEYXRhYmFzZU1ldGFkYXRhOjpEZWZhdWx0SW50VmVyc2lvbikgewog ICAgICAgICAvLyBGb3IgdW5pdCB0ZXN0cyBvbmx5IC0gc2tpcCB1cGdyYWRlIHN0ZXBzLiBDYWxs aW5nIGZyb20gc2NyaXB0IHdpdGggRGVmYXVsdEludFZlcnNpb24gdGhyb3dzIGV4Y2VwdGlvbi4K KyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICAgICAgQVNTRVJUKFdlYktpdDo6UGxhdGZvcm06 OmN1cnJlbnQoKS0+dW5pdFRlc3RTdXBwb3J0KCkpOworI2VuZGlmCiAgICAgICAgIEFTU0VSVChp c05ld0RhdGFiYXNlKTsKICAgICAgICAgbV9kYXRhYmFzZUNhbGxiYWNrc1NldC5hZGQoZGF0YWJh c2VDYWxsYmFja3MpOwogICAgICAgICBjYWxsYmFja3MtPm9uU3VjY2Vzcyh0aGlzLCB0aGlzLT5t ZXRhZGF0YSgpKTsKQEAgLTEzNDgsNyArMTM1NCwxMyBAQCB2b2lkIElEQkRhdGFiYXNlQmFja2Vu ZEltcGw6OmNsb3NlKFBhc3NSZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFja3M+IHBycENhbGxiYWNr cwogICAgICAgICBBU1NFUlQobV90cmFuc2FjdGlvbnMuaXNFbXB0eSgpKTsKIAogICAgICAgICBt X2JhY2tpbmdTdG9yZS5jbGVhcigpOwotICAgICAgICAvLyBUaGlzIGNoZWNrIHNob3VsZCBvbmx5 IGJlIGZhbHNlIGluIHRlc3RzLgorCisgICAgICAgIC8vIFRoaXMgY2hlY2sgc2hvdWxkIG9ubHkg YmUgZmFsc2UgaW4gdW5pdCB0ZXN0cy4KKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICAgICAg QVNTRVJUKG1fZmFjdG9yeSB8fCBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPnVuaXRUZXN0 U3VwcG9ydCgpKTsKKyNlbHNlCisgICAgICAgIEFTU0VSVChtX2ZhY3RvcnkpOworI2VuZGlmCiAg ICAgICAgIGlmIChtX2ZhY3RvcnkpCiAgICAgICAgICAgICBtX2ZhY3RvcnktPnJlbW92ZUlEQkRh dGFiYXNlQmFja2VuZChtX2lkZW50aWZpZXIpOwogICAgIH0K