113577 2013-03-29 06:44:13 -0700 Snapshotted plugins must be able to restart on appropriate mouseup events 2013-03-29 12:37:11 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino eric esprehn+autocc ojan.autocc thorton webkit.review.bot oldest_to_newest 866129 0 dino 2013-03-29 06:44:13 -0700 If a page is preventing the default on a mouse down, a snapshotted plugin can never restart. We need to bypass the normal event processing mechanism in this case and notice when we see a mouseup that was associated with a mousedown in the snapshot. This won't actually trigger any user-side code, just restart the snapshotted plugin. <rdar://problem/13256956> 866131 1 195737 dino 2013-03-29 06:49:42 -0700 Created attachment 195737 Patch 866306 2 dino 2013-03-29 12:37:11 -0700 Committed r147240: <http://trac.webkit.org/changeset/147240> 195737 2013-03-29 06:49:42 -0700 2013-03-29 11:42:39 -0700 Patch bug-113577-20130330004938.patch text/plain 4175 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVkMmY3NzliMDIwYzE5 OWEzMzJjZjEwOTNhOWMwODM1ZjNlOGY5OC4uNTMzM2VlMWRiOTE1NmE3YTZmZjFlYTBiZmIxZDhk ZWVhYjY5ODEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTI5ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTbmFwc2hvdHRlZCBwbHVnaW5z IG11c3QgYmUgYWJsZSB0byByZXN0YXJ0IG9uIGFwcHJvcHJpYXRlIG1vdXNldXAgZXZlbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM1NzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgcGFn ZSBjb250ZW50IHByZXZlbnRzIHRoZSBkZWZhdWx0IGJlaGF2aW91ciBvZiBhIG1vdXNlZG93biBl dmVudCwgdGhlbiBhIHNuYXBzaG90dGVkCisgICAgICAgIHBsdWdpbiB3b3VsZCBuZXZlciByZWNl aXZlIGEgY2xpY2sgZXZlbnQsIGFuZCB0aHVzIGJlIHVuYWJsZSB0byByZXN0YXJ0LiBXZSBoYXZl IHRvIGFsc28KKyAgICAgICAgbG9vayBmb3IgYSBtb3VzZXVwIHRoYXQgaGFwcGVucyB3aXRoIGFu IGFzc29jaWF0ZWQgbW91c2Vkb3duLCBhbmQgdHJpZ2dlciByZXN0YXJ0LiBUaGlzCisgICAgICAg IHdvbid0IGNhbGwgYW55IHBhZ2UgY29kZSAtIGl0J3MganVzdCBiZWhpbmQgdGhlIHNjZW5lcy4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJTbmFwc2hvdHRlZFBsdWdJbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJTbmFwc2hvdHRlZFBsdWdJbjo6UmVuZGVyU25hcHNob3R0ZWRQ bHVnSW4pOiBJbml0aWFsaXplIG5ldyBtZW1iZXIgdmFyaWFibGUuCisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJTbmFwc2hvdHRlZFBsdWdJbjo6aGFuZGxlRXZlbnQpOiBUcmFjayB0aGUgc3RhdGUg b2YgbW91c2Vkb3duIGFuZCB1cCBwYWlycywgYW5kIHJlc3RhcnQKKyAgICAgICAgICAgIGlmIHlv dSBzZWUgYW4gYXBwcm9wcmlhdGUgbW91c2V1cC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy U25hcHNob3R0ZWRQbHVnSW4uaDogTmV3IG1lbWJlciB2YXJpYWJsZSB0byB0cmFjayBtb3VzZSBz dGF0ZS4KKwogMjAxMy0wMy0yOCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSAxIHNlY29uZCBzbGVlcCBvbiB3aW5kb3dz IGZyb20gcHJlcHJvY2Vzc29yLnBtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclNuYXBzaG90dGVkUGx1Z0luLmNwcAppbmRleCA2MDFkZDE2ZmMwYjVlOThhYTVkOWQx NzIxMGUyNWU0Y2YxNGQwZmMxLi5lYzI5YjE3ZThlNDRkZDJiOTlhMjAwMDU5MmRmYTRmYmJjMzU0 YzVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU25hcHNob3R0 ZWRQbHVnSW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTbmFwc2hv dHRlZFBsdWdJbi5jcHAKQEAgLTQ2LDYgKzQ2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogUmVu ZGVyU25hcHNob3R0ZWRQbHVnSW46OlJlbmRlclNuYXBzaG90dGVkUGx1Z0luKEhUTUxQbHVnSW5J bWFnZUVsZW1lbnQqIGVsZW1lbnQpCiAgICAgOiBSZW5kZXJFbWJlZGRlZE9iamVjdChlbGVtZW50 KQogICAgICwgbV9zbmFwc2hvdFJlc291cmNlKFJlbmRlckltYWdlUmVzb3VyY2U6OmNyZWF0ZSgp KQorICAgICwgbV9pc1BvdGVudGlhbE1vdXNlQWN0aXZhdGlvbihmYWxzZSkKIHsKICAgICBtX3Nu YXBzaG90UmVzb3VyY2UtPmluaXRpYWxpemUodGhpcyk7CiB9CkBAIC0xNTQsMTcgKzE1NSwyNyBA QCB2b2lkIFJlbmRlclNuYXBzaG90dGVkUGx1Z0luOjpoYW5kbGVFdmVudChFdmVudCogZXZlbnQp CiAKICAgICBNb3VzZUV2ZW50KiBtb3VzZUV2ZW50ID0gc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+ KGV2ZW50KTsKIAotICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5jbGlja0V2 ZW50KSB7Ci0gICAgICAgIGlmIChtb3VzZUV2ZW50LT5idXR0b24oKSAhPSBMZWZ0QnV0dG9uKQot ICAgICAgICAgICAgcmV0dXJuOworICAgIC8vIElmIHdlJ3JlIGEgc25hcHNob3R0ZWQgcGx1Z2lu LCB3ZSB3YW50IHRvIG1ha2Ugc3VyZSB3ZSBhY3RpdmF0ZSBvbgorICAgIC8vIGNsaWNrcyBldmVu IGlmIHRoZSBwYWdlIGlzIHByZXZlbnRpbmcgb3VyIGRlZmF1bHQgYmVoYXZpb3VyLiBPdGhlcndp c2UKKyAgICAvLyB3ZSBjYW4gbmV2ZXIgcmVzdGFydC4gT25lIHdlIGRvIHJlc3RhcnQsIHRoZW4g dGhlIHBhZ2Ugd2lsbCBoYXBwaWx5CisgICAgLy8gYmxvY2sgdGhlIG5ldyBwbHVnaW4gaW4gdGhl IG5vcm1hbCByZW5kZXJlci4gQWxsIHRoaXMgbWVhbnMgd2UgaGF2ZSB0bworICAgIC8vIGJlIG9u IHRoZSBsb29rb3V0IGZvciBhIG1vdXNldXAgZXZlbnQgdGhhdCBjb21lcyBhZnRlciBhIG1vdXNl ZG93bgorICAgIC8vIGV2ZW50LiBUaGUgY29kZSBiZWxvdyBpcyBub3QgY29tcGxldGVseSBmb29s cHJvb2YsIGJ1dCB0aGUgd29yc3QgdGhhdAorICAgIC8vIGNvdWxkIGhhcHBlbiBpcyB0aGF0IGEg c25hcHNob3R0ZWQgcGx1Z2luIHJlc3RhcnRzLgogCisgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0g ZXZlbnROYW1lcygpLm1vdXNlb3V0RXZlbnQpCisgICAgICAgIG1faXNQb3RlbnRpYWxNb3VzZUFj dGl2YXRpb24gPSBmYWxzZTsKKworICAgIGlmIChtb3VzZUV2ZW50LT5idXR0b24oKSAhPSBMZWZ0 QnV0dG9uKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVu dE5hbWVzKCkuY2xpY2tFdmVudCB8fCAobV9pc1BvdGVudGlhbE1vdXNlQWN0aXZhdGlvbiAmJiBl dmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZXVwRXZlbnQpKSB7CisgICAgICAgIG1f aXNQb3RlbnRpYWxNb3VzZUFjdGl2YXRpb24gPSBmYWxzZTsKICAgICAgICAgcGx1Z0luSW1hZ2VF bGVtZW50KCktPnNldERpc3BsYXlTdGF0ZShIVE1MUGx1Z0luRWxlbWVudDo6UmVzdGFydGluZ1dp dGhQZW5kaW5nTW91c2VDbGljayk7CiAgICAgICAgIHBsdWdJbkltYWdlRWxlbWVudCgpLT51c2Vy RGlkQ2xpY2tTbmFwc2hvdChtb3VzZUV2ZW50KTsKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRI YW5kbGVkKCk7CiAgICAgfSBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5t b3VzZWRvd25FdmVudCkgewotICAgICAgICBpZiAobW91c2VFdmVudC0+YnV0dG9uKCkgIT0gTGVm dEJ1dHRvbikKLSAgICAgICAgICAgIHJldHVybjsKLQorICAgICAgICBtX2lzUG90ZW50aWFsTW91 c2VBY3RpdmF0aW9uID0gdHJ1ZTsKICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7 CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNu YXBzaG90dGVkUGx1Z0luLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU25hcHNo b3R0ZWRQbHVnSW4uaAppbmRleCA4NTRhMjhhZmM3ZjEzZWY3ODY3Y2IzYzVmMzQ5MjEwOTM5N2U5 NGY1Li5iZWFlMjU2ZmFjNjc1ZTA0MjViNDcyZjMyZTdlODg1MDUwMGIzOTFkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uaApAQCAt NTgsNiArNTgsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKSBPVkVSUklE RTsKIAogICAgIE93blB0cjxSZW5kZXJJbWFnZVJlc291cmNlPiBtX3NuYXBzaG90UmVzb3VyY2U7 CisgICAgYm9vbCBtX2lzUG90ZW50aWFsTW91c2VBY3RpdmF0aW9uOwogfTsKIAogaW5saW5lIFJl bmRlclNuYXBzaG90dGVkUGx1Z0luKiB0b1JlbmRlclNuYXBzaG90dGVkUGx1Z0luKFJlbmRlck9i amVjdCogb2JqZWN0KQo=