113574 2013-03-29 06:09:26 -0700 [Qt] Qt 5.1 related stuff add to the webkitpy. 2013-10-02 21:28:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114171 1 kadam webkit-unassigned abarth allan.jensen dpranke eric galpeter ossy webkit.review.bot zarvai oldest_to_newest 866113 0 kadam 2013-03-29 06:09:26 -0700 Prepare webkitpy for the arrival of Qt 5.1. The patch is coming soon. 866118 1 195734 kadam 2013-03-29 06:20:13 -0700 Created attachment 195734 proposed patch 866120 2 195734 ossy 2013-03-29 06:23:58 -0700 Comment on attachment 195734 proposed patch cq- now, I'm not sure if it is the best direction now. Because with this change we should duplicate all 5.0 expectations for 5.1. But maybe 5.1 should fallback 5.0. I'm not sure which one would be better, it needs more investigation. 866608 3 allan.jensen 2013-03-30 05:24:27 -0700 Hopefully we can remove 5.0 expectations shortly after converting to 5.1. Once we have all starting developing based on Qt 5.1 then there is little reason to keep the 5.0 baseline around. 869151 4 allan.jensen 2013-04-04 07:15:32 -0700 The way we are going to introduce the big rebaselines in 'qt 5.0', means that the best way forward would be to make qt 5.1 default to qt 5.0, or perhaps make a qt5 dir they both default to. 927782 5 allan.jensen 2013-09-11 08:12:35 -0700 The issues in this patch was solved in two other bugs which restructured the Qt layout results. 935681 6 195734 andersca 2013-10-02 21:28:33 -0700 Comment on attachment 195734 proposed patch Qt has been removed, clearing review flags. 195734 2013-03-29 06:20:13 -0700 2013-10-02 21:28:33 -0700 proposed patch addedqt51.patch text/plain 4206 kadam ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMGI4 MjZkLi5mN2MwMmJkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDMtMjkgIMOBZMOhbSBLYWxsYWkgIDxrYWRh bUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBRdCA1LjEgcmVsYXRlZCBzdHVmZiBh ZGQgdG8gdGhlIHdlYmtpdHB5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTEzNTc0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weToK KyAgICAgICAgKFF0UG9ydC5xdF92ZXJzaW9uKToKKyAgICAgICAgKFF0UG9ydC5fc2VhcmNoX3Bh dGhzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3Vu aXR0ZXN0LnB5OgorICAgICAgICAoUXRQb3J0VGVzdCk6CisgICAgICAgIChRdFBvcnRUZXN0Ll9x dF92ZXJzaW9uKToKKwogMjAxMy0wMy0yOCAgTWluZyBYaWUgIDxteGllQGJsYWNrYmVycnkuY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBDb21taXR0ZXIgRW1haWwgVXBkYXRlcwpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXggNDg0MDcy NS4uYmFmZWM3ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3F0LnB5CkBAIC0xMTQsNyArMTE0LDcgQEAgY2xhc3MgUXRQb3J0KFBvcnQpOgogICAgICAg ICAgICAgICAgICAgICB2ZXJzaW9uID0gbWF0Y2guZ3JvdXAoJ3ZlcnNpb24nKQogICAgICAgICAg ICAgICAgICAgICBicmVhawogICAgICAgICBleGNlcHQgT1NFcnJvcjoKLSAgICAgICAgICAgIHZl cnNpb24gPSAnNC44JworICAgICAgICAgICAgdmVyc2lvbiA9ICc1LjAnCiAgICAgICAgIHJldHVy biB2ZXJzaW9uCiAKICAgICBkZWYgX3NlYXJjaF9wYXRocyhzZWxmKToKQEAgLTEyOSwxNCArMTI5 LDE0IEBAIGNsYXNzIFF0UG9ydChQb3J0KToKICAgICAgICAgIyAgICAgICAgICAgICAgIHF0CiAg ICAgICAgIHNlYXJjaF9wYXRocyA9IFtdCiAgICAgICAgIHZlcnNpb24gPSBzZWxmLnF0X3ZlcnNp b24oKQotICAgICAgICBpZiAnNS4wJyBpbiB2ZXJzaW9uOgotICAgICAgICAgICAgaWYgc2VsZi5n ZXRfb3B0aW9uKCd3ZWJraXRfdGVzdF9ydW5uZXInKToKLSAgICAgICAgICAgICAgICBpZiBzZWxm Lm9wZXJhdGluZ19zeXN0ZW0oKSA9PSAnbWFjJzoKLSAgICAgICAgICAgICAgICAgICAgc2VhcmNo X3BhdGhzLmFwcGVuZCgncXQtNS4wLW1hYy13azInKQotICAgICAgICAgICAgICAgIHNlYXJjaF9w YXRocy5hcHBlbmQoJ3F0LTUuMC13azInKQotICAgICAgICAgICAgZWxzZToKLSAgICAgICAgICAg ICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC01LjAtd2sxJykKLSAgICAgICAgc2VhcmNoX3Bh dGhzLmFwcGVuZCgncXQtNS4wJykKKworICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ3dlYmtp dF90ZXN0X3J1bm5lcicpOgorICAgICAgICAgICAgaWYgc2VsZi5vcGVyYXRpbmdfc3lzdGVtKCkg PT0gJ21hYyc6CisgICAgICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtJXMtbWFj LXdrMicgJSAodmVyc2lvbikpCisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC0l cy13azInICUgKHZlcnNpb24pKQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgc2VhcmNoX3Bh dGhzLmFwcGVuZCgncXQtJXMtd2sxJyAlICh2ZXJzaW9uKSkKKyAgICAgICAgc2VhcmNoX3BhdGhz LmFwcGVuZCgncXQtJXMnICUgKHZlcnNpb24pKQogCiAgICAgICAgIHNlYXJjaF9wYXRocy5hcHBl bmQoc2VsZi5wb3J0X25hbWUgKyAnLScgKyBzZWxmLm9wZXJhdGluZ19zeXN0ZW0oKSkKICAgICAg ICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLnBvcnRfbmFtZSkKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0LnB5CmluZGV4 IDJhZGZiYzEuLmUxNjU1MzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9xdF91bml0dGVzdC5weQpAQCAtNDksNiArNDksMTQgQEAgY2xh c3MgUXRQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgICAgIHsnc2Vh cmNoX3BhdGhzJzpbJ3F0LTUuMC13azEnLCAncXQtNS4wJywgJ3F0LW1hYycsICdxdCddLCAnb3Nf bmFtZSc6J21hYycsICd1c2Vfd2Via2l0Mic6RmFsc2UsICdxdF92ZXJzaW9uJzonNS4wJ30sCiAg ICAgICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0LTUuMC13azEnLCAncXQtNS4wJywgJ3F0LXdpbics ICdxdCddLCAnb3NfbmFtZSc6J3dpbicsICd1c2Vfd2Via2l0Mic6RmFsc2UsICdxdF92ZXJzaW9u JzonNS4wJ30sCiAgICAgICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0LTUuMC13azEnLCAncXQtNS4w JywgJ3F0LWxpbnV4JywgJ3F0J10sICdvc19uYW1lJzonbGludXgnLCAndXNlX3dlYmtpdDInOkZh bHNlLCAncXRfdmVyc2lvbic6JzUuMCd9LAorCisgICAgICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0 LTUuMS1tYWMtd2syJywgJ3F0LTUuMS13azInLCAncXQtNS4xJywgJ3F0LW1hYycsICdxdCddLCAn b3NfbmFtZSc6J21hYycsICd1c2Vfd2Via2l0Mic6VHJ1ZSwgJ3F0X3ZlcnNpb24nOic1LjEnfSwK KyAgICAgICAgeydzZWFyY2hfcGF0aHMnOlsncXQtNS4xLXdrMicsICdxdC01LjEnLCAncXQtd2lu JywgJ3F0J10sICdvc19uYW1lJzond2luJywgJ3VzZV93ZWJraXQyJzpUcnVlLCAncXRfdmVyc2lv bic6JzUuMSd9LAorICAgICAgICB7J3NlYXJjaF9wYXRocyc6WydxdC01LjEtd2syJywgJ3F0LTUu MScsICdxdC1saW51eCcsICdxdCddLCAnb3NfbmFtZSc6J2xpbnV4JywgJ3VzZV93ZWJraXQyJzpU cnVlLCAncXRfdmVyc2lvbic6JzUuMSd9LAorCisgICAgICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0 LTUuMS13azEnLCAncXQtNS4xJywgJ3F0LW1hYycsICdxdCddLCAnb3NfbmFtZSc6J21hYycsICd1 c2Vfd2Via2l0Mic6RmFsc2UsICdxdF92ZXJzaW9uJzonNS4xJ30sCisgICAgICAgIHsnc2VhcmNo X3BhdGhzJzpbJ3F0LTUuMS13azEnLCAncXQtNS4xJywgJ3F0LXdpbicsICdxdCddLCAnb3NfbmFt ZSc6J3dpbicsICd1c2Vfd2Via2l0Mic6RmFsc2UsICdxdF92ZXJzaW9uJzonNS4xJ30sCisgICAg ICAgIHsnc2VhcmNoX3BhdGhzJzpbJ3F0LTUuMS13azEnLCAncXQtNS4xJywgJ3F0LWxpbnV4Jywg J3F0J10sICdvc19uYW1lJzonbGludXgnLCAndXNlX3dlYmtpdDInOkZhbHNlLCAncXRfdmVyc2lv bic6JzUuMSd9LAogICAgIF0KIAogICAgIGRlZiBfYXNzZXJ0X3NlYXJjaF9wYXRoKHNlbGYsIHNl YXJjaF9wYXRocywgb3NfbmFtZSwgdXNlX3dlYmtpdDI9RmFsc2UsIHF0X3ZlcnNpb249JzUuMCcp OgpAQCAtNzcsNiArODUsOCBAQCBjbGFzcyBRdFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRl c3RDYXNlKToKICAgICBkZWYgX3F0X3ZlcnNpb24oc2VsZiwgcXRfdmVyc2lvbik6CiAgICAgICAg IGlmIHF0X3ZlcnNpb24gaW4gJzUuMCc6CiAgICAgICAgICAgICByZXR1cm4gJ1FNYWtlIHZlcnNp b24gMi4wMWFcblVzaW5nIFF0IHZlcnNpb24gNS4wLjAgaW4gL3Vzci9sb2NhbC9Ucm9sbHRlY2gv UXQtNS4wLjAvbGliJworICAgICAgICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuICdRTWFrZSB2 ZXJzaW9uIDMuMFxuVXNpbmcgUXQgdmVyc2lvbiA1LjEgaW4gL3Vzci9sb2NhbC9Ucm9sbHRlY2gv UXQtNS4xL2xpYicKIAogICAgIGRlZiB0ZXN0X2Jhc2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpOgog ICAgICAgICBmb3IgY2FzZSBpbiBzZWxmLnNlYXJjaF9wYXRoc19jYXNlczoK