113536 2013-03-28 14:15:54 -0700 Remove unnecessary 1 second sleep on windows from preprocessor.pm 2013-03-28 14:29:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth haraken japhet webkit.review.bot oldest_to_newest 865783 0 jamesr 2013-03-28 14:15:54 -0700 Remove unnecessary 1 second sleep on windows from preprocessor.pm 865784 1 195639 jamesr 2013-03-28 14:16:17 -0700 Created attachment 195639 Patch 865786 2 195639 eric 2013-03-28 14:19:00 -0700 Comment on attachment 195639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review > Source/WebCore/ChangeLog:8 > + > + This regressed in 146661 You should comment that this made the build 12 minutes longer. :) Sell it, man! :p 865790 3 jamesr 2013-03-28 14:19:33 -0700 (In reply to comment #2) > (From update of attachment 195639 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review > > > Source/WebCore/ChangeLog:8 > > + > > + This regressed in 146661 > > You should comment that this made the build 12 minutes longer. :) Sell it, man! :p I'm actually not 100% sure on that point - do we run the preprocessors in parallel? 865792 4 195639 haraken 2013-03-28 14:21:45 -0700 Comment on attachment 195639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review >>> Source/WebCore/ChangeLog:8 >>> + This regressed in 146661 >> >> You should comment that this made the build 12 minutes longer. :) Sell it, man! :p > > I'm actually not 100% sure on that point - do we run the preprocessors in parallel? What was this sleep for? I couldn't find a rationale from a ChangeLog of r146661 (http://trac.webkit.org/changeset/146661). 865803 5 jamesr 2013-03-28 14:29:49 -0700 Committed r147157: <http://trac.webkit.org/changeset/147157> 195639 2013-03-28 14:16:17 -0700 2013-03-28 14:29:57 -0700 Patch bug-113536-20130328141615.patch text/plain 1417 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjljZDI0MTkxODkyYzIy MGQ3ZmI5NTU4N2YyMmZiMGI2NjYyNTU4Zi4uYTdmZmNlN2U0ZWFlMjQzNTg1ODY4MTJiYzFhOGUw YWVjN2E1YjhkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTI4ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVubmVj ZXNzYXJ5IDEgc2Vjb25kIHNsZWVwIG9uIHdpbmRvd3MgZnJvbSBwcmVwcm9jZXNzb3IucG0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMzUzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcmVncmVz c2VkIGluIDE0NjY2MQorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3Iu cG06CisgICAgICAgIChhcHBseVByZXByb2Nlc3Nvcik6CisKIDIwMTMtMDMtMjggIEFybmF1ZCBS ZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBleGNlcHRp b25zIGFyZSBub3QgY2hlY2tlZCBhZnRlciB0b0ludDMyIGNhbGxzIGluIGJpbmRpbmdzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0g Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQppbmRleCAx MGQ2ZmFjOWVjNDRjNmI5ZGUzMjQ5YWQ1MDllZjFiZWEzMmRhZDI5Li43MGFiMDU1ZjhmMzgwNzZi OGY0YWFhYWU3YTBlN2EyMzU4YjVhMTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQpAQCAtODUsNyArODUsNyBAQCBzdWIgYXBwbHlQcmVw cm9jZXNzb3IKICAgICAgICAgICAgICAgICAjIG5hbWUgaXNuJ3QgbmVlZGxlc3NseSBlY2hvZWQu CiAgICAgICAgICAgICAgICAgdXNlIFN5bWJvbCAnZ2Vuc3ltJzsgbXkgJGVyciA9IGdlbnN5bTsK ICAgICAgICAgICAgICAgICAkcGlkID0gb3BlbjMoXCpQUF9JTiwgXCpQUF9PVVQsICRlcnIsIHNw bGl0KCcgJywgJHByZXByb2Nlc3NvciksIEBhcmdzLCBAbWFjcm9zLCAkZmlsZU5hbWUpOwotICAg ICAgICAgICAgICAgIHNsZWVwIDE7CisgICAgICAgICAgICAgICAgMTsKICAgICAgICAgICAgIH0g b3IgZG8gewogICAgICAgICAgICAgICAgIHNsZWVwIDE7CiAgICAgICAgICAgICB9Cg==