113528 2013-03-28 12:33:06 -0700 REGRESSION: run-perf-tests --profiler= seems to have broken 2015-01-23 06:56:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric svillar ap commit-queue darin dbates glenn leviw ojan pdr rniwa simon.fraser svillar oldest_to_newest 865706 0 eric 2013-03-28 12:33:06 -0700 REGRESSION: run-perf-tests --profiler seems to have broken --profiler=pprof used to let you use the pprof profiler on linux for example. Now it no longer seems to work. Something (probably my fault) broke at some point in recent memory. 1063652 1 svillar 2015-01-23 04:06:32 -0800 Not sure if the failure is the same than the one reported by Eric but it definitely does not work in GTK (and I guess that also in EFL) when using jhbuild to build. The problem is that "perf --record" is never called because we just wrap the command with jhbuild-run. 1063653 2 245221 svillar 2015-01-23 04:11:07 -0800 Created attachment 245221 Patch 1063661 3 245224 svillar 2015-01-23 05:39:05 -0800 Created attachment 245224 Patch Now with unit test 1063671 4 245224 dbates 2015-01-23 06:45:04 -0800 Comment on attachment 245224 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245224&action=review > Tools/Scripts/webkitpy/port/driver.py:228 > + wrapper = [] Maybe a better name for this variable would be wrapper_arguments. 1063672 5 svillar 2015-01-23 06:48:53 -0800 (In reply to comment #4) > Comment on attachment 245224 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245224&action=review > > > Tools/Scripts/webkitpy/port/driver.py:228 > > + wrapper = [] > > Maybe a better name for this variable would be wrapper_arguments. Okidoki 1063674 6 svillar 2015-01-23 06:56:57 -0800 Committed r179008: <http://trac.webkit.org/changeset/179008> 245221 2015-01-23 04:11:07 -0800 2015-01-23 05:38:57 -0800 Patch bug-113528-20150123131114.patch text/plain 1911 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4OTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTYwZDk1MGFkYWZkMDE0YjRlMmY4MmM3ZjQ1YjhlZTZi Y2RlYjczZC4uMDE1NThjYmYzNGRjMTk3NjMxNDFjMjNkMGIyMzI4MTNjZjRlNzk5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE1LTAxLTIzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IHJ1bi1wZXJmLXRlc3RzIC0tcHJvZmlsZXI9IHNlZW1z IHRvIGhhdmUgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTM1MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0ICJwZXJmIC0tcmVjb3JkIiAob3IgdGhlIGVxdWl2 YWxlbnQgY2FsbCBmb3IKKyAgICAgICAgb3RoZXIgcHJvZmlsZXJzKSBpcyBuZXZlciBjYWxsZWQg d2hlbmV2ZXIgdGhlcmUgaXMgYSB3cmFwcGVyCisgICAgICAgIG9wdGlvbiBpbiB0aGUgcG9ydC4g V2Ugc2hvdWxkIGluamVjdCB0aGUgcHJvZmlsZXIgY2FsbCBmaXJzdAorICAgICAgICAoc2hvdWxk IGl0IGV4aXN0cykgYW5kIHRoZW4gdXNlIHRoZSBwb3J0IHdyYXBwZXIuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLl9jb21tYW5k X3dyYXBwZXIpOgorCiAyMDE1LTAxLTIxICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFw cGxlLmNvbT4KIAogICAgICAgICBUZWFjaCBidWlsZC53ZWJraXQub3JnIGFib3V0IGJvdDMwOCBh bmQgYm90MzA5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZl ci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKaW5kZXggNGU1OGVi ODc5Y2Y2MjA3ZmU1ZDU2OWIxZjNmZjc4OTE2OTk3YjU4Yi4uOGRlZDM2NWMwZGQwZDI3NjE2ZDRl NTAxNjE2NWRkZmIyN2I4YjNlZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L2RyaXZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5 CkBAIC0yMjUsMTEgKzIyNSwxMiBAQCBjbGFzcyBEcml2ZXIob2JqZWN0KToKIAogICAgIGRlZiBf Y29tbWFuZF93cmFwcGVyKHNlbGYpOgogICAgICAgICAjIEhvb2sgZm9yIGluamVjdGluZyB2YWxn cmluZCBvciBvdGhlciBydW50aW1lIGluc3RydW1lbnRhdGlvbiwgdXNlZCBieSBlLmcuIHRvb2xz L3ZhbGdyaW5kL3ZhbGdyaW5kX3Rlc3RzLnB5LgotICAgICAgICBpZiBzZWxmLl9wb3J0LmdldF9v cHRpb24oJ3dyYXBwZXInKToKLSAgICAgICAgICAgIHJldHVybiBzaGxleC5zcGxpdChzZWxmLl9w b3J0LmdldF9vcHRpb24oJ3dyYXBwZXInKSkKKyAgICAgICAgd3JhcHBlciA9IFtdCiAgICAgICAg IGlmIHNlbGYuX3Byb2ZpbGVyOgotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3Byb2ZpbGVyLndy YXBwZXJfYXJndW1lbnRzKCkKLSAgICAgICAgcmV0dXJuIFtdCisgICAgICAgICAgICB3cmFwcGVy ID0gc2VsZi5fcHJvZmlsZXIud3JhcHBlcl9hcmd1bWVudHMoKQorICAgICAgICBpZiBzZWxmLl9w b3J0LmdldF9vcHRpb24oJ3dyYXBwZXInKToKKyAgICAgICAgICAgIHJldHVybiBzaGxleC5zcGxp dChzZWxmLl9wb3J0LmdldF9vcHRpb24oJ3dyYXBwZXInKSkgKyB3cmFwcGVyCisgICAgICAgIHJl dHVybiB3cmFwcGVyCiAKICAgICBIVFRQX0RJUiA9ICJodHRwL3Rlc3RzLyIKICAgICBIVFRQX0xP Q0FMX0RJUiA9ICJodHRwL3Rlc3RzL2xvY2FsLyIK 245224 2015-01-23 05:39:05 -0800 2015-01-23 06:43:29 -0800 Patch bug-113528-20150123143912.patch text/plain 3131 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4OTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTYwZDk1MGFkYWZkMDE0YjRlMmY4MmM3ZjQ1YjhlZTZi Y2RlYjczZC4uNzMzMWE0MGU4MWM3YzZjZTZkN2YwMGJiYzc2ZTJmYTQyZDk0ZjRjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE1LTAxLTIzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IHJ1bi1wZXJmLXRlc3RzIC0tcHJvZmlsZXI9IHNlZW1z IHRvIGhhdmUgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTM1MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0ICJwZXJmIC0tcmVjb3JkIiAob3IgdGhlIGVxdWl2 YWxlbnQgY2FsbCBmb3IKKyAgICAgICAgb3RoZXIgcHJvZmlsZXJzKSBpcyBuZXZlciBjYWxsZWQg d2hlbmV2ZXIgdGhlcmUgaXMgYSB3cmFwcGVyCisgICAgICAgIG9wdGlvbiBpbiB0aGUgcG9ydC4g V2Ugc2hvdWxkIGluamVjdCB0aGUgcHJvZmlsZXIgY2FsbCBmaXJzdAorICAgICAgICAoc2hvdWxk IGl0IGV4aXN0cykgYW5kIHRoZW4gdXNlIHRoZSBwb3J0IHdyYXBwZXIuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLl9jb21tYW5k X3dyYXBwZXIpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXJfdW5pdHRl c3QucHk6CisgICAgICAgIChEcml2ZXJUZXN0LnRlc3RfcHJvZmlsZXJfYW5kX3dyYXBwZXIpOiBO ZXcgdW5pdCB0ZXN0LgorCiAyMDE1LTAxLTIxICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVy QGFwcGxlLmNvbT4KIAogICAgICAgICBUZWFjaCBidWlsZC53ZWJraXQub3JnIGFib3V0IGJvdDMw OCBhbmQgYm90MzA5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Ry aXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKaW5kZXggNGU1 OGViODc5Y2Y2MjA3ZmU1ZDU2OWIxZjNmZjc4OTE2OTk3YjU4Yi4uOGRlZDM2NWMwZGQwZDI3NjE2 ZDRlNTAxNjE2NWRkZmIyN2I4YjNlZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2RyaXZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVy LnB5CkBAIC0yMjUsMTEgKzIyNSwxMiBAQCBjbGFzcyBEcml2ZXIob2JqZWN0KToKIAogICAgIGRl ZiBfY29tbWFuZF93cmFwcGVyKHNlbGYpOgogICAgICAgICAjIEhvb2sgZm9yIGluamVjdGluZyB2 YWxncmluZCBvciBvdGhlciBydW50aW1lIGluc3RydW1lbnRhdGlvbiwgdXNlZCBieSBlLmcuIHRv b2xzL3ZhbGdyaW5kL3ZhbGdyaW5kX3Rlc3RzLnB5LgotICAgICAgICBpZiBzZWxmLl9wb3J0Lmdl dF9vcHRpb24oJ3dyYXBwZXInKToKLSAgICAgICAgICAgIHJldHVybiBzaGxleC5zcGxpdChzZWxm Ll9wb3J0LmdldF9vcHRpb24oJ3dyYXBwZXInKSkKKyAgICAgICAgd3JhcHBlciA9IFtdCiAgICAg ICAgIGlmIHNlbGYuX3Byb2ZpbGVyOgotICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3Byb2ZpbGVy LndyYXBwZXJfYXJndW1lbnRzKCkKLSAgICAgICAgcmV0dXJuIFtdCisgICAgICAgICAgICB3cmFw cGVyID0gc2VsZi5fcHJvZmlsZXIud3JhcHBlcl9hcmd1bWVudHMoKQorICAgICAgICBpZiBzZWxm Ll9wb3J0LmdldF9vcHRpb24oJ3dyYXBwZXInKToKKyAgICAgICAgICAgIHJldHVybiBzaGxleC5z cGxpdChzZWxmLl9wb3J0LmdldF9vcHRpb24oJ3dyYXBwZXInKSkgKyB3cmFwcGVyCisgICAgICAg IHJldHVybiB3cmFwcGVyCiAKICAgICBIVFRQX0RJUiA9ICJodHRwL3Rlc3RzLyIKICAgICBIVFRQ X0xPQ0FMX0RJUiA9ICJodHRwL3Rlc3RzL2xvY2FsLyIKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9kcml2ZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvZHJpdmVyX3VuaXR0ZXN0LnB5CmluZGV4IDMyMWIxMDM2N2Y0YjBhNTlmOWZlZmQw OWExODgwMzcxYTg2NDkxYjQuLjJhMjE4MzczMjMxOTkwMjYwYjVlZTY0MTkwZDVmOTNjYmE0MDlj MGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXJfdW5pdHRl c3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlcl91bml0dGVzdC5w eQpAQCAtMTAzLDYgKzEwMywxMCBAQCBjbGFzcyBEcml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKICAgICAgICAgZHJpdmVyID0gRHJpdmVyKHNlbGYubWFrZV9wb3J0KE1vY2tTeXN0ZW1Ib3N0 KG9zX25hbWU9J2xpbnV4JyksIE1vY2tPcHRpb25zKHByb2ZpbGU9VHJ1ZSwgcHJvZmlsZXI9J3Bl cmYnKSksIE5vbmUsIEZhbHNlKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGRyaXZlci5fY29t bWFuZF93cmFwcGVyKCksIFsncGVyZicsICdyZWNvcmQnLCAnLWcnLCAnLS1vdXRwdXQnLCAnL21v Y2stYnVpbGQvbGF5b3V0LXRlc3QtcmVzdWx0cy90ZXN0LmRhdGEnXSkKIAorICAgIGRlZiB0ZXN0 X3Byb2ZpbGVyX2FuZF93cmFwcGVyKHNlbGYpOgorICAgICAgICBkcml2ZXIgPSBEcml2ZXIoc2Vs Zi5tYWtlX3BvcnQoTW9ja1N5c3RlbUhvc3Qob3NfbmFtZT0nbGludXgnKSwgTW9ja09wdGlvbnMo cHJvZmlsZT1UcnVlLCBwcm9maWxlcj0ncGVyZicsIHdyYXBwZXI9J3ZhbGdyaW5kJykpLCBOb25l LCBGYWxzZSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChkcml2ZXIuX2NvbW1hbmRfd3JhcHBl cigpLCBbJ3ZhbGdyaW5kJywgJ3BlcmYnLCAncmVjb3JkJywgJy1nJywgJy0tb3V0cHV0JywgJy9t b2NrLWJ1aWxkL2xheW91dC10ZXN0LXJlc3VsdHMvdGVzdC5kYXRhJ10pCisKICAgICBkZWYgdGVz dF90ZXN0X3RvX3VyaShzZWxmKToKICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KCkKICAg ICAgICAgZHJpdmVyID0gRHJpdmVyKHBvcnQsIE5vbmUsIHBpeGVsX3Rlc3RzPUZhbHNlKQo=