113524 2013-03-28 11:55:36 -0700 [Chromium] Don't create SolidColorLayer for full transparent background 2013-03-28 16:07:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu cc-bugs enne jamesr webkit.review.bot oldest_to_newest 865673 0 wangxianzhu 2013-03-28 11:55:36 -0700 http://trac.webkit.org/changeset/146826 which enabled solidColorLayer on Chromium breaks Chromium-Android. I'd like to disable it temporarily until we support it for impl-side-painting. 865695 1 jamesr 2013-03-28 12:16:01 -0700 It's supported today, isn't it? 865702 2 jamesr 2013-03-28 12:23:30 -0700 http://trac.webkit.org/export/147140/trunk/LayoutTests/compositing/geometry/fixed-in-composited.html triggers the solid color layer path and works fine with impl-side painting on my linux box. 865825 3 wangxianzhu 2013-03-28 14:50:54 -0700 The scrolling problem on Android is caused by a full-transparent SolidColorLayer over a scrollable layer. 865834 4 jamesr 2013-03-28 14:57:10 -0700 Ah, I see - is the fully transparent layer eating input events or something like that? If something's fully transparent then we definitely shouldn't make any layer at all. 865835 5 wangxianzhu 2013-03-28 14:59:44 -0700 (In reply to comment #4) > Ah, I see - is the fully transparent layer eating input events or something like that? Yes. The compositor selects the transparent solid color layer instead of the scrollable layer under it as the potentially scrolling layer. 865855 6 195658 wangxianzhu 2013-03-28 15:29:18 -0700 Created attachment 195658 Patch 865859 7 195658 jamesr 2013-03-28 15:37:11 -0700 Comment on attachment 195658 Patch Nice. 865882 8 195658 webkit.review.bot 2013-03-28 16:06:59 -0700 Comment on attachment 195658 Patch Clearing flags on attachment: 195658 Committed r147178: <http://trac.webkit.org/changeset/147178> 865883 9 webkit.review.bot 2013-03-28 16:07:03 -0700 All reviewed patches have been landed. Closing bug. 195658 2013-03-28 15:29:18 -0700 2013-03-28 16:06:59 -0700 Patch bug-113524-20130328152915.patch text/plain 3341 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FjZWI1MWE5OWYzZmEx MTg4NmZhNjY5ODU5YTBhM2M2N2FiZjEyZS4uN2IyZGJlYTgyZjYxNjU4YTU2MTM3MGNkZTUyZjQ1 YzJmM2Q5NTdjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTI4ICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVt XSBEb24ndCBjcmVhdGUgU29saWRDb2xvckxheWVyIGZvciBmdWxsIHRyYW5zcGFyZW50IGJhY2tn cm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MzUyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IEdyYXBoaWNzTGF5ZXJDaHJvbWl1bVRlc3Quc2V0Q29udGVudHNUb1NvbGlkQ29sb3IKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1 bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2hyb21pdW06OnNldENvbnRl bnRzVG9Tb2xpZENvbG9yKToKKwogMjAxMy0wMy0yNyAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBUZXh0IHRyYWNrIG1lbnUgaXRlbXMgc29t ZXRpbWVzIGxhYmVsZWQgaW5jb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MTA1YjVkMGQ1ZDEzNzg0ZTIyZDdhMjAwOTFiN2I4MTJmMDNkYjU4MS4uMTkzZjg5NWU1ODdkZTY3 ZWYxZDQ2MDJjYjcyZjQxZDMyNWIzOTlhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMy0wMy0yOCAgWGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRG9uJ3QgY3JlYXRlIFNvbGlkQ29sb3JM YXllciBmb3IgZnVsbCB0cmFuc3BhcmVudCBiYWNrZ3JvdW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM1MjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL0dyYXBoaWNzTGF5ZXJDaHJvbWl1 bVRlc3QuY3BwOgorICAgICAgICAoR3JhcGhpY3NMYXllckNocm9taXVtVGVzdDo6c2V0Q29udGVu dHNUb1NvbGlkQ29sb3IpOgorCiAyMDEzLTAzLTI3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZW5hbWUgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6cmVhZE9u bHkgdG8gaXNSZWFkT25seQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKaW5k ZXggMjAzZDE5ZWU4NGU4ZDVkMzk3NjNlYTM0MmE2NzA3ZTIyZTBkODU3YS4uNzk0ZWM3MzQyZDRh YWYxYzJmZWNjMmIzNmJjYWM1MDk1ZmQxYjJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVy Q2hyb21pdW0uY3BwCkBAIC01MjQsNyArNTI0LDcgQEAgdm9pZCBHcmFwaGljc0xheWVyQ2hyb21p dW06OnNldENvbnRlbnRzVG9Tb2xpZENvbG9yKGNvbnN0IENvbG9yJiBjb2xvcikKIAogICAgIG1f Y29udGVudHNTb2xpZENvbG9yID0gY29sb3I7CiAKLSAgICBpZiAoY29sb3IuaXNWYWxpZCgpKSB7 CisgICAgaWYgKGNvbG9yLmlzVmFsaWQoKSAmJiBjb2xvci5hbHBoYSgpKSB7CiAgICAgICAgIGlm ICghbV9jb250ZW50c1NvbGlkQ29sb3JMYXllcikgewogICAgICAgICAgICAgbV9jb250ZW50c1Nv bGlkQ29sb3JMYXllciA9IGFkb3B0UHRyKFBsYXRmb3JtOjpjdXJyZW50KCktPmNvbXBvc2l0b3JT dXBwb3J0KCktPmNyZWF0ZVNvbGlkQ29sb3JMYXllcigpKTsKICAgICAgICAgICAgIHJlZ2lzdGVy Q29udGVudHNMYXllcihtX2NvbnRlbnRzU29saWRDb2xvckxheWVyLT5sYXllcigpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvR3JhcGhpY3NMYXllckNocm9taXVt VGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0dyYXBoaWNzTGF5ZXJDaHJv bWl1bVRlc3QuY3BwCmluZGV4IGQ3NDA1YzYyZWM5MWZlOWI1ZjNjOTA3ODU0YTdhNDU2MjBjODI3 NGYuLjBiOGQyZDQwZjE3NWU5ZDk1ZTE0YzlhMjA1NzZjYjc0ZjAxMWNjMjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvR3JhcGhpY3NMYXllckNocm9taXVtVGVzdC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9HcmFwaGljc0xheWVyQ2hyb21p dW1UZXN0LmNwcApAQCAtMTQ3LDQgKzE0NywxNiBAQCBURVNUX0YoR3JhcGhpY3NMYXllckNocm9t aXVtVGVzdCwgYXBwbHlTY3JvbGxUb1Njcm9sbGFibGVBcmVhKQogICAgIEVYUEVDVF9FUShzY3Jv bGxQb3NpdGlvbiwgV2ViUG9pbnQoc2Nyb2xsYWJsZUFyZWEuc2Nyb2xsUG9zaXRpb24oKSkpOwog fQogCitURVNUX0YoR3JhcGhpY3NMYXllckNocm9taXVtVGVzdCwgc2V0Q29udGVudHNUb1NvbGlk Q29sb3IpCit7CisgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c1RvU29saWRDb2xvcihD b2xvcjo6dHJhbnNwYXJlbnQpOworICAgIEVYUEVDVF9GQUxTRShtX2dyYXBoaWNzTGF5ZXItPmNv bnRlbnRzTGF5ZXIoKSk7CisKKyAgICBtX2dyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9Tb2xp ZENvbG9yKENvbG9yOjp3aGl0ZSk7CisgICAgRVhQRUNUX1RSVUUobV9ncmFwaGljc0xheWVyLT5j b250ZW50c0xheWVyKCkpOworCisgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c1RvU29s aWRDb2xvcihDb2xvcigpKTsKKyAgICBFWFBFQ1RfRkFMU0UobV9ncmFwaGljc0xheWVyLT5jb250 ZW50c0xheWVyKCkpOworfQorCiB9IC8vIG5hbWVzcGFjZQo=