113490 2013-03-28 01:30:13 -0700 Use String.trim() in editing/selection/move-vertically-with-paddings-borders.html test 2013-03-28 12:51:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110487 0 csaavedra webkit-unassigned rniwa webkit.review.bot oldest_to_newest 865245 0 csaavedra 2013-03-28 01:30:13 -0700 Use String.trim() in editing/selection/move-vertically-with-paddings-borders.html test 865246 1 195499 csaavedra 2013-03-28 01:31:21 -0700 Created attachment 195499 Patch 865650 2 195499 rniwa 2013-03-28 11:25:32 -0700 Comment on attachment 195499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195499&action=review > LayoutTests/editing/selection/move-vertically-with-paddings-borders.html:39 > - return window.getSelection().toString(); > + return window.getSelection().toString().trim(); window. is not needed here. 865690 3 195615 csaavedra 2013-03-28 12:14:53 -0700 Created attachment 195615 Patch for landing 865724 4 195615 webkit.review.bot 2013-03-28 12:51:01 -0700 Comment on attachment 195615 Patch for landing Clearing flags on attachment: 195615 Committed r147143: <http://trac.webkit.org/changeset/147143> 865725 5 webkit.review.bot 2013-03-28 12:51:04 -0700 All reviewed patches have been landed. Closing bug. 195499 2013-03-28 01:31:21 -0700 2013-03-28 12:14:47 -0700 Patch bug-113490-20130328103118.patch text/plain 1665 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MDY4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWVkN2Y0MmM2NmU4ODRmMzRlYjg2 NjY1YWI0MWNjNzgwOGU5NTcyMS4uODc5MDZlOTM5ZmM3YjI5ZDgzNjRjZmJhYTUyMWQwYjM1NjJl MjA2NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTI4ICBDbGF1ZGlvIFNhYXZlZHJh ICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgVXNlIFN0cmluZy50cmltKCkgaW4g ZWRpdGluZy9zZWxlY3Rpb24vbW92ZS12ZXJ0aWNhbGx5LXdpdGgtcGFkZGluZ3MtYm9yZGVycy5o dG1sIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZWRpdGluZy9zZWxlY3Rpb24vbW92ZS12ZXJ0aWNhbGx5LXdpdGgtcGFkZGluZ3MtYm9yZGVy cy5odG1sOgorICAgICAgICAoc2VsZWN0V29yZCk6IFVzZSBTdHJpbmcudHJpbSgpIHRvIGRyb3Ag dHJhaWxpbmcgd2hpdGVzcGFjZXMgdGhhdAorICAgICAgICBtaWdodCBiZSBhZGRlZCBkZXBlbmRp bmcgb24gdGhlIGVkaXRpbmcgYmVoYXZpb3IuIFNlZSByZWxhdGVkIGJ1ZworICAgICAgICAxMTA0 ODcuCisKIDIwMTMtMDMtMjcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3Jn PiAKIAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBUZXN0IEV4cGVj dGF0aW9ucyB1cGRhdGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlv bi9tb3ZlLXZlcnRpY2FsbHktd2l0aC1wYWRkaW5ncy1ib3JkZXJzLmh0bWwgYi9MYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXZlcnRpY2FsbHktd2l0aC1wYWRkaW5ncy1ib3JkZXJz Lmh0bWwKaW5kZXggNDM2MzU3OTM0YjgwYjc5MGNiYTI1MWQxNWIzMjFiOTgwNzc1YjhhNi4uNWM0 OTkzMDBiZGUxNGM5ZjI1ZTYzNjYzMjFjNWI2YzNhY2FlOGQ2ZSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS12ZXJ0aWNhbGx5LXdpdGgtcGFkZGluZ3MtYm9y ZGVycy5odG1sCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdmVydGlj YWxseS13aXRoLXBhZGRpbmdzLWJvcmRlcnMuaHRtbApAQCAtMzYsNyArMzYsNyBAQCBmdW5jdGlv biBtb3ZlVG9NaWRkbGVPZldvcmQobm9kZSwgd29yZCkgewogZnVuY3Rpb24gc2VsZWN0V29yZCgp IHsKICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCdtb3ZlJywgJ2JhY2t3YXJkJywg J3dvcmQnKTsKICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCdleHRlbmQnLCAnZm9y d2FyZCcsICd3b3JkJyk7Ci0gICAgcmV0dXJuIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS50b1N0cmlu ZygpOworICAgIHJldHVybiB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKS50cmltKCk7 CiB9CiAKIGZ1bmN0aW9uIG1vdmVWZXJ0aWNhbGx5QW5kVmVyaWZ5KG5vZGUsIGRpcmVjdGlvbiwg ZnJvbSwgdG8pIHsK 195615 2013-03-28 12:14:53 -0700 2013-03-28 12:51:01 -0700 Patch for landing bug-113490-20130328211450.patch text/plain 1656 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MDY4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWVkN2Y0MmM2NmU4ODRmMzRlYjg2 NjY1YWI0MWNjNzgwOGU5NTcyMS4uMzdjNTM5NzZmZGM2MDJjZTY2NDJkMjk3Y2UzYjcxMDMzMzM1 MGZkZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTI4ICBDbGF1ZGlvIFNhYXZlZHJh ICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgVXNlIFN0cmluZy50cmltKCkgaW4g ZWRpdGluZy9zZWxlY3Rpb24vbW92ZS12ZXJ0aWNhbGx5LXdpdGgtcGFkZGluZ3MtYm9yZGVycy5o dG1sIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMzQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICAq IGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtdmVydGljYWxseS13aXRoLXBhZGRpbmdzLWJvcmRlcnMu aHRtbDoKKyAgICAgICAgKHNlbGVjdFdvcmQpOiBVc2UgU3RyaW5nLnRyaW0oKSB0byBkcm9wIHRy YWlsaW5nIHdoaXRlc3BhY2VzIHRoYXQKKyAgICAgICAgbWlnaHQgYmUgYWRkZWQgZGVwZW5kaW5n IG9uIHRoZSBlZGl0aW5nIGJlaGF2aW9yLiBTZWUgcmVsYXRlZCBidWcKKyAgICAgICAgMTEwNDg3 LgorCiAyMDEzLTAzLTI3ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4g CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdhcmRlbmluZy4gVGVzdCBFeHBlY3Rh dGlvbnMgdXBkYXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24v bW92ZS12ZXJ0aWNhbGx5LXdpdGgtcGFkZGluZ3MtYm9yZGVycy5odG1sIGIvTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vbW92ZS12ZXJ0aWNhbGx5LXdpdGgtcGFkZGluZ3MtYm9yZGVycy5o dG1sCmluZGV4IDQzNjM1NzkzNGI4MGI3OTBjYmEyNTFkMTViMzIxYjk4MDc3NWI4YTYuLjNiMzA2 NDVmZDRjNmI4M2I1ZjVhYjcyNzY5ZjNlODI1YWY4ZGUwNzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtdmVydGljYWxseS13aXRoLXBhZGRpbmdzLWJvcmRl cnMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLXZlcnRpY2Fs bHktd2l0aC1wYWRkaW5ncy1ib3JkZXJzLmh0bWwKQEAgLTM2LDcgKzM2LDcgQEAgZnVuY3Rpb24g bW92ZVRvTWlkZGxlT2ZXb3JkKG5vZGUsIHdvcmQpIHsKIGZ1bmN0aW9uIHNlbGVjdFdvcmQoKSB7 CiAgICAgd2luZG93LmdldFNlbGVjdGlvbigpLm1vZGlmeSgnbW92ZScsICdiYWNrd2FyZCcsICd3 b3JkJyk7CiAgICAgd2luZG93LmdldFNlbGVjdGlvbigpLm1vZGlmeSgnZXh0ZW5kJywgJ2Zvcndh cmQnLCAnd29yZCcpOwotICAgIHJldHVybiB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmco KTsKKyAgICByZXR1cm4gZ2V0U2VsZWN0aW9uKCkudG9TdHJpbmcoKS50cmltKCk7CiB9CiAKIGZ1 bmN0aW9uIG1vdmVWZXJ0aWNhbGx5QW5kVmVyaWZ5KG5vZGUsIGRpcmVjdGlvbiwgZnJvbSwgdG8p IHsK