113472 2013-03-27 20:25:55 -0700 Removed some dead code in the DFG bytecode parser 2013-03-27 20:51:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren fpizlo mhahnenberg sam oldest_to_newest 865133 0 ggaren 2013-03-27 20:25:55 -0700 Removed some dead code in the DFG bytecode parser 865134 1 195472 ggaren 2013-03-27 20:26:49 -0700 Created attachment 195472 Patch 865140 2 195472 sam 2013-03-27 20:38:17 -0700 Comment on attachment 195472 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195472&action=review > Source/JavaScriptCore/ChangeLog:9 > + remove the vestigates of code that used to do that in the bytecod Neither "vestigates" nor "bytecod" are words. 865141 3 ggaren 2013-03-27 20:39:18 -0700 Committed r147053: <http://trac.webkit.org/changeset/147053> 865147 4 sam 2013-03-27 20:51:14 -0700 (In reply to comment #2) > (From update of attachment 195472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195472&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + remove the vestigates of code that used to do that in the bytecod > > Neither "vestigates" nor "bytecod" are words. But they should be :( 195472 2013-03-27 20:26:49 -0700 2013-03-27 20:38:17 -0700 Patch bug-113472-20130327202650.patch text/plain 3988 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3MDUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTAzLTI3ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmVtb3ZlZCBzb21lIGRlYWQgY29kZSBpbiB0aGUgREZHIGJ5dGVjb2RlIHBhcnNlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEzNDcyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IHRoYXQgUGhp IGNyZWF0aW9uIGFuZCBsaXZlbmVzcyBhbmFseXNpcyBhcmUgc2VwYXJhdGUgcGFzc2VzLCB3ZSBj YW4KKyAgICAgICAgcmVtb3ZlIHRoZSB2ZXN0aWdhdGVzIG9mIGNvZGUgdGhhdCB1c2VkIHRvIGRv IHRoYXQgaW4gdGhlIGJ5dGVjb2QKKyAgICAgICAgcGFyc2VyLgorCisgICAgICAgICogZGZnL0RG R0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEJ5dGVDb2RlUGFyc2VyKToKKyAgICAgICAg KEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6YWRkVG9HcmFwaCk6CisgICAgICAgIChKU0M6OkRG Rzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlKToKKwogMjAxMy0wMy0yNyAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpJVCBhbmQgREZHIHNob3VsZCBOYU4tY2hlY2sg bG9hZHMgZnJvbSBGbG9hdDMyIGFycmF5cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDE0NzAxMikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xOTMsMTMgKzE5Myw2IEBAIHByaXZhdGU6CiAgICAgLy8gTGluayBibG9jayBzdWNjZXNz b3JzLgogICAgIHZvaWQgbGlua0Jsb2NrKEJhc2ljQmxvY2sqLCBWZWN0b3I8QmxvY2tJbmRleD4m IHBvc3NpYmxlVGFyZ2V0cyk7CiAgICAgdm9pZCBsaW5rQmxvY2tzKFZlY3RvcjxVbmxpbmtlZEJs b2NrPiYgdW5saW5rZWRCbG9ja3MsIFZlY3RvcjxCbG9ja0luZGV4PiYgcG9zc2libGVUYXJnZXRz KTsKLSAgICAvLyBMaW5rIEdldExvY2FsICYgU2V0TG9jYWwgbm9kZXMsIHRvIGVuc3VyZSBsaXZl IHZhbHVlcyBhcmUgZ2VuZXJhdGVkLgotICAgIGVudW0gUGhpU3RhY2tUeXBlIHsKLSAgICAgICAg TG9jYWxQaGlTdGFjaywKLSAgICAgICAgQXJndW1lbnRQaGlTdGFjawotICAgIH07Ci0gICAgdGVt cGxhdGU8UGhpU3RhY2tUeXBlIHN0YWNrVHlwZT4KLSAgICB2b2lkIHByb2Nlc3NQaGlTdGFjaygp OwogICAgIAogICAgIFZhcmlhYmxlQWNjZXNzRGF0YSogbmV3VmFyaWFibGVBY2Nlc3NEYXRhKGlu dCBvcGVyYW5kLCBib29sIGlzQ2FwdHVyZWQpCiAgICAgewpAQCAtNjk3LDggKzY5MCw2IEBAIHBy aXZhdGU6CiAgICAgICAgIHJldHVybiB2YWx1ZS5pc0Jvb2xlYW4oKSB8fCB2YWx1ZS5pc1VuZGVm aW5lZE9yTnVsbCgpOwogICAgIH0KICAgICAKLSAgICAvLyBUaGVzZSBtZXRob2RzIGNyZWF0ZSBh IG5vZGUgYW5kIGFkZCBpdCB0byB0aGUgZ3JhcGguIElmIG5vZGVzIG9mIHRoaXMgdHlwZSBhcmUK LSAgICAvLyAnbXVzdEdlbmVyYXRlJyB0aGVuIHRoZSBub2RlICB3aWxsIGltcGxpY2l0bHkgYmUg cmVmJ2VkIHRvIGVuc3VyZSBnZW5lcmF0aW9uLgogICAgIE5vZGUqIGFkZFRvR3JhcGgoTm9kZVR5 cGUgb3AsIE5vZGUqIGNoaWxkMSA9IDAsIE5vZGUqIGNoaWxkMiA9IDAsIE5vZGUqIGNoaWxkMyA9 IDApCiAgICAgewogICAgICAgICBOb2RlKiByZXN1bHQgPSBtX2dyYXBoLmFkZE5vZGUoCkBAIC03 MTksMTAgKzcxMCw4IEBAIHByaXZhdGU6CiAgICAgewogICAgICAgICBOb2RlKiByZXN1bHQgPSBt X2dyYXBoLmFkZE5vZGUoCiAgICAgICAgICAgICBTcGVjTm9uZSwgb3AsIGN1cnJlbnRDb2RlT3Jp Z2luKCksIGluZm8sIEVkZ2UoY2hpbGQxKSwgRWRnZShjaGlsZDIpLCBFZGdlKGNoaWxkMykpOwot ICAgICAgICBpZiAob3AgPT0gUGhpKQotICAgICAgICAgICAgbV9jdXJyZW50QmxvY2stPnBoaXMu YXBwZW5kKHJlc3VsdCk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fY3VycmVudEJsb2Nr LT5hcHBlbmQocmVzdWx0KTsKKyAgICAgICAgQVNTRVJUKG9wICE9IFBoaSk7CisgICAgICAgIG1f Y3VycmVudEJsb2NrLT5hcHBlbmQocmVzdWx0KTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAg ICB9CiAgICAgTm9kZSogYWRkVG9HcmFwaChOb2RlVHlwZSBvcCwgT3BJbmZvIGluZm8xLCBPcElu Zm8gaW5mbzIsIE5vZGUqIGNoaWxkMSA9IDAsIE5vZGUqIGNoaWxkMiA9IDAsIE5vZGUqIGNoaWxk MyA9IDApCkBAIC03NDgsMTMgKzczNyw2IEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiByZXN1 bHQ7CiAgICAgfQogCi0gICAgTm9kZSogaW5zZXJ0UGhpTm9kZShPcEluZm8gaW5mbywgQmFzaWNC bG9jayogYmxvY2spCi0gICAgewotICAgICAgICBOb2RlKiByZXN1bHQgPSBtX2dyYXBoLmFkZE5v ZGUoU3BlY05vbmUsIFBoaSwgY3VycmVudENvZGVPcmlnaW4oKSwgaW5mbyk7Ci0gICAgICAgIGJs b2NrLT5waGlzLmFwcGVuZChyZXN1bHQpOwotICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgIH0K LQogICAgIHZvaWQgYWRkVmFyQXJnQ2hpbGQoTm9kZSogY2hpbGQpCiAgICAgewogICAgICAgICBt X2dyYXBoLm1fdmFyQXJnQ2hpbGRyZW4uYXBwZW5kKEVkZ2UoY2hpbGQpKTsKQEAgLTEwMjQsMjEg KzEwMDYsNiBAQCBwcml2YXRlOgogICAgIC8vIFRoZSBpbmRleCBpbiB0aGUgZ2xvYmFsIHJlc29s dmUgaW5mby4KICAgICB1bnNpZ25lZCBtX2dsb2JhbFJlc29sdmVOdW1iZXI7CiAKLSAgICBzdHJ1 Y3QgUGhpU3RhY2tFbnRyeSB7Ci0gICAgICAgIFBoaVN0YWNrRW50cnkoQmFzaWNCbG9jayogYmxv Y2ssIE5vZGUqIHBoaSwgdW5zaWduZWQgdmFyTm8pCi0gICAgICAgICAgICA6IG1fYmxvY2soYmxv Y2spCi0gICAgICAgICAgICAsIG1fcGhpKHBoaSkKLSAgICAgICAgICAgICwgbV92YXJObyh2YXJO bykKLSAgICAgICAgewotICAgICAgICB9Ci0KLSAgICAgICAgQmFzaWNCbG9jayogbV9ibG9jazsK LSAgICAgICAgTm9kZSogbV9waGk7Ci0gICAgICAgIHVuc2lnbmVkIG1fdmFyTm87Ci0gICAgfTsK LSAgICBWZWN0b3I8UGhpU3RhY2tFbnRyeSwgMTY+IG1fYXJndW1lbnRQaGlTdGFjazsKLSAgICBW ZWN0b3I8UGhpU3RhY2tFbnRyeSwgMTY+IG1fbG9jYWxQaGlTdGFjazsKLSAgICAKICAgICBIYXNo TWFwPENvbnN0YW50QnVmZmVyS2V5LCB1bnNpZ25lZD4gbV9jb25zdGFudEJ1ZmZlckNhY2hlOwog ICAgIAogICAgIHN0cnVjdCBJbmxpbmVTdGFja0VudHJ5IHsKQEAgLTM3NjAsOSArMzcyNyw2IEBA IGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlKCkKIAogICAgIGxpbmtCbG9ja3MoaW5saW5lU3Rh Y2tFbnRyeS5tX3VubGlua2VkQmxvY2tzLCBpbmxpbmVTdGFja0VudHJ5Lm1fYmxvY2tMaW5raW5n VGFyZ2V0cyk7CiAgICAgbV9ncmFwaC5kZXRlcm1pbmVSZWFjaGFiaWxpdHkoKTsKLSNpZiBERkdf RU5BQkxFKERFQlVHX1BST1BBR0FUSU9OX1ZFUkJPU0UpCi0gICAgZGF0YUxvZ0YoIlByb2Nlc3Np bmcgbG9jYWwgdmFyaWFibGUgcGhpcy5cbiIpOwotI2VuZGlmCiAgICAgCiAgICAgQVNTRVJUKG1f cHJlc2VydmVkVmFycy5zaXplKCkpOwogICAgIHNpemVfdCBudW1iZXJPZkxvY2FscyA9IDA7Cg==