11346 2006-10-18 05:09:07 -0700 _blank is assigned to Window name 2007-09-30 03:30:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 0 madhu.mukund webkit-unassigned madhu.mukund oldest_to_newest 52010 0 madhu.mukund 2006-10-18 05:09:07 -0700 If there is no name given in window.open, then in WebKit '_blank' is assigned to the name of the window. In Firefox it will be empty string. In WebKit if id is given and there is no name then name of the window is assigned as the id. In firefox if the name is given as '_blank' it will be changed to "". 52008 1 11132 madhu.mukund 2006-10-18 05:18:17 -0700 Created attachment 11132 Patch for review It is a sample fix for review for the issue to make the behavior similar to Mozilla Firefox 51962 2 ap 2006-10-18 09:24:02 -0700 To ask for a review, please select '?' from a popup on the screen that opens when you click "Edit" link. A proper patch must include an automated testcase, but you can ask for a review just to get some feedback on the approach. FWIW, when I enter "javascript:window.open()" in the address bar of ToT, I get a window named "about:/undefined". 49860 3 11132 madhu.mukund 2006-10-25 04:13:38 -0700 Comment on attachment 11132 Patch for review In window.open, if there is no name is given, as the second parameter, in Safari _blank is assigned to the name of the Window. But in Firefox it will be "". 49861 4 11200 madhu.mukund 2006-10-25 04:18:14 -0700 Created attachment 11200 the zip contains the sample pages to show the bug Open the main.htm in Safari and click on the link, it will give self.name=_blank. Do the same in Firefox. It will be 'self.name= ' 49863 5 11202 madhu.mukund 2006-10-25 04:27:37 -0700 Created attachment 11202 Patch for the issue In this patch I have modified the code, to make the behaviour of Safari similar to Firefox. I have assigned "" to Window name if the name is undefined or null. If the name is given as _blank it will be changed to "" 49864 6 11202 madhu.mukund 2006-10-25 04:31:30 -0700 Comment on attachment 11202 Patch for the issue Please review and give suggestion 48408 7 mjs 2006-10-31 04:23:36 -0800 Reopened since this is not resolved. 48374 8 11202 mjs 2006-10-31 10:07:38 -0800 Comment on attachment 11202 Patch for the issue My comments: 1) This patch appears to be in RTF format, it needs to be in plain text. 2) There is no ChangeLog entry. 3) There is no test case in the patch - this probably can't be tested automatically but it should include a test for the manual-tests directory. 4) This fix is at the wrong layer. There are ther constructs besides window.open that can open a new window, such as <a href="http://somesite.com/" target="_blank">, these need to be covered as well. The right place to fix this is in the Frame code itself - a request to open a new window for _blank should make sure that the name ends up empt instead of "_blank". 5) Comments in the code should not talk about making a specific fix, nor should they describe what the code is doing if that is obvious just from reading. 6) Coding style issue, there should be a space between the "if" and the open paren: if(frameName == "_blank") Please addresse these issues and resubmit. 40594 9 11964 madhu.mukund 2006-12-22 06:30:58 -0800 Created attachment 11964 The attachment is a fix for the issue Reviewer, Please send me a sample change log. The attachment contains the fix as suggested by MJS 40591 10 11964 ddkilzer 2006-12-22 06:49:35 -0800 Comment on attachment 11964 The attachment is a fix for the issue Thanks for the patch! There are still some issues that need to be cleaned up, though. 1. Please use WebKitTools/Scripts/prepare-ChangeLog to generate your own ChangeLog entry, then use WebKitTools/Scripts/svn-create-patch to generate the patch. More info here: http://webkit.org/coding/contributing.html 2. No tabs are allowed in the source code. Please use spaces instead. More info here: http://webkit.org/coding/coding-style.html 3. A manual test in WebCore/manual-tests should be included with the patch per Maciej in Comment #8. Almost there! 29119 11 ddkilzer 2007-02-01 13:05:45 -0800 This may be fixed now. Tested local debug build of WebKit r19341 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037). 57434 12 andrew 2007-09-30 03:30:28 -0700 As ddkilzer mentioned this issue has been fixed (see FrameTree::uniqueChildName) in r13257 11132 2006-10-18 05:18:17 -0700 2006-10-25 04:27:37 -0700 Patch for review _blank issue.txt text/plain 1093 madhu.mukund e1xydGYxXG1hY1xhbnNpY3BnMTAwMDBcY29jb2FydGY4MjRcY29jb2FzdWJydGY0MTAKe1xmb250 dGJsXGYwXGZzd2lzc1xmY2hhcnNldDc3IEhlbHZldGljYTt9CntcY29sb3J0Ymw7XHJlZDI1NVxn cmVlbjI1NVxibHVlMjU1O30KXG1hcmdsMTQ0MFxtYXJncjE0NDBcdmlld3c5MDAwXHZpZXdoODQw MFx2aWV3a2luZDAKXHBhcmRcdHg3MjBcdHgxNDQwXHR4MjE2MFx0eDI4ODBcdHgzNjAwXHR4NDMy MFx0eDUwNDBcdHg1NzYwXHR4NjQ4MFx0eDcyMDBcdHg3OTIwXHR4ODY0MFxxbFxxbmF0dXJhbFxw YXJkaXJuYXR1cmFsCgpcZjBcZnMyNCBcY2YwIEluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL2tq c193aW5kb3cuY3BwXAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09XAotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2lu ZG93LmNwcCAgKHJldmlzaW9uIDE1NTI2KVwKKysrIFdlYkNvcmUvYmluZGluZ3MvanMva2pzX3dp bmRvdy5jcHAgICh3b3JraW5nIGNvcHkpXApAQCAtMTU1MSw3ICsxNTUxLDkgQEAgSlNWYWx1ZSAq V2luZG93RnVuYzo6Y2FsbEFzRnVuY3Rpb24oRXhlY1wKICAgY2FzZSBXaW5kb3c6Ok9wZW46XAog ICBce1wKICAgICAgIEF0b21pY1N0cmluZyBmcmFtZU5hbWUgPSBhcmdzWzFdLT5pc1VuZGVmaW5l ZE9yTnVsbCgpXAotICAgICAgICA/ICJfYmxhbmsiIDogQXRvbWljU3RyaW5nKGFyZ3NbMV0tPnRv U3RyaW5nKGV4ZWMpKTtcCisgICAgICAgID8gIiIgOiBBdG9taWNTdHJpbmcoYXJnc1sxXS0+dG9T dHJpbmcoZXhlYykpO1wKKyAgICAgICAgaWYoZnJhbWVOYW1lID09ICJfYmxhbmsiKVwKKyAgICAg ICAgICAgZnJhbWVOYW1lPSIiO1wKICAgICAgIC8vIEJlY2F1c2UgRnJhbWVUcmVlOjpmaW5kKCkg cmV0dXJucyB0cnVlIGZvciBlbXB0eSBzdHJpbmdzLCB3ZSBtdXN0IGNoZWNrIGZvciBlbXB0eSBm cmFtZW5hbWVzLlwKICAgICAgIC8vIE90aGVyd2lzZSwgaWxsZWdpdGltYXRlIHdpbmRvdy5vcGVu KCkgY2FsbHMgd2l0aCBubyBuYW1lIHdpbGwgcGFzcyByaWdodCB0aHJvdWdoIHRoZSBwb3B1cCBi bG9ja2VyLlwKfQ== 11200 2006-10-25 04:18:14 -0700 2006-10-25 04:18:14 -0700 the zip contains the sample pages to show the bug _blank issue.zip application/x-zip-compressed 1454 madhu.mukund UEsDBAoAAAAAAF2LEjUAAAAAAAAAAAAAAAANABAAX2JsYW5rIGlzc3VlL1VYDACTWuZE0VrmRPUB 9QFQSwMEFAAIAAgAB4kSNQAAAAAAAAAAAAAAABkAEABfYmxhbmsgaXNzdWUvY2hpbGR3aW4uaHRt VVgMANda5kRuVuZE9QH1AbPxCPH1seOy8XB1dAFS+lDayd8l0o6LyybYOcgzIMSOqzwzLyW/XC8/ Lyc/McU2Jd8HSFlzpZXmJZdk5ucpQAQ0NLmquTgTc1KLSjSUilNz0vTyEnNTrayUtBXgPE1rrlqg ufowg7mcMzJzUhTCweaDJCA2Ax0CchcAUEsHCAdJcUp6AAAAngAAAFBLAwQKAAAAAABiixI1AAAA AAAAAAAAAAAACQAQAF9fTUFDT1NYL1VYDADXWuZE11rmRPUB9QFQSwMECgAAAAAAYosSNQAAAAAA AAAAAAAAABYAEABfX01BQ09TWC9fYmxhbmsgaXNzdWUvVVgMANda5kTXWuZE9QH1AVBLAwQUAAgA CAAHiRI1AAAAAAAAAAAAAAAAJAAQAF9fTUFDT1NYL19ibGFuayBpc3N1ZS8uX2NoaWxkd2luLmh0 bVVYDADXWuZEblbmRPUB9QFjYBVjZ2BiwAQgMU4gNgJiBSg/CCQR4hoREqSVnIFFDxgAAFBLBwgx aw3NIwAAAFIAAABQSwMEFAAIAAgAI4kSNQAAAAAAAAAAAAAAABUAEABfYmxhbmsgaXNzdWUvbWFp bi5odG1VWAwA11rmRKFW5kT1AfUBNY4/D8IgFMRn3qd46VJYyq7I4urujPwJTys0iDbG+N3FVrfL 5e53p2K9jhrUzRaaqgYW7slWygnz5NOREnKBL2BspuTyPHxd5L2NNLpmDa3eiy2wNyj5Z6hTdk8N +wPZC0ZfPIZcUBmMxYdddzYPs0Y3vw0uOr0QcV1R0jSKXDFNLB8/UEsHCH7A3v2EAAAAqgAAAFBL AwQUAAgACAAjiRI1AAAAAAAAAAAAAAAAIAAQAF9fTUFDT1NYL19ibGFuayBpc3N1ZS8uX21haW4u aHRtVVgMANda5kShVuZE9QH1AWNgFWNnYGLABCAxTiA2AmIFKD8IJBHiGhESpJWcgUUPGAAAUEsH CDFrDc0jAAAAUgAAAFBLAQIVAwoAAAAAAF2LEjUAAAAAAAAAAAAAAAANAAwAAAAAAAAAAEDtQQAA AABfYmxhbmsgaXNzdWUvVVgIAJNa5kTRWuZEUEsBAhUDFAAIAAgAB4kSNQdJcUp6AAAAngAAABkA DAAAAAAAAAAAQKSBOwAAAF9ibGFuayBpc3N1ZS9jaGlsZHdpbi5odG1VWAgA11rmRG5W5kRQSwEC FQMKAAAAAABiixI1AAAAAAAAAAAAAAAACQAMAAAAAAAAAABA/UEMAQAAX19NQUNPU1gvVVgIANda 5kTXWuZEUEsBAhUDCgAAAAAAYosSNQAAAAAAAAAAAAAAABYADAAAAAAAAAAAQP1BQwEAAF9fTUFD T1NYL19ibGFuayBpc3N1ZS9VWAgA11rmRNda5kRQSwECFQMUAAgACAAHiRI1MWsNzSMAAABSAAAA JAAMAAAAAAAAAABApIGHAQAAX19NQUNPU1gvX2JsYW5rIGlzc3VlLy5fY2hpbGR3aW4uaHRtVVgI ANda5kRuVuZEUEsBAhUDFAAIAAgAI4kSNX7A3v2EAAAAqgAAABUADAAAAAAAAAAAQKSBDAIAAF9i bGFuayBpc3N1ZS9tYWluLmh0bVVYCADXWuZEoVbmRFBLAQIVAxQACAAIACOJEjUxaw3NIwAAAFIA AAAgAAwAAAAAAAAAAECkgeMCAABfX01BQ09TWC9fYmxhbmsgaXNzdWUvLl9tYWluLmh0bVVYCADX WuZEoVbmRFBLBQYAAAAABwAHADQCAABkAwAAAAA= 11202 2006-10-25 04:27:37 -0700 2006-12-22 06:37:09 -0800 Patch for the issue Patch-_blank.txt text/plain 1439 madhu.mukund e1xydGYxXG1hY1xhbnNpY3BnMTAwMDBcY29jb2FydGY4MjRcY29jb2FzdWJydGY0MTAKe1xmb250 dGJsXGYwXGZzd2lzc1xmY2hhcnNldDc3IEhlbHZldGljYTt9CntcY29sb3J0Ymw7XHJlZDI1NVxn cmVlbjI1NVxibHVlMjU1O30KXG1hcmdsMTQ0MFxtYXJncjE0NDBcdmlld3c5MDAwXHZpZXdoODQw MFx2aWV3a2luZDAKXHBhcmRcdHg3MjBcdHgxNDQwXHR4MjE2MFx0eDI4ODBcdHgzNjAwXHR4NDMy MFx0eDUwNDBcdHg1NzYwXHR4NjQ4MFx0eDcyMDBcdHg3OTIwXHR4ODY0MFxxbFxxbmF0dXJhbFxw YXJkaXJuYXR1cmFsCgpcZjBcZnMyNCBcY2YwIEluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL2tq c193aW5kb3cuY3BwXAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09XAotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2lu ZG93LmNwcAkocmV2aXNpb24gMTU1MjYpXAorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2lu ZG93LmNwcAkod29ya2luZyBjb3B5KVwKQEAgLTE1NTAsOCArMTU1MCwxNiBAQCBKU1ZhbHVlICpX aW5kb3dGdW5jOjpjYWxsQXNGdW5jdGlvbihFeGVjXAogICBcfVwKICAgY2FzZSBXaW5kb3c6Ok9w ZW46XAogICBce1wKKwkvKiBUaGUgZm9sbG93aW5nIGZpeCBpcyBtYWRlIHRvIG1ha2UgdGhlIGJl aGF2aW91ciBvZiBXZWJraXQgc2ltaWxhciB0byBGaXJlZm94Ki9cCisJLyogaWYgYXJnc1sxXSBp cyB1bmRlZmluZWQgb3IgbnVsbCAiIiBpcyBhc3NpZ25lZCB0byB0aGUgbmFtZSBvZiB3aW5kb3cq L1wKKwkgXAogICAgICAgQXRvbWljU3RyaW5nIGZyYW1lTmFtZSA9IGFyZ3NbMV0tPmlzVW5kZWZp bmVkT3JOdWxsKClcCi0gICAgICAgID8gIl9ibGFuayIgOiBBdG9taWNTdHJpbmcoYXJnc1sxXS0+ dG9TdHJpbmcoZXhlYykpO1wKKyAgICAgICAgPyAiIiA6IEF0b21pY1N0cmluZyhhcmdzWzFdLT50 b1N0cmluZyhleGVjKSk7XAorCQlcCisJLyogaWYgYXJnc1sxXSBpcyAiX2JsYW5rIHRoZW4gYWxz byAiIiBpcyBhc3NpZ25lZCB0byB0aGUgbmFtZSBvZiB3aW5kb3cqL1wKKwkgaWYoZnJhbWVOYW1l ID09ICJfYmxhbmsiKVwKKwkgICAgZnJhbWVOYW1lPSIiO1wKKwlcCiAgICAgICAvLyBCZWNhdXNl IEZyYW1lVHJlZTo6ZmluZCgpIHJldHVybnMgdHJ1ZSBmb3IgZW1wdHkgc3RyaW5ncywgd2UgbXVz dCBjaGVjayBmb3IgZW1wdHkgZnJhbWVuYW1lcy5cCiAgICAgICAvLyBPdGhlcndpc2UsIGlsbGVn aXRpbWF0ZSB3aW5kb3cub3BlbigpIGNhbGxzIHdpdGggbm8gbmFtZSB3aWxsIHBhc3MgcmlnaHQg dGhyb3VnaCB0aGUgcG9wdXAgYmxvY2tlci5cCiAgICAgICBpZiAoIWFsbG93UG9wVXAoZXhlYywg d2luZG93KSAmJiAoZnJhbWVOYW1lLmlzRW1wdHkoKSB8fCAhZnJhbWUtPnRyZWUoKS0+ZmluZChm cmFtZU5hbWUpKSlcCn0= 11964 2006-12-22 06:30:58 -0800 2006-12-22 06:49:35 -0800 The attachment is a fix for the issue _blankissue.txt text/plain 337 madhu.mukund IApJbmRleDogRnJhbWVUcmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBGcmFtZVRyZWUuY3BwCShyZXZp c2lvbiAxNTUyNikKKysrIEZyYW1lVHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUy LDggQEAgdm9pZCBGcmFtZVRyZWU6OnNldE5hbWUoY29uc3QgQXRvbWljU3RyaQogewogICAgIGlm ICghcGFyZW50KCkpIHsKICAgICAgICAgbV9uYW1lID0gbmFtZTsKKwlpZiAobV9uYW1lID09ICJf YmxhbmsiKQorCSAgICBtX25hbWUgPSAiIjsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIA==